[sr-dev] Re: [kamailio/kamailio] cmake format options and naming styles (Issue #4075)

- `dangle_parens = True` : If a statement is wrapped to more than one line, than dangle the closing parenthesis on its own line. This follows closely the whole kamailio codebase, I think. - `keyword_case = 'upper'`: Format keywords consistently as 'lower' or 'upper' case. default was 'unchanged`

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

@Fr-Soltanzadeh pushed 1 commit. 628a03f5b5f9edf442410674465bf80ac371e7ce rtpengine: export subscribe operation functions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4071/files/b33ec805d9e2e339a92711329b396a181127fb94..628a03f5b5f9edf442410674465bf80ac371e7ce You are receiv

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)

I had installed via: ``` git clone https://github.com/wolfSSL/wolfssl.git --depth 1 /usr/local/src/kamailio/misc/external/wolfssl/wolfssl cd /usr/local/src/kamailio make modules modules=modules/tls_wolfssl make install modules modules=modules/tls_wolfssl ``` -- Reply to this email directly or v

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)

Got it - you are using the git submodule - I'll test that then -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4074#issuecomment-2548723657 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

@Fr-Soltanzadeh pushed 1 commit. 33faf97844ec372c22bf8801a256c49cc278bca9 rtpengine: export subscribe operation functions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4071/files/95fd0134d97c5ee8b3cba8ed8861412697425998..33faf97844ec372c22bf8801a256c49cc278bca9 You are receiv

[sr-dev] git:master:bef43438: cmake: module_doc made from two targets module_doc_text and module_doc_html

Module: kamailio Branch: master Commit: bef434385f32a685241a431b54082751c590b32c URL: https://github.com/kamailio/kamailio/commit/bef434385f32a685241a431b54082751c590b32c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-17T11:38:14+01:00 cmake: module_doc made

[sr-dev] git:master:aa41dd85: tls_wolfssl: update internal submodule to v5.7.4-stable tag

Module: kamailio Branch: master Commit: aa41dd85ed5420f1fff3c6870eb1e5c3b8810f11 URL: https://github.com/kamailio/kamailio/commit/aa41dd85ed5420f1fff3c6870eb1e5c3b8810f11 Author: S-P Chan Committer: S-P Chan Date: 2024-12-17T23:44:45+08:00 tls_wolfssl: update internal submodule to v5.7.4-stabl

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

Thanks. Can you also add some module documentation (in XML format) to this PR? If I understood the previous discussion correctly, the cfg functions should be probably also named ..subscribe.. instead of ..copy.. You don't need to add the README to the PR, it will created later automatically. --

[sr-dev] git:master:763d3622: cmake: Make docs install optional

Module: kamailio Branch: master Commit: 763d3622fdb2cdd7916963b6d3f4d532525a5fcc URL: https://github.com/kamailio/kamailio/commit/763d3622fdb2cdd7916963b6d3f4d532525a5fcc Author: Xenofon Karamanos Committer: Xenofon Karamanos Date: 2024-12-17T13:31:59Z cmake: Make docs install optional --- M

[sr-dev] Re: [kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)

@miconda Sure thing, all the available options, are in that `cmake/cmake-format.py`. We can also use other formats apart from python conf file, like yaml or json. `cmake-format --dump-config [yaml|json|python] > file.ext` will output all the default configs so that we can manually edit it after

[sr-dev] [kamailio/kamailio] cmake format options and naming styles (Issue #4075)

Discussion to define cmake format options and coding/naming styles. It is better to define most of them now to have coherency in the future. Started from the discussion on #4066. Comment with what you would like to have, describing when useful why your proposal is a good/better option. -- Rep

[sr-dev] Re: [kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)

Not to continue the discussion on this closed PR, I created tracker issue for it: #4075. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066#issuecomment-2548184645 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

@Fr-Soltanzadeh pushed 1 commit. 95fd0134d97c5ee8b3cba8ed8861412697425998 rtpengine: export subscribe operation functions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4071/files/b63d8d1badab990b5f3af42c61eedff701da74df..95fd0134d97c5ee8b3cba8ed8861412697425998 You are receiv

[sr-dev] Re: [kamailio/kamailio] cmake format options and naming styles (Issue #4075)

I would propose a longer limit for the line width (`line_width`) - 80 could be too short for comments (some cmake commands also take comment parameter) and string parameters. Nowadays, all displays as well as the terminal apps support way larger number of chars per line. A second proposal is to

[sr-dev] [kamailio/kamailio] Kamailio passive instance tries to send dialog keepalives after service restart (Issue #4077)

### Description Kamailio is running on 2 nodes using DMQ for HA. Following DMQ parameters are set: ``` modparam("dmq", "server_address", "sip:LOCAL_IP:DMQ_PORT") modparam("dmq", "notification_address", "sip:OTHER_NODE_IP:DMQ_PORT") modparam("dmq", "multi_notify", 0) modparam("dmq_usrloc", "enabl

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)

Looks like it is 5.7.2 version: ``` Name: wolfssl Description: wolfssl C library. Version: 5.7.2 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4074#issuecomment-2548649913 You are receiving this because you are subscribed to this thread. M

[sr-dev] git:master:19625af3: cmake: rename files to use - instead of _ in the name

Module: kamailio Branch: master Commit: 19625af3f3b5d36e3515dcc7efc9f6c85ea6bcf9 URL: https://github.com/kamailio/kamailio/commit/19625af3f3b5d36e3515dcc7efc9f6c85ea6bcf9 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-17T10:44:24+01:00 cmake: rename files to

[sr-dev] Re: [kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)

@linuxmaniac Is this pre-commit using the `cmake-format.py` config file found in `cmake` or it just go by the defaults? If we are fine with the defaults, we can remove the file completely, as it might mess up the format if configured to use the one provided (happened to me that I was already u

[sr-dev] Re: [kamailio/kamailio] cmake --install looking for various text files like auth.txt, async.txt (Issue #4076)

@space88man Yeah i am aware of that! I have a fix ready for it. I will push it asap! Thanks for the feedback! It's due to `kamailio_docs` not being built with the `all`/`target`, hence the files to be installed are not there yet! -- Reply to this email directly or view it on GitHub: https://gi

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

@Fr-Soltanzadeh pushed 1 commit. b33ec805d9e2e339a92711329b396a181127fb94 rtpengine: export subscribe operation functions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4071/files/33faf97844ec372c22bf8801a256c49cc278bca9..b33ec805d9e2e339a92711329b396a181127fb94 You are receiv

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

Thanks for the update. Aparently there is some format related error, can you investigate and force-push again? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4071#issuecomment-2548140270 You are receiving this because you are subscribed to this th

[sr-dev] Re: [kamailio/kamailio] pre-commit: cmake-format and cmake-lint hooks [skip ci] (PR #4066)

If a custom config is going to be used, maybe it would be good to tune it a bit, since we are at the beginning of using cmake files. For example I would suggest a longer `line_width`, 80 was (maybe still is) for code to be easily seen on the very old terminal/console, but considering the current

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)

Interesting: where did you get this package from? bookworm looks to have only libwolfssl35 > Looks like it is 5.7.2 version: -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4074#issuecomment-2548704398 You are receiving this because you are subs

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

> Overall LGTM with some exceptions. > > As for style - I would prefer to retain the "subscribe" schema of naming the > functions instead of "copy" - took me a while to understand that this refers > to making a copy of the media stream. > Thanks for the feedback, I’ve updated the function names

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: new xhttp_prom_tags parameter (PR #4073)

Hey @ChristianBergerSipgate, The commit itself should be fixed with `clang-format --style=file -i [filename]` iirc the command or use the `pre-commit` python package to not let you push if it fails the `pre-commit` config and it fixes this for you. The format check is per commit therefore, push

[sr-dev] Re: [kamailio/kamailio] cmake --install looking for various text files like auth.txt, async.txt (Issue #4076)

Closed #4076 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4076#event-15686672884 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - Development

[sr-dev] Re: [kamailio/kamailio] cmake --install looking for various text files like auth.txt, async.txt (Issue #4076)

Closed with commit on master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4076#issuecomment-2548548422 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio - De

[sr-dev] [kamailio/kamailio] cmake --install looking for various text files like auth.txt, async.txt (Issue #4076)

### Description Ping @xkaraman cmake error on installation; it seems to be looking for various x.txt files ``` cmake --install . -- Install configuration: "Debug" -- Installing: /home/centos/src/CHROOT/usr/local/kamailio/sbin/kamailio -- kamailio.cfg already exists in /home/centos/src/CHR

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: crash qm_free / qm_debug_check_frag (Issue #4074)

@fredposner - can I confirm the runtime library is libwolfssl35? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4074#issuecomment-2548357872 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] git:master:da1c3456: cmake/modules-docs.cmake: added COMMENT to target definitions

Module: kamailio Branch: master Commit: da1c3456054fbfc3a353b5462fe4e27e852c8e47 URL: https://github.com/kamailio/kamailio/commit/da1c3456054fbfc3a353b5462fe4e27e852c8e47 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-17T19:28:54+01:00 cmake/modules-docs.cma

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,bullseye #2886

See ___ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.ka

[sr-dev] [kamailio/kamailio] cmake: should we use >= 3.13, i.e., "more modern cmake" generation? (Issue #4078)

### Description >From the cmake timeline 3.0(2014) is called "modern cmake" and >~3.12/3.13(2018) is "more modern cmake" : >https://www.youtube.com/watch?v=y7ndUhdQuU8 Since we are doing a major renovation on the kamailio build system should we target the "more modern" generation (that is alr

[sr-dev] git:master:2dc8de17: cmake: Add support for multiple groups

Module: kamailio Branch: master Commit: 2dc8de17cd9103f4075e3324427f3009144a324d URL: https://github.com/kamailio/kamailio/commit/2dc8de17cd9103f4075e3324427f3009144a324d Author: Xenofon Karamanos Committer: Xenofon Karamanos Date: 2024-12-17T16:59:49Z cmake: Add support for multiple groups -

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

> Thanks. Can you also add some module documentation (in XML format) to this > PR? If I understood the previous discussion correctly, the cfg functions > should be probably also named ..subscribe.. instead of ..copy.. You don't > need to add the README to the PR, it will created later automatica

[sr-dev] Re: [kamailio/kamailio] cmake: switching deb rules (Issue #4053)

Hey @linuxmaniac, After 2dc8de1, you should be able to pass multiple groups in the `-DMODULE_GROUP_NAME` option like `cmake -S . -B build-multigroup -DMODULE_GROUP_NAME="KSTANDARD KMYSQL"` along with the `INCLUDE_MODULES` and `EXCLUDE_MODULES` options that accept specific modules. -- Reply

[sr-dev] Re: [kamailio/kamailio] rtpengine: export subscribe operation functions (PR #4071)

Thanks for the clarification, I thought there were already supposed to be used in the cfg (did not reviewed the code in detail yet). Ok, then lets wait for eventual more comments from @rfuchs and then merge it in the next days. -- Reply to this email directly or view it on GitHub: https://githu

[sr-dev] git:master:96c9317b: pkg/kamailio/deb: version set 6.0.0~pre0

Module: kamailio Branch: master Commit: 96c9317b5f7a52eba94286dbe832d4bb1e4efd48 URL: https://github.com/kamailio/kamailio/commit/96c9317b5f7a52eba94286dbe832d4bb1e4efd48 Author: Victor Seva Committer: Victor Seva Date: 2024-12-17T20:15:48+01:00 pkg/kamailio/deb: version set 6.0.0~pre0 --- M

[sr-dev] git:master:6f54793e: cmake/modules-docs.cmake: added target to generate readme for modules

Module: kamailio Branch: master Commit: 6f54793ebbd86f898be749f9e6b00274ccb1f631 URL: https://github.com/kamailio/kamailio/commit/6f54793ebbd86f898be749f9e6b00274ccb1f631 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-17T19:15:34+01:00 cmake/modules-docs.cma

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: new xhttp_prom_tags parameter (PR #4073)

@ChristianBergerSipgate pushed 1 commit. dee479370b9bea526f61fd5a856e378ad49e8897 xhttp_prom: new xhttp_prom_tags parameter -- View it on GitHub: https://github.com/kamailio/kamailio/pull/4073/files/7fddb272839667d046b8663af2af0c9d1f482a9c..dee479370b9bea526f61fd5a856e378ad49e8897 You are rece

[sr-dev] git:master:da629acc: src/CMakeLists.txt: remove explicit sources lex.yy.c and cfg.tab.c

Module: kamailio Branch: master Commit: da629accb2c2095e3255f4aa3389a0af02272980 URL: https://github.com/kamailio/kamailio/commit/da629accb2c2095e3255f4aa3389a0af02272980 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-12-18T08:48:02+01:00 src/CMakeLists.txt: re