The code introduced by this PR does not seem to deal properly with some valid
cases. Detecting if the URI is enclosed in `<>` fails if there are header
parameters. For example:
```
From: ;tag=abc\r\n
```
The `tag` is a header parameter, is not a URI parameter. I think it should
check the `uri`
The problem with checking the `uri` field is that it's always the URI
**WITHOUT** the `<>` even if the message header includes them. That's why I had
to check on the original unparsed body of the message to figure out if URI was
enclosed or not in `< >`.
--
Reply to this email directly or vie
The check can be that if `uri` is inside `body`, then the before or after chars
should be `<` and `>`. Maybe the SIP grammar should be checked to see if
whitespaces are allowed after `<` or before `>`.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pu
Module: kamailio
Branch: master
Commit: 9ff1080cc6452343e6bc2de00350b2f7bcecf6d2
URL:
https://github.com/kamailio/kamailio/commit/9ff1080cc6452343e6bc2de00350b2f7bcecf6d2
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-08-20T12:26:10+02:00
core: new internal fla
Module: kamailio
Branch: master
Commit: e0f10477728922cefbbff9d23d846cd5912eb148
URL:
https://github.com/kamailio/kamailio/commit/e0f10477728922cefbbff9d23d846cd5912eb148
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-08-20T13:05:42+02:00
core: explicit unsigne
@xkaraman pushed 1 commit.
a39a5f58cf06e524cad380aa4f543133dd3a88f0 pv: Ensure URI enclosed in <> when
changing Display Name
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3935/files/8a8c9c2fe8dc591de9a36a017a33ccee7c695611..a39a5f58cf06e524cad380aa4f543133dd3a88f0
You are rec
So far, 24 hours in, it looks like `tls_threads_mode=2` solve the problem for
me.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3205#issuecomment-2298993089
You are receiving this because you are subscribed to this thread.
Message ID:
I just pushed an updated version.
I made some assumptions (also noted as comments):
1. When parsing the `FROM` body, all leading whitespace up to `<` are removed
when there is no Display Name.
2. We are modifying a valid SIP message (otherwise parser has already failed
beforehand). Therefore, we
This issue is stale because it has been open 6 weeks with no activity. Remove
stale label or comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3844#issuecomment-2300396785
You are receiving this because yo
