[sr-dev] Re: [kamailio/kamailio] BUG: freeing already freed pointer (0x7f19a3edec68), called from tls: tls_init.c with random core dumps (Issue #3205)

2024-08-19 Thread Oded Arbel via sr-dev
Setting `init_mode` did not solve the problem for me. During production load today, we still got many `ser_free` double free reports. Kamailio does not crash everytime there is this error in the logs, sometimes after 7 or 8 occurrences (over 15 minutes or so). I'll try to set `tls_threads_mode`

[sr-dev] Re: [kamailio/kamailio] cdp: export all functions in KEMI module (PR #3943)

2024-08-19 Thread bazrafshan.m.h via sr-dev
Closed #3943. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3943#event-13926166392 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] cdp: export all functions in KEMI module (PR #3949)

2024-08-19 Thread bazrafshan.m.h via sr-dev
- Added `cdp_has_app` function: - Accepts a single parameter: - `application`: The Application ID. - Added `cdp_has_app2` function: - Accepts two parameters: - `vendorid`: The Vendor ID associated with the application. - `application`: The Application ID. - Added cdp_check_peer function: -

[sr-dev] Re: [kamailio/kamailio] secfilter: all functions are exported in KEMI (PR #3940)

2024-08-19 Thread bazrafshan.m.h via sr-dev
sorry -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3940#issuecomment-2295894369 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing Li

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Mojtaba Esfandiari.S via sr-dev
I see, but SIPREC in Opensip is a general approach and uses the SIPREC protocol. Is your approach the same? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296006175 You are receiving this because you are subscribed to this threa

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Mojtaba Esfandiari.S via sr-dev
> > In my opinion, consider the considerations of strong module dependencies in > > the design. For example, you have used the capabilities of another module > > in your code and called it recently, while it might be better to design and > > implement this capability in the new module itself. An

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Unfortunately there are still clang-format errors in the PR. If you are not able to solve them let us know, it can be also merged manually. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296055216 You are receiving this because

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Farzaneh Soltanzadeh via sr-dev
> I see, but SIPREC in Opensip is a general approach and uses the SIPREC > protocol. Is your approach the same? Not exactly the same but yes. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296182344 You are receiving this becau

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Farzaneh Soltanzadeh via sr-dev
> Unfortunately there are still clang-format errors in the PR. If you are not > able to solve them let us know, it can be also merged manually. It seems that the problem is that checking clang-format is commit by commit and since my first commit had clang-format error, the problem was still ther

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Victor Seva via sr-dev
sorry but, can you please rebase instead of merge? We don't want any merge commit in PR -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296232597 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Farzaneh Soltanzadeh via sr-dev
> sorry but, can you please rebase instead of merge? We don't want any merge > commit in PR Yes, done, thank you. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296312645 You are receiving this because you are subscribed to thi

[sr-dev] [kamailio/kamailio] [Websocket] websocket:closed sometimes is not fired (Issue #3950)

2024-08-19 Thread Gustavo Almeida via sr-dev
### Description After carrying out some load tests using the `Websocket` module, I noticed that sometimes the `websocket:closed` event is not triggered. This problem seems to be particularly noticeable when the load is high and simultaneous. Example: 1000 records simultaneously. In the tests c

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Checks are all fine now, thanks. Lets wait for a bit more time for eventual feedback from @rfuchs, otherwise it will be merged soon. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296367557 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Richard Fuchs via sr-dev
No objections from my POV -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296400629 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - De

[sr-dev] git:master:3d002d56: rtpengine: export API for other modules (GH #3949)

2024-08-19 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 3d002d561e82b8bb71b225da708bdfd9ce504335 URL: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335 Author: Farzaneh Soltanzadeh Committer: Henning Westerholt Date: 2024-08-19T12:30:29Z rtpengine: export API for other modul

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Closed #3948. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#event-13929747287 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Thanks, it was manually merged (due to the commit message not conforming to the standard) in commit 3d002d561e82b8bb. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#issuecomment-2296465727 You are receiving this because you are subscribed to

[sr-dev] Re: [kamailio/kamailio] cdp: export all functions in KEMI module (PR #3949)

2024-08-19 Thread Henning Westerholt via sr-dev
Just for future reference, I made a mistake in the comment for the commit 3d002d561e82b8bb, it should link to #3948 and not to this issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3949#issuecomment-2296468447 You are receiving this because y

[sr-dev] Re: [kamailio/kamailio] pv: Ensure URI enclosed in <> when changing Display Name (PR #3935)

2024-08-19 Thread Xenofon Karamanos via sr-dev
After some review and search (https://github.com/kamailio/kamailio/issues/1719), it seems that there is "bug" when trying to apply multiple changes at once (at least regarding the display name and URI as well). Since all changes are done in respect to the original message, some consecutive chan

[sr-dev] Re: [kamailio/kamailio] rtpengine: export API for other modules (GH #3949) (3d002d5)

2024-08-19 Thread Farzaneh Soltanzadeh via sr-dev
Thanks for merging the PR. It seems that the referenced PR is wrong. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335#commitcomment-145516854 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] rtpengine: export API for other modules (GH #3949) (3d002d5)

2024-08-19 Thread Henning Westerholt via sr-dev
Yes, I commented it in the other issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/3d002d561e82b8bb71b225da708bdfd9ce504335#commitcomment-145517761 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Daniel-Constantin Mierla via sr-dev
I think this PR is completely wrong as it was done, because the API exports the functions for kamailio.cfg, which take pseudo-variables in parameters that are fixed-up at startup, thus at runtime the parameters are expected to be pv-string-parsed pointer, not pointer to a string value. I expect

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Reopened #3948. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3948#event-13933037948 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailin

[sr-dev] Re: [kamailio/kamailio] rtpengine: export api (PR #3948)

2024-08-19 Thread Henning Westerholt via sr-dev
Yes, you are right, I and also others missed it unfortunately. The author probably did only minimal tests. @Fr-Soltanzadeh can you create a new PR that changes the API to use the KEMI functions as suggested? If there are more questions, let us know. -- Reply to this email directly or view it o