Not using this module to comment more on the patch, but I guess this can be
merged as there were no other comments so far.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3865#issuecomment-2146977235
You are receiving this because you are subscribe
@xkaraman: I am fine to merge it if you reviewed it and fixes it.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3863#issuecomment-2146980949
You are receiving this because you are subscribed to this thread.
Message ID: ___
@xkaraman: fine to merge it from my point of view, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3858#issuecomment-2146991340
You are receiving this because you are subscribed to this thread.
Message ID: __
@xkaraman pushed 2 commits.
642dd10c3968468a4a1201e5a39f138f5bcf510f nathelper: fixed
handle_ruri_alias_mode(1) cannot proper handle multi alias
32c73c34c8eaaa703693de414a72058db8423f23 nathelper: remove magic constant
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3863/files
Thanks, merging!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3858#issuecomment-2147088159
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developmen
@miconda Yeap, i did some experiments with the patch and it works as intended
now.
Rebased to master, removed the `+4` magic constant and will merge when checks
pass.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3863#issuecomment-2147087445
Merged #3858 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3858#event-13033452964
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Developm
Thanks for reporting and testing!
#3858 Merged to master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3350#issuecomment-2147092245
You are receiving this because you are subscribed to this thread.
Message ID: ___
Closed #3350 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3350#event-13033482386
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Devel