[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Morten Tryfoss via sr-dev
I suspect that might cause duplicate entry if any other db mode is used, after restore and then something that causes a change to the dialog - or even, not being deleted correctly since the DLG_FLAG_NEW flag is set. Please have a look at the remove_dialog_from_db() function. This will return on

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2023-12-21 Thread Henning Westerholt via sr-dev
@xkaraman -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866055685 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mai

[sr-dev] git:master:8ed4165f: pv: remove redunant variable definition (warning: unused variable ??????innerIndex??????)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 8ed4165fd3b0a331a4580894e2e7f83456b474fa URL: https://github.com/kamailio/kamailio/commit/8ed4165fd3b0a331a4580894e2e7f83456b474fa Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:23:51Z pv: remove redunant variable definition

[sr-dev] git:master:0547a4be: pv: remove another redunant variable definition (warning: unused variable ??????innerIndex??????)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 0547a4becbc6a48fdc473cfd26cdeedfa2a9317d URL: https://github.com/kamailio/kamailio/commit/0547a4becbc6a48fdc473cfd26cdeedfa2a9317d Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:34:14Z pv: remove another redunant variable de

[sr-dev] git:master:b2045d55: pv: remove another redunant variable definition related commit 8ed4165fd3b0a33

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: b2045d559ed720789df80f543fc00923a07ada83 URL: https://github.com/kamailio/kamailio/commit/b2045d559ed720789df80f543fc00923a07ada83 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:54:52Z pv: remove another redunant variable de

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
> You should probably only do this if: > if(dlg_db_mode == DB_MODE_SHUTDOWN) { Yes, i missed it, will test all the db modes. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3669#issuecomment-1866163424 You are receiving this because you are subs

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2023-12-21 Thread Daniel-Constantin Mierla via sr-dev
@miconda commented on this pull request. > @@ -825,6 +837,16 @@ int usrloc_dmq_send_contact( srjson_AddNumberToObject(&jdoc, jdoc.root, "reg_id", ptr->reg_id); srjson_AddNumberToObject(&jdoc, jdoc.root, "server_id", ptr->server_id); + /* Loop through Χavp attributes of t

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2023-12-21 Thread Daniel-Constantin Mierla via sr-dev
The commit for usrloc #3d79568 does not only change the destroy order, is it also fixing something? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1866178136 You are receiving this because you are subscribed to this thread. Mess

[sr-dev] git:master:4399fe39: sms: define buffer size for name field

2023-12-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 4399fe3966f6774b18e02ea6e54a5ba132c7c4ab URL: https://github.com/kamailio/kamailio/commit/4399fe3966f6774b18e02ea6e54a5ba132c7c4ab Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-12-21T13:56:28+01:00 sms: define buffer siz

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2023-12-21 Thread Xenofon Karamanos via sr-dev
@xkaraman pushed 2 commits. a192e503f58507fdca4dc5cb861a4dc309873e81 dmq_usrloc: Transfer attributes 6673124597eb94bcf00d81c5e2598d4eee7ee832 usrloc: Modify destroy order and contact xavp -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3679/files/3d79568e13f5fbc947ad1452244bf1

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2023-12-21 Thread Xenofon Karamanos via sr-dev
@xkaraman commented on this pull request. > @@ -825,6 +837,16 @@ int usrloc_dmq_send_contact( srjson_AddNumberToObject(&jdoc, jdoc.root, "reg_id", ptr->reg_id); srjson_AddNumberToObject(&jdoc, jdoc.root, "server_id", ptr->server_id); + /* Loop through Χavp attributes of

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2023-12-21 Thread Xenofon Karamanos via sr-dev
Hey Daniel, Besides the order change of destroy, it copies to the new contact the `xavp` from incoming `ucontact_t` argument just like the rest of the fields. If the config variable `xavp_contact` is found and not empty, then `ucontact_xavp_store` destroy this xavp and fills it up with whatev

[sr-dev] git:master:ac4fa112: tmx: use unsigned for bitwise operations

2023-12-21 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: ac4fa1129f5fbd1a48aad1b7dc21a2c130ecd164 URL: https://github.com/kamailio/kamailio/commit/ac4fa1129f5fbd1a48aad1b7dc21a2c130ecd164 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2023-12-21T16:05:04+01:00 tmx: use unsigned for

[sr-dev] git:master:4c939854: pua: fix possible copy/paste error, we should use reginfo_increase_version for reginfo events (GH #3234)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 4c93985437122706bc68143b2f96a9d7f35be16d URL: https://github.com/kamailio/kamailio/commit/4c93985437122706bc68143b2f96a9d7f35be16d Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T16:10:25Z pua: fix possible copy/paste error, we

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2023-12-21 Thread Xenofon Karamanos via sr-dev
Hey @xadhoom, A commit has been made in 4c93985 that probably fixes this, can you maybe help and confirm it works? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866586959 You are receiving this because you are subscr

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
I have tested all 3 DB modes with my latest modifications, the results look correct: ``` === Test mode 1 === modparam("dialog", "db_url", "sqlite:///etc/kamailio/sqlite.db") modparam("dialog", "db_mode", 1) # systemctl start kamailio # echo 'select "dlgs: "||count(*) from dialog'|sqlite3 sqlite.

[sr-dev] Re: [kamailio/kamailio] Dialogs loaded from the DB are no longer saved. (Issue #3669)

2023-12-21 Thread Dennis via sr-dev
I have tested all 3 DB modes with my latest modifications, the results look correct: ``` === Test mode 1 === modparam("dialog", "db_url", "sqlite:///etc/kamailio/sqlite.db") modparam("dialog", "db_mode", 1) # systemctl start kamailio # echo 'select "dlgs: "||count(*) from dialog'|sqlite3 sqlite.

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2023-12-21 Thread Matteo via sr-dev
Sure, I'll be able to test it in the very beginning of the new year, will keep you posted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866982085 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] [kamailio/kamailio] build error on Alpine: grep -P not supported in BusyBox anymore (Issue #3686)

2023-12-21 Thread Victor Seva via sr-dev
### Description It seems PCRE is not supported anymore ``` make[2]: --libs: No such file or directory grep: unrecognized option: P BusyBox v1.36.1 (2023-12-20 14:59:51 UTC) multi-call binary. ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues

[sr-dev] Re: [kamailio/kamailio] build error on Alpine: grep -P not supported in BusyBox anymore (Issue #3686)

2023-12-21 Thread Victor Seva via sr-dev
Closed #3686 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3686#event-11323919412 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] git:master:16302854: db_redis: replace use of grep -P

2023-12-21 Thread Victor Seva via sr-dev
Module: kamailio Branch: master Commit: 163028549df3abd3173a7c0ac8a9dc666c0e4879 URL: https://github.com/kamailio/kamailio/commit/163028549df3abd3173a7c0ac8a9dc666c0e4879 Author: Victor Seva Committer: Victor Seva Date: 2023-12-22T08:53:32+01:00 db_redis: replace use of grep -P PCRE option is

[sr-dev] git:master:ca450901: ndb_redis: replace use of grep -P

2023-12-21 Thread Victor Seva via sr-dev
Module: kamailio Branch: master Commit: ca4509013a123f02d6d9c09d016fce3fea3e3dbe URL: https://github.com/kamailio/kamailio/commit/ca4509013a123f02d6d9c09d016fce3fea3e3dbe Author: Victor Seva Committer: Victor Seva Date: 2023-12-22T08:53:45+01:00 ndb_redis: replace use of grep -P PCRE option i