[sr-dev] [kamailio/kamailio] siputils: fix time_t warning and a typo (PR #3266)

2022-10-16 Thread micmac1
Fix the below warning one gets when compiling siputils for a 32 bit target against a time64 libc (musl). Also fix a spelling mistake on the same line ("autdated" -> "outdated"). ``` siputils.c: In function 'ki_hdr_date_check': ../../core/parser/../dprint.h:321:73: warning: format '%ld' expects

Re: [sr-dev] [kamailio/kamailio] time: add support for time64 libc (PR #2894)

2021-10-22 Thread micmac1
> Thanks for the pull request. Just inventing a new patch category is not the > right approach, sorry. Changed to core. > Please just use "core" for the core part and the other module parts as > individual commits per module with the respective module name as prefix. Done. Kind regards, Seb

Re: [sr-dev] [kamailio/kamailio] time: add support for time64 libc (PR #2894)

2021-10-22 Thread micmac1
> Thanks for the pull request. Just inventing a new patch category is > not the right approach, sorry. > > Please just use "core" for the core part and the other module parts as > individual commits per module with the respective module name as > prefix. No problem, will do. > One small question

[sr-dev] [kamailio/kamailio] time: add support for time64 libc (PR #2894)

2021-10-22 Thread micmac1
libcs are implementing changes to fix the year 2038 issue on 32 bit platforms (see [1]). musl libc already went ahead and implemented it, starting with musl-1.2.0 (see [2]). This commit adds a new definition to src/core/dprint.h: TIME_T_INT_FMT If __USE_TIME_BITS64 is defined (by a time64 libc,

Re: [sr-dev] [kamailio/kamailio] app_python3: Makefile - suppress warning if --embed is not supported by python3-config (392688f)

2020-04-13 Thread micmac1
> @micmac1: I did it because after merging your PR, I got usage message on > macos: > > ``` > $ python3-config --ldflags --embed > Usage: /opt/local/bin/python3-config > [--prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--extension-suffix|--help|--abiflags|--c

Re: [sr-dev] [kamailio/kamailio] app_python3: Makefile - suppress warning if --embed is not supported by python3-config (392688f)

2020-04-13 Thread micmac1
Hello @miconda Just as a comment, I thought about this, too, but in the end decided against it because the python3(.x)-config scripts don't send out error messages to stderr. exit_with_usage() echoes to stdout. So if there is an error message it'll be saved inside "tmp_py3_libs". Kind regards

[sr-dev] [kamailio/kamailio] app_python3: update Python3 detection mechanism (#2282)

2020-04-12 Thread micmac1
This commit - removes the python calls whose output is never actually used. - changes the include discovery to use python3(.x)-config. This is preferable because it also works for cross-compiling. Calling python3(.x) directly will always provide host flags, which for cross-compili

Re: [sr-dev] [kamailio/kamailio] modules: fix hiredis handling (#1816)

2019-01-28 Thread micmac1
Closed #1816. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1816#event-2101681555___ Kamailio (SER) - Development Mailing List sr-dev@lis

Re: [sr-dev] [kamailio/kamailio] modules: fix hiredis handling (#1816)

2019-01-28 Thread micmac1
Hello Daniel, Sorry, my mistake. The current handling is correct. I'll close this pull request. With kind regards, Seb -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1816#issueco

[sr-dev] [kamailio/kamailio] modules: fix hiredis handling (#1816)

2019-01-20 Thread micmac1
The define WITH_HIREDIS_PATH causes the source files to include "". But the Makefiles check HIREDISDEFS for the string "hiredis" and set WITH_HIREDIS_PATH if not found. Which is exactly the opposite of what is needed. This commit corrects the logic. Signed-off-by: Sebastian Kemper Pre-S

[sr-dev] [kamailio/kamailio] kamctl: keep it POSIX (#1815)

2019-01-20 Thread micmac1
Hi all, I was trying to add entries to a remote database on OpenWrt and kamctl (address add ...) seemed to just hang there. A bit of digging showed that it prompted for a password, but I couldn't see it because it redirected the prompt to /dev/stderr, which doesn't exist on every system. This p

[sr-dev] [kamailio/kamailio] dialplan: fix dp_replace() in cmd_export_t struct (#1704)

2018-11-02 Thread micmac1
In the struct `int param_no` is set to `2`. But `dp_replace()` has actually three parameters `(dpid, inval, outvar)`, so kamailio's cfg parser fails when `dp_replace()` is called: ``` yyparse(): cfg. parser: failed to find command dp_replace (params 3) yyerror_at(): parse error in config file /et

[sr-dev] [kamailio/kamailio] kamctl: make jsonrpc filter portable (#1669)

2018-10-07 Thread micmac1
The filter has a regex looking for a literal '{' in the beginning of a line. Some awk implementations interpret this as a meta character, so the regex is deemed broken. Example with busybox awk (POSIX): `root@hank2:~# kamctl ps` `awk: bad regex '^{.+"id"[ ]*:[]*[0-9]+[ ]*}$': Invali