> @nchaigne are you interested in working further on this? Right now its also
> in a conflict state due to other changes in the last weeks in the core.
Hello Henning,
Unfortunately I don't think I will be able to continue working on this.
As Daniel pointed out, it is currently too limited in sco
@nchaigne commented on this pull request.
On src/modules/http_client/doc/http_client_admin.xml:
Typos : "paramters", "cirtificates"
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3619#pullrequestreview-1701397662
You are receiving this because
The behaviour is actually documented:
"The HTTP connection will be defined using default values in modparam's **above
the definition of the httpcon** in the configuration file."
But this can easily be overlooked. I also had trouble understanding why my
configuration did not work initially.
It's
@nchaigne pushed 1 commit.
32a1c04d1643f40fbb4e75a3b0d7c07b913de0c1 http_client: Add parameter
timeout_mode (timeout in seconds or milliseconds)
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3615/files/93fccd8430617cfc7ec6b3729bd0278faa3b1684..32a1c04d1643f40fbb4e75a3b0d7c07b
@nchaigne commented on this pull request.
> @@ -854,3 +854,24 @@ curl_con_t *curl_init_con(str *name)
LM_DBG("CURL: Added connection [%.*s]\n", name->len, name->s);
return cc;
}
+
+/*! Fixup CURL connections - if timeout is not configured, Use as default
global connection_timeo
@nchaigne commented on this pull request.
> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)
- Default value is zero, i.e.,
- the timeout funct
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for m
@nchaigne commented on this pull request.
> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)
- Default value is zero, i.e.,
- the timeout funct
@nchaigne commented on this pull request.
> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)
- Default value is zero, i.e.,
- the timeout funct
@nchaigne commented on this pull request.
> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)
- Default value is zero, i.e.,
- the timeout funct
> I don't see a major difference from the point of view of the internal
> variables/fields compared with the other PR #3609.
>
> Maybe a simpler approach is to introduce a new parameter to specify what is
> the type (unit) of the timeout, like `timeout_mode`, which if it is 0
> (default) is goi
Alright, the new pull request is done:
https://github.com/kamailio/kamailio/pull/3611
I have tested locally with all possible combinations (I hope).
Yes, it's a bit complicated... having just a timeout in ms would have been much
simpler. But I wanted to avoid breaking existing configurations.
An
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for m
> It might add more complexity to try to work on the same variable, as I
> quickly looked over the commit of the PR, one field is inside a cfg-param
> reload structure, which is trickier to figure out if it was set because of a
> modparam or because of a rpc command and then know which parameter
> It might add more complexity to try to work on the same variable, as I
> quickly looked over the commit of the PR, one field is inside a cfg-param
> reload structure, which is trickier to figure out if it was set because of a
> modparam or because of a rpc command and then know which parameter
Regarding the http_client API, there is no impact, because it uses the name of
a preset http connection.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3609#issuecomment-1773045819
You are receiving this because you are subscribed to this thread.
> I think we need two config options - but they set the same variable
> internally and only call ONE curl interface - the one you add here. We need
> also to verify the http_client API if we need to add something there. Having
> two variables internally is just overhead.
Alright, I'll try somet
> Thank you for contributing. I would prefer if there's only one variable and
> that we use the milliseconds always internally and just keep the old setting
> for backwards compatibility.
What do you mean exactly ?
A single parameter "timeout" which could store seconds and milliseconds, e.g.
"1
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for mo
19 matches
Mail list logo
