drTr0jan left a comment (kamailio/kamailio#4155)
Also 69086114ad6eee016d1b7634f37c5ef31d4543e0 cherry-pick will be great!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4155#issuecomment-2713350580
You are receiving this because you are subscribed
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for mo
drTr0jan left a comment (kamailio/kamailio#4155)
@miconda, why 1f3b45056caf298062c6fbe683660ac6c158331a and
41b2cba74a9fff204b2cc671670073d008b3c6b1 hasn't been cherry-picked to 6.0.1?
Can you cherry-pick them to 6.0.2?
--
Reply to this email directly or view it on GitHub:
https://github.com/k
@drTr0jan commented on this pull request.
> @@ -1,3 +1,9 @@
file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
+
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(PCRE2 REQUIRED IMPORTED_TARGET libpcre2-8)
Yep, you're right! Fixed. Thx!
--
Reply to thi
@drTr0jan pushed 2 commits.
eb918897d7efcd5b5f1e0cdecff2ea3d77235802 sctp: cmake - search for libsctp on
linux only
e1577208ffcbf2591354f31fe26bbf3851d85781 dialplan: cmake - add pcre2
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/4155/files/bd9e7dcf0be7d7525dad08a65e606cf2a
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for mo
### Description
There're `1xx_replies` metric in `sl` module. But the metric doesn't work.
### Troubleshooting
There're no handle in `void update_sl_stats(int code)`.
https://github.com/kamailio/kamailio/blob/f37940b9a113ab79611f851334af7f8fbb7b3f6a/src/modules/sl/sl_stats.c#L151-L153
### Propo
> @drTr0jan: would you have time to test the cmake-based building system on
> FreeBSD? I am not sure if anyone tried it yet, as I can't say if there are
> many people using FreeBSD active in our development space. The plan is to
> replace the old-Makefiles with cmake, some tutorials are availabl
> Indeed we may have to alter some of the link stuff of `kamailio` and `kamcmd`
> as noted by @drTr0jan for proper `FreeBSD` support.
>
> Regarding the
>
> https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa5423004879f55/cmake/defs.cmake#L321
>
> , it will probably go away and
@drTr0jan commented on this pull request.
> @@ -8,7 +8,7 @@ option(PROFILE "Enable profiling" OFF)
add_library(common_compiler_flags INTERFACE)
# Define the flags for the C compiler
-if(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
+if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|amd64")
Yes, of cour
> That is the default one used if none is provided.
I think, the default value should be a `USE_SYSV_SEM` as in Makefiles.defs:
https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa5423004879f55/src/Makefile.defs#L2156-L2160
> If FreeBSD requires some other we can overwrite the va
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for mo
@miconda, I can't promise for the testing, but I'll try. I am a little familiar
with CMake.
You can open an issue for the testing and assign me.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4099#issuecomment-2584077379
You are receiving this bec
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for mo
14 matches
Mail list logo
