[sr-dev] Re: [kamailio/kamailio] pua_reginfo: free pkg memory after getting the XML attribute (PR #3953)

2024-08-26 Thread Andrew Pogrebennyk via sr-dev
@linuxmaniac the PR comments have been incorporated, please recheck. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3953#issuecomment-2310334134 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] pua_reginfo: free pkg memory after getting the XML attribute (PR #3953)

2024-08-26 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk commented on this pull request. > @@ -439,10 +477,11 @@ int process_body(str notify_body, udomain_t *domain) if(xmlStrcasecmp(params->name, BAD_CAST "unknown-param") !=

[sr-dev] Re: [kamailio/kamailio] pua_reginfo: free pkg memory after getting the XML attribute (PR #3953)

2024-08-26 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk commented on this pull request. > @@ -417,12 +450,17 @@ int process_body(str notify_body, udomain_t *domain) if(xmlStrcasecmp(params->name, BAD_CAST "unknown-param") != 0)

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-26 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk pushed 1 commit. 969f7f8bc80872e2e66d1f992eb93bced6fb2aa3 pua_reginfo: free pkg memory after getting the content of each XML attribute -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3953/files/1d6b6439b3e312d303546fcdccd0b9aaafda4672..969f7f8bc80872e2e66d1f992eb9

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
This looks stable now. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3953#issuecomment-2302842068 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk pushed 1 commit. 4d1207f99eff84785b00752d6d9723bd9faac115 fix(pua_reginfo): fix contact_uri memory leak -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3953/files/ec690a7d93715423cb6d50412756df6272dca067..4d1207f99eff84785b00752d6d9723bd9faac115 You are receiving

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk pushed 1 commit. ec690a7d93715423cb6d50412756df6272dca067 fix(pua_reginfo): free pkg memory after getting the content of each XML attribute -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3953/files/11ea7ab0ae105882c402ccd45a244881cadbe910..ec690a7d93715423cb6d504

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk pushed 1 commit. 11ea7ab0ae105882c402ccd45a244881cadbe910 fix(pua_reginfo): free pkg memory after getting the content of each XML attribute -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3953/files/578297d62c1e37abc11ddce6cd4e36a824fe2407..11ea7ab0ae105882c402ccd

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
Local test running, I will update the checklist once I notice no new memory leaks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3953#issuecomment-2301604662 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] Re: [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
@apogrebennyk pushed 1 commit. 578297d62c1e37abc11ddce6cd4e36a824fe2407 fix(pua_reginfo): free pkg memory after getting the content of each XML attribute -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3953/files/0e48c3f32a356862e824b6f65e258e7a99f73e45..578297d62c1e37abc11ddce

[sr-dev] [kamailio/kamailio] fix(pua_reginfo): free pkg memory after getting the XML attribute (PR #3953)

2024-08-21 Thread Andrew Pogrebennyk via sr-dev
fix(pua_reginfo): free pkg memory after getting the XML attribute - free the memory from the state XML attribute that was returned and immediately used in another function call without freeing leaving one small mem leak; - add comments but keep the dead code regarding parsed but unused attrs.

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-30 Thread Andrew Pogrebennyk via sr-dev
Will do, thanks again. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3928#issuecomment-2258227084 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing Lis

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-30 Thread Andrew Pogrebennyk via sr-dev
Closed #3928 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3928#event-13695190417 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-29 Thread Andrew Pogrebennyk via sr-dev
@henningw it is a fork from pre-5.4 Henning, actually I am going to test the latest release because this is a separate kamailio registrar that is not dependable on the IMS modules for which we maintain a lot of customizations. I have not been yet able to test the mem_delete_ucontact() line addi

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-25 Thread Andrew Pogrebennyk via sr-dev
I think the pua is cleaning the memory in normal scenario, there has been some other passing issue such as innodb locks that caused some transactions to get stuck. Sorry for confusion. I understood the point about the tm callbacks. I am still investigating some mem leak in usrloc for XAVP when w

[sr-dev] Re: [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-24 Thread Andrew Pogrebennyk via sr-dev
Thank you Daniel! On Tue, Jul 23, 2024 at 6:28 PM Daniel-Constantin Mierla via sr-dev < sr-dev@lists.kamailio.org> wrote: > As far as I know, *reginfo* is not used (much, if at all) outside of ims > world, so it might be related to *pua_reginfo*. Maybe you can look at > pua_dialoginfo and see how

[sr-dev] [kamailio/kamailio] Suspected mem leak in the pua and request for ideas (Issue #3928)

2024-07-22 Thread Andrew Pogrebennyk via sr-dev
Hi! it seems the pua module in send_subscribe ( ) is leaking some memory because the hentity is not released. According to memory allocations the shmem allocated for hentity is not cleaned. ``` 1454582 file = 0x70e59fd30209 "usrloc: ../../core/ut.h", func = 0x70e59fd326c8 <__func__.16> "shm_str_d