[sr-dev] Re: [kamailio/kamailio] dispatcher: ds_is_from_list() with mode flag 16 provides only exact matches (Issue #4236)

2025-06-11 Thread Daniel-Constantin Mierla via sr-dev
miconda left a comment (kamailio/kamailio#4236) I haven't implemented that matching mode and it was a bit weird from the beginning (weight of matching socket is higher than port+proto), anyhow, what you commented seemed valid, the continue statements were preventing the setting of a matching no

[sr-dev] Re: [kamailio/kamailio] rr: loose_route_mode: add vmode bit 2 to skip outbound (PR #4280)

2025-06-11 Thread Daniel-Constantin Mierla via sr-dev
miconda left a comment (kamailio/kamailio#4280) I think it is better so, more flexible via function param. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4280#issuecomment-2963734291 You are receiving this because you are subscribed to this thread

[sr-dev] Re: [kamailio/kamailio] rtpengine: make myseqn more random (Issue #4281)

2025-06-11 Thread Henning Westerholt via sr-dev
henningw left a comment (kamailio/kamailio#4281) Thanks for the report. I have some pending changes related to randomness in other areas as well, let me have a look to it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4281#issuecomment-2963489

[sr-dev] git:master:dfb5ef6f: dispatcher: rename varaiable about strictest match with common prefix

2025-06-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: dfb5ef6f9d670a9ee2de223eac0a665f9e5cab71 URL: https://github.com/kamailio/kamailio/commit/dfb5ef6f9d670a9ee2de223eac0a665f9e5cab71 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2025-06-11T19:56:57+02:00 dispatcher: rename var

[sr-dev] [kamailio/kamailio] rtpengine: make myseqn more random (Issue #4281)

2025-06-11 Thread Christian Berger via sr-dev
ChristianBergerSipgate created an issue (kamailio/kamailio#4281) ### Description The rtpengine module uses a `cookie` field in the Protocol controlling rtpengines. This field needs to be unique, and is derived from the `server_id` field set in the Kamailio, the `pid` as well as the value of a v

[sr-dev] Re: [kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)

2025-06-11 Thread Henning Westerholt via sr-dev
henningw left a comment (kamailio/kamailio#4250) > @henningw no, as @miconda mentions. > > > The ACKs for 200ok are end-to-end, should not be generated by Kamailio, > > just forwarded (stateless). But the ACKs for 300+ replies of > > received+relayed INVITEs are hop-by-hop, and they should not

[sr-dev] Re: [kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)

2025-06-11 Thread tsearle via sr-dev
tsearle left a comment (kamailio/kamailio#4250) @henningw no, as @miconda mentions. > The ACKs for 200ok are end-to-end, should not be generated by Kamailio, just > forwarded (stateless). But the ACKs for 300+ replies of received+relayed > INVITEs are hop-by-hop, and they should not trigger b

[sr-dev] Re: [kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)

2025-06-11 Thread tsearle via sr-dev
tsearle left a comment (kamailio/kamailio#4250) @henningw Correct, only 2xx OK to Generated INVITE will have an ACK in the local request. I tested the 2xx case, @xkaraman tested the non-2xx case, I am not sure if he retested with a 2xx case. -- Reply to this email directly or view it on GitHu

[sr-dev] Re: [kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)

2025-06-11 Thread Henning Westerholt via sr-dev
henningw left a comment (kamailio/kamailio#4250) > @henningw Correct, only 2xx OK to Generated INVITE will have an ACK in the > local request. I tested the 2xx case, @xkaraman tested the non-2xx case, I am > not sure if he retested with a 2xx case. Thanks for the feedback. But it should trigger

[sr-dev] Re: [kamailio/kamailio] tm: invoke tm:local-request on generated ACK messages (PR #4250)

2025-06-11 Thread Henning Westerholt via sr-dev
henningw left a comment (kamailio/kamailio#4250) It got a bit confusing for me, so I tried to summarize the different cases: 1. INVITE between phones A-Proxy-B, no ACK logging in local request event route for 200 OK and non 200 OK This seems to be working as expected with the PR according to

[sr-dev] Re: [kamailio/kamailio] rr: loose_route_mode: add vmode bit 2 to skip outbound (PR #4280)

2025-06-11 Thread Michael Furmur via sr-dev
furmur left a comment (kamailio/kamailio#4280) changed to use new _vmode_ value in `loose_route_mode(vmode)` instead of the `force_lr_no_outbound_flag` param -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4280#issuecomment-2962612683 You are rece

[sr-dev] [kamailio/kamailio] rr: add force_lr_no_outbound_flag param (PR #4280)

2025-06-11 Thread Michael Furmur via sr-dev