[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)

2024-08-29 Thread Ivan Ribakov via sr-dev
> Does it affect in any way the modules log_custom or log_systemd? Hi @miconda , did the above answer provide sufficient details for you? > it seems rather important change considering that logging is critical > component Perhaps you would us to make any additional changes to further isolate th

[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)

2024-08-29 Thread github-actions[bot] via sr-dev
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3902#issuecomment-2319752277 You are receiving this because you are

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix api using ki functions (PR #3956)

2024-08-29 Thread Richard Fuchs via sr-dev
> I changed all function names to rtpengine_xxx . This way is better for > readability and fixes the problem. As long as there are no other modules that will ever use this binding ... 😆 (Welcome to one of the only two hard things in computer science) Anyway, fine with me -- Reply to this emai

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix api using ki functions (PR #3956)

2024-08-29 Thread Farzaneh Soltanzadeh via sr-dev
I changed all function names to rtpengine_xxx . This way is better for readability and fixes the problem. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3956#issuecomment-2317361312 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix api using ki functions (PR #3956)

2024-08-29 Thread Farzaneh Soltanzadeh via sr-dev
@Fr-Soltanzadeh pushed 1 commit. 4bca9684b258dbb4fe679c197a56f61a5f09ca2c use ki functions as exported api functions -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3956/files/1d8336ee26e4117f067c6389b0b8e551d05e18ef..4bca9684b258dbb4fe679c197a56f61a5f09ca2c You are receiving t

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix api using ki functions (PR #3956)

2024-08-29 Thread Henning Westerholt via sr-dev
> I see that `delete` field was renamed to `_delete`. Any particular reason it > was done now? Refer to the discussion in the PR, Richard also raised it. We probably should stay with the "delete". We can rename it when necessary due to C++. -- Reply to this email directly or view it on GitHub:

[sr-dev] git:master:0a2517f6: siputils: export sip_parse_headers() to kemi

2024-08-29 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 0a2517f6e1b6a49eafd1846c1d65b4420ed404f5 URL: https://github.com/kamailio/kamailio/commit/0a2517f6e1b6a49eafd1846c1d65b4420ed404f5 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-08-29T11:46:23+02:00 siputils: export sip_p

[sr-dev] Re: [kamailio/kamailio] dialog: Remove deprecated dlg_flag (PR #3961)

2024-08-29 Thread Henning Westerholt via sr-dev
Thanks for the PR. There are several modules that seems to related to the dlg_flag: * nat_traversal * call_control * cnxx * acc * qos * sst * pua_dialoginfo * mediaproxy * different IMS modules (ims_dialog will be not changed in this PR) Some of the modules are using it only to check if there is

[sr-dev] [kamailio/kamailio] move app_mono to archive (PR #3964)

2024-08-29 Thread Victor Seva via sr-dev
Pre-Submission Checklist