If the array is used only in that file, I would suggest to make it static and
maybe it would be also good rename it to p_usrloc_columns (or similar) to have
the module prefix in the name, being a global variable.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/
Thank you Henning, let's see if there are other comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3845#issuecomment-2104412982
You are receiving this because you are subscribed to this thread.
Message ID: ___
Can you try with master branch or the patch from the commit references above?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3835#issuecomment-2104391186
You are receiving this because you are subscribed to this thread.
Message ID: _
Module: kamailio
Branch: master
Commit: d1f377ff23f491bfd5162cb7bf510759440dd8e5
URL:
https://github.com/kamailio/kamailio/commit/d1f377ff23f491bfd5162cb7bf510759440dd8e5
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-05-10T12:45:25+02:00
sipcapture: use local
Module: kamailio
Branch: master
Commit: 9b087fd618ab6c5cbd6a29c352b09c7198f1b594
URL:
https://github.com/kamailio/kamailio/commit/9b087fd618ab6c5cbd6a29c352b09c7198f1b594
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-05-10T08:17:17+02:00
tcpops: reformat expor
I am not a C developer so I have to guess here.
For me it looks like the `static` address of `buff` is returned by `ip_addr2a`.
```c
char *ip_addr2a(struct ip_addr *ip)
{
static char buff[IP_ADDR_MAX_STR_SIZE];
// ...
return buff;
}
```
--
https://github.com/kamailio/kam
For kamailio 5.8 we have used
```
# gcc --version
gcc (Debian 12.2.0-14) 12.2.0
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3835#issuecomment-2104301799
You are receiving this because you are subscribed to this thread.
Message ID: __
Looks good to me. It similar code is used in usrloc udomain.c, the same
refactoring could be of course also done there.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3845#issuecomment-2104180664
You are receiving this because you are subscribed t
Pre-Submission Checklist