[sr-dev] Re: [kamailio/kamailio] uac: add reload_delta parameter (PR #3829)

2024-04-25 Thread Henning Westerholt via sr-dev
Thanks for the PR. Could you please fix the format by running clang-format on the files and do a force-push to update the individual commit(s)? This check is right now failing. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3829#issuecomment-2078

[sr-dev] Re: [kamailio/kamailio] multiple subsytems: unsigned integer conversion fixes (PR #3828)

2024-04-25 Thread Henning Westerholt via sr-dev
Thanks for the PR. Could you please fix the format by running clang-format on the files and do a force-push to update the individual commits? This check is right now failing. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3828#issuecomment-207868

[sr-dev] git:master:9f284503: uid_auth_db: spelling fix in documentation

2024-04-25 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 9f28450312749dfbc021a8cbc23472c8a39d3fef URL: https://github.com/kamailio/kamailio/commit/9f28450312749dfbc021a8cbc23472c8a39d3fef Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-04-26T05:54:27Z uid_auth_db: spelling fix in documentat

[sr-dev] git:master:db176a49: core: spelling fix in comment and log message

2024-04-25 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: db176a4918c0b500f5f051cad16fd8d442450ab7 URL: https://github.com/kamailio/kamailio/commit/db176a4918c0b500f5f051cad16fd8d442450ab7 Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-04-26T05:53:30Z core: spelling fix in comment and log m

[sr-dev] Re: [kamailio/kamailio] utils/kamctl: make root host/port configurable (PR #3830)

2024-04-25 Thread Tyler Moore via sr-dev
## background We found that mariadb ver >= 10.6.1 --port= now defaults to transport=tcp. Using mysql client to connect to a unix socket --port= should **not** be provided. To support this in kamdbctl the port / host is only added to the command if *set* in kamctlrc. ## tests Tested with ma

[sr-dev] [kamailio/kamailio] utils/kamctl: make root host/port configurable (PR #3830)

2024-04-25 Thread Tyler Moore via sr-dev
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for mo

[sr-dev] [kamailio/kamailio] uac: add reload_delta parameter (PR #3829)

2024-04-25 Thread Tyler Moore via sr-dev
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for mo

[sr-dev] Re: [kamailio/kamailio] Uint fixes (PR #3828)

2024-04-25 Thread Tyler Moore via sr-dev
For testing this was validated on master with the setup below. ## environment ``` root@kam:~# uname -a Linux kam 6.1.0-9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.27-1 (2023-05-08) x86_64 GNU/Linux ``` ``` root@kam:~# lsb_release -a Distributor ID: Debian Description:Debian GNU/Linux 12 (book

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-25 Thread Ostap via sr-dev
@ostap0207 commented on this pull request. > } static int ki_statsd_decr_with_labels(sip_msg_t *msg, str *key, str *labels) { - return statsd_count(key->s, "-1", labels->s); + return convert_result(statsd_count(key->s, "-1", labels->s)); +} + +static int convert_result(bool resu

[sr-dev] [kamailio/kamailio] Uint fixes (PR #3828)

2024-04-25 Thread Tyler Moore via sr-dev
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for mo

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-25 Thread Daniel-Constantin Mierla via sr-dev
@miconda commented on this pull request. > } static int ki_statsd_decr_with_labels(sip_msg_t *msg, str *key, str *labels) { - return statsd_count(key->s, "-1", labels->s); + return convert_result(statsd_count(key->s, "-1", labels->s)); +} + +static int convert_result(bool result

[sr-dev] [kamailio/kamailio] usrloc: delete location_attrs in db_only mode on delete_urecord (PR #3827)

2024-04-25 Thread Rick Barenthin via sr-dev