[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Morten Tryfoss via sr-dev
Thanks for the tip! Updated with shm_realloc() now. Also rebased with master, and the check seems to be successful. I'm currently also investigating a deadlock issue (#3641), but it doesn't seem to be related to changes in this PR. Any feedback there would be helpful too. -- Reply to this emai

[sr-dev] Re: [kamailio/kamailio] topos: Add db version check (PR #3639)

2023-11-14 Thread Daniel-Constantin Mierla via sr-dev
If I haven't overlooked something, it seems to be missing closing db connection on mod_init, which results in inheriting it on children after fork and conflicts during runtime. Maybe it is better to move it in child_init with rank 1, we discussed a bit about that during K Devs meeting. Further

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Morten Tryfoss via sr-dev
@mtryfoss pushed 1 commit. d924b632a8157d9f856d039d91ba26453e2c9725 ims_charging: Various changes to make module compatible to other charging servers -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3640/files/cefa42dbf3eaf32fea9b7e232aaf6ff6e4013896..d924b632a8157d9f856d039d91b

[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: add AoR parameter to ipsec_destroy() (Issue #3570)

2023-11-14 Thread github-actions[bot] via sr-dev
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3570#issuecomment-1811719467 You are receiving this because yo

[sr-dev] [kamailio/kamailio] Deadlock in ims_charging / cdp modules on connection issues (Issue #3641)

2023-11-14 Thread Morten Tryfoss via sr-dev
### Description I've been simulating calls while there's (faked) issues against the diameter server using TCP. Ro_CCR() uses t_suspend() to suspend the SIP transaction while waiting for a response from the charging server. A cdp transaction is also created with a callback to resume_on_initial_

[sr-dev] Re: [SR-Users] Obsoleting unmaintained modules

2023-11-14 Thread Daniel-Constantin Mierla via sr-dev
Good spot, actually uri_db was not proposed to be obsoleted, my mistake on copy&paste the group of uid* modules. Cheers, Daniel On 14.11.23 14:12, Social Boh wrote: > I use uri_db module and the does_uri_exist() function to know if a > user exist or not. > > I don't know if there is other functio

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Henning Westerholt via sr-dev
Thanks for the PR. Regarding your questions about the shared memory management, there is a function to re-alloc an existing memory segment for SHM and PKG pool [link](https://www.asipto.com/pub/kamailio-devel-guide/#c04shm_realloc) -- Reply to this email directly or view it on GitHub: https://g

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Henning Westerholt via sr-dev
Yes, I don't know why it fails for older commits. If its not related to changes you've done, it can be ignored. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3640#issuecomment-1810148053 You are receiving this because you are subscribed to this t

[sr-dev] Obsoleting unmaintained modules

2023-11-14 Thread Daniel-Constantin Mierla via sr-dev
Hello, during the Kamailio Developers Meeting 2023 in Dusseldorf that took place last week, it was proposed to obsolete modules that seem to be unmaintained and no activity about them was noticed during the past years. It is quite some overhead in packaging them and trying to keep them compiling w

[sr-dev] Releasing v5.7.3

2023-11-14 Thread Daniel-Constantin Mierla via sr-dev
Hello, I am considering to release Kamailio v5.7.3 (out of branch 5.7) soon (likely on Friday 17 or during the beginning of next week). If anyone is aware of issues not yet on the bug tracker, report them there asap in order to have a better chance to be fixed. Cheers, Daniel -- Daniel-Constant

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Morten Tryfoss via sr-dev
I notice check-format fails, but that doesn't seem to be from this PR? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3640#issuecomment-1809876548 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Morten Tryfoss via sr-dev