Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-24 Thread Kalki70
I never said there was a bug. I don't think it is a bug. For me a bug is something wrong in the code, so the application does not behave as it is expected. In this case the code is right. It does what it is expected to do. Problem is, I think the expected behavior is a bad behavior. Maybe the or

Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-24 Thread Daniel-Constantin Mierla
I didn't want to be sarcastic at all, just admired how you put your perspective that you fix a bug -- you are right and others are wrong. And yes, I am sure I am not aware of all SIP scenarios, every day I am surprised on what new issues I have to troubleshoot on SIP traffic. That's why I haven'

[sr-dev] git:master:edd35d35: modules: readme files regenerated - pua ... [skip ci]

2020-06-24 Thread Kamailio Dev
Module: kamailio Branch: master Commit: edd35d35e4a0bffc0d68decb6a7895b4d47823dc URL: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b4d47823dc Author: Kamailio Dev Committer: Kamailio Dev Date: 2020-06-24T21:16:15+02:00 modules: readme files regenerated - pua ... [s

Re: [sr-dev] [kamailio/kamailio] pua readme : small typo (#2371)

2020-06-24 Thread Daniel-Constantin Mierla
Closed #2371. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2371#event-3478913961___ Kamailio (SER) - Development Mailing List sr-dev@lis

Re: [sr-dev] [kamailio/kamailio] pua readme : small typo (#2371)

2020-06-24 Thread Daniel-Constantin Mierla
I fixed it separately being a small change, the pr still has the changes to readme. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2371#issuecomment-649010311___

[sr-dev] git:master:9adccda3: pua: docs - fixed missing comma in example

2020-06-24 Thread GitHub
Module: kamailio Branch: master Commit: 9adccda325d258fe539b54ec67d4389d3a2fc72c URL: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389d3a2fc72c Author: Daniel-Constantin Mierla Committer: GitHub Date: 2020-06-24T21:05:56+02:00 pua: docs - fixed missing comma in examp

Re: [sr-dev] [kamailio/kamailio] keepalive: manage the `ping_from` config value as str. (#2372)

2020-06-24 Thread Daniel-Constantin Mierla
Merged #2372 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2372#event-3478886719___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] MOHQUEUE: Crash on procesing ACK (#2370)

2020-06-24 Thread Emmanuel Schmidbauer
Closed #2370. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2370#event-3478885973___ Kamailio (SER) - Development Mailing List sr-dev@l

[sr-dev] git:master:6e3a8aea: Merge pull request #2372 from danielmartinezruiz/keepalive_config_ka_ping_from_value_cut_off

2020-06-24 Thread GitHub
Module: kamailio Branch: master Commit: 6e3a8aea7f9f6dde462c86dfd8cd3027c2751e98 URL: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd3027c2751e98 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2020-06-24T21:00:11+02:00 Merge pull request #2372 from danielmar

Re: [sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
> Thanks! You can merge and close the related issue. > > As a side note, @kamailio-dev is a bot account, usually no human behind it to > do a review, so I removed the review request for it. oops didn't know that! should there be a "dev group" we can assign reviews to? -- You are receiving t

Re: [sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
Merged #2373 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2373#event-3478884924___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] keepalive: manage the `ping_from` config value as str. (#2372)

2020-06-24 Thread Daniel-Constantin Mierla
Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2372#issuecomment-649006651___ Kamailio (SER) - Development Mailing List sr-dev@lis

[sr-dev] git:master:12b3cfe6: Merge pull request #2373 from kamailio/mohqueue-issue-2370

2020-06-24 Thread GitHub
Module: kamailio Branch: master Commit: 12b3cfe6fb6c48de28a9aee0420328c6ae863663 URL: https://github.com/kamailio/kamailio/commit/12b3cfe6fb6c48de28a9aee0420328c6ae863663 Author: Emmanuel Schmidbauer Committer: GitHub Date: 2020-06-24T14:59:45-04:00 Merge pull request #2373 from kamailio/mohqu

[sr-dev] git:master:6b708e93: mohqueue: use t_newtran() if transaction does not exist

2020-06-24 Thread Emmanuel Schmidbauer
Module: kamailio Branch: master Commit: 6b708e937d161101adc91a4de5a527bf190b55c0 URL: https://github.com/kamailio/kamailio/commit/6b708e937d161101adc91a4de5a527bf190b55c0 Author: Emmanuel Schmidbauer Committer: Emmanuel Schmidbauer Date: 2020-06-24T14:32:15-04:00 mohqueue: use t_newtran() if t

Re: [sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Daniel-Constantin Mierla
Thanks! You can merge and close the related issue. As a side note, @kamailio-dev is a bot account, usually no human behind it to do a review, so I removed the review request for it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on G

[sr-dev] [kamailio/kamailio] mohqueue: use t_newtran() if transaction does not exist (#2373)

2020-06-24 Thread Emmanuel Schmidbauer
Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: