Re: [sr-dev] [kamailio/kamailio] mqueue: add support for db persistency (#2359)

2020-06-17 Thread Julien Chavanton
builded and tested locally, seems like it did run out of ram, he found a real problem last time, good work -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2359#issuecomment-645625041

Re: [sr-dev] [kamailio/kamailio] mqueue: add support for db persistency (#2359)

2020-06-17 Thread Julien Chavanton
@linuxmaniac I am trying to understand the LGTM failure. ``` [2020-06-16 23:12:29] [analysis] [EVALUATION 95/150] [FAIL] Error running query semmlecode-cpp-queries/Security/CWE/CWE-079/CgiXss.ql: OutOfMemory Query evaluation ran out of memory (maximum allowed mem

Re: [sr-dev] [kamailio/kamailio] Dispatcher : Re-distribution of messages when hash used and destination not available (#2361)

2020-06-17 Thread Kalki70
It seems that addresses are loaded in reverse order in dispatcher module. As it can be seen, when Dest4 is down, it's not Dest5 which receives all load. Its Dest3. In the code it's clear that id is incremented by one, not decremented. Only explanation I see is that order of addresses is loaded i

Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-17 Thread Kalki70
When I realized the use of "use_default" flag I had trouble trying to fix the rehash in that case. According to documentation: [use_default](https://kamailio.org/docs/modules/4.3.x/modules/dispatcher.html#dispatcher.p.use_default) _3.10. use_default (int) If the parameter is set to 1, the last

Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-17 Thread Kalki70
@Kalki70 pushed 1 commit. ce177c134f00cd1509313b50163849f736b6e0a9 dispatcher : FIX. Previous implementation of rehash did not consider case when "use_default" flag is active. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/

Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-17 Thread Kalki70
@Kalki70 pushed 1 commit. fdd623a50fedd4312f8324cf8796ef00eed12af5 dispatcher: Fixs rehash of has when ds_rehash_max is 1. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/2363/files/083a5151cfe2cf4d1d4c53233b0c9

Re: [sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-17 Thread Luis Rojas
OK, guys, It seems I did the pull request right this time. Now it contains only my changes, as I verified my forked repo was in full sync with kamailio:master. if one of the maintainers could take a look at this pull request, please? It'd be great if it could be at release 5.4.0. It's a very sm

[sr-dev] [kamailio/kamailio] dispatcher : better distribution when using hash and destination is not available (#2363)

2020-06-17 Thread Kalki70