Merged #2000 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2000#event-2585925498___
Kamailio (SER) - Development Mailing Lis
Fixed by https://github.com/kamailio/kamailio/pull/2040.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2039#issuecomment-524987390___
K
Closed #2039.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2039#event-2584666320___
Kamailio (SER) - Development Mailing List
sr-dev@l
Thanks for the review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2040#issuecomment-524980037___
Kamailio (SER) - Development Mailing
Merged #2040 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2040#event-2584612402___
Kamailio (SER) - Development Mailing Lis
Module: kamailio
Branch: master
Commit: fe6614feb5f9b062a556de82fd7df6fc12c96471
URL:
https://github.com/kamailio/kamailio/commit/fe6614feb5f9b062a556de82fd7df6fc12c96471
Author: Juha Heinanen
Committer: Juha Heinanen
Date: 2019-08-23T10:05:33+03:00
modules/rtpengine: set_rtpengine_set fix
--
Module: kamailio
Branch: master
Commit: e4edf53858c399e5a3e635d04725a8a137523d15
URL:
https://github.com/kamailio/kamailio/commit/e4edf53858c399e5a3e635d04725a8a137523d15
Author: juha-h
Committer: GitHub
Date: 2019-08-26T21:43:53+03:00
Merge pull request #2040 from kamailio/set_rtpengine_set
LGTM, no objections
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2040#issuecomment-524966592___
Kamailio (SER) - Development Mailing Lis
Module: kamailio
Branch: master
Commit: 78a62e19955ada9d67245031780bad29035b0ef2
URL:
https://github.com/kamailio/kamailio/commit/78a62e19955ada9d67245031780bad29035b0ef2
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2019-08-26T16:02:22+02:00
modules: readme files regenerated - tm ... [sk
Module: kamailio
Branch: master
Commit: fa3c97a331b06ea675e830f418771e94375216cc
URL:
https://github.com/kamailio/kamailio/commit/fa3c97a331b06ea675e830f418771e94375216cc
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2019-08-26T15:52:29+02:00
tm: docs - note about
Module: kamailio
Branch: master
Commit: ce6612402f122d38878834f7da70ebf75c12b37b
URL:
https://github.com/kamailio/kamailio/commit/ce6612402f122d38878834f7da70ebf75c12b37b
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2019-08-26T15:49:42+02:00
tm: execute on_sl_repl
Module: kamailio
Branch: master
Commit: 3f1b5142c45f979b7847b2878ccf3b130baeae65
URL:
https://github.com/kamailio/kamailio/commit/3f1b5142c45f979b7847b2878ccf3b130baeae65
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2019-08-26T13:31:29+02:00
tm: lookup on_sl_reply
It has to be `%.*s`, you used `*` before the `.` -- also you do not need that
expression with address of the first char, just give `session->ip_addr.s`
instead of `&session->ip_addr.s[0]`, it should avoid array access and get
address of it -- probably there is not much difference in performance,
@miconda
I dont understand reason but it gives empty line.
loggin:
```
LM_ERR("SDP CLINE2 [%*.s][LEN: %d]
\n",session->ip_addr.len,&session->ip_addr.s[0],session->ip_addr.len);
LM_ERR("SDP CLINE2 [%s] \n",&session->ip_addr.s[0]);
```
here is result
```
9(4455) ERROR: {1 1 INVITE 1-4478@192.168.
Have you tested that session->ip_addr.len>0? Can you print the str value for
session->ip_addr and see if it is a valid IP?
Then it would be better to use str2ipx(), because it tries internally both
ipv4/6.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Reproduction
Install newest Kamailio 5.2.
Change date e.g. 2 Years into the future. (Make sure you have no daemon running
which prohibits those operations):
```
sudo date -s "2014-12-25 $(date +%H:%M:%S)"
```
```
sudo date -s "2016-12-25 $(date +%H:%M:%S)"
```
Kamailio now uses the whole C
@miconda
I tried to convert string to ip_addr struct as you mentioned but , functions
cannot convert it. In addition , when i try to log "sdp ip address " it gives
empty. I didnt understand reason.
converting with str2ip gives NULL.
```
struct ip_addr* cline_addr;
if(session->pf==AF_INET6){
Ok, I will investigate this as well - would be a bit more extensive change, but
better to change it now before 5.3 then later.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2043#
I see that the comparison of the IPs is done with string operations. That's ok
for ipv4, but can be a mismatch with ipv6 because there can be different forms
of the same address.
I suggest to convert the the ip in sdp to binary struct and compare with the
src ip which is in binary struct -- see
I am fine with this change, but I think uri_len should be also increased to at
least 256 if people found that 128 is not enough for specific cases when ipv6
is used.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://g
Thanks Yasin, looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-524756254___
Kamailio (SER) - Development
Looking if there are other suggestions or objections about this change.. If not
I would change this by the middle of the week.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2043#
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files
23 matches
Mail list logo
