[sr-dev] git:master:b951d88e: ims_qos: use msg_ctx_id_t to detect same msg/transaction processing

2019-05-15 Thread szcom
Module: kamailio Branch: master Commit: b951d88eea52e9fbbec62d2069b6169fc182ba91 URL: https://github.com/kamailio/kamailio/commit/b951d88eea52e9fbbec62d2069b6169fc182ba91 Author: szcom Committer: szcom Date: 2019-05-15T12:54:12+02:00 ims_qos: use msg_ctx_id_t to detect same msg/transaction pro

Re: [sr-dev] [kamailio/kamailio] In-place string transform having occasionally corrupted results (#1937)

2019-05-15 Thread Henning Westerholt
The other string operation had already this function call, so I think they should work already. (Some of the functions works also in-place, and not need it). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.co

Re: [sr-dev] [kamailio/kamailio] Siptrace patch review (#1955)

2019-05-15 Thread Daniel-Constantin Mierla
For reference, an example of adding an XAVP with data pointing to share memory and a callback to free it is at: * https://github.com/kamailio/kamailio/blob/master/src/modules/rtjson/rtjson_routing.c#L159-L166 Data struct being constructed a bit above there: * https://github.com/kamailio/kam

Re: [sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Daniel-Constantin Mierla
Merged. If you want, you can also make a pull request for branch 5.2, if not I will try cherry pick before the v5.2.3 release. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1954#is

Re: [sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Daniel-Constantin Mierla
Merged #1954 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1954#event-2343911513___ Kamailio (SER) - Development Mailing Lis

[sr-dev] git:master:d3770425: Merge pull request #1954 from omnicate/master

2019-05-15 Thread GitHub
Module: kamailio Branch: master Commit: d377042513a5092ad2dc127ed500d50e97002d73 URL: https://github.com/kamailio/kamailio/commit/d377042513a5092ad2dc127ed500d50e97002d73 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2019-05-15T18:33:43+02:00 Merge pull request #1954 from omnicate/m

Re: [sr-dev] [kamailio/kamailio] Siptrace patch review (#1955)

2019-05-15 Thread Ionut Ionita
I've looked over, everything looks fine. I'll run some tests just to make sure everything is fine. Regarding your concerns, in-dialog requests are ok since string values are taken from dlg_val, but there's a bug for current transaction messages that may end up in a different process. I will fix

[sr-dev] git:master:b925c9c2: modules: readme files regenerated - db_text ... [skip ci]

2019-05-15 Thread Kamailio Dev
Module: kamailio Branch: master Commit: b925c9c2799367d116c8594b340839a9039233c2 URL: https://github.com/kamailio/kamailio/commit/b925c9c2799367d116c8594b340839a9039233c2 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-05-15T16:32:26+02:00 modules: readme files regenerated - db_text ..

[sr-dev] git:5.2:9260a2bd: modules: readme files regenerated - modules ... [skip ci]

2019-05-15 Thread Kamailio Dev
Module: kamailio Branch: 5.2 Commit: 9260a2bd11767d694dcb93c2600869b94abb5e27 URL: https://github.com/kamailio/kamailio/commit/9260a2bd11767d694dcb93c2600869b94abb5e27 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-05-15T16:32:07+02:00 modules: readme files regenerated - modules ... [

[sr-dev] git:5.1:01c3d06f: modules: readme files regenerated - modules ... [skip ci]

2019-05-15 Thread Kamailio Dev
Module: kamailio Branch: 5.1 Commit: 01c3d06f5ee65d15693118d9cf55086a84b3b0c2 URL: https://github.com/kamailio/kamailio/commit/01c3d06f5ee65d15693118d9cf55086a84b3b0c2 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-05-15T16:31:47+02:00 modules: readme files regenerated - modules ... [

[sr-dev] git:5.0:c35e6930: modules: readme files regenerated - modules ... [skip ci]

2019-05-15 Thread Kamailio Dev
Module: kamailio Branch: 5.0 Commit: c35e69302c246e8e24e2e0f0513fc602cab930d7 URL: https://github.com/kamailio/kamailio/commit/c35e69302c246e8e24e2e0f0513fc602cab930d7 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-05-15T16:31:20+02:00 modules: readme files regenerated - modules ... [

[sr-dev] git:5.0:7c988639: db_text: add missing "max_result_rows" param to the doc

2019-05-15 Thread Ovidiu Sas
Module: kamailio Branch: 5.0 Commit: 7c9886391094a6bc87886f8246edfbfefc21dbf2 URL: https://github.com/kamailio/kamailio/commit/7c9886391094a6bc87886f8246edfbfefc21dbf2 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2019-05-15T10:19:35-04:00 db_text: add missing "max_result_rows" param to the d

[sr-dev] git:5.1:aed2b5ca: db_text: add missing "max_result_rows" param to the doc

2019-05-15 Thread Ovidiu Sas
Module: kamailio Branch: 5.1 Commit: aed2b5cacc6cd278693452e6e73eccb33fbcb4a1 URL: https://github.com/kamailio/kamailio/commit/aed2b5cacc6cd278693452e6e73eccb33fbcb4a1 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2019-05-15T10:18:36-04:00 db_text: add missing "max_result_rows" param to the d

[sr-dev] git:5.2:efa66015: db_text: add missing "max_result_rows" param to the doc

2019-05-15 Thread Ovidiu Sas
Module: kamailio Branch: 5.2 Commit: efa660150a4e68e1af274d492acc7b05bf9b555a URL: https://github.com/kamailio/kamailio/commit/efa660150a4e68e1af274d492acc7b05bf9b555a Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2019-05-15T10:17:54-04:00 db_text: add missing "max_result_rows" param to the d

[sr-dev] git:master:6b7d02c9: db_text: add missing "max_result_rows" param to the doc

2019-05-15 Thread Ovidiu Sas
Module: kamailio Branch: master Commit: 6b7d02c9ed404abaa7c45dbcc86173533a838e01 URL: https://github.com/kamailio/kamailio/commit/6b7d02c9ed404abaa7c45dbcc86173533a838e01 Author: Ovidiu Sas Committer: Ovidiu Sas Date: 2019-05-15T10:16:27-04:00 db_text: add missing "max_result_rows" param to th

Re: [sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Sergey Zyrianov
looks like that -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1954#issuecomment-492635465___ Kamailio (SER) - Development Mailing List s

[sr-dev] git:master:94c2b4e3: modules: readme files regenerated - tm ... [skip ci]

2019-05-15 Thread Kamailio Dev
Module: kamailio Branch: master Commit: 94c2b4e3d940f360a2efcbec121b9cab0261b094 URL: https://github.com/kamailio/kamailio/commit/94c2b4e3d940f360a2efcbec121b9cab0261b094 Author: Kamailio Dev Committer: Kamailio Dev Date: 2019-05-15T14:31:49+02:00 modules: readme files regenerated - tm ... [sk

[sr-dev] git:master:4a4dbdbe: tm: docs for t_get_status_code()

2019-05-15 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 4a4dbdbe8e683d4f3e081391e54a9f2489c7d5ae URL: https://github.com/kamailio/kamailio/commit/4a4dbdbe8e683d4f3e081391e54a9f2489c7d5ae Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-05-15T14:25:24+02:00 tm: docs for t_get_sta

[sr-dev] git:master:08714c23: tm: added t_get_status_code()

2019-05-15 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: 08714c23ac3a9785d5df3f04bdf5214cb0a81774 URL: https://github.com/kamailio/kamailio/commit/08714c23ac3a9785d5df3f04bdf5214cb0a81774 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-05-15T14:18:59+02:00 tm: added t_get_status

[sr-dev] RFC: split out old sr api from app_lua

2019-05-15 Thread Daniel-Constantin Mierla
Hello, I am considering to split the app_lua module in order to move the older style API available under Lua 'sr' module in a dedicated module (like app_lua_sr). Later this module can be obsoleted and removed, once we know that everything there is covered by KEMI KSR Lua module. In this way, we m

Re: [sr-dev] [kamailio/kamailio] Terminated Websocket connection keeps logging "forcibly closing connection" (#1886)

2019-05-15 Thread Timur
Same problem at 5.2.2 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1886#issuecomment-492622167___ Kamailio (SER) - Development Mailing

Re: [sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Daniel-Constantin Mierla
Thanks! It will be merged. Does it need to be backported to 5.2? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1954#issuecomment-492620805___

[sr-dev] review of siptrace adjustments

2019-05-15 Thread Daniel-Constantin Mierla
Hello Ionut, writing also via email and sr-dev, just in case you are not receiving the github notification, as I mentioned you on the issue:   * https://github.com/kamailio/kamailio/issues/1955 As I went through the code, It seemed that trace type (per message, transaction or dialog) was not use

Re: [sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Sergey Zyrianov
based on this commit https://github.com/kamailio/kamailio/commit/08c683bfa8f2f05b02a878c861af3458d5380869#diff-a4e6d9ed59e787b5a97e2524f2abc297 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kama

Re: [sr-dev] [kamailio/kamailio] TOPOS module does not strip Via headers from ACK and BYE. (#1926)

2019-05-15 Thread Daniel-Constantin Mierla
Closing, no other report for such issue that should be a basic one to spot. If still an issue, then get the troubleshooting data as requested in a previous comment, reopen and add it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [sr-dev] [kamailio/kamailio] TOPOS module does not strip Via headers from ACK and BYE. (#1926)

2019-05-15 Thread Daniel-Constantin Mierla
Closed #1926. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1926#event-2342970415___ Kamailio (SER) - Development Mailing List sr-dev@l

[sr-dev] [kamailio/kamailio] Siptrace patch review (#1955)

2019-05-15 Thread Daniel-Constantin Mierla
### Description A patch was pushed to master branch to enable use of trace_type in the ki_sip_trace_dst_cid_flag(), following the latest additions to the module. It seemed that the trace type was used only for kamailio.cfg functions, because inside ki_sip_trace_dst_cid_flag() the trace_type w

[sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)

2019-05-15 Thread Sergey Zyrianov
- relies on msg id and pid, not only msg id (which is incremeted by each process and has potential conflicts with failure routing) - msg id and pid are enough to indentify the transaction thus dropping checks for the pointers Pre-Submission Checklist - [x] Commit message has the format

Re: [sr-dev] [kamailio/kamailio] git master siptrace regression in sip_trace function (#1942)

2019-05-15 Thread Daniel-Constantin Mierla
Closed #1942. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1942#event-2342938534___ Kamailio (SER) - Development Mailing List sr-dev@l

Re: [sr-dev] [kamailio/kamailio] git master siptrace regression in sip_trace function (#1942)

2019-05-15 Thread Daniel-Constantin Mierla
Closing, expected to be fixed after the last commits. If not, a new issue should be opened with the symptoms of the master branch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1

[sr-dev] git:master:e8d76561: siptrace: use trace type for ki_sip_trace_dst_cid_flag()

2019-05-15 Thread Daniel-Constantin Mierla
Module: kamailio Branch: master Commit: e8d765610c6926cc6cb4dfa490595214a3680f97 URL: https://github.com/kamailio/kamailio/commit/e8d765610c6926cc6cb4dfa490595214a3680f97 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-05-15T13:03:28+02:00 siptrace: use trace ty

[sr-dev] git:5.2:f4062669: siptrace: fix memory leak on sip trace function with dst uri

2019-05-15 Thread Daniel-Constantin Mierla
Module: kamailio Branch: 5.2 Commit: f406266966b68fff9493c62ac5c9ccc5b8237e6b URL: https://github.com/kamailio/kamailio/commit/f406266966b68fff9493c62ac5c9ccc5b8237e6b Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2019-05-15T12:47:51+02:00 siptrace: fix memory leak

[sr-dev] git:5.1:5268c0b6: dialplan: don't try to translate on dp_match()

2019-05-15 Thread Victor Seva
Module: kamailio Branch: 5.1 Commit: 5268c0b6b1ece7f6dffb0f77c15a86b379d309f1 URL: https://github.com/kamailio/kamailio/commit/5268c0b6b1ece7f6dffb0f77c15a86b379d309f1 Author: Victor Seva Committer: Victor Seva Date: 2019-05-15T11:39:13+02:00 dialplan: don't try to translate on dp_match() fix

[sr-dev] git:5.2:b536723c: dialplan: don't try to translate on dp_match()

2019-05-15 Thread Victor Seva
Module: kamailio Branch: 5.2 Commit: b536723c66441203c2eaaa1ed1a68c981a0254be URL: https://github.com/kamailio/kamailio/commit/b536723c66441203c2eaaa1ed1a68c981a0254be Author: Victor Seva Committer: Victor Seva Date: 2019-05-15T11:38:24+02:00 dialplan: don't try to translate on dp_match() fix

Re: [sr-dev] [kamailio/kamailio] dialplan: dp_match() does substitution and replace (#1952)

2019-05-15 Thread Victor Seva
Closed #1952 via cced23795582d9f4cc2bae545ea1c24664303036. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1952#event-2342699884___ Kamai

[sr-dev] git:master:cced2379: dialplan: don't try to translate on dp_match()

2019-05-15 Thread Victor Seva
Module: kamailio Branch: master Commit: cced23795582d9f4cc2bae545ea1c24664303036 URL: https://github.com/kamailio/kamailio/commit/cced23795582d9f4cc2bae545ea1c24664303036 Author: Victor Seva Committer: Victor Seva Date: 2019-05-15T11:37:41+02:00 dialplan: don't try to translate on dp_match()

Re: [sr-dev] [kamailio/kamailio] dialplan: don't try to translate on dp_match() (#1953)

2019-05-15 Thread Victor Seva
Merged #1953 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1953#event-2342699797___ Kamailio (SER) - Development Mailing Lis

Re: [sr-dev] [kamailio/kamailio] dialplan: dp_match() does substitution and replace (#1952)

2019-05-15 Thread Daniel-Constantin Mierla
Thanks! You can merge and backport. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1952#issuecomment-492581613___ Kamailio (SER) - Devel

[sr-dev] git:master:61b67197: janssonrpcc: remove compilation warning

2019-05-15 Thread Victor Seva
Module: kamailio Branch: master Commit: 61b67197ba8b996abdaff1388362469563ba2202 URL: https://github.com/kamailio/kamailio/commit/61b67197ba8b996abdaff1388362469563ba2202 Author: Victor Seva Committer: Victor Seva Date: 2019-05-15T11:13:17+02:00 janssonrpcc: remove compilation warning > janss

Re: [sr-dev] [kamailio/kamailio] dialplan: don't try to translate on dp_match() (#1953)

2019-05-15 Thread Victor Seva
is that the correct behavior for ``dp_match()``? That is what I understand from the description ``` 6.2. dp_match(dpid, inval) The function matches the input value 'inval' using the rules with dialplan id 'dpid'. If the rule that was applied has attributes, they are stored in the variab

[sr-dev] [kamailio/kamailio] dialplan: don't try to translate on dp_match() (#1953)

2019-05-15 Thread Victor Seva
``` INFO:

[sr-dev] [kamailio/kamailio] dialplan: dp_match() does substitution and replace (#1952)

2019-05-15 Thread Victor Seva
### Description dialplan ``dp_match()`` fails with a substitution error when subst_exp doesn't match the string. I was expecting to only match the rule to get the attrs no matter what is defined in ``subst_exp/repl_exp`` ### Troubleshooting Reproduction ``` => select * from dialplan wher

[sr-dev] Releasing Kamailio v5.2.3

2019-05-15 Thread Daniel-Constantin Mierla
Hello, I am considering to release Kamailo v5.2.3 out of latest git branch 5.2 next week, likely on Wednesday, May 22. As usual, if you are aware of issues not reported to the github bug tracker, fill a report there as soon as possible to give a chance to be analyzed and fixed. Also, if there was