Thank you for the report.
Better place to report this issue is https://github.com/daynix/UsbDk/issues
Can you please collect the file memory.dmp from Windows directory, zip
it and share with us via some file sharing service (google
drive/dropbox/...)?
Thanks
On Tue, Apr 2, 2019 at 5:16 AM wangji
-sharing via USB redirection
Yuri Benditovich (3):
usb: use native libusb procedure for getting error name
usb-redirection: isolate usage of libusb and usbredirhost
usb-redirection: do not duplicate USB device properties
src/Makefile.am | 2 +
src/channel-usbredir-priv.h | 9
libusb has libusb_error_name procedure that returns name
for any error that libusb may return, so we do not need
to analyze error values by ourselves.
Signed-off-by: Yuri Benditovich
---
src/usbutil.c | 32 +---
1 file changed, 1 insertion(+), 31 deletions(-)
diff
-off-by: Yuri Benditovich
---
src/Makefile.am | 2 +
src/channel-usbredir-priv.h | 9 +-
src/channel-usbredir.c| 216 +++-
src/meson.build | 2 +
src/usb-backend.c | 622 ++
src/usb-backend.h
Do not keep bus, address, vid and pid of the USB device
in SpiceUsbDeviceInfo structure. Getters for these properties
can easily obtain them from respective backend device.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 29 +
1 file changed, 13
On Thu, Apr 11, 2019 at 12:35 PM Victor Toso wrote:
>
> Hi,
>
> On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote:
> > libusb has libusb_error_name procedure that returns name
> > for any error that libusb may return, so we do not need
> > to ana
ictor Toso wrote:
> > Hi,
> >
> > On Thu, Apr 11, 2019 at 02:57:21PM +0300, Yuri Benditovich wrote:
> > > On Thu, Apr 11, 2019 at 12:35 PM Victor Toso
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Wed, Apr 10, 201
: spice-qxl-wddm-dod-0.19.zip
Signed by Red Hat binaries: wddm-dod-0.19-8.1-compatible.zip
Best regards,
Yuri Benditovich
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Thu, Apr 18, 2019 at 3:01 PM Yuri Benditovich
wrote:
>
> Hi All,
>
> QXL-WDDM-DOD 0.19 has been released.
>
> The latest QXL-WDDM-DOD source code available at:
> https://gitlab.com/spice/qxl-wddm-dod
The main repository was migrated to
https://gitlab.freedesktop.org/spi
Hi all,
UsbDk 1.0-21 has been released
Latest source code:
https://gitlab.freedesktop.org/spice/win32/usbdk
Binaries (MSI):
https://www.spice-space.org/download/windows/usbdk/UsbDk_1.0.21_x64.msi
https://www.spice-space.org/download/windows/usbdk/UsbDk_1.0.21_x86.msi
Thanks,
Yuri Benditovich
l/2019-May/049071.html
> [1] https://lists.freedesktop.org/archives/spice-devel/2019-May/049087.html
>
> So, with this introduction in mind, let's go.
>
> On Tue, May 21, 2019 at 09:05:51AM +, Victor Toso wrote:
> > From: Yuri Benditovich
> >
> > As a step
On Mon, Jun 10, 2019 at 2:15 PM Victor Toso wrote:
>
> On Wed, Apr 10, 2019 at 10:31:39PM +0300, Yuri Benditovich wrote:
> > Do not keep bus, address, vid and pid of the USB device
> > in SpiceUsbDeviceInfo structure. Getters for these properties
> > can easily obtain them
On Mon, Jun 10, 2019 at 1:48 PM Victor Toso wrote:
>
> Hi,
>
> Keeping the chat as you might enjoy then, in order to merge this
> patches:
>
> On Wed, Apr 10, 2019 at 10:31:38PM +0300, Yuri Benditovich wrote:
> > As a step toward possibility to present emulated USB d
On Tue, Jul 9, 2019 at 1:07 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Jun 24, 2019 at 06:02:23PM +0300, Yuri Benditovich wrote:
> > On Mon, Jun 10, 2019 at 1:48 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > Keeping the chat as you
device, wraps libusb_device
* SpiceUsbBackendChannel: accumulates redirection functionality,
wraps usbredirhost
Signed-off-by: Yuri Benditovich
---
src/Makefile.am | 2 +
src/channel-usbredir-priv.h | 12 +-
src/channel-usbredir.c| 236 ++--
src/meson.build
-sharing via USB redirection
Changes from v1: cosmetic changes per v1 review
Added a rebased patch (3) from Frediano Ziglio
For the increment see
https://gitlab.freedesktop.org/yuri_benditovich/spice-gtk/commits/backend2-increment
Yuri Benditovich (3):
usb-redir: isolate usage of libusb and
SpiceUsbDevice* was converted to SpiceUsbDeviceInfo* as _SpiceUsbDevice
was never defined. Define instead the structure to avoid useless
casts.
Signed-off-by: Frediano Ziglio
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 54 ++--
1 file
Do not keep bus, address, vid and pid of the USB device
in SpiceUsbDeviceInfo structure. Getters for these properties
can easily obtain them from respective backend device.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 29 +
1 file changed, 13
>
> Cheers,
> Victor
>
> >
> > Cheers,
> > Victor
> >
> > >
> > > Changes from v2: rebased on master
> > >
> > > Changes from v1: cosmetic changes per v1 review
> > > Added a rebased patch (3) from Frediano Ziglio
>
stop it.
This removes many lines of code and also removes all the
differences between Linux and Windows in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c| 28 -
src/usb-backend.c | 48 ++---
src/usb-backend.h
-by: Yuri Benditovich
---
src/usb-backend.c| 5 -
src/usb-backend.h| 3 ++-
src/usb-device-manager.c | 3 ++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 9964c4f..829d81d 100644
--- a/src/usb-backend.c
+++ b/src/usb
The delete in error flow was missing.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index 857d057..7105ff1 100644
--- a/src/usb-device-manager.c
+++ b/src/usb-device-manager.c
Previous commit ca641a5b92 uses libusb_interrupt_event_handler
which requires newer version of libusb.
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 32561ee..54160f9 100644
--- a/meson.build
This series is dedicated to unification of Linux Windows flows
in usb-device-manager. It moves differences related to libusb
to USB backend module and simplifies implementation of procedure
related to USB redirection.
Yuri Benditovich (5):
build: require minimal libusb version 1.0.21
usb
nd maintains its own 'redirecting' field
in Windows to prevent update of device list when
libusb opens the device (device redirection causes
temporary removal of target device)
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
src/meson.build | 4 +-
On Mon, Jul 15, 2019 at 5:04 PM Frediano Ziglio wrote:
>
> >
> > The delete in error flow was missing.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/usb-device-manager.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --
On Mon, Jul 15, 2019 at 5:28 PM Frediano Ziglio wrote:
>
> >
> > On Mon, Jul 15, 2019 at 5:04 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > The delete in error flow was missing.
> > > >
> > > > Signed-off-by: Yuri Benditov
On Fri, Jul 19, 2019 at 1:14 PM Victor Toso wrote:
>
> Hi,
>
> On Sun, Jul 14, 2019 at 05:07:38PM +0300, Yuri Benditovich wrote:
> > Remove Windows-specific part of hotplug detection from
> > usb-device-manager and win-usb-dev and place it into
> > USB backend modu
On Mon, Jul 22, 2019 at 12:53 PM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 19, 2019 at 1:14 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Sun, Jul 14, 2019 at 05:07:38PM +0300, Yuri Benditovich wrote:
> > > > Remove Win
Ping
On Sun, Jul 14, 2019 at 5:07 PM Yuri Benditovich
wrote:
>
> Before this commit:
> usb-device-manager starts thread for handling libusb events.
> On Linux - from the beginning (as it is needed for hotplug
> callbacks)
> On Windows - starts it on first redirect
On Mon, Jul 22, 2019 at 6:00 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Jul 22, 2019 at 04:34:48PM +0300, Yuri Benditovich wrote:
> > Ping
>
> Sorry, missed it.
>
> Patch seems fine and again, code is getting nicer thanks to
> usb-backend.[ch]. Thanks. Only cosm
-by: Yuri Benditovich
---
src/usb-backend.c| 5 -
src/usb-backend.h| 3 ++-
src/usb-device-manager.c | 3 ++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 1581f90..486875e 100644
--- a/src/usb-backend.c
+++ b/src/usb
Previous commit ca641a5b92 uses libusb_interrupt_event_handler
which requires newer version of libusb.
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 32561ee..54160f9 100644
--- a/meson.build
nd maintains its own 'redirecting' field
in Windows to prevent update of device list when
libusb opens the device (device redirection causes
temporary removal of target device)
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
src/meson.build | 4 +-
Unify with other places for better readability.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index c2268e3..53ac430 100644
--- a/src/usb-backend.c
+++ b/src/usb-backend.c
lines of code and also removes all the
differences between Linux and Windows in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c| 28 -
src/usb-backend.c | 54 +---
src/usb-backend.h | 2 -
src/usb-device
Procedures moved without changes, they will be reused
in later commits.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 110 +++---
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index a2c502d
Newer API (glib 2.32) is safe, in case of error it does not
abort the process and returns error information.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index bbd3b67
Unify parameter name for libusb_device.
Use g_return_val_if_fail for expected condition.
Remove redundant casting.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/usb-backend.c b/src/usb
Utility procedure get_usb_device_info_from_libusb_device
will be reused later.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index a33cbe6..c2268e3 100644
This series is dedicated to unification of Linux Windows flows
in usb-device-manager. It moves differences related to libusb
to USB backend module and simplifies implementation of procedures
related to USB redirection.
Yuri Benditovich (9):
build: require minimal libusb version 1.0.21
usb
ion.
>
> See
> https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#g-return-val-if-fail
> g_return_val_if_fail represents a bug in the code, not an "expected
> condition".
>
> > Remove redundant casting.
> >
> > Signed-off-by: Yuri Benditovich
&
lines of code and also removes all the
differences between Linux and Windows in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c| 28 -
src/usb-backend.c | 49 +++---
src/usb-backend.h | 2 -
src/usb-device
-by: Yuri Benditovich
---
src/usb-backend.c| 5 -
src/usb-backend.h| 3 ++-
src/usb-device-manager.c | 3 ++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 3f99739..2a2f9fa 100644
--- a/src/usb-backend.c
+++ b/src/usb
Newer API (glib 2.32) is safe, in case of error it does not
abort the process and returns error information.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/usb-backend.c b/src/usb-backend.c
index 7c9b544
nd maintains its own 'redirecting' field
in Windows to prevent update of device list when
libusb opens the device (device redirection causes
temporary removal of target device)
Signed-off-by: Yuri Benditovich
---
meson.build | 2 +-
src/meson.build | 4 +-
This series is dedicated to unification of Linux Windows flows
in usb-device-manager. It moves differences related to libusb
to USB backend module and simplifies implementation of procedures
related to USB redirection.
Changes from v2: cosmetic changes
Yuri Benditovich (4):
usb-redir: unify
pabilities from it and upon receive of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Y
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..961a464 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
end
device fields set to NULL and use it for indication. Device
description for such device will be 'USB Redirection'.
Unreferencing of such device will be 'no operation'.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c| 3 +++
src/usb-device-manager.c | 14 +
This series of patches adds feature of sharing CD image via
redirection of emulated CD device. Currently the trigger to
create the device is command-line option:
'--spice-share-cd
Yuri Benditovich (9):
usb-redir: define interfaces to support emulated devices
usb-redir: device error s
This module contains implementation of emulated device
interface for shared CD.
Signed-off-by: Yuri Benditovich
---
src/usb-device-cd.c | 794
1 file changed, 794 insertions(+)
create mode 100644 src/usb-device-cd.c
diff --git a/src/usb-device-cd.c
Register constructor for emulated CD device. Now creation
of CD devices at startup is possible.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 6 ++
src/usb-backend.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/meson.build b/src/meson.build
index 49fec52..944b083
its device type (currently only 'CD device'
defined). Implementation module registers constructor for
this device type. Device structure is abstract but always
starts from table of virtual functions required to redirect
such virtual device.
Signed-off-by: Yuri Benditovich
---
src/m
Ability to retrieve device description for emulated USB
device, defined by implementation. For example, for shared
CD the implementation may use basename of ISO file.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
Added command-line option for shared CD devices and respective
property in usb-device-manager.
Signed-off-by: Yuri Benditovich
---
src/spice-option.c | 15 +++
src/usb-device-manager.c | 33 +
2 files changed, 48 insertions(+)
diff --git a/src
On Thu, Jul 25, 2019 at 11:08 AM Victor Toso wrote:
>
> Hi,
>
> On Wed, Jul 24, 2019 at 01:53:43PM +0300, Yuri Benditovich wrote:
> > SpiceUsbBackendDevice structure is extended to support
> > additional kind of device that is emulated by Spice-GTK
> > and not pres
device, when the device is not created yet. For that we
> > allocate temporary SpiceUsbDevice structure with backend
> > device fields set to NULL and use it for indication. Device
> > description for such device will be 'USB Redirection'.
> > Unreferencing o
On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote:
>
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/channel-usbredir.c | 29 ++---
> > 1 file changed, 14 insertions(+), 15 deletions(-)
> >
> > diff --git a/sr
e is abstract but always
> > starts from table of virtual functions required to redirect
> > such virtual device.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 1 +
> > src/usb-backend.c | 128 +++
On Thu, Jul 25, 2019 at 12:09 PM Frediano Ziglio wrote:
>
> >
> > Added command-line option for shared CD devices and respective
> > property in usb-device-manager.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/spice-option.c | 15
On Thu, Jul 25, 2019 at 1:32 PM Victor Toso wrote:
>
> Hi,
>
> On Thu, Jul 25, 2019 at 05:09:17AM -0400, Frediano Ziglio wrote:
> > >
> > > Added command-line option for shared CD devices and respective
> > > property in usb-device-manager.
>
On Thu, Jul 25, 2019 at 1:33 PM Victor Toso wrote:
>
> On Wed, Jul 24, 2019 at 01:53:45PM +0300, Yuri Benditovich wrote:
> > Added command-line option for shared CD devices and respective
> > property in usb-device-manager.
> >
> > Signed-off-by: Yuri Benditovich
&
ceUsbDevice structure with backend
> > > > > device fields set to NULL and use it for indication. Device
> > > > > description for such device will be 'USB Redirection'.
> > > > > Unreferencing of such device will be 'no operation'.
&g
On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote:
>
> > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Signed-off-by: Yuri Benditovich
> > > > ---
> > > > src/channel-usbredir.c | 29 ++
ts device type (currently only 'CD device'
> > > > defined). Implementation module registers constructor for
> > > > this device type. Device structure is abstract but always
> > > > starts from table of virtual functions required to redirect
> &g
On Fri, Jul 26, 2019 at 1:02 PM Frediano Ziglio wrote:
>
> > On Fri, Jul 26, 2019 at 11:47 AM Frediano Ziglio wrote:
> > >
> > > > On Thu, Jul 25, 2019 at 12:17 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
&g
On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote:
>
> Hi,
>
> On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote:
> > On Thu, Jul 25, 2019 at 8:46 PM Frediano Ziglio wrote:
> > > > > > > @@ -1440,6 +1446,10 @@ gchar
> > > > >
On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote:
>
> >
> > Register constructor for emulated CD device. Now creation
> > of CD devices at startup is possible.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 6 ++
>
On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jul 26, 2019 at 08:08:07AM +0300, Yuri Benditovich wrote:
> > > >
On Fri, Jul 26, 2019 at 6:51 PM Frediano Ziglio wrote:
>
> > On Fri, Jul 26, 2019 at 4:17 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Register constructor for emulated CD device. Now creation
> > > > of CD devices at startup is pos
On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
>
> Hi,
>
> On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > On Fri, Jul 26, 2019 at 2:09 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > On Fri, Jul 26, 2019 at 10:09 AM
. Implementation module registers constructor for
> > > > > > this device type. Device structure is abstract but always
> > > > > > starts from table of virtual functions required to redirect
> > > > > > such virtual device.
> > > > >
On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio wrote:
>
> >
> > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Jul 26, 2019 at 06:30:51PM +0300, Yuri Benditovich wrote:
> > > >
SpiceUsbEmulatedDevice
> > > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > depends on its device type (currently only 'CD device'
> > > > > > > > defined). Implementation module regis
> > >
> > > > > > > >
> > > > > > > > On Fri, Jul 26, 2019 at 10:09 AM Victor Toso
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > &g
io wrote:
> > >
> > > > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
> > > > > > On Fri, Jul 26, 2019 at 7:14 PM Victor Toso
> > > > > > wrote:
> > >
rediano Ziglio
> > > > wrote:
> > > > >
> > > > > > On Mon, Jul 29, 2019 at 10:48 AM Frediano Ziglio
> > > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > >
> > > > > > &
> >
> > > > On Mon, Jul 29, 2019 at 2:14 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > > On Mon, Jul 29, 2019 at 12:27 PM Frediano Ziglio
> > > > > >
> > > > > > wrote:
> > > > &g
On Tue, Jul 30, 2019 at 1:43 PM Frediano Ziglio wrote:
>
> >
> > This module contains implementation of emulated device
> > interface for shared CD.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/usb-device-cd.c | 794 +++
of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fixup! usb-redir: add implementation of emulated CD device
> fix
On Tue, Jul 30, 2019 at 4:59 PM Frediano Ziglio wrote:
>
> >
> > On Tue, Jul 30, 2019 at 1:43 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > This module contains implementation of emulated device
> > > > interface fo
On Thu, Aug 1, 2019 at 3:26 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Jul 29, 2019 at 12:26:11PM +0300, Yuri Benditovich wrote:
> > On Mon, Jul 29, 2019 at 11:03 AM Frediano Ziglio wrote:
> > > What does it means? The code cannot be improved before being
> > >
For local USB device the USB backend returns the same device
description as spice-usb-manager did, for emulated devices it
uses the description provided by device's implementation.
Signed-off-by: Yuri Benditovich
---
src/usb-backend.c| 41
This series of patches adds feature of sharing CD image via
redirection of emulated CD device. Currently the trigger to
create the device is command-line option:
'--spice-share-cd
Changes from v1: fixes resulted by reviews (mainly based on fixups
of Frediano Ziglio)
Yuri Benditovich (8):
its device type. Implementation module will define
constructor for specific device type.
Device structure is abstract but always starts from table of
virtual functions required to redirect such virtual device.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 1 +
src/usb-backend.c
pabilities from it and upon receive of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Y
Added command-line option for sharing emulated CD devices.
It uses property interface of usb-device-manager to
create CD, this is a temporary solution until public API of
usb-device-manager defined for shared CD management from both
GUI and command line.
Signed-off-by: Yuri Benditovich
---
src
Signed-off-by: Yuri Benditovich
---
src/channel-usbredir.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..8fd6b41 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
This module contains implementation of emulated device
interface for shared CD.
Signed-off-by: Yuri Benditovich
---
src/usb-device-cd.c | 790
src/usb-device-cd.h | 37 +++
2 files changed, 827 insertions(+)
create mode 100644 src/usb-device-cd.c
Add implementation of emulated device to build.
Now it is possible to create emulated CD devices.
Signed-off-by: Yuri Benditovich
---
src/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/meson.build b/src/meson.build
index fe19c16..3837a9d 100644
--- a/src/meson.build
f
> > virtual functions required to redirect such virtual device.
> >
> > Signed-off-by: Yuri Benditovich
> > ---
> > src/meson.build | 1 +
> > src/usb-backend.c | 102 +++-
> > src/usb-backend.h | 3
device type. Implementation module will define
> > > > constructor for specific device type.
> > > > Device structure is abstract but always starts from table of
> > > > virtual functions required to redirect such virt
gt; +struct libusb_device_descriptor *desc;
> > > > > > +uint16_t device_desc_size;
> > > > > > + uint8_t address = 0;
> > > > > > +
> > > > > > +if (be->own_devices_mask == 0x) {
> > > > > > +g_set_e
> > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > depends on its device type. Implementation module will define
> > > > > > > > constructor for specific de
evice
> > > > > > > > > > abstract structure. Specific implementation of such device
> > > > > > > > > > depends on its device type. Implementation module will
> > > > > > > > > > define
> > > > > > > > &g
On Thu, Aug 8, 2019 at 1:41 PM Frediano Ziglio wrote:
>
> Change reference counting semantic for emulated devices.
> Make the same as not emulated.
> This fix a leak if spice_usb_backend_device_eject is not called.
> Consistently the reference counter for SpiceUsbBackendDevice is
> now the number
ed by reviews (mainly based on fixups
of Frediano Ziglio)
Frediano Ziglio (1):
usb-redir: cosmetic style fixes
Yuri Benditovich (8):
usb-redir: define interfaces to support emulated devices
usb-redir: move implementation of device description to USB backend
usb-redir: do no
pabilities from it and upon receive of
'hello' response we provide it also to the parser.
When libusb device is redirected via a channel, instance of
usbredirhost serves it.
When emulated device is redirected via a channel, instance
of usbredirparser does the job.
Signed-off-by: Y
Signed-off-by: Yuri Benditovich
Acked-by: Frediano Ziglio
---
src/channel-usbredir.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 8d4cd66..8fd6b41 100644
--- a/src/channel-usbredir.c
1 - 100 of 435 matches
Mail list logo
