[Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Sean Paul
From: Sean Paul Introduced in the patch below, the END macro was missing 'dev' and BEGIN macro needs drm_drv_uses_atomic_modeset() from drm_drv.h Fixes: bbaac1354cc9 ("drm/qxl: Replace deprecated function in qxl_display") Cc: Sidong Yang Cc: Gerd Hoffmann Cc: Dave Air

Re: [Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Sean Paul
On Mon, Aug 17, 2020 at 3:58 PM Sean Paul wrote: > > From: Sean Paul > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > macro needs drm_drv_uses_atomic_modeset() from drm_drv.h > > Fixes: bbaac1354cc9 ("drm/qxl: Replace depre

Re: [Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Sean Paul
On Mon, Aug 17, 2020 at 4:09 PM Sean Paul wrote: > > On Mon, Aug 17, 2020 at 4:05 PM Sam Ravnborg wrote: > > > > Hi Sean. > > > > On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > Introduced in t

Re: [Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-18 Thread Sean Paul
On Mon, Aug 17, 2020 at 4:05 PM Sam Ravnborg wrote: > > Hi Sean. > > On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > > macro need

Re: [Spice-devel] [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-12 Thread Sean Paul
On Wed, Jul 12, 2023 at 10:52 AM Jani Nikula wrote: > > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer variables being named "dev" > > because with that name I usually

Re: [Spice-devel] [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-15 Thread Sean Paul
On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: > > hello Sean, > > On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: > > I'd really prefer this patch (series or single) is not accepted. This > > will cause problems for everyone cherry-picking patch