mode;
> > - reds_agent_remove;
> > - reds_find_channel;
> > - reds_mig_cleanup;
> > - reds_reset_vdp;
> > - reds_main_channel_connected;
> > - reds_client_disconnect;
> > - reds_disconnect;
> > - reds_mig_disconnect.
> >
> > Acked-by: Frediano Ziglio
>
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> More consistent with glib naming conventions.
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 fil
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:37 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/inputs-channel.c | 6 +++---
> server/reds.c | 5 +++--
> server/reds.h | 2 +-
> 3 files changed, 7 insertions(+), 6 deletions
vdi_port_read_buf_process(RedsState *reds, int port,
> VDIReadBuf *buf)
I like when the first parameter corresponds with the function name.
Moving reds to the last position?
Reviewed-by: Pavel Grunt
> {
> VDIPortState *state = &reds->agent_state;
>
On Mon, 2016-01-18 at 16:37 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> This allows us to access the RedsState variable non-globally without
> changing the signature of the callback functions.
Acked-by: Pavel Grunt
> ---
> server/reds.c | 3 ++-
> 1 file
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Also making it private/static
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> server/reds.h | 1 -
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/serve
Also changes reds_on_main_agent_monitors_config() to take RedsState
Reviewed-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 6 +++---
> server/reds.h
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
ed outside of this source file.
>
> I don't know if this patch has changed slightly due to rebase, but
> the function
> appears to already be static. So we can remove this last sentence
> from the
> commit log.
Yes, it should be moved to the PATCH 07
Acked-by: Pavel Grunt
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
Acked-by: Pavel Grunt
On Mon, 2016-01-18 at 16:38 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/reds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index b183ee1..5c038ca 1006
_read_buf_release(uint8_t
> > > *data, void *opaque)
> > > }
> > >
> > > /* returns TRUE if the buffer can be forwarded */
> > > -static int vdi_port_read_buf_process(int port, VDIReadBuf *buf)
> > > +static int vdi_port_read_buf_process(RedsState *reds
On Tue, 2016-01-19 at 10:02 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> server/reds.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> in
On Tue, 2016-01-19 at 10:03 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> More consistent with glib naming conventions. Also make the function
> static since it's not used outside of this source file.
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++
On Mon, 2016-01-18 at 14:33 +, Frediano Ziglio wrote:
> This make happy address sanitizer during make check.
> Otherwise memory leak detector can keep in and make tests fails.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/tests/test-
Change the default option to "auto"
---
m4/spice-deps.m4 | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
index d533c81..88edf7e 100644
--- a/m4/spice-deps.m4
+++ b/m4/spice-deps.m4
@@ -207,14 +207,20 @@ AC_DEFUN([SPICE_CHECK
On Tue, 2016-01-19 at 10:16 -0500, Frediano Ziglio wrote:
> >
> > Rules are now:
> >
> > Compression type:
> > off -> uncompressed
> > quic -> quic if possible else off
>
> I think original code always fall back to jpeg (if possible).
> Actually was more an use jpeg if possible and
It will be used in the server code
---
common/canvas_base.c | 12 +++-
common/draw.h| 2 ++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index d918441..509e0bf 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.
slightly modified and reused.
The patch 5/6 of the series tries to refactor the compression code
to make more clear when each of the compression methods should be used.
Thanks,
Pavel Grunt (6):
build-sys: Update spice-common submodule
dcc_compress_image: Handle NULL drawable
dcc-send: Use
---
v3: Uses a helper function from spice-common
---
server/dcc-send.c | 44 ++--
1 file changed, 2 insertions(+), 42 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index c3f79ef..3cb50ba 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send
For spice_image_descriptor_is_lossy()
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index b61f43f..723e50d 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit b61f43f228950505ef809dccd6a73aefdfd44ce1
+Subpro
It will be used in the following commit.
The GLZ compression cannot be used when the drawable is NULL.
Acked-by: Frediano Ziglio
---
server/dcc.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index 2568e24..613d7af 1
Reviewed-by: Victor Toso
Acked-by: Frediano Ziglio
---
server/dcc.c | 30 +++---
server/dcc.h | 15 ---
2 files changed, 15 insertions(+), 30 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index 613d7af..bf692f8 100644
--- a/server/dcc.c
+++ b/server/d
Rules are now:
Compression type:
off -> uncompressed
quic -> jpeg if possible else quic else off
lz -> lz if possible else off
glz -> glz if possible else lz else off
auto_lz -> lz if possible else jpeg else quic else off
auto_glz -> glz if possible else lz else jp
---
server/dcc.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index 6f7babf..5e642b8 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -662,6 +662,10 @@ static int dcc_compress_image_glz(DisplayChannelClient
*d
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 0e31b59..52fcb5e 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
Acked-by: Pavel Grunt
>
> ---
> server/main-channel.c | 2 +-
> server/reds.c | 2 +-
> server/reds.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&g
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/main-dispatcher.c | 4 ++--
> server/reds.c| 2 +-
> server/reds.h| 2 +-
> 3 files changed, 4 insertions(+), 4 deletions
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/red-channel.c | 2 +-
> server/reds.c| 2 +-
> server/reds.h| 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
&
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 1923bf5..d8ee53d 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index d8ee53d..a2e15
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 77e9bd6..1923bf5 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/main-dispatcher.c | 4 ++--
> server/reds.c| 2 +-
> server/reds.h| 2 +-
> 3 files changed, 4 insertions(+), 4 deletions
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 58e45ae..81d253c 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 824e149..91fab12 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 81d253c..824e149 1006
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 91fab12..3f7ee27 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -2787
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Rather than using global 'reds' variable
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ser
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index e47c694..67b20
On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 67b2071..566d346 1006
It will be used in the server code
---
v2: changed to static inline function
---
common/canvas_base.c | 8 ++--
common/draw.h| 6 ++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index d918441..fa4d373 100644
--- a/common
On Wed, 2016-01-20 at 10:16 -0500, Frediano Ziglio wrote:
> >
> > On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote:
> > > From: Jonathon Jongsma
> > >
> > Acked-by: Pavel Grunt
> > > ---
> > > server/reds.c | 4 ++
Hi,
On Wed, 2016-01-20 at 16:55 -0600, Jonathon Jongsma wrote:
> On Wed, 2016-01-20 at 16:32 +, Frediano Ziglio wrote:
> > Finally is time to approach again these patches to use GLib loop
> > functions for RedWorker.
> > Patches has been through so many passages that I'm posting as they
> > ar
On Wed, 2016-01-20 at 15:43 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 38e4aef..0db2ad5 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@
On Wed, 2016-01-20 at 10:50 -0500, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Rather than using global 'reds' variable
> > ---
> > server/reds.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index 080c0f6..c
e presence of the needed plugins.
> * It separates adding checks for the client codec support from
> specifying which codec to use in the server and from adding VP8
> support.
>
> From 407f7268de18d92880cfe7deee9223d0e8c16c9e Mon Sep 17 00:00:00 2001
From: Pavel Grunt
Date: Thu, 21 Jan 2016 12:49:2
Hi,
I was able to reproduce it also without the replay utility.
On Thu, 2016-01-21 at 17:20 +0100, Francois Gouget wrote:
> On Thu, 21 Jan 2016, Pavel Grunt wrote:
> [...]
> > With "gstreamer:h264" it hangs after a while and I see a few of:
> > ((null):24420):
>priv;
> +gchar *str, *markup_str;
> +const gchar *free_channels_str;
> +int free_channels;
> +
> +g_object_get(priv->manager, "free-channels", &free_channels,
> NULL);
> +free_channels_str = ngettext(_("Select USB devices to redirect
Thanks!
Acked-by: Pavel Grunt
On Thu, 2016-01-21 at 11:25 -0600, Jonathon Jongsma wrote:
> The replay file should start with a header such as
> SPICE_REPLAY 1
>
> Instead of soldiering on if we don't encounter this header, print a
> warning and return NULL. Also ex
Hi,
I was thinking about it and the assert also checks for us if there are
more instances of SpiceServer. I would postponed these patches till
other global variables are removed/moved to reds.
Pavel
On Thu, 2016-01-21 at 16:16 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Rather t
On Fri, 2016-01-22 at 10:59 +0100, Fabiano Fidêncio wrote:
> This typo was introduced by commit 5166f891e and unfortunately was
> not
> caught during the review.
I did not consider it wrong, we have '#if USE_SMARTCARD' on one place
and "USE_*" is always defined with 1 as the value.
I don't have a
Hi,
On Mon, 2016-01-25 at 06:48 -0500, Frediano Ziglio wrote:
>
>
> Hi Frediano,
>
> On Čt, 2016-01-14 at 12:52 -0500, Frediano Ziglio wrote:
> >
> > On Thu, 2016-01-14 at 12:07 -0500, Frediano Ziglio wrote:
> > > >
> > > > On Thu, Jan 14, 2016 at 10:27:02AM -0500, Frediano Ziglio
> wrote:
> >
On Mon, 2016-01-25 at 13:58 -0500, Frediano Ziglio wrote:
>
> Hi,
>
> On Mon, 2016-01-25 at 06:48 -0500, Frediano Ziglio wrote:
>
>
> Hi Frediano,
>
> On Čt, 2016-01-14 at 12:52 -0500, Frediano Ziglio wrote:
> >
> > On Thu, 2016-01-14 at 12:07 -0500, Frediano Ziglio wrote:
> > > >
> > > > On
On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote:
> All checks for full channel pipes have to be consistents
> so there is no point in passing as a parameter.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/red-worker.c | 22 +++---
gned-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/red-worker.c | 28 +---
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/server/red-worker.c b/server/red-worker.c
> index dd293f7..32a7110 100644
> --- a/serve
Hi,
On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote:
> This also prevents future use of a NULL pointer.
>
Can this happen now? Is it related to the PATCH 5/9 - function
cursor_is_connected() ?
Pavel
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 1 -
> 1 file changed,
On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/red-worker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-worker.c b/server/red-worker.c
> index 5e
Hi,
I would prefer to have a just one type of boolean and gboolean is
already used in the code...
Pavel
On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote:
> Send wakeups only when a command is available.
> This emulate better what a guest driver should do (append the command
> to the ring
Hi,
On Tue, 2016-01-26 at 18:11 +0600, Baurzhan Konurbayev wrote:
> Thanks for the reply.
>
> We would like to try hardware acceleration for our thin clients and
> therefore, tried to apply the patch called "Add GStreamer support for
> video streaming", https://patchwork.freedesktop.org/series/18
On Tue, 2016-01-26 at 10:57 +, Frediano Ziglio wrote:
> Send wakeups only when a command is available.
> This emulate better what a guest driver should do (append the command
> to the ring and then signal).
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> -
On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 68 ++-
> --
> 1 file changed, 23 insertions(+), 45 deletions(-)
>
> diff --git a/server/red-worker.c b/server/red-worker.c
> i
Hi,
sorry for the late reply.
On Mon, 2016-01-25 at 20:45 +0100, Francois Gouget wrote:
> On Thu, 21 Jan 2016, Pavel Grunt wrote:
> [...]
> > > I have never tested it with the replay functionality so I don't
> > > know of
> > > any compatibility issue.
Hi,
On Thu, 2016-01-28 at 16:10 +0800, 苏成才 wrote:
> Hi guys:
> I encountered a problem: the windows screen cannot display properly
> when use spice-html5, also the VM installed spice-guest-tools.exe.
> But if i don't install the spice-guest-tools, then everything is ok.
> My env is:
> 1) spice-htm
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Since the mouse mode is now stored in the inputs channel, we were
> crashing when somebody was calling this API before the inputs channel
> was created.
The same apply for more functions in inputs-channel.h, n
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Rename function to be more consistent
>
> Acked-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/inputs-channel.c | 2 +-
> server/inputs-channel.h | 2 +-
> server/r
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Rename to make function name more consistent
>
> Acked-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/main-channel.c | 2 +-
> server/main-channel.h | 2 +-
> server
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Not global.
Looking at PATCH 12/16: What is the usage of the field? It is
initialized in spice_server_new(), added to renderers in
spice_server_init() and cleared when spice_server_add_renderer() is
called. Wh
On Thu, 2016-01-28 at 12:16 +0100, Victor Toso wrote:
> Hi,
> On Wed, Jan 20, 2016 at 09:02:30AM +0100, Pavel Grunt wrote:
> > Change the default option to "auto"
> I really don't see any problem on having this
> Acked-by: Victor Toso
Thanks, pushed
Pavel
>
From: Jonathon Jongsma
Make the RedsState object own an InputsChannel object rather than
having a global inputs channel. This means changing a lot of
inputs-related API to take an InputsChannel* argument and moving the
keyboard, mouse, and tablet objects into the InputsChannel object.
---
v2: squ
op upside down?
There are some patches that may help, see and try the "topdown" branch:
http://cgit.freedesktop.org/~pgrunt/spice-html5/?h=topdown
Regards,
Pavel
>
> Thanks again,
> Melo
>
>
>
>
>
> At 2016-01-28 18:57:50, "Pavel Grunt" wrote:
To see how many images and data could not be compressed.
---
server/dcc.c | 27 +++
server/display-channel.c | 11 +++
server/display-channel.h | 1 +
3 files changed, 39 insertions(+)
diff --git a/server/dcc.c b/server/dcc.c
index bf692f8..15cec72 100
7;t display properly and some
> windows repeat draw. Are there any other patch to solve this problem?
> please see the screen shot in the attachment.
>
> Thanks,
> Melo
>
>
>
>
>
>
> 在 2016-01-29 14:48:54，"Pavel Grunt" 写道：
> >Hi Melo,
> &
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index ebb1629..8b17a76 1006
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Acked-by: Frediano Ziglio
> ---
> server/display-channel.c | 13 +++--
> server/display-channel.h | 3 +--
> server/reds-private.h| 2 ++
> server/reds.c| 20
>
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Remove another global variable
Acked-by: Pavel Grunt
> ---
> server/reds-private.h | 1 +
> server/reds.c | 8
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
ISIBLE int
> spice_server_set_tls(SpiceServer *s, int port,
> }
> memset(&ssl_parameters, 0, sizeof(ssl_parameters));
>
> -spice_secure_port = port;
> +s->spice_secure_port = port;
Or reds->spice_secure_port ?
Acked-by: Pavel Grunt
> g_strl
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Since this is public API, we can't easily change the signature of the
> function to take a RedsState argument, so instead we apply a hack and
> store the reds argument inside the device state struct when the
>
On Fri, 2016-01-29 at 08:41 -0500, Frediano Ziglio wrote:
> >
> > To see how many images and data could not be compressed.
> > ---
> > server/dcc.c | 27 +++
> > server/display-channel.c | 11 +++
> > server/display-channel.h | 1 +
> > 3 files changed
It is needed for g_source_set_ready_time()
Set GLIB_VERSION_MAX_ALLOWED to avoid using not available functions.
---
configure.ac | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2b09ec7..f2f37dd 100644
--- a/configure.ac
+++ b/configur
On Mon, 2016-02-01 at 13:53 +, Frediano Ziglio wrote:
> Was used to just assure there was at least one renderer in the list.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/reds-private.h | 2 --
> server/reds.c | 8
> 2 files
On Mon, 2016-02-01 at 13:53 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/reds.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index dbf0976..0ee55c9
On Tue, 2016-02-02 at 13:23 -0600, Jonathon Jongsma wrote:
> On Fri, 2016-01-29 at 11:31 +0100, Pavel Grunt wrote:
> > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> > > From: Jonathon Jongsma
> > >
> > > Since this is public API, we can't
tate struct when the
> interface is added, and retrieve it for use later when it is removed.
Acked-by: Pavel Grunt
> ---
> server/char-device.c| 11 +++
> server/char-device.h| 2 ++
> server/inputs-channel.c | 16 +++-
> server/inputs-ch
On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Also requires adding reds_get_streaming_video() accessor so that
> other
> files can check this value.
> ---
> server/red-dispatcher.c | 7 ---
> server/red-worker.c | 2 +-
> server/reds-private.h |
On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Required adding a RedsState arg to reds_get_agent_mouse()
> ---
> server/inputs-channel.c | 8
> server/reds-private.h | 2 ++
> server/reds.c | 10 +-
> server/reds.h
Ack
On Wed, 2016-02-03 at 11:54 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> spice-common | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/spice-common b/spice-common
> index 472e563..fd9ba72 16
> --- a/spice-common
> +++ b/spice-common
> @@
On Tue, 2016-02-02 at 16:06 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Removing more global variables
Acked-by: Pavel Grunt
> ---
> server/reds-private.h | 1 +
> server/reds.c | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
&g
On Wed, 2016-02-03 at 15:10 -0600, Jonathon Jongsma wrote:
> Also requires adding reds_get_streaming_video() accessor so that
> other
> files can check this value.
Acked-by: Pavel Grunt
Thanks,
Pavel
> ---
>
> - Changed back to assert
>
> server/red-dispatcher.c |
On Wed, 2016-02-03 at 15:07 -0600, Jonathon Jongsma wrote:
> Required adding a RedsState arg to reds_get_agent_mouse()
Acked-by: Pavel Grunt
> ---
> server/inputs-channel.c | 8
> server/reds-private.h | 2 ++
> server/reds.c | 10 +-
> server/red
makes sense
Thanks,
Pavel
Acked-by: Pavel Grunt
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/red-worker.c b/server/red-worker.c
> index df24a5b..e70c9df 100644
> -
Hi Francois,
On Fri, 2016-02-05 at 05:27 +0100, Francois Gouget wrote:
> On Thu, 28 Jan 2016, Pavel Grunt wrote:
> [...]
> > I can provide a recording without the warning:
> > http://people.freedesktop.org/~pgrunt/rhel6_gstreamer_record.spice.
> > xz
> >
> >
Hi,
G_SOURCE_REMOVE was introduced in glib2.32
Pavel
On Tue, 2016-02-09 at 10:27 +, Frediano Ziglio wrote:
> Make code more readable.
> Value is exactly the same.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/event-loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
esult.
extra space ^
Acked-by: Pavel Grunt
Thanks,
Pavel
> ---
> src/channel-usbredir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
> index a9942b2..f16a30f 100644
> --- a/src/channel-usbredir
---
server/dcc.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index c479091..c63f6c1 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -718,6 +718,10 @@ static int dcc_compress_image_glz(DisplayChannelClient
*d
Rules are now:
Compression type:
off -> uncompressed
quic -> jpeg if possible else quic else off
lz -> lz if possible else off
glz -> glz if possible else lz else off
auto_lz -> lz if possible else jpeg else quic else off
auto_glz -> glz if possible else lz else jp
To see how many images and data could not be compressed.
---
server/dcc.c | 32 +++-
server/display-channel.c | 11 +++
server/display-channel.h | 1 +
3 files changed, 35 insertions(+), 9 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index
Hi,
with gtk2:
spice-widget-egl.c: In function ‘spice_egl_init’:
spice-widget-egl.c:203:9: error: implicit declaration of function
‘GDK_IS_X11_DISPLAY’ [-Werror=implicit-function-declaration]
if (GDK_IS_X11_DISPLAY(gdk_dpy)) {
^
spice-widget-egl.c:203:5: error: nested extern declarat
1 - 100 of 1683 matches
Mail list logo
