tive endian. With muliple
layers of headers this is a bit tricky. A few message types have to be swapped
fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
---
src/vdagentd/uinput.c | 4 +++
src/vdagentd/vdagentd.c| 68 ++
tive endian.
With muliple layers of headers this is a bit tricky. A few message types
have to be swapped fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
---
v2:
- introduce helper functions to swap (a portion of) a message wholesale
- pollute fewer places with swapping somet
Signed-off-by: Michal Suchanek
---
src/vdagentd/vdagentd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index 991514e..60a866e 100644
--- a/src/vdagentd/vdagentd.c
+++ b/src/vdagentd/vdagentd.c
@@ -334,6 +334,7 @@ static void
Signed-off-by: Michal Suchanek
---
src/vdagentd/vdagentd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index 4cac473..f759b4c 100644
--- a/src/vdagentd/vdagentd.c
+++ b/src/vdagentd/vdagentd.c
@@ -334,6 +334,7 @@ static void
tive endian.
With muliple layers of headers this is a bit tricky. A few message types
have to be swapped fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
---
v2:
- introduce helper functions to swap (a portion of) a message wholesale
- pollute fewer places with swapping somet
tive endian.
With muliple layers of headers this is a bit tricky. A few message types
have to be swapped fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
---
v2:
- introduce helper functions to swap (a portion of) a message wholesale
- pollute fewer places with swapping somet
Move some mouse-specific code from the start of
virtio_port_read_complete to a separate helper
as is the case with other message types.
Signed-off-by: Michal Suchanek
---
src/vdagentd/vdagentd.c | 43 ---
1 file changed, 24 insertions(+), 19 deletions
n
swapping patch.
Thanks
Michal
Michal Suchanek (4):
Quiet uninitialized variable warning.
udscs: don't pass message type strings into the server.
Move mouse-specific handling out of virtio_port_read_complete
Do endian swapping.
Victor Toso (1):
vdagentd: early return on bad mes
NULLs at the end.
Signed-off-by: Michal Suchanek
---
src/udscs.c | 23 +++
src/udscs.h | 4 ++--
src/vdagent/vdagent.c| 1 -
src/vdagentd-proto-strings.h | 3 ++-
src/vdagentd/vdagentd.c | 1 -
5 files changed, 11 insertions
Move some mouse-specific code from the start of
virtio_port_read_complete to a separate helper
as is the case with other message types.
Signed-off-by: Michal Suchanek
---
src/vdagentd/vdagentd.c | 43 ---
1 file changed, 24 insertions(+), 19 deletions
Signed-off-by: Michal Suchanek
---
v2:
- use g_return_if_reached
---
src/vdagentd/vdagentd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index a1faf23..e2d6159 100644
--- a/src/vdagentd/vdagentd.c
+++ b/src/vdagentd/vdagentd.c
tive endian.
With muliple layers of headers this is a bit tricky. A few message types
have to be swapped fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
Signed-off-by: Victor Toso
---
v2:
- introduce helper functions to swap (a portion of) a message wholesale
- pollute f
().
Signed-off-by: Victor Toso
Signed-off-by: Michal Suchanek
---
v6
- bring back the proper size check for clipboard messages
- sort messages to fixed and variable length and check size accordingly
- size the vdagent_message_min_size array with VD_AGENT_END_MESSAGE
---
src/vdagentd/vdagentd.c
the switch.
Signed-off-by: Michal Suchanek
---
v2:
- use g_return_if_reached
v7:
- reword
---
src/vdagentd/vdagentd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index e934f3f..5ca0106 100644
--- a/src/vdagentd/vdagentd.c
+++ b/src/vdage
fixed size messages were checked only
for being too short and not for extra garbage.
Signed-off-by: Victor Toso
Signed-off-by: Michal Suchanek
---
v6
- bring back the proper size check for clipboard messages
- sort messages to fixed and variable length and check size accordingly
- size the
tive endian.
With muliple layers of headers this is a bit tricky. A few message types
have to be swapped fully before passing through vdagentd.
Signed-off-by: Michal Suchanek
Signed-off-by: Victor Toso
---
v2:
- introduce helper functions to swap (a portion of) a message wholesale
- pollute f
Hello,
I installed the spice guest tools on Windows 7 - the exe installer from
spice-space.org.
The vdagent service is not running. When I start it it stops.
How do I debug this?
Thanks
Michal
___
Spice-devel mailing list
Spice-devel@lists.freedeskto
Device manager if virtio-serial driver is
> installed and working. vdservice exits when it can't open the spice
> virtio port.
>
> David
>
> On St, 2015-05-06 at 12:03 +0200, Michal Suchanek wrote:
> > Hello,
> >
> > I installed the spice guest tools on
Excerpts from Victor Toso's message of Wed May 06 13:47:12 +0200 2015:
> Hi,
>
> On Wed, May 06, 2015 at 01:13:24PM +0200, Michal Suchanek wrote:
> > Hello,
> >
> > it appears I have no virtio serial port. Where would that connect,
> > anyway? I am runnin
error from
ACL helper to the user seems like the best thing we can do.
Signed-off-by: Michal Suchanek
---
spice-common | 2 +-
src/channel-usbredir.c | 30 ++
2 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/spice-common b/spice-common
index
.
>
> Hey,
>
> On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote:
> > This basically reverts 63c8526c699692b6fdca15db8209730fca7eb817
> >
> > After this change opening the device node is not tried at all.
>
> Imo this is what should be fixed
&g
Excerpts from Christophe Fergeau's message of Mon Jun 29 17:01:23 +0200 2015:
> On Mon, Jun 29, 2015 at 04:52:31PM +0200, Suchánek Michal wrote:
> > Or the other way around compiling in policykit support *should not
> > disable* access to already accessible devices.
>
> We agree on that, and the l
When calling ACL helper fails also try to open the device node directly.
Otherwise user-accessible device nodes are rejected when policykit
support is compiled in and policy is not set up when in fact the device
could be accessed.
Signed-off-by: Michal Suchanek
---
src/channel-usbredir.c | 15
Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015:
> On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Mon Jun 29 17:01:23 +0200
> > 2015:
> > > On Mon, Jun 29, 2015 at
Excerpts from Christophe Fergeau's message of Tue Jun 30 09:30:42 +0200 2015:
> On Mon, Jun 29, 2015 at 06:59:26PM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200
> > 2015:
> > > On Mon, Jun 29, 2015 at
> Otherwise user-accessible device nodes are rejected when policykit
> support is compiled in and policy is not set up when in fact the device
> could be accessed.
>
> Signed-off-by: Michal Suchanek
> ---
> src/channel-usbredir.c | 15 +--
> 1 file changed, 9 inserti
Excerpts from Christophe Fergeau's message of Thu Jul 09 13:47:51 +0200 2015:
> On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote:
> > When calling ACL helper fails also try to open the device node directly.
> >
> > Otherwise user-accessible device nodes a
When calling ACL helper fails also try to open the device node directly.
Otherwise user-accessible device nodes are rejected when policykit
support is compiled in and policy is not set up when in fact the device
could be accessed.
Signed-off-by: Michal Suchanek
--
v2:
- clear errors
Excerpts from Christophe Fergeau's message of Thu Jul 09 16:41:58 +0200 2015:
> On Thu, Jul 09, 2015 at 03:25:19PM +0100, Michal Suchanek wrote:
> > When calling ACL helper fails also try to open the device node directly.
> >
> > Otherwise user-accessible device nodes a
When calling ACL helper fails also try to open the device node directly.
Otherwise user-accessible device nodes are rejected when policykit
support is compiled in and policy is not set up when in fact the device
could be accessed.
Signed-off-by: Michal Suchanek
--
v2:
- clear errors
Excerpts from Christophe Fergeau's message of Thu Jul 09 17:11:45 +0200 2015:
> On Thu, Jul 09, 2015 at 04:58:52PM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Thu Jul 09 16:41:58 +0200
> > 2015:
> > > On Thu, Jul 09, 2015 at
Excerpts from Christophe Fergeau's message of Fri Jul 10 10:23:33 +0200 2015:
> On Fri, Jul 10, 2015 at 10:18:15AM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Thu Jul 09 17:11:45 +0200
> > 2015:
> > > On Thu, Jul 09, 2015 at
Excerpts from Christophe Fergeau's message of Fri Jul 10 13:49:28 +0200 2015:
> On Fri, Jul 10, 2015 at 01:33:41PM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Fri Jul 10 10:23:33 +0200
> > 2015:
> > > On Fri, Jul 10, 2015 at
When calling ACL helper fails also try to open the device node directly.
Otherwise user-accessible device nodes are rejected when policykit
support is compiled in and policy is not set up when in fact the device
could be accessed.
Signed-off-by: Michal Suchanek
--
v2:
- clear errors
Excerpts from Hans de Goede's message of Mon Jul 20 17:46:41 +0200 2015:
> Hi,
>
> On 20-07-15 11:51, Christophe Fergeau wrote:
> > Hey,
> >
> > Looks good te me now.
> > Hans, would you mind taking a quick look at that
> > patch in case you have objections on the change (if
> > spice_usb_acl_help
Hello,
Excerpts from Michal Suchanek's message of Mon Jul 20 19:10:20 +0200 2015:
> Excerpts from Hans de Goede's message of Mon Jul 20 17:46:41 +0200 2015:
> > Hi,
> >
> > On 20-07-15 11:51, Christophe Fergeau wrote:
> > > Hey,
> > >
> > > Looks good te me now.
> > > Hans, would you mind taking
Hello,
I installed the python bindings library but I don't see any
documentation/sample.
I can connect to the server using the python SSL library and the
connection appears to work but I don't know how to create a spice
session.
The Spice GTK C documentation suggests to instantiate SpiceSession
Hello,
I tried to build spice-gtk but I get an error about demarshaller without any
error message.
The README says to install vala but even with vala installed and enabled the
file is not generated.
Any idea what might be wrong?
Thanks
Michal
PKG_CONFIG_PATH=/scratch/celt-bin/lib/pkgconfig
Excerpts from Christophe Fergeau's message of Tue Nov 19 18:23:22 +0100 2013:
> On Tue, Nov 19, 2013 at 06:19:23PM +0100, Michal Suchanek wrote:
> > Hello,
> >
> > I tried to build spice-gtk but I get an error about demarshaller without
> > any error message.
>
Hello,
On Wed, Sep 23, 2015 at 10:05:40AM -0400, David Mansfield wrote:
> Hi,
>
> The attached is a very simple patch, which is working but possibly not
> suitable for inclusion at this point, that locks the x11 session when the
> client disconnects.
>
> Locking is performed using "xdg-screensav
40 matches
Mail list logo
