Re: [PATCH] drm/qxl: Add drm_panic support

2024-09-14 Thread Jocelyn Falempe
On 12/09/2024 11:30, Ryosuke Yasuoka wrote: QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Thanks a lot for this work, one more driver that will handle drm_panic. I have a few comments below, but from drm_panic point of view, it looks alr

Re: [PATCH v2] drm/qxl: Add drm_panic support

2024-09-21 Thread Jocelyn Falempe
On 19/09/2024 09:12, Ryosuke Yasuoka wrote: QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. It looks good to me. I think you just need to adjust some functions argument indentation (tab size is 8), see below. Best regards, -- Jocelyn

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-02 Thread Jocelyn Falempe
On 02/12/2024 17:19, Dmitry Osipenko wrote: On 12/2/24 17:29, Dmitry Osipenko wrote: On 11/29/24 15:24, Ryosuke Yasuoka wrote: +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, +struct drm_scanout_buffer *sb) +{ + struct virtio