Hi Jose,
I have spent a fair amount of time using this client and reviewing it,
and I've got a number of comments for you.
There are a range of minor technical issues; you've got a hiddeninput in
your version that prevents use of a top strip of a window. Removing
that fixes that easily. Similar
This fixes a display glitch in xspice which is caused when
a surface create is queued, but then a direct call to update
the area is issued. Unless we flush the queue, the surface
does not exist, and we fail.
Signed-off-by: Jeremy White
---
This issue is resolved in the tip, so this patch is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
>> I guess that's a long way of saying that I think my patch is
>> appropriate for 0.12.6 :-/.
>
> Would you mind sending this as a separate patch so that it does not
> get lost in this thread? Or maybe you have done that already and I
> missed it?
D
I developed a usbredir kernel module to provide USB transport
capabilities for Xspice.
I started a discussion of it's value to the Linux kernel in a thread here:
http://marc.info/?l=linux-usb&m=143570167111406&w=2
The ending consensus of that discussion was that an upcoming ma-usb
kernel module
The kernel limits stack size to 2048, so using a large local
variable does not work there.
This only happens in error conditions, and should not make
a material difference to the non kernel cases.
Signed-off-by: Jeremy White
---
usbredirparser/usbredirparser.c | 2 +-
1 file changed, 1
This allows us to compile this code for use in the kernel
where we do not have libc functions available.
Signed-off-by: Jeremy White
---
usbredirparser/usbredirfilter.c | 11 +-
usbredirparser/usbredirparser.c | 46 -
usbredirparser
Signed-off-by: Jeremy White
---
usbredirparser/usbredirfilter.c | 2 ++
usbredirparser/usbredirfilter.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser/usbredirfilter.c
index dfabacb..6b5310b 100644
--- a/usbredirparser/usbredirfilter.c
Signed-off-by: Jeremy White
---
usbredirparser/usbredirparser.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/usbredirparser/usbredirparser.c b/usbredirparser/usbredirparser.c
index 366654c..991b6b8 100644
--- a/usbredirparser/usbredirparser.c
+++ b
This allows us to use the kernel strol function to implement
the cover function.
Signed-off-by: Jeremy White
---
usbredirparser/usbredirfilter.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser
Signed-off-by: Jeremy White
---
usbredirparser/usbredirfilter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser/usbredirfilter.c
index 65d65e4..dfabacb 100644
--- a/usbredirparser/usbredirfilter.c
+++ b/usbredirparser
Signed-off-by: Jeremy White
---
usbredirparser/strtok_r.c | 4
usbredirparser/usbredirfilter.c | 5 +
usbredirparser/usbredirfilter.h | 2 ++
usbredirparser/usbredirparser.c | 8
usbredirparser/usbredirproto-compat.h | 2 ++
usbredirparser
Signed-off-by: Jeremy White
---
usbredirparser/usbredirparser.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/usbredirparser/usbredirparser.c b/usbredirparser/usbredirparser.c
index 991b6b8..6d8735d 100644
--- a/usbredirparser/usbredirparser.c
+++ b/usbredirparser
Signed-off-by: Jeremy White
---
kernel/redir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/redir.c b/kernel/redir.c
index 0c71aee..26ab373 100644
--- a/kernel/redir.c
+++ b/kernel/redir.c
@@ -208,7 +208,8 @@ static void redir_device_connect(void *priv,
static
Signed-off-by: Jeremy White
---
kernel/Makefile | 11 +++
kernel/usbredir.modules | 30 ++
2 files changed, 37 insertions(+), 4 deletions(-)
create mode 100644 kernel/usbredir.modules
diff --git a/kernel/Makefile b/kernel/Makefile
index dd67ac2
Signed-off-by: Jeremy White
---
kernel/Makefile | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/kernel/Makefile b/kernel/Makefile
index d14501e..dd67ac2 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -1,10 +1,21 @@
includes := -I$(PWD
Signed-off-by: Jeremy White
---
kernel/.gitignore | 6 +
kernel/Makefile | 10 +
kernel/README | 24 +++
kernel/TODO | 7 +
kernel/device.c | 359 +++
kernel/hub.c | 503 +
kernel/includes.c
Signed-off-by: Jeremy White
---
kernel/hub.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/kernel/hub.c b/kernel/hub.c
index 66ba64b..1c5f24d 100644
--- a/kernel/hub.c
+++ b/kernel/hub.c
@@ -305,6 +305,18 @@ static struct hc_driver usbredir_hc_driver
Signed-off-by: Jeremy White
---
kernel/device.c | 42 ++
kernel/urb.c | 16
kernel/usbredir.h | 8
3 files changed, 66 insertions(+)
diff --git a/kernel/device.c b/kernel/device.c
index e39e264..f8d1f83 100644
--- a
Signed-off-by: Jeremy White
---
kernel/main.c | 10 ++
kernel/redir.c | 34 ++
2 files changed, 44 insertions(+)
diff --git a/kernel/main.c b/kernel/main.c
index cf11cbb..7b52b94 100644
--- a/kernel/main.c
+++ b/kernel/main.c
@@ -88,6 +88,16
Signed-off-by: Jeremy White
---
connectkernel/connectkernel.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/connectkernel/connectkernel.c b/connectkernel/connectkernel.c
index f45cf62..03bd881 100644
--- a/connectkernel/connectkernel.c
+++ b/connectkernel
This prevents a kernel panic when removing a module
at exactly the right time.
Signed-off-by: Jeremy White
---
kernel/rx.c | 4
kernel/tx.c | 5 +
2 files changed, 9 insertions(+)
diff --git a/kernel/rx.c b/kernel/rx.c
index 92ffa97..16d87af 100644
--- a/kernel/rx.c
+++ b/kernel/rx.c
This utility will connect to a remote system running usbredirserver,
and then write the socket to the sysfs attach point of usbredir,
thereby injecting the remote device into the local kernel.
Signed-off-by: Jeremy White
---
Makefile.am | 2 +-
configure.ac
This server can create a large number of dummy usbredir test
devices. This is particularly useful in testing the usbredir
kernel module.
Signed-off-by: Jeremy White
---
Makefile.am | 2 +-
configure.ac| 1 +
usbredirtestserver
We should now be able to do sane-find-scanner indefinitely.
Signed-off-by: Jeremy White
---
usbredirtestserver/scanjet4370.script | 12 ++
usbredirtestserver/usbredirtestserver.c | 224 +++-
2 files changed, 176 insertions(+), 60 deletions(-)
diff --git a
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/usbredirtestserver/usbredirtestserver.c
b/usbredirtestserver/usbredirtestserver.c
index 00c82ae..0bca621 100644
--- a/usbredirtestserver/usbredirtestserver.c
+++ b
Signed-off-by: Jeremy White
---
connectkernel/connectkernel.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/connectkernel/connectkernel.c b/connectkernel/connectkernel.c
index b9ed114..f45cf62 100644
--- a/connectkernel/connectkernel.c
+++ b/connectkernel
Signed-off-by: Jeremy White
---
connectkernel/connectkernel.1 | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/connectkernel/connectkernel.1 b/connectkernel/connectkernel.1
index 8e5d3d5..12257b8 100644
--- a/connectkernel/connectkernel.1
+++ b/connectkernel
Signed-off-by: Jeremy White
---
connectkernel/connectkernel.c | 133 +-
1 file changed, 92 insertions(+), 41 deletions(-)
diff --git a/connectkernel/connectkernel.c b/connectkernel/connectkernel.c
index cf665e5..b9ed114 100644
--- a/connectkernel
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 89 +++--
1 file changed, 85 insertions(+), 4 deletions(-)
diff --git a/usbredirtestserver/usbredirtestserver.c
b/usbredirtestserver/usbredirtestserver.c
index 0bca621..53204c1 100644
--- a
Signed-off-by: Jeremy White
---
usbredirtestserver/scanjet4370.script | 63 +++
1 file changed, 63 insertions(+)
create mode 100644 usbredirtestserver/scanjet4370.script
diff --git a/usbredirtestserver/scanjet4370.script
b/usbredirtestserver/scanjet4370.script
This adds device, interface, and endpoint commands, along with
fixing the ctrl command and adding a new expect ctrl command.
Put all together and we can simulate the attachment of a HP
Scanjet 4370.
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 423
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/usbredirtestserver/usbredirtestserver.c
b/usbredirtestserver/usbredirtestserver.c
index 4a071f0..81bdda2 100644
--- a/usbredirtestserver
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/usbredirtestserver/usbredirtestserver.c
b/usbredirtestserver/usbredirtestserver.c
index 4937fba..2539182 100644
--- a/usbredirtestserver
This makes it easier to build complex test scripts on a single machine.
Signed-off-by: Jeremy White
---
usbredirtestserver/usbredirtestserver.c | 65 ++---
1 file changed, 51 insertions(+), 14 deletions(-)
diff --git a/usbredirtestserver/usbredirtestserver.c
b
I've parked some working code, and I wanted to leave a pointer to it to
end this thread.
That is, the sense was that usbredir was not appropriate for the linux
kernel, because Intel was working on a driver implementing the Media
Agnostic USB standard, and having a proliferation of drivers didn't m
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Christophe,
Thanks for the review.
On 12/11/2015 03:47 AM, Christophe Fergeau wrote:
> On Wed, Dec 02, 2015 at 02:14:32PM -0600, Jeremy White wrote:
>> This prevents the fallback from calling prepare_access against
>> the whole s
On 12/14/2015 07:42 AM, Frediano Ziglio wrote:
>>
>> On Tue, Dec 08, 2015 at 09:11:08AM -0600, Jeremy White wrote:
>>> This fixes a display glitch in xspice which is caused when
>>> a surface create is queued, but then a direct call to update
>>> the area is
>> To me, the logical next step would be to modify the Spice API to allow
>> Xspice to do everything directly. That would be faster and make for a
>> much cleaner interface (not to mention a more sensible use of memory).
>>
>
> What do you have in mind?
Well, I didn't have anything specific in m
On 12/16/2015 09:33 AM, Daniel P. Berrange wrote:
> On Wed, Dec 16, 2015 at 04:16:04PM +0100, Francois Gouget wrote:
>
> I understand the general desire to support something better than
> MJPEG, but what is the compelling rationale for adding both VP8
> and H264, as opposed to just VP8 ?
>
> Supp
I've spent some time this past week relearning some of the details of
the way Xspice interacts with the Spice server; I thought I'd share my
questions and thoughts, and potential plans for the future.
First, I have a big, naive, question:
http://lists.x.org/archives/xorg-devel/2012-August/033174
801 - 840 of 840 matches
Mail list logo
