Signed-off-by: Jeremy White
---
Makefile|2 --
apache.conf | 10 --
apache.conf.sample | 10 ++
spice-html5.spec.in |4 ++--
4 files changed, 12 insertions(+), 14 deletions(-)
delete mode 100644 apache.conf
create mode 100644 apache.conf.sample
Signed-off-by: Jeremy White
---
spice-html5.spec.in |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/spice-html5.spec.in b/spice-html5.spec.in
index 928d88b..1ce1725 100644
--- a/spice-html5.spec.in
+++ b/spice-html5.spec.in
@@ -5,7 +5,7 @@ Summary:Pure
Signed-off-by: Jeremy White
---
spice-html5.spec.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-html5.spec.in b/spice-html5.spec.in
index 1ce1725..467875a 100644
--- a/spice-html5.spec.in
+++ b/spice-html5.spec.in
@@ -31,7 +31,7 @@ file for Apache, but should
Signed-off-by: Jeremy White
---
spice-html5.spec.in |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spice-html5.spec.in b/spice-html5.spec.in
index 467875a..236ae26 100644
--- a/spice-html5.spec.in
+++ b/spice-html5.spec.in
@@ -1,6 +1,6 @@
Name: spice-html5
Hi,
If you're not going to respond to my comments:
http://lists.freedesktop.org/archives/spice-devel/2013-March/012529.html
I'm certainly not going to commit anything you send.
Cheers,
Jeremy
___
Spice-devel mailing list
Spice-devel@lists.freedesktop
> Dear Jeremy,
> This is a *new* version of the patch that address your comments.
> It sends both down and up keys messages as well as the key modifiers.
> It also fixes the white spaces you have commented on.
I'm very sorry; I jumped to the wrong conclusion based on the
--- Forwarded --- header l
--disable-ticketing :1
remote-viewer spice://localhost:5900
Cheers,
Jeremy
Jeremy White (6):
Handle cache and surface options the same way we handle all options.
Add missing options to the example xorg.conf file.
Consolidate and document the missing parameters
Add a '--auto' flag
Add comment lines for them to the example xorg.conf file.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 12
src/qxl_driver.c| 12 ++--
2 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/examples
Poor man's documentation for the win!
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 16
1 file changed, 16 insertions(+)
diff --git a/examples/spiceqxl.xorg.conf.example
b/examples/spiceqxl.xorg.conf.example
index fd94dc1..a07906e 100644
Signed-off-by: Jeremy White
---
scripts/Xspice | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index d625ea2..1686f9e 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -70,16 +70,25 @@ parser.add_argument('--zlib-gl
Signed-off-by: Jeremy White
---
scripts/Xspice | 59 +++-
1 file changed, 58 insertions(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 1686f9e..32219b4 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -19,6 +19,7
Signed-off-by: Jeremy White
---
scripts/Xspice | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 32219b4..d7b3887 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -50,6 +50,8 @@ parser.add_argument('--config'
Signed-off-by: Jeremy White
---
scripts/Xspice | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index d7b3887..9917aca 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -20,6 +20,7 @@ import argparse
import os
+# Set Spice Agent Mouse
+# defaults to false
+#Option "SpiceAgentMouse" "False"
I must have missed this - since when do we support an agent with Xspice?
+
+# Set Spice Playback compression
+# defaults to true
+#Option "SpicePlaybackCompression" "True"
+
+# Disable
Probably better to use atexit to allow for possible python exceptions on the
way (i.e. bugs)
My python-fu is weak; your approach does look better.
Cheers,
Jeremy
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop
On 03/14/2013 02:00 PM, Alon Levy wrote:
> Looks good to me, ACK series, atexit suggestion used or not.
Pushed, with the use of atexit (although I kept ^C handling just
because it made the common use case look nicer).
Cheers,
Jeremy
___
Spice-devel mai
On 03/15/2013 09:19 AM, Andrew Eikum wrote:
> This introduces a new Xorg.conf option, SpicePlaybackFIFODir, which will
> be monitored for files. The XSpice driver will mix and forward the audio
> data sent to those pipes to the Spice client.
>
> This is designed to work with PulseAudio's module-pi
ACK series, and pushed - thanks!
Cheers,
Jeremy
On 03/18/2013 09:40 AM, Amos Benari wrote:
> ---
> inputs.js | 20
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/inputs.js b/inputs.js
> index 4d3b28f..1131d09 100644
> --- a/inputs.js
> +++ b/inputs.
This prevents a bug when using old versions of qemu (< 1.2) and the latest
driver version.
Signed-off-by: Jeremy White
---
src/qxl_driver.c | 10 --
src/qxl_ums_mode.c |2 +-
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
in
I discovered late last week that my patch
beccf8e81ea6bb4c86bcaf3cd4aac5e18f6d3f0d:
Establish a preferred default of 1024x768 correctly.
causes a failure if running a Linux guest VM with an older host qemu
(qemu < 1.2).
This comes about because the video ram allocated
by older qemu versions (8M
http://lists.x.org/archives/xorg-devel/2013-March/035799.html
<http://lists.x.org/archives/xorg-devel/2013-March/035799.html>
Jeremy White (6):
Eliminate gcc warning on duplicate use of ARRAY_SIZE by Xorg.
Removed unused local variables
Document a meaningful warning.
Eliminate a printf format
Signed-off-by: Jeremy White
---
src/spiceqxl_driver.c |4 ++--
src/spiceqxl_spice_server.c |8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/spiceqxl_driver.c b/src/spiceqxl_driver.c
index dea5190..990467f 100644
--- a/src/spiceqxl_driver.c
+++ b/src
Signed-off-by: Jeremy White
---
src/qxl_driver.c |1 -
src/qxl_image.c |1 -
2 files changed, 2 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 526bd69..ff58601 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -590,7 +590,6 @@ qxl_create_screen_resources
Signed-off-by: Jeremy White
---
src/qxl_ring.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qxl_ring.c b/src/qxl_ring.c
index 2156113..0dcacf7 100644
--- a/src/qxl_ring.c
+++ b/src/qxl_ring.c
@@ -91,6 +91,8 @@ qxl_ring_push (struct qxl_ring *ring,
idx = header->prod &
Signed-off-by: Jeremy White
---
src/spiceqxl_io_port.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index 9d92f93..f570041 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@ -186,8 +186,8 @@ static
Signed-off-by: Jeremy White
---
src/uxa/uxa-accel.c |2 +-
src/uxa/uxa-priv.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/uxa/uxa-accel.c b/src/uxa/uxa-accel.c
index f7c32b7..b84b2b3 100644
--- a/src/uxa/uxa-accel.c
+++ b/src/uxa/uxa-accel.c
@@ -949,7
Silences a gcc warning (-Wattributes).
Signed-off-by: Jeremy White
---
src/murmurhash3.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/murmurhash3.c b/src/murmurhash3.c
index afb7d7d..0df34a7 100644
--- a/src/murmurhash3.c
+++ b/src/murmurhash3.c
@@ -52,12
> Hi,
>
> So gcc is not happy with the FORCE_INLINE which translates into
> "__attribute__((always_inline)"
> and requires an additional "inline" ?
Google led me to this similar commit for DragonFly BSD:
http://leaf.dragonflybsd.org/mailarchive/commits/2012-10/msg00145.html
It says:
> The
Signed-off-by: Jeremy White
---
This is the controversial patch; see previous conversation here:
http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html
I feel the benefit (nearly zero warnings) outweighs the harm (our moral
outrage at what we have to do to the code). I
The '__attribute__((always_inline))' does not strictly imply 'inline'.
Newer versions of gcc detect this misuse and issue the warning.
Including the missing 'inline' resolves the build warning.
Looked reasonable to me, hence the patch.
I'd expect gcc to inline the function anyway, ev
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/22/2013 08:57 AM, Christophe Fergeau wrote:
> On Fri, Mar 22, 2013 at 07:43:38AM -0500, Jeremy White wrote:
>>>>> The '__attribute__((always_inline))' does not strictly
>>>>> imply 'inline'
I thought it would be lovely if I could make my deferred_fps stuff
available to users of qemu. I think it is a helpful change for people
with bandwidth constraints.
And, of course, it'd be nice if I weren't the only one using it .
But as I went to write the patches to make this possible, I found
>> Is that right? Did I miss a better way?
> Can't you do it in a similar way to the "OffScreen Surfaces" and "Image
> Cache" entries in xorg.conf?
I guess I'm not sure exactly if/how those are used.
As far as I can tell, the only way those options can be set is if you
build a custom xorg.conf
Here is the current patch set. I'd appreciate feedback on whether this
is horribly offensive. If not, I'll submit the qemu patch upstream, and
the spice-protocol and xf86-video-qxl patches here.
With these three patches, a
qemu -spice deferred-fps=nn
should make the qemu/xf86-video-qxl driver
> Since this effects only the guest driver, and then only the guest
> driver for one platform, this really should not be handled through qemu
> and the rom at all IMHO. Guest driver options should use whatever is
> the common mechanism in that platform to set driver options, so in
> this case xorg.
Signed-off-by: Jeremy White
---
configure.ac | 18 +-
src/Makefile.am |2 ++
src/dfps.c | 40 +++-
src/dfps.h |1 +
src/qxl.h| 12 +---
src/qxl_driver.c | 23 ++-
src
> I guess this is why the build time dependency is needed. But since
> you now define a custom struct for this in dfps.c, can't we just
> have a "struct SpiceTimer;" somewhere, without needing to build-time
> depend on spice-server ? Also is it just me, or do the dfps.c
> changes break xspice mode
Signed-off-by: Jeremy White
---
This time without the spice-server build requirements of the prior version.
src/Makefile.am |1 +
src/dfps.c | 57 +++---
src/dfps.h | 17 +---
src/qxl.h| 11
On 04/12/2013 03:54 PM, Алексей wrote:
> Hello,
>
> I was using Chrome of up-to-date-at-that-time-version and i used my own
> page with some nodejs-based design. The main difference from default
> spice-html5 page was that parent of spiceDisplay window had zero offset
> from browser window and in
static cursors to improve the behavior.
Cheers,
Jeremy
Jeremy White (3):
Extend the native ArrayBuffer to add a slice() method if missing.
Use document.documentElement.scrollXXX if document.body.scrollXXX is
not present.
Provide two levels of workaround for IE 10 cursor support.
cursor.js
This allows IE10 to function. Note that we would normally subclass
this type, but ArrayBuffer is implemented in native code, and so is
difficult to subclass.
Signed-off-by: Jeremy White
---
spice.html |1 +
spice_auto.html |1 +
spicearraybuffer.js | 58
Provides compatibility for IE10.
Signed-off-by: Jeremy White
---
spicemsg.js |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/spicemsg.js b/spicemsg.js
index 31e54a0..365fdf7 100644
--- a/spicemsg.js
+++ b/spicemsg.js
@@ -639,8 +639,11 @@ function
suggests using a different browser as well.
Signed-off-by: Jeremy White
---
cursor.js |6 +-
display.js|2 +
inputs.js |9 +++
simulatecursor.js | 202 +
spice.html|1 +
spice_auto.html |1
the best choice for now.
Signed-off-by: Jeremy White
---
src/qxl_driver.c | 14 +-
src/spiceqxl_main_loop.c |6 +-
src/spiceqxl_main_loop.h |1 +
3 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index f847c12
Signed-off-by: Jeremy White
---
scripts/Xspice |3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/Xspice b/scripts/Xspice
index 7936c87..bfa9197 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -203,6 +203,9 @@ if cgdb and args.cgdb:
exec_args = [cgdb, '-
I've been testing Fedora 19 in prep for our test days, and I find that I
was able to get a fairly nasty behavior. That is, I would not get
multiple displays, and I'd have a hang at X server termination which
prevents shutdown.
I've tracked one piece down to a spurious setting of
ram->monitors_con
This avoid some configuration races when connecting to a multi-channel
display server which is slow to set up.
Would you mind describing the symptoms of that race?
I'm puzzled by a nasty glitch, and it has monitor config issues
as a symptom. So of course, you have a hammer - and I'm wondering
This commit:
commit 3e37b2c38f661b0b8e285cfa7f0549aa3d216eb5
Author: Dave Airlie
Date: Thu May 9 13:43:57 2013 +1000
qxl: add KMS support v1.2
Avoid DRI create busid symbol for now.
fix warnings.
Creates this error for me:
qxl.h:189:21: fatal error: qxl_drm.h: No such file or di
> I'll add a libdrm version check tomorrow to the configure.ac.
Thanks.
>
> The main reason I pushed it was a certain person was pushing to get
> dfps into Fedora, and since we had the KMS patch in there already
> rebasing it was getting to be a pain, so I just realigned things, but
> yeah I'll
On 05/23/2013 02:39 AM, andya wrote:
> mouse pointer is not at the correct location in the VM and have two
> mouse cursor why?
Cursor positioning in html5 is tricky, and it varies by browser.
I've been meaning to try to make a careful study of it and get it
working correctly for all environments
Signed-off-by: Jeremy White
---
src/qxl.h |1 +
src/qxl_surface.c | 11 +++
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index a9c3b76..b71bca6 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -423,6 +423,7 @@ surface_cache_t
Signed-off-by: Jeremy White
---
src/qxl.h | 12 +++-
src/qxl_kms.c |2 +-
src/qxl_mem.c |2 +-
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index b71bca6..c79a63a 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -56,6 +56,16 @@
#include
ACK, and pushed. Thanks!
Cheers,
Jeremy
On 05/25/2013 11:08 AM, Thomas Goirand wrote:
> Hi,
>
> I'm the Debian Developer working on spice-html5 (eg: I uploaded
> spice-html5 recently in Debian Sid).
>
> I noticed that the minus key on the alphanumeric block wasn't mapped.
> This was particula
Acked and pushed.
Cheers,
Jeremy
On 05/30/2013 10:10 AM, Alon Levy wrote:
> Signed-off-by: Alon Levy
> ---
> spice.html | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/spice.html b/spice.html
> index 0f705fd..bd8d1ab 100644
> --- a/spice.html
> +++ b/spice.html
> @@ -
> Thank you everybody who was involved!
>
> I'd also like to give special credits here to:
> * Dunrong Huang, who single-handedly contributed whole file-transfer feature
> * folks at Codeweavers for contributions to Xspice and creation of
> spice-html5 project
On 08/01/2013 07:54 AM, Fabio Fantoni wrote:
> Are there news about these things?
> - Opus (now stable) implementation and the option to have celt as
> optional on compile.
> about celt optional there is already a patch from one debian maintainer.
I, too, am interested in this. My survey of the
Hi Jordan,
On 08/20/2013 12:04 PM, Jordan Pittier wrote:
> If server runs on port 80 or 443 the default value of
> window.location.port is an empty string
I'm concerned that setting port 80/443 as the default may be misleading
to the average user.
In general, the port we need to specify is going
On 08/23/2013 03:50 AM, Jordan Pittier wrote:
> Hi,
>> I'm concerned that setting port 80/443 as the default may be misleading
>> to the average user.
> Yep, you're right. But the patch is not really defaulting to port 80 or 443,
> it's more like a "fallback" port if window.location.port is empty.
The failure to ack pings led to a nasty bug whereby an inactive client hangs.
The relatively recent change to monitor latency with ping exposed this bug.
Signed-off-by: Jeremy White
---
spiceconn.js | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a
On 08/28/2013 05:09 AM, Alon Levy wrote:
>> The failure to ack pings led to a nasty bug whereby an inactive client hangs.
>> The relatively recent change to monitor latency with ping exposed this bug.
>
> Looks good to me.
>
> Patch didn't apply for some reason, not sure why, just mentioning this
I have done a cursory review, and it doesn't seem to break things
horribly .
A few nits:
> I have used this for the last day and it seems fine, so I'm sending it as a
> patchset and not RFC.
>
> Alon Levy (11):
> xspice: support sending monitors config
This introduces a warning; and we were
> +n = read(uinput_fd, (char *)&inp_event + offset, sizeof(inp_event) -
> offset);
> +offset += n;
> +if (offset < sizeof(inp_event)) {
> +return;
> +}
Nit: you don't handle errors (I realize you're only here when select
indicates read data is present, but still...)
Chee
Signed-off-by: Jeremy White
---
display.js |4
1 file changed, 4 insertions(+)
diff --git a/display.js b/display.js
index f9bfe76..d0d0994 100644
--- a/display.js
+++ b/display.js
@@ -778,6 +778,10 @@ function handle_draw_jpeg_onload()
{
context.drawImage(this
Signed-off-by: Jeremy White
---
src/qxl.h | 12 +++-
src/qxl_kms.c |2 +-
src/qxl_mem.c |2 +-
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index c026b63..a3bc7db 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -56,6 +56,16 @@
#include
Signed-off-by: Jeremy White
---
spicedataview.js | 12
spicemsg.js |3 +--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/spicedataview.js b/spicedataview.js
index ef9555d..43f0170 100644
--- a/spicedataview.js
+++ b/spicedataview.js
@@ -93,4 +93,16
ACK, and pushed.
On 09/16/2013 11:13 AM, Aric Stewart wrote:
> Apologies I did not head these patches correctly.
>
> ---
> spicedataview.js | 12
> spicemsg.js | 6 ++
> spicetype.js | 15 ---
> 3 files changed, 18 insertions(+), 15 deletions(-)
>
>
> di
ACK, and pushed, thanks!
On 09/16/2013 11:13 AM, Aric Stewart wrote:
>
> Also converts the display cache from an array to an object. This is to help
> enforce proper sparceness of the data as well as make it easier to reliably
> fully delete a given cache entry without affecting access to the r
Signed-off-by: Jeremy White
---
src/qxl_driver.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index ac5408e..515704b 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1214,10 +1214,12 @@ qxl_init_scrn (ScrnInfoPtr pScrn
Signed-off-by: Jeremy White
---
client/screen.cpp |2 ++
1 file changed, 2 insertions(+)
diff --git a/client/screen.cpp b/client/screen.cpp
index e76fd50..ce14edd 100644
--- a/client/screen.cpp
+++ b/client/screen.cpp
@@ -357,7 +357,9 @@ inline void RedScreen::update_done
> https://bugzilla.redhat.com/show_bug.cgi?id=1014066
I commented on the bug. It is not at all surprising; spice-html5 has
been used primarily with XSpice sessions, not with Windows and Qemu.
A Javascript console log will likely shed some light on what needs to be
done to fix the issue.
Cheers,
adb5080ebe72 Mon Sep 17 00:00:00 2001
From: Jeremy White
Date: Fri, 4 Oct 2013 09:19:48 -0500
Subject: [PATCH] Add a snd_codec interface to abstract the use of audio
codecs such as celt.
To:
---
common/Makefile.am |4 +
common/snd_codec.c | 260 +
>> Second, the current client does not record correctly in celt mode. I
>> get a stuttered recording when I use that. The gtk code works fine. In
>> my testing, this is true both with and without this patch set. But it's
>> still an unsatisfying result :-/.
>
> You mean it's stuttering with th
Instead of having to resample, can't we fix qemu (and spice headers) to use
48khz by default?
Sure we can switch the default. spice headers is enougth btw. Just
update the frequency there. And bumb the minor version so spice-server
can figure which frequency is used by qemu.
You can still f
>> When spice-server detects that qemu hasn't been updated and is still using
>> 44.1, then it could advertise it does not support Opus and only use celt
>> until qemu is recompiled.
>
> Yep, that will work too. And it will probably handle the transition
> with less code.
That would sure be easi
> 2. Modify qemu to change the device sample rate dynamically
>
> This seems like it should be possible. I'm working up a
> hack to try it (basically, we regen the rate at voice_enable
> time). This seems to fly in the face of 'normal'
> practice, so there is probably
Attached is a patch that suggests my idea. I've done some hacks,
and it seems 'safe' to adjust the rate on the fly like this.
line_out_ctl is driven by guest. Why would you change the rate when the device
start/stop a stream? I don't think that's the right approach.
Well, if you're going to
On old client connection, new qemu/new spice-server should also use celt,
the old client should be able to decode that even if it's 48kHz.
Perhaps; but the number of hard coded values, and the fact
that this code has never been run at anything but 44.1 makes me nervous.
At the very least, won't
However, I can see the record path has a fixed 44100 value, which is probably
bogus today for != 44100 recording?
Yah; there is a fair amount of hard coding (although I'm probably
overly biased by my time in the old client :-/).
And, afaik, there's not a lot of testing done at anything other t
My work on Opus came to a screeching halt while I tried to figure out
why I could not record clean audio in qemu + a Fedora guest.
What I've now found is that if I use soundhw ac97, things seem to work;
but if I use soundhw hda, my recording playback is fairly mangled.
That is, without any of my
The following 8 patches generalize audio codec processing in Spice and
enable the use of Opus for encoding audio.
These patches work for me with qemu/Fedora.
I did use soundhw ac97, and I also applied this patch to qemu:
http://lists.nongnu.org/archive/html/qemu-devel/2013-10/msg01204.html
(Wit
Signed-off-by: Jeremy White
---
common/Makefile.am |4 +
common/snd_codec.c | 261
common/snd_codec.h | 79
configure.ac | 16
4 files changed, 360 insertions(+)
create mode 100644 common/snd_codec.c
This makes celt optional, and paves the way to readily add additional codecs.
Signed-off-by: Jeremy White
---
README |1 -
client/audio_channels.h | 12 ++-
client/playback_channel.cpp | 51 ---
client/record_channel.cpp | 65
Signed-off-by: Jeremy White
---
configure.ac | 37 +++---
gtk/channel-playback.c | 58 +++-
gtk/channel-record.c | 98 +++-
3 files changed, 77 insertions(+), 116 deletions(-)
diff --git a
Signed-off-by: Jeremy White
---
spice/enums.h|1 +
spice/protocol.h |2 ++
2 files changed, 3 insertions(+)
diff --git a/spice/enums.h b/spice/enums.h
index f192e43..fdcffa8 100644
--- a/spice/enums.h
+++ b/spice/enums.h
@@ -325,6 +325,7 @@ typedef enum SpiceAudioDataMode
Signed-off-by: Jeremy White
---
client/Makefile.am |2 +
client/audio_devices.h |8 ---
client/platform.h |6 ++-
client/playback_channel.cpp | 17 ---
client/record_channel.cpp | 24 +
client/x11/platform.cpp | 10 ++--
client/x11
Signed-off-by: Jeremy White
---
audio/spiceaudio.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index bc24557..1a94d8e 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -25,8 +25,17
Signed-off-by: Jeremy White
---
configure.ac |9 +
gtk/Makefile.am|2 ++
gtk/channel-playback.c | 48 +---
gtk/channel-record.c | 14 +++---
4 files changed, 39 insertions(+), 34 deletions(-)
diff --git
Signed-off-by: Jeremy White
---
common/Makefile.am |1 +
common/snd_codec.c | 124 +---
common/snd_codec.h | 22 --
configure.ac |9
spice.proto|1 +
spice1.proto |1 +
6 files changed, 149
Signed-off-by: Jeremy White
---
audio/spiceaudio.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index 5af436c..d648d50 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -25,8 +25,17
> Not that I know of. You may want try building qemu with this patch first
> though:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-10/msg01204.html
Yeah, that prevented a hard lock for me. Thanks!
>
> Which fixes a generic audio bug which I've recently found. Not sure if this
> will he
> If that works it would be good if you could also try:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-10/msg01205.html
>
> And check it does not cause any regressions.
I did try that, and I saw no change in behavior, so I guess that's good
news.
Cheers,
Jeremy
_
My apologies; this was an error - I sent this one twice. The 'correct'
one is opus 5/qemu.
Cheers,
Jeremy
On 10/15/2013 09:29 AM, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> audio/spiceaudio.c | 27 +--
> 1 file changed, 25 inse
> Hmm. I'm a qemu newb; I'll see if fiddling with '-device' gets me
> different results than -soundhw. True confession: my report was also
> against a non tip build of qemu, so I need to retest there as well.
Against the tip of qemu, with your patch, this bug goes away; both ac97
and hda work f
Are you intentionally using the same value for ENCODE/DECODE_FAILED? I'm
asking because ENCODER/DECODER_UNAVAILABLE got different values.
Nope, that's a bug. I'll respin that one.
Looks good otherwise, ACK.
Christophe
___
Spice-devel mailing li
Thanks for the review; it is much appreciated.
On 10/16/2013 06:05 AM, Christophe Fergeau wrote:
> The subject is misleading, it's not just changing spice-server, but both
> server and client.
Fair enough, I'll amend that.
> Can you fix the playbacke typo while at it?
Sure.
> This does not see
The following three patches are a resend of my first sequence from
yesterday that generalizes sound processing.
This set should incorporate all of Christophe's feedback.
The open issue, in my mind, is whether or not it is worth doing a more
complete generalization. That is, the current code has
Signed-off-by: Jeremy White
---
common/Makefile.am |7 ++
common/snd_codec.c | 285
common/snd_codec.h | 69 +
configure.ac | 16 +++
4 files changed, 377 insertions(+)
create mode 100644 common/snd_codec.c
create
This makes celt optional, and paves the way to readily add additional codecs.
Signed-off-by: Jeremy White
---
README |1 -
client/audio_channels.h | 12 ++-
client/playback_channel.cpp | 59 ++--
client/record_channel.cpp | 69
Signed-off-by: Jeremy White
---
README |2 +-
configure.ac |8 +---
gtk/channel-playback.c | 59 -
gtk/channel-record.c | 99
4 files changed, 49 insertions(+), 119 deletions
> The open issue, in my mind, is whether or not it is worth doing a more
> complete generalization. That is, the current code has essentially hard
> coded requirements for the format and number of channels. It also uses
> fairly static sizing for frame buffers.
The spice-gtk code is pretty clean
501 - 600 of 840 matches
Mail list logo
