[Spice-devel] [PATCH] Update SPICE_SERVER_VERSION to be current with 5819976c7ed6669f4334bb5ec8b25cd213dd7e8a.

2012-09-06 Thread Jeremy White
--- server/spice.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice.h b/server/spice.h index fdcfbb7..4b23037 100644 --- a/server/spice.h +++ b/server/spice.h @@ -22,7 +22,7 @@ #include #include -#define SPICE_SERVER_VERSION 0x000b02 /* release 0.11.2 */ +#

Re: [Spice-devel] [PATCH] Technically, the xorg/ prefix should not be specified. It generally works, because xorg/ is usually hung off /usr/include. This enables compliation that correctly respects a

2012-09-06 Thread Jeremy White
> ACK Nudge? ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] Regression in xf86-video-qxl

2012-09-06 Thread Jeremy White
The following commit: commit 2fecf3a171e64ca0dad5653ed740409dc5af2edf Author: Søren Sandmann AuthorDate: Tue Dec 20 09:01:17 2011 -0500 Commit: Søren Sandmann Pedersen CommitDate: Wed Sep 5 18:17:21 2012 -0400 Enable 8 bit pixmaps. a8 surfaces are now supported with the 8BIT_A

[Spice-devel] [PATCH] Enable the use of SpiceExitOnDisconnect so that Xspice can be configured to allow exactly one server per client session.

2012-09-06 Thread Jeremy White
--- src/qxl.h |1 + src/qxl_driver.c|2 ++ src/spiceqxl_spice_server.c | 12 3 files changed, 15 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 8494550..03d08a1 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -125,6 +125,7 @@ enum { OPTI

[Spice-devel] [warning reduction 00/11] Eliminating warnings in xf86-video-qxl

2012-09-09 Thread Jeremy White
The following patch series remove nearly all warnings from xf86-video-qxl. The final one does not remove a warning, but documents the related code with a TODO as the warning appears to be correct. You still get a large number of redudant decl warnings from two xorg include files even with this; a

[Spice-devel] [warning reduction 01/11] mathcalls.h defines a y1() function which triggers a gcc warning; use y_1 local variables instead to avoid this warning.

2012-09-09 Thread Jeremy White
--- src/qxl_driver.c |4 +- src/qxl_surface.c| 66 +-- src/uxa/uxa-accel.c | 70 ++--- src/uxa/uxa-damage.c | 50 ++--- src/uxa/uxa-glyphs.c | 120 +- 5 files changed

[Spice-devel] [warning reduction 02/11] Use an alternate local variable than sin, as it conflicts with the math library. Eliminates gcc -Wshadow warnings.

2012-09-09 Thread Jeremy White
--- src/spiceqxl_display.c | 42 +- src/spiceqxl_inputs.c | 32 2 files changed, 37 insertions(+), 37 deletions(-) diff --git a/src/spiceqxl_display.c b/src/spiceqxl_display.c index b1ce557..b6ae73d 100644 --- a/src/sp

[Spice-devel] [warning reduction 03/11] Rename local parameter 'access' to avoid a conflict; solves a gcc -Wshadow warning.

2012-09-09 Thread Jeremy White
--- src/qxl_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index f543680..8e19bb8 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1232,10 +1232,10 @@ int uxa_pixmap_index; #endif static Bool -qxl_prepare_access

[Spice-devel] [warning reduction 04/11] Eliminate gcc warning on duplicate use of ARRAY_SIZE by Xorg.

2012-09-09 Thread Jeremy White
--- src/spiceqxl_driver.c |4 ++-- src/spiceqxl_spice_server.c |8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/spiceqxl_driver.c b/src/spiceqxl_driver.c index dea5190..990467f 100644 --- a/src/spiceqxl_driver.c +++ b/src/spiceqxl_driver.c @@ -33,7 +33

[Spice-devel] [warning reduction 05/11] Silence a gcc "assignment discards 'const' qualifier" warning

2012-09-09 Thread Jeremy White
--- src/qxl_driver.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 8e19bb8..360a245 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -2544,9 +2544,10 @@ qxl_identify (int flags) static void qxl_init_scrn (ScrnInfoPtr

[Spice-devel] [warning reduction 06/11] Eliminate a gcc "cast discards '__attribute__((const))'" warning

2012-09-09 Thread Jeremy White
--- src/uxa/uxa-accel.c |2 +- src/uxa/uxa-priv.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/uxa/uxa-accel.c b/src/uxa/uxa-accel.c index 557ca75..66087d9 100644 --- a/src/uxa/uxa-accel.c +++ b/src/uxa/uxa-accel.c @@ -949,7 +949,7 @@ out: REGION_DESTROY(pS

[Spice-devel] [warning reduction 07/11] Eliminate a printf format warning on 32 bit systems.

2012-09-09 Thread Jeremy White
--- src/spiceqxl_io_port.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c index 9d92f93..f570041 100644 --- a/src/spiceqxl_io_port.c +++ b/src/spiceqxl_io_port.c @@ -186,8 +186,8 @@ static void qxl_set_mode(qxl_screen_t *

[Spice-devel] [warning reduction 08/11] Add the gnu_printf format attributes; silences a warning.

2012-09-09 Thread Jeremy White
--- src/qxl_mem.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qxl_mem.c b/src/qxl_mem.c index c32eba6..fc3d6d1 100644 --- a/src/qxl_mem.c +++ b/src/qxl_mem.c @@ -54,6 +54,9 @@ qxl_mem_unverifiable(struct qxl_mem *mem) #endif static void +errout (void *data, const char *forma

[Spice-devel] [warning reduction 09/11] Eliminate const warnings.

2012-09-09 Thread Jeremy White
--- src/spiceqxl_inputs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c index c1f6be3..6bf3a81 100644 --- a/src/spiceqxl_inputs.c +++ b/src/spiceqxl_inputs.c @@ -46,9 +46,10 @@ void XSpicePointerUnIn

[Spice-devel] [warning reduction 10/11] Eliminate gcc warning "initialization discards 'const' qualifier from pointer target type"

2012-09-09 Thread Jeremy White
--- src/qxl_driver.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 360a245..f3515e4 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -67,6 +67,10 @@ extern void compat_init_scrn (ScrnInfoPtr); #define

[Spice-devel] [warning reduction 11/11] Document a meaningful warning.

2012-09-09 Thread Jeremy White
--- src/qxl_ring.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_ring.c b/src/qxl_ring.c index 2156113..0dcacf7 100644 --- a/src/qxl_ring.c +++ b/src/qxl_ring.c @@ -91,6 +91,8 @@ qxl_ring_push (struct qxl_ring *ring, idx = header->prod & (ring->n_elements - 1); elt =

Re: [Spice-devel] [PATCH xf86-video-qxl] src/qxl_driver: use the new dixScreenSpecificPrivatesSize

2012-09-11 Thread Jeremy White
Hey Alon (and all), Could this patch be done instead with an #ifdef on XORG_VERSION_CURRENT? It'd be nice if the tip of spice could continue to be useful with older Xorgs (said a guy who's focused on RHEL development... :-/). If that would be okay, I can spin up a patch for it. Cheers, Jeremy

Re: [Spice-devel] [warning reduction 00/11] Eliminating warnings in xf86-video-qxl

2012-09-12 Thread Jeremy White
> Some general comments: > > - You have this pattern where you assign a string to a global variable > and then you assign that variable to a field instead of the string > itself. If this really is necessary, I think the string should just be > cast instead. I haven't been able to make gcc ge

[Spice-devel] [PATCH] Only use dixScreenSpecificPrivatesSize if we have a new enough Xorg.

2012-09-12 Thread Jeremy White
This lets us continue to support older Xorg releases. This reverts 4f37cd85 and partially reverts 4a43bd4. --- configure.ac |2 +- src/qxl_driver.c |6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b8a4b35..11ef73c 100644 --- a/

Re: [Spice-devel] [PATCH spice-html5] rewrite quic.js to be a native javascript implementation

2012-09-13 Thread Jeremy White
ACK - and huzzah! Nice 5x performance boost... ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] Fix XSPICE compile breakage introduced by fb038eb3.

2012-09-13 Thread Jeremy White
--- src/qxl_driver.c |4 1 file changed, 4 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 04a9aa8..dbb8ceb 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1386,7 +1386,9 @@ static Bool qxl_has_composite (qxl_screen_t *qxl) { return +#ifndef XSPICE

[Spice-devel] [PATCH] Simplify memory management for the primary screen.

2012-09-13 Thread Jeremy White
Passing NULL for pbits into fbScreenInit is a treacherous thing to do. It works, because we rapidly resize the screen, and because the normal path never uses the screen pixmap. However, having NULL for pbits has side effects that derive from the fact that NULL prevents ModifyPixmapHeader from doi

Re: [Spice-devel] [PATCH] Simplify memory management for the primary screen.

2012-09-13 Thread Jeremy White
> So we allocate another framebuffer here. Hmm, it is just another 1-16 MB of > memory ;) Yeah, good point. > > Do you have an example how to produce corruption? I'm working on a proper patch for my render + send mode. When I go to render into the screen frame buffer, my world comes crashing

[Spice-devel] [PATCH] Unify memory management for the primary screen.

2012-09-13 Thread Jeremy White
We never actually connected the host_image pixmap to the primary screen, because we never operate on the bits of the primary screen. This causes problems if we wish to use traditional X operations to modify the primary screen, as they will fail and corrupt memory as they go. --- src/qxl.h

Re: [Spice-devel] [PATCH spice-html5][1/6]correct some issues with prototype vs instance member objects

2012-09-13 Thread Jeremy White
ACK series. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] Patch series introduction - Deferred FPS mode

2012-09-15 Thread Jeremy White
The next set of 3 patches introduce a 'Deferred Frames' mode into xf86-video-qxl. This more correctly (at least imho) implements the patch first presented in the email titled: Performance of Xspice - some results, and a potential patch For the use cases I'm focused on (XSpice, simple office app

[Spice-devel] [PATCH 1/3] Add a DeferredFPS option.

2012-09-15 Thread Jeremy White
--- src/qxl.h|3 +++ src/qxl_driver.c |8 2 files changed, 11 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 33b0fb7..f26ddd0 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -125,6 +125,7 @@ enum { OPTION_SPICE_TLS_CIPHERS, OPTION_SPICE_CACERT_FILE, OPTIO

[Spice-devel] [PATCH 2/3] Shift the uxa function initialization to a separate function.

2012-09-15 Thread Jeremy White
--- src/qxl_driver.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 1c79060..c43cbde 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1616,28 +1616,9 @@ qxl_destroy_pixmap (P

[Spice-devel] [PATCH 3/3] Add a deferred frames mode.

2012-09-15 Thread Jeremy White
OM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + * + * Authors: + *Jeremy White + */ + +/* + Deferred Frames Per Second (dfps) Support File + +By default, The x

Re: [Spice-devel] [PATCH 3/3] Add a deferred frames mode.

2012-09-15 Thread Jeremy White
On 09/15/2012 12:28 PM, Alon Levy wrote: >>> This renders all operations to a frame buffer, >>> and sends updates periodically. > > One question I forgot: have you tried composite as well? It's too bad you > have to replace uxa completely for your implementation. I understand anything > else wou

[Spice-devel] [PATCH 1/2] Implement copy with fbFill.

2012-09-20 Thread Jeremy White
This fixes issues with 1 bit images; some pixman implementations did not support 1 bit images - the general fbFill implementation takes care of it for us. --- This depends on the previous series that implement a Deferred FPS mode. src/dfps.c | 27 +++ 1 file changed, 19

[Spice-devel] [PATCH 2/2] Implement prepare_copy using GC functions.

2012-09-20 Thread Jeremy White
This avoids having to screen out bad alu and planemasks; we let the X driver take care of it. --- src/dfps.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/dfps.c b/src/dfps.c index 3e74d65..e5a2273 100644 --- a/src/dfps.c +++ b/src/dfps.c @@ -14

[Spice-devel] [PATCH] Stop constraining the video mode to a maximum of 1024x768.

2012-09-20 Thread Jeremy White
--- src/qxl_driver.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index f52fec6..dbe3a04 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -2309,12 +2309,6 @@ qxl_init_randr (ScrnInfoPtr pScrn, qxl_screen_t *qxl)

Re: [Spice-devel] [PATCH spice-html5] Discard input messages until input channel is ready

2012-09-26 Thread Jeremy White
ACK On 09/26/2012 10:01 AM, Aric Stewart wrote: > Signed-off-by: Aric Stewart > --- > inputs.js | 16 > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/inputs.js b/inputs.js > index 57ee626..4d3b28f 100644 > --- a/inputs.js > +++ b/inputs.js > @@ -86,7 +86,7 @

Re: [Spice-devel] [PATCH] Fix XSPICE compile breakage introduced by fb038eb3.

2012-09-28 Thread Jeremy White
On 09/28/2012 12:50 PM, Christophe Fergeau wrote: > ACK fyi, this patch was similarly completed by this commit: --- commit 6520293e1e1f57bafbcf99592e766f810ce3ad2d Author: Søren Sandmann Pedersen Date: Thu Sep 20 16:26:36 2012 -0400 Make the checks for composite and a8 return FALSE for Xs

[Spice-devel] To warn or not to warn

2012-10-02 Thread Jeremy White
...that is the question. I started a thread here: http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html on dealing with the (many) warnings in xf86-video-qxl. I think it boils down to one big question: are we willing to satisfy gcc, or do we want to turn off warnings we

Re: [Spice-devel] [PATCH spice-html5] support decompressing LZ_IMAGE_TYPE_XXXA images

2012-10-09 Thread Jeremy White
> -function convert_spice_lz_rgb_to_web(context, lz_rgb) > +function convert_spice_lz_to_web(context, lz_image) > { > -var u8 = new Uint8Array(lz_rgb.data); > var at; > -if (lz_rgb.type != LZ_IMAGE_TYPE_RGB32 && lz_rgb.type != > LZ_IMAGE_TYPE_RGBA) > -return undefined; > - > -

Re: [Spice-devel] [PATCH spice-html5] support loading SPICE_IMAGE_TYPE_JPEG_ALPHA image types

2012-10-09 Thread Jeremy White
On 10/03/2012 02:39 PM, Aric Stewart wrote: ACK; the first patch is also ACK'd, modulo the question re data initialization. Cheers, Jeremy > the alpha layering is not well tested > > Signed-off-by: Aric Stewart > --- > display.js | 86 +++---

Re: [Spice-devel] To warn or not to warn

2012-10-09 Thread Jeremy White
> That said, you both agree about keeping that warning and going out of our > way to please xorg, so I'm fine with any patches you agree on ;) Sure; two of us agree. However, Søren has raised concerns, and has not yet further commented. And Søren clearly deserves a substantial voice in what happ

Re: [Spice-devel] To warn or not to warn

2012-10-09 Thread Jeremy White
> There was already one time when code was commited and reverted later because > of misunderstanding on the way the code should be organized, last time it was > coding standard (which to be honest Soren has made clear twice already that > he follows pixman's coding style for xf86-video-qxl), so

Re: [Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-19 Thread Jeremy White
On 10/19/12 6:50 AM, Alon Levy wrote: New API: spice_server_set_ws_ports This adds an optional dependency on libwebsockets. You need to get my patched 0.0.3 version here: git://people.freedesktop.org/~alon/libwebsockets Very cool! I'll try to give this a try early next week. Cheers, Jerem

Re: [Spice-devel] HTML5 Client - hide guest mouse pointer

2012-12-11 Thread Jeremy White
Hi Erfane, > Is it possible to hide the guest mouse pointer in the HTML5 client and only > display the local one (i.e. : the client one) ? > Then, it would make sense to also display locally the pointer as it appears > on the guest. > > If this option is not available, where's the best place to

Re: [Spice-devel] [PATCH spice-html5] Add spice_auto.html for automated console display

2013-01-08 Thread Jeremy White
On 01/08/2013 03:44 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a spice_auto.html which removes the form inputs and obtains > connection details from query parameters. The optional 'token' > parameter is an opaque string passed to the websockets server > to allow it to auto

[Spice-devel] [video-qxl 0/6] Deferred Frame mode series introduction

2013-01-10 Thread Jeremy White
hives/spice-devel/2012-September/010991.html Cheers, Jeremy --- Jeremy White (6): Unify memory management for the primary screen. Add a DeferredFPS option. Shift the uxa function initialization to a separate function. Add a deferred frames mode. Implement copy with fbFill. Impl

[Spice-devel] [video-qxl 1/6] Unify memory management for the primary screen.

2013-01-10 Thread Jeremy White
: Jeremy White --- src/qxl.h |2 +- src/qxl_driver.c | 63 + src/qxl_surface.c | 13 +-- 3 files changed, 37 insertions(+), 41 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 2583c72..4cf9830 100644 --- a/src/qxl.h +++ b

[Spice-devel] [video-qxl 2/6] Add a DeferredFPS option.

2013-01-10 Thread Jeremy White
Signed-off-by: Jeremy White --- examples/spiceqxl.xorg.conf.example |7 +++ src/qxl.h |3 +++ src/qxl_driver.c| 10 ++ 3 files changed, 20 insertions(+) diff --git a/examples/spiceqxl.xorg.conf.example b/examples

[Spice-devel] [video-qxl 3/6] Shift the uxa function initialization to a separate function.

2013-01-10 Thread Jeremy White
Signed-off-by: Jeremy White --- src/qxl_driver.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index b01845c..72beb0f 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1622,28

[Spice-devel] [video-qxl 4/6] Add a deferred frames mode.

2013-01-10 Thread Jeremy White
This renders all operations to a frame buffer, and sends updates periodically. Signed-off-by: Jeremy White --- src/Makefile.am |1 + src/dfps.c| 290 + src/dfps.h| 42 src/qxl.h |5 + src

[Spice-devel] [video-qxl 5/6] Implement copy with fbFill.

2013-01-10 Thread Jeremy White
This fixes issues with 1 bit images; some pixman implementations did not support 1 bit images - the general fbFill implementation takes care of it for us. Signed-off-by: Jeremy White --- src/dfps.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git

[Spice-devel] [video-qxl 6/6] Implement prepare_copy using GC functions.

2013-01-10 Thread Jeremy White
This avoids having to screen out bad alu and planemasks; we let the X driver take care of it. Signed-off-by: Jeremy White --- src/dfps.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/dfps.c b/src/dfps.c index 3e74d65..e5a2273 100644 --- a/src

[Spice-devel] [video-qxl 1/2] Stop constraining the video mode to a maximum of 1024x768.

2013-01-11 Thread Jeremy White
But still default to 1024x768 if no other mode is given. Signed-off-by: Jeremy White --- src/qxl_driver.c | 81 ++ 1 file changed, 20 insertions(+), 61 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index e2d08c7..c7a07cb

[Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-11 Thread Jeremy White
This makes the default display not stretch for 4096x768. Signed-off-by: Jeremy White --- src/qxl_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index c7a07cb..3dae401 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-11 Thread Jeremy White
On 01/11/2013 04:02 PM, Hans de Goede wrote: > Hi, > > On 01/11/2013 10:34 PM, Jeremy White wrote: >> This makes the default display not stretch for 4096x768. > > Hmm this seems to expose a problem with your previous patch then, > as this second patch is not acceptable

Re: [Spice-devel] [PATCH spice-html5]Handling non top-down lz_rgb

2013-01-16 Thread Jeremy White
Hi Vincent, On 01/16/2013 10:54 AM, Vincent Desprez wrote: > Hi, > In order to make spice-html5 working with windows guest and qxl driver, > I made a patch to handle non top-down lz_rgb. I don’t know if it is > possible to make it more efficient but tests showed the result is > responsive enough.

Re: [Spice-devel] [PATCH spice-html5]Handling non top-down lz_rgb

2013-01-21 Thread Jeremy White
Hi Vincent, > +function flip_image_data(img) > +{ > +var w = img.width; > +var h = img.height; > +var temp_w = w; > +var temp_h = h; > +var buff = new Uint8Array(img.width * img.height * 4); > +while (temp_h--) > +{ > +while (temp_w--) > +{ > +

[Spice-devel] FOSDEM?

2013-01-21 Thread Jeremy White
Are there going to be any SPICE devs at FOSDEM? Anyone interested in trying to connect for a bit? Is there already a logical place to connect? Cheers, Jeremy ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Spice-devel] [PATCH spice-html5] Add spice_auto.html for automated console display

2013-01-21 Thread Jeremy White
On 01/15/2013 03:46 PM, Daniel P. Berrange wrote: > On Tue, Jan 08, 2013 at 11:02:38AM -0600, Jeremy White wrote: >> On 01/08/2013 03:44 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> Add a spice_auto.html which removes the form

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-21 Thread Jeremy White
>> Hmm. I've been making sure that no change I make impacts the gtk spice >> client connecting to a qemu fedora 17 guest. But I don't see that >> option there. I'll see about using remote viewer instead. >> >> Did you see an actual problem using the patch, or is just clear to you >> that there w

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-22 Thread Jeremy White
BTW reading patch 1 again, I wonder what exactly it tries to solve, since currently when using spice with qemu (no experience with x-spice) you can already set modes > 1024x768 without problems. This will teach me to set down a patch for a few months while I work on other things :-(. I was in p

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-23 Thread Jeremy White
> You not getting this to work is not your fault, but ours :) It is a > pretty new feature lacking documentation. > > First of all you will need Fedora-18 (preferably fully up2date with > all updates from updates-testing) as both host and guest! I have thus far resisted the need to build an enti

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-23 Thread Jeremy White
>> I currently have qemu-1.3 + spice server 0.12-2, with spice client gtk >> and virt-viewer from git tip of yesterday. I am running a fully up to >> date fc18 guest. > > Hmm that should be new enough I think... > >> I launch qemu from the command line, adding the -global qxl-vga.revision >> fla

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-23 Thread Jeremy White
Aha! I built a qxl_driver from git tip, put that on my fc18 guest, and now I see 4 displays in my drop down list. (I had mistakenly presumed that by up to date fc18 guest, you wanted those stock qxl packages, but the fc18 qxl driver is fairly old). Cheers, Jeremy ___

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-23 Thread Jeremy White
> BTW reading patch 1 again, I wonder what exactly it tries to solve, since > currently when using spice with qemu (no experience with x-spice) you can > already set modes > 1024x768 without problems. Alright, I've spent my day relearning this code, and feel I have a better grasp. The issue is pr

[Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-23 Thread Jeremy White
This fixes a bug with x-spice where you could not specify a default mode in an xorg.conf modeline that was greater than 1024x768. This also eliminates (and partially reverts) patch c1b537fc. It may also fix bug 894421, where gnome modes flicker and work poorly. Signed-off-by: Jeremy White

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-24 Thread Jeremy White
Is it possible to break out the #if 0 removals since I don't see any relation between them and this patch? I'm a huge fan of smaller, more surgical patches. And yeah, I'll shift the first #if 0 removal to another patch. But I think the larger and more material #if 0 removals are related to th

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-24 Thread Jeremy White
On 01/24/2013 05:37 AM, Hans de Goede wrote: Hi, Overall comments: 1) I've run several tests with this, and this looks good to go. Great, thanks! 2) As Alon said, please split of the #if 0 blocks removal, I agree they can be removed after this patch, but lets do so in a follow-up patch Se

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-24 Thread Jeremy White
truly good handle on how the virtual sizing should work. I've attached my current 'best' patch if others are interested. I'll try to follow through tomorrow or Monday. Cheers, Jeremy >From db807800165777bbe2b55ed79db2d830c4a5bd36 Mon Sep 17 00:00:00 2001 From: Jeremy Whit

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-25 Thread Jeremy White
> It didn't even work until recently (with the release of Fedora 17) as seen in > this features page for Fedora 17: > > https://fedoraproject.org/wiki/Features/Gnome_shell_software_rendering > > As you probably know, GNOME 3 has the 3D required desktop and the Fallback > mode desktop. I believ

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-25 Thread Jeremy White
it). But this patch doesn't seem to make it worse; I'd just like to understand why it's so bad. I'm going to look a bit more on Monday, and if I'm satisfied with what I see, I'll submit then. Cheers, Jeremy >From db807800165777bbe2b55ed79db2d830c4a5bd36 Mon S

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-25 Thread Jeremy White
Have we really looked into this? I feel like we're all just throwing our hands up in horror without seeing if there is anything we can do. Be my guest. I'm not a programmer. I can tell you that I'm not aware of anyone doing accelerated 3D stuff in a remoting protocol. Perhaps PC-over-IP (V

[Spice-devel] qemu qxl driver and default display size questions

2013-01-28 Thread Jeremy White
I've spent more time trying to understand X and the qxl driver in a qemu / 4 head environment. It's a bit challenging; there isn't really definitive documentation for what we can expect ScreenInfoRec records to contain (or even exactly what we're supposed to set and when). Does anyone have a set

[Spice-devel] Experimental patch to enable Deferred FPS mode for the qemu qxl driver.

2013-01-28 Thread Jeremy White
When I decided to try to understand what was going on with Gnome fallback, I hacked the Deferred FPS mode into working with a qemu system. This is not quite ready for prime time, but should make for interesting testing. My rather biased sense is that it's an improvement over the normal mode. Che

Re: [Spice-devel] qemu qxl driver and default display size questions

2013-01-29 Thread Jeremy White
>> Does anyone have a set of tests, formal or informal, that are 'good >> enough' for testing the qxl driver with qemu? I'd like to feel that I'm >> putting the code through a known set of tests prior to claiming that my >> patch is good enough. > > What I usually do is fire up a Fedora-18 vm, th

[Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-29 Thread Jeremy White
This fixes a bug with x-spice where you could not specify a default mode in an xorg.conf modeline that was greater than 1024x768. This also eliminates (and partially reverts) patch c1b537fc. It also fixes bug 894421, where gnome modes flicker and work poorly. Signed-off-by: Jeremy White

Re: [Spice-devel] Experimental patch to enable Deferred FPS mode for the qemu qxl driver.

2013-01-29 Thread Jeremy White
> Hmm, this seems like some debugging / wip work left over ? Sorry if I wasn't clear; I had thought that others were interested in trying the dfps stuff in conjunction with qemu. Given my recent experience, I was able to cobble something together that would let people try that use case. I didn't

Re: [Spice-devel] Xspice, Using...

2013-02-05 Thread Jeremy White
On 02/05/2013 06:36 AM, Tomas Jamrisko wrote: > Hi, > > This is a bug ( https://bugzilla.redhat.com/show_bug.cgi?id=907852 ). Some > applications when run first make Xspice unresponsive (loop infinitely, take > as much of CPU as it can...). It should work with icewm. Not so much with > metacit

[Spice-devel] Packaging spice-html5

2013-02-07 Thread Jeremy White
I'm going to put together a fedora package for spice-html5 and apply to become a package maintainer. That leads me to questions: 1. The process likes to have a static download location for the source tar ball. Presuming I make a spice-html5-0.0.1.tgz, where can I stash it? 2. A

[Spice-devel] [spice-html5] Add a basic Apache configuration file.

2013-02-08 Thread Jeremy White
Signed-off-by: Jeremy White --- apache.conf | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 apache.conf diff --git a/apache.conf b/apache.conf new file mode 100644 index 000..dda4cb0 --- /dev/null +++ b/apache.conf @@ -0,0 +1,11 @@ +# +# spice-html5 is a Javascript

[Spice-devel] [spice-html5] Add the ability to build an rpm.

2013-02-08 Thread Jeremy White
Signed-off-by: Jeremy White --- .gitignore |1 + Makefile| 70 +++ spice-html5.spec.in | 38 3 files changed, 109 insertions(+) create mode 100644 .gitignore create mode 100644 Makefile

[Spice-devel] [spice-html5] Update the TODO

2013-02-08 Thread Jeremy White
Signed-off-by: Jeremy White --- TODO | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/TODO b/TODO index 8cf0994..c2ae5fa 100644 --- a/TODO +++ b/TODO @@ -1,22 +1,3 @@ -Bugs: - - . In my latest Xorg/fluxbox theme test, I get flickering of title

Re: [Spice-devel] Packaging spice-html5

2013-02-08 Thread Jeremy White
On 02/07/2013 09:33 AM, Alon Levy wrote: >> I'm going to put together a fedora package for spice-html5 and apply >> to >> become a package maintainer. So I think I've settled on 0.1.0 as the first version. Presuming no one objects to my latest patches, I'll apply those, and tag that tip as versio

Re: [Spice-devel] Packaging spice-html5

2013-02-13 Thread Jeremy White
> Then I'll try submitting the RPM that now builds to the Fedora project. https://bugzilla.redhat.com/show_bug.cgi?id=910793 Wish me luck . Cheers, Jeremy ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [Spice-devel] improving spice-html5 performance

2013-02-19 Thread Jeremy White
Hi Vincent, On 02/19/2013 07:56 AM, Vincent Desprez wrote: > I would like to participate improving the HTML5 client. Are there some > critical features missing (e.g., is caching implemented yet?). Finally, > does someone more involved in the project want to coach me in this task? It would be grea

Re: [Spice-devel] improving spice-html5 performance

2013-02-19 Thread Jeremy White
On 02/19/2013 10:42 AM, Erfane Arwani wrote: > Hi, > > Is there currently someone in charge of the HTML5 client? Who developed the > first version? I developed it initially, and I imagine that I'm considered the primary maintainer as well. Cheers, Jeremy ___

Re: [Spice-devel] xorg driver cleanups

2013-02-25 Thread Jeremy White
On 02/24/2013 11:31 PM, airl...@gmail.com wrote: > Hi, > > these patches just move code around in the X.org driver so it looks more > like something that can be maintained, I'm going to start adding KMS support > to it soon and i'd like to get stuff split out a bit better with an eye > towards >

Re: [Spice-devel] qxl X.org driver bo abstraction for user mode setting

2013-02-26 Thread Jeremy White
Hey Dave, On 02/25/2013 10:32 PM, Dave Airlie wrote: > Hi, > > Okay this is the next chunk of prep for getting KMS into the driver, > the first 8 patches are just preparation work and moving stuff around, > along with a couple of minor fixes. > > The big guy on the end adds the BO abstraction l

Re: [Spice-devel] [Spice-HTML5][PATCH 2/2] added on succeess event

2013-03-04 Thread Jeremy White
Forgive me for niggling, but: > if (o.onerror !== undefined) > this.onerror = o.onerror; > +if (o.onsuccess !== undefined) > + this.onsuccess = o.onsuccess; > ... > +report_success: function(m) > +{ > + if (this.onsuccess != undefined) > +this.onsu

Re: [Spice-devel] [Spice-HTML5][PATCH 1/2] added sendCtrlAltDel method.

2013-03-04 Thread Jeremy White
>> >> Don't you need to also send KEY_UP messages ? > No, the clients (tested on windows and fedora) respond to the key down event. > The next keyboard event contain modifier flags state(Shift, Ctrl, Alt etc.) > in it and the html client will update the modifier state. > Amos. I am concerned abou

Re: [Spice-devel] improving spice-html5 performance

2013-03-06 Thread Jeremy White
On 03/05/2013 09:58 AM, Alon Levy wrote: >> >> >> Hi, >> >> I am currrently trying to correct the glitches when using Win7 with >> qxl driver. Amoung the warning messages I find these ones: "FIXME: >> DrawCopy we don't handle mask flag: xxx" and "FIXME: DrawCopy >> unhandled image flags: xxx". My g

Re: [Spice-devel] [PATCH spice-html5] handling cursor caching

2013-03-06 Thread Jeremy White
Hi Vincent, On 03/06/2013 04:46 AM, Vincent Desprez wrote: > A very small patch to handle cursor caching in spice-html. Indeed until > now the cursor shape wasn't cached so it appeared correctly only once. Your patch look great, with one exception - you really need to treat the flags field as a b

[Spice-devel] [xf86-PATCH 1/2] We're uploading a drawable from the primary surface, use it.

2013-03-06 Thread Jeremy White
Signed-off-by: Jeremy White --- src/qxl_surface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index fc1bdf9..d1644a4 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -294,7 +294,7 @@ upload_one_primary_region(qxl_screen_t

[Spice-devel] [xf86-PATCH 2/2] Initialize our update region at surface creation, avoids 0 size regions

2013-03-06 Thread Jeremy White
Signed-off-by: Jeremy White --- src/dfps.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/dfps.c b/src/dfps.c index e5a2273..6ac29f9 100644 --- a/src/dfps.c +++ b/src/dfps.c @@ -253,6 +253,7 @@ static PixmapPtr dfps_create_pixmap (ScreenPtr screen, int w, int h, int depth, info

Re: [Spice-devel] qxl X.org driver bo abstraction for user mode setting

2013-03-06 Thread Jeremy White
> Well it shouldn't change anything from Xspice execpt I broke the build > or something. XSpice was okay, the dfps mode within Xspice was broken. One I think was a bug in your port, the other was a bug in my code exposed by the (new) crash if you try to create a 0 height pixmap. Patches sent. C

[Spice-devel] IE 10 support - anyone know a clever way to do dynamic cursor support?

2013-03-07 Thread Jeremy White
I'm working on supporting IE 10 in the spice-html5 client. It requires a workaround for missing ArrayBuffer.slice(), but that's pretty straightforward. The issue I'm stuck on is that it appears to not allow data: uris for cursor elements. This stack overflow thread describes the issue: http://s

Re: [Spice-devel] spice client migrate to Android & IOS plateform

2013-03-08 Thread Jeremy White
Can some one let me konw how much effort it would cost, respectively in Android or IOS ? if NOT such official dev plan, I'd like to initiate one. I had hoped that the spice-html5 client would lend itself to being used within Android or iOS, greatly simplifying the port (you just drop an html co

Re: [Spice-devel] spice client migrate to Android & IOS plateform

2013-03-09 Thread Jeremy White
Hi, right now I checked this link for websocket support on android 4.2+ browser: http://code.google.com/p/android/issues/detail?id=25221 the latest post, dated 16th of February, says: " I've prepared solution for Web Socktes, and will propagate it for code review on next week. " any possibility?

[Spice-devel] [spice-html5 0/7] Patches for fedora packaging

2013-03-11 Thread Jeremy White
These patches resulted in spice-html5 being approved for inclusion in Fedora. Jeremy White (7): Make our sample Apache configuration work on a RHEL server as well. Fix our SPEC file to indicate LGPLv3 license, not GPLv3 Revise the .spec file to use %{name}, and remove a few unneded

[Spice-devel] [spice-html5 1/7] Make our sample Apache configuration work on a RHEL server as well.

2013-03-11 Thread Jeremy White
Signed-off-by: Jeremy White --- apache.conf |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/apache.conf b/apache.conf index dda4cb0..f3bd2fe 100644 --- a/apache.conf +++ b/apache.conf @@ -3,9 +3,8 @@ # Alias /spice /usr/share/spice-html5 -AllowOverride None

[Spice-devel] [spice-html5 2/7] Fix our SPEC file to indicate LGPLv3 license, not GPLv3

2013-03-11 Thread Jeremy White
Signed-off-by: Jeremy White --- spice-html5.spec.in |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/spice-html5.spec.in b/spice-html5.spec.in index 5351f38..35c386a 100644 --- a/spice-html5.spec.in +++ b/spice-html5.spec.in @@ -3,7 +3,7 @@ Version:VERSION

[Spice-devel] [spice-html5 3/7] Revise the .spec file to use %{name}, and remove a few unneded statements

2013-03-11 Thread Jeremy White
Signed-off-by: Jeremy White --- spice-html5.spec.in | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/spice-html5.spec.in b/spice-html5.spec.in index 35c386a..6c10817 100644 --- a/spice-html5.spec.in +++ b/spice-html5.spec.in @@ -5,12 +5,12 @@ Summary:Pure

<    1   2   3   4   5   6   7   8   9   >