On 05/16/2018 05:17 AM, Christophe Fergeau wrote:
From: Joel Purra
- It seems `SpiceDisplayConn` does not always have the array
`this.o.sc.streams` set.
- It also seems (stream?) images can be loaded before `streams` is set.
- Without `streams`, or the specific stream matching `this.o.id`,
`t
Hey Christophe,
On 07/12/2018 11:07 AM, Christophe Fergeau wrote:
log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does n
diff --git a/display.js b/display.js
index 7719b23..c55b686 100644
--- a/display.js
+++ b/display.js
@@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw = function(prefix,
draw)
str += "; src_bitmap type " + draw.data.src_bitmap.descriptor.type +
", flags " + draw.data.src_bi
Acked-by: Jeremy White
On 07/17/2018 10:18 AM, Christophe Fergeau wrote:
log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
s
Also worked for me.
Acked-by: Jeremy White
On 07/17/2018 10:04 AM, Christophe Fergeau wrote:
spice-html5 does not support multiple display channels, and will only
use the first one offered by spice-server, and ignore the others. This
can cause issues when using a VM with a configured but
Hi Lorenzo,
On 05/25/2016 07:35 AM, Lorenzo Garcia wrote:
> Hello,
>
> First of all, thanks for your help. The biggest change was that we
> changed the physical server, but i have used the same debs for the
> installation and used the same ubuntu. The spice-html5 client was
> upgraded, but with t
On 06/14/2016 10:24 AM, Christophe Fergeau wrote:
> Hey,
>
> So I've finally pushed all of the spice-server bits save for the
> patch trying to guess the number of CPUs to use for the vp8 encoder
> (hopefully I did not introduce rebase issues).
>
> Thanks a lot (again) for all the work, and sorry
o the SASL implementation.
This includes a limited implementation of the WebSocket protocol,
sufficient for our purposes.
Signed-off-by: Jeremy White
---
Resend; there was discussion without clear consensus. Daniel expressed concern:
https://lists.freedesktop.org/archives/spice-devel/2015-November/0
Signed-off-by: Jeremy White
---
spiceconn.js | 4
1 file changed, 4 insertions(+)
diff --git a/spiceconn.js b/spiceconn.js
index 903f3b0..f20424f 100644
--- a/spiceconn.js
+++ b/spiceconn.js
@@ -334,6 +334,7 @@ SpiceConn.prototype =
process_message: function(msg)
{
var
Signed-off-by: Jeremy White
---
playback.js | 6 +++---
utils.js| 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/playback.js b/playback.js
index 9659381..36e6611 100644
--- a/playback.js
+++ b/playback.js
@@ -46,7 +46,7
This patch series introduces support for VP8 codecs to the
spice-html5 client.
The first few patches simply introduce debug tools; the money
patches are the 4th, 5th and 6th patches.
This works in Firefox 45. It works in Chrome for small browser
window sizes; for larger sizes, Chrome appears to
Signed-off-by: Jeremy White
---
playback.js | 5 -
webm.js | 11 +++
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/playback.js b/playback.js
index 96efb08..ea5017f 100644
--- a/playback.js
+++ b/playback.js
@@ -186,10 +186,13
Previously, we sent them strictly upon receipt. However, receiving
is fast; by adding in some of the processing time (i.e. queueing and
so on), we encourage the adaptive rate control to slow down.
Signed-off-by: Jeremy White
---
display.js | 81
Signed-off-by: Jeremy White
---
display.js | 230 ++-
enums.js | 6 ++
spiceconn.js | 5 +-
utils.js | 1 +
webm.js | 98 +
5 files changed, 337 insertions(+), 3 deletions(-)
diff --git a
Signed-off-by: Jeremy White
---
playback.js | 63 -
utils.js| 53 +++
2 files changed, 115 insertions(+), 1 deletion(-)
diff --git a/playback.js b/playback.js
index 36e6611..96efb08
win
- Determine why the discontinuous feed causes so much heartburn, and
work to mitigate it. This is worst, and reproducible with audio, so I
plan to focus there and then bring any lessons learned back into the
video handling later.
Cheers,
Jeremy
On 06/05/2015 10:05 AM, Jeremy White wrote:
> Hey a
> +if (video_codecs) {
> +#if SPICE_SERVER_VERSION >= 0x000c06 /* 0.12.6 */
> +if (spice_server_set_video_codecs(spice_server, video_codecs)) {
> +fprintf(stderr, "spice: invalid video encoder %s\n",
> video_codecs);
> +exit(1);
This should be 13.2, right? Oth
On 07/07/2016 08:09 AM, Francois Gouget wrote:
> On Wed, 6 Jul 2016, Jeremy White wrote:
>
>>> +if (video_codecs) {
>>> +#if SPICE_SERVER_VERSION >= 0x000c06 /* 0.12.6 */
>>> +if (spice_server_set_video_codecs(spice_server, video_codecs)) {
>
Hi folks,
I've gone ahead and built an x11spice utility as discussed here:
https://lists.freedesktop.org/archives/spice-devel/2016-March/027747.html
The source code is here (at least for now):
https://github.com/jwhite66/x11spice
Essentially, this adds the ability to export a running Xorg se
Thanks for all the testing, and thanks for the (now merged) patch, Pavel.
>>>
>>> I'd be grateful if folks gave it a try; feedback is greatly appreciated.
>>
>> It works nicely, I noticed that cpu usage is 100% all the time (even
>> when no client is connected).
>
> My cpu usage is okay (below 50
---
Changelog:
* Wed Aug 17 2016 Jeremy White 0.1.7-1
- Jeremy White: Add support for vp8 video streams
- Jeremy White: Support sized data streams and stream data reports
- Jeremy White: Add minor debug tools for media playback
- Jeremy White: Enable file transfer for spice_auto.html
- Oliver Gutierrez
>
> I'm glad it's broadly usable; I hope to have a patch attacking the CPU
> usage sometime fairly soon.
I've pushed a series of patches that improve both CPU usage and
performance in the extreme damage case for me.
Cheers,
Jeremy
___
Spice-devel mail
Acked-by: Jeremy White
On 09/20/2016 09:30 AM, Oliver Gutierrez wrote:
> ---
> enums.js| 2 +-
> main.js | 2 +-
> spice.html | 40
> spice_auto.html | 2 +-
> spicemsg.js | 6 +++---
> 5 files changed,
Hey Oliver,
Thanks for this patch; it broadly looks good to me, with one question:
On 09/20/2016 09:30 AM, Oliver Gutierrez wrote:
> +this.portName = new TextDecoder('utf-8').decode(new
> Uint8Array(m.name));
TextDecoder is considered experimental, and is not supported by IE.
Could
Acked and pushed.
Cheers,
Jeremy
On 09/27/2016 10:29 AM, Oliver Gutierrez wrote:
> ---
> README | 4 ++--
> TODO| 2 +-
> cursor.js | 2 +-
> display.js | 36 ++--
> enums.js| 2 +-
> main.js
Looks good to me. I don't have the time to test this myself, so I'll
leave this open for others to kibitz for now.
I don't think it will do harm, so if no one else expresses an opinion
after a while, you can probably nudge me into pushing it.
Reviewed-by: Jeremy White
Cheers,
Browsers now reliably autoplay, and issuing play prematurely
can generate an error in both Firefox and Chrome.
Hence we can simply remove this call and audio seems to work fine.
Signed-off-by: Jeremy White
---
playback.js | 3 ---
1 file changed, 3 deletions(-)
diff --git a/playback.js b
This allows audio processing to be more robust in Firefox.
Signed-off-by: Jeremy White
---
playback.js | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/playback.js b/playback.js
index 55dc0e8..48d4cdd 100644
--- a/playback.js
+++ b/playback.js
@@ -158,7
We previously had a fairly crude 'gap detection', but browsers
are largely supporting the modern buffer semantics, and we can
now rely on them to detect under runs for us.
This improves audio in Chrome while playing large videos.
Signed-off-by: Jeremy White
---
playba
-html5 implementation to play back
sound effectively in both Chrome 53 and Firefox 45.
Jeremy White (4):
Use modern brower information to detect underrun.
Revise sound packet time sequencing for a more recent Firefox.
Rely on the auto play attribute.
Implement support for the playback stop
duplicated time packets.
The long term solution would appear to be 'sequence' mode, but I cannot get
Firefox to use that mode (and MDN suggests that for codecs such as VP8 with time
stamps in line, that Firefox will not accept it).
Signed-off-by: Jeremy White
---
playba
Signed-off-by: Jeremy White
---
spiceconn.js | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/spiceconn.js b/spiceconn.js
index 9651b47..33e7388 100644
--- a/spiceconn.js
+++ b/spiceconn.js
@@ -127,21 +127,28 @@ SpiceConn.prototype
Instead, let's set it to an empty gif. Should have the
same benefit.
Signed-off-by: Jeremy White
---
display.js | 2 +-
utils.js | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/display.js b/display.js
index 6c6b962..d9bdd9f 100644
--- a/display.js
+++ b/displ
Signed-off-by: Jeremy White
---
display.js | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/display.js b/display.js
index 9fc13c0..6c6b962 100644
--- a/display.js
+++ b/display.js
@@ -535,7 +535,10 @@ SpiceDisplayConn.prototype.process_channel_message =
function(msg
Signed-off-by: Jeremy White
---
display.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/display.js b/display.js
index d9bdd9f..e26bff8 100644
--- a/display.js
+++ b/display.js
@@ -963,8 +963,8 @@ function handle_draw_jpeg_onload()
this.o.sc.surfaces
In testing audio in conjunction with video playback, I made a number
of fairly modest improvements to the spice-html5 streaming support.
This patch set provides those; with this set, and the prior audio set,
you can arguably play videos using spice-html5 and the result is usable.
Jeremy White (5
Otherwise, we end up discarding stream data messages, and our decode
can become corrupted, notably on Chrome.
This way, we should not lose any messages while we are waiting for
source buffer creation.
Signed-off-by: Jeremy White
---
display.js | 23 ++-
1 file changed, 10
This will allow client cleanup to happen.
Signed-off-by: Jeremy White
---
server/reds.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index c235421..e380dd1 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -559,12 +559,6 @@ void
t at first
client disconnect :-/.
Cheers,
Jeremy
>
> Pavel
>
> On Wed, 2016-11-02 at 10:42 -0500, Jeremy White wrote:
>> This will allow client cleanup to happen.
>>
>> Signed-off-by: Jeremy White
>> ---
>> server/reds.c | 12 ++--
>> 1
>> On 11/03/2016 04:58 AM, Pavel Grunt wrote:
>>> moving it down can cause server to not exit in case client==NULL
>>
>> I spent some time and could not persuade myself of a case where this
>> function would be called with client == NULL. Am I missing
>> something?
>
> Same here, you are right, b
Hey Christophe,
Thanks for driving for a release; it is much appreciated.
On 10/28/2016 05:18 AM, Christophe Fergeau wrote:
> xspice needs to be updated to cope with some X.Org 1.19 API changes,
> better to make that explicit at configure time rather than letting
> people discover the hard way (i
Hey Christophe,
> I don't know what others think, so just let me know how you feel about
> that.
I'm a huge fan!
I've just run an Xspice smoke test on Debian and make check and a basic
Xspice test looked clean.
I hit one tiny hitch; the lz4-dev library on Debian is r122, too old to
support the
>> Looks like you still have the original patch in Fedora ;)
>
> Yes, because it fixes the build. Xspice is not widely used,
> so no-one has noticed it is broken yet...
I've noticed, but I don't have an urgent need for server 1.19 just yet.
Cheers,
Jeremy
___
Hi Frediano,
Thanks for the review, and all the hard work to tighten the code.
I've reviewed all 30 patches, and have done a quick dry run test, and it
still seems to work for my use case - thanks!
I have to confess I didn't have the time for as detailed a review as
perhaps it calls for; the PIN
Signed-off-by: Jeremy White
---
This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with
xdg-email.
v4: Tweaks suggested by Andre.
v3: Replace use of memset with more precise behavior, use return of
MultiByteToWideChar
instead of strlen, make a helper function visibly
> This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with
> xdg-email.
*Blush*. I really need to configure repo by repo to targets...
Sorry for the confusion.
Cheers,
Jeremy
___
Spice-devel mailing list
Spice-devel@lists.freede
ably
want to do a git pull before you start any work.
Cheers,
Jeremy
>
> Thanks
>
>
> On 08/03/2016 12:24 AM, Jeremy White wrote:
>> Hi folks,
>>
>> I've gone ahead and built an x11spice utility as discussed here:
>> https://lists.freedesktop
Signed-off-by: Jeremy White
---
display.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/display.js b/display.js
index e26bff8..268f1b0 100644
--- a/display.js
+++ b/display.js
@@ -535,7 +535,7 @@ SpiceDisplayConn.prototype.process_channel_message =
function(msg
Signed-off-by: Jeremy White
---
v2: Turns out my working copy had a subtly different (and better) refinement
than the version I prepared as a patch.
---
display.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/display.js b/display.js
index e26bff8..40a809e 100644
They are fairly noisy, and more appropriate to the
more detailed level.
Signed-off-by: Jeremy White
---
display.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/display.js b/display.js
index e26bff8..1012786 100644
--- a/display.js
+++ b/display.js
@@ -1203,10 +1203,11
It's a fair amount of noise, and not useful at level 1.
Signed-off-by: Jeremy White
---
display.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/display.js b/display.js
index 0646744..788fcc6 100644
--- a/display.js
+++ b/display.js
@@ -1185,7 +1185,7 @@ fun
They are low frequency, useful messages and should be seen
more readily.
Signed-off-by: Jeremy White
---
display.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/display.js b/display.js
index 1012786..0646744 100644
--- a/display.js
+++ b/display.js
@@ -535,7 +535,7
Signed-off-by: Jeremy White
---
display.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/display.js b/display.js
index 788fcc6..40a809e 100644
--- a/display.js
+++ b/display.js
@@ -535,7 +535,7 @@ SpiceDisplayConn.prototype.process_channel_message =
function(msg)
if
This helps Firefox in situations where the incoming traffic
is preventing the audio element from processing data quickly enough.
Signed-off-by: Jeremy White
---
playback.js | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/playback.js b/playback.js
This involved a review of the Firefox parsing code along
with the official specifcation, and setting these fields
to the specified default values.
Signed-off-by: Jeremy White
---
webm.js | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/webm.js b/webm.js
Signed-off-by: Jeremy White
---
display.js | 4
1 file changed, 4 insertions(+)
diff --git a/display.js b/display.js
index c124483..d4baef7 100644
--- a/display.js
+++ b/display.js
@@ -,7 +,11 @@ function handle_append_video_buffer_done(e)
{
if (STREAM_DEBUG >
This helps us avoid stalled video streams.
Signed-off-by: Jeremy White
---
display.js | 8
1 file changed, 8 insertions(+)
diff --git a/display.js b/display.js
index d4baef7..c97f237 100644
--- a/display.js
+++ b/display.js
@@ -1114,6 +1114,14 @@ function
Signed-off-by: Jeremy White
---
display.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/display.js b/display.js
index 40a809e..c124483 100644
--- a/display.js
+++ b/display.js
@@ -1106,6 +1106,12 @@ function handle_append_video_buffer_done(e)
{
stream.append_okay
: Jeremy White
---
webm.js | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/webm.js b/webm.js
index 789da14..72c1853 100644
--- a/webm.js
+++ b/webm.js
@@ -393,28 +393,39 @@ webm_SeekHead.prototype =
function webm_AudioTrackEntry
This does not appear to matter, but let's just be safe.
Signed-off-by: Jeremy White
---
webm.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/webm.js b/webm.js
index 72c1853..6245498 100644
--- a/webm.js
+++ b/webm.js
@@ -406,7 +406,7 @@ function webm_AudioTrack
This fixes a bug introduced by my commit 42134d3e, which would
lead to an infinite recursion of onload statements.
Signed-off-by: Jeremy White
---
display.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/display.js b/display.js
index 40a809e..6691c5e 100644
--- a/display.js
+++ b
Signed-off-by: Jeremy White
---
display.js | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/display.js b/display.js
index 6691c5e..c450088 100644
--- a/display.js
+++ b/display.js
@@ -582,7 +582,9 @@ SpiceDisplayConn.prototype.process_channel_message =
function
Signed-off-by: Jeremy White
---
server/tests/replay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index 8ec65d6..1f3ebb1 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -44,7 +44,7 @@ static SpiceServer
On 01/13/2017 04:48 AM, Frediano Ziglio wrote:
>>
>> Signed-off-by: Jeremy White
>> ---
>> server/tests/replay.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/server/tests/replay.c b/server/tests/replay.c
>> ind
Static variables don't need initializers to be 0.
Signed-off-by: Jeremy White
---
v2: Simply remove the initializer; the whole structure, if static, should be
zero.
---
server/tests/replay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/tests/replay.c b/s
Hi Cory,
On 01/29/2017 04:38 PM, Cory Schwartz wrote:
> Hi,
>
> I noticed on the example page
> https://www.spice-space.org/spice-html5/spice.html
> that you are unable to connect to a websocket where SSL is not
> implemented. The reason for this is that the original site redirects
> to https a
Signed-off-by: Jeremy White
---
main.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/main.js b/main.js
index 2d8a1ff..173ff97 100644
--- a/main.js
+++ b/main.js
@@ -145,7 +145,12 @@ SpiceMainConn.prototype.process_channel_message =
function(msg
On 03/06/2017 02:39 AM, Pavel Grunt wrote:
> Any comments?
ACK, and pushed; a clear improvement, and the patches look sound.
Although this still leaves a lot of work to be done for the html5 client
to look nice.
Cheers,
Jeremy
>
> Thanks,
> Pavel
>
> On Tue, 2017-01-10 at 22:54 +0100, Pavel
Hey all,
We've got an issue with a remote viewer kiosk. That is, in our normal
mode of operation, if something goes wrong with a client connection
(e.g. the sessions is killed, server restarted normally), the kiosk will
exit on disconnect, and we get a chance to retry the connection, or
present t
>> I looked for past discussions on spice-devel; I only readily
>> found discussion of the keepalive parameters on the server side,
>> and it looks like we take the idle timer down to 10 minutes now,
>> from 2 hours. I didn't find discussion of something similar
>> client side.
>>
>> Have we cons
Hi,
On 03/16/2017 10:02 AM, Christophe Fergeau wrote:
> The code to enable/disable on a TCP socket is duplicated in multiple
> places in the code base, this commit replaces this duplicated code with
> a helper in RedsStream.
>
> Signed-off-by: Christophe Fergeau
> ---
> server/Makefile.am
Hi,
On 03/16/2017 10:02 AM, Christophe Fergeau wrote:
> This allows to move some low-level code out of reds.c
>
> Signed-off-by: Christophe Fergeau
> ---
> server/net-utils.c | 24
> server/net-utils.h | 1 +
> server/reds.c | 13 ++---
> 3 files changed,
Hi Cedric,
On 2/1/19 11:55 AM, Cedric Bosdonnat wrote:
Hi Jeremy,
I'm pondering converting spice-html5 before submitting it to npmjs.org.
In the move I'ld move everythin into a SpiceHtml5 namespace.
How does that sound? I'm ready to invest some effort into it, but I'ld
rather to have your ACK
I'd be delighted if spice-html5 had a proper name space!
How should we proceed? I could implement this using ES6 exports, but
that rules out really old browsers. Not sure if CommonJS exports would
cover a broader audience thought.
To some extent, spice-html5 does not support truly old browser
Hi Cédric,
Thank you for this! This is very useful work, and I appreciate you
taking the time to work on it.
I've been through all of the patches, and I think everything looks great.
However, your 02 patch in this sequence has a lot of trailing white
space; could you eliminate that?
Also,
tors: Greg Holt, Andrew Kepert, Ydnar, Lostinet
- * Distributed under the BSD License
- * See http://pajhome.org.uk/crypt/md5 for details.
- */
-
- /* Downloaded 6/1/2012 from the above address by Jeremy White.
-License reproduce here for completeness:
-
-Copyright (c) 1998 - 2009, Pau
local 'password'.
This series is
Acked-by: Jeremy White
I'll push them shortly.
Cheers,
Jeremy
All whitespaces should be fixed now.
Cédric Bosdonnat (13):
CSS: don't force the background color or inputs
dos2unix sha1.js
Introduce ES6 modules
Remove dupli
Signed-off-by: Jeremy White
---
spice.html | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/spice.html b/spice.html
index f9e1af4..d744ef9 100644
--- a/spice.html
+++ b/spice.html
@@ -146,8 +146,10 @@
m.style.display = '
Signed-off-by: Jeremy White
---
spice.css | 2 ++
spice.html | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/spice.css b/spice.css
index 4c61cb3..968ba16 100644
--- a/spice.css
+++ b/spice.css
@@ -103,6 +103,8 @@ body
-webkit-box-shadow: 5px 5px 5px rgba(0, 0, 0, 0.2
Signed-off-by: Jeremy White
---
.gitignore | 1 +
Makefile| 30 +-
package.json => package.json.in | 2 +-
3 files changed, 23 insertions(+), 10 deletions(-)
rename package.json => package.json.in (95%)
diff -
On 04/25/2017 04:40 AM, Victor Toso wrote:
Hey,
On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote:
---
Wouldn't be useful to have x11spice on the download page too?
The only difference I can spot is that the other packages are versioned
and released. But I agree its nice to add a r
On 04/25/2017 08:56 AM, Victor Toso wrote:
> On Tue, Apr 25, 2017 at 08:18:53AM -0500, Jeremy White wrote:
>> On 04/25/2017 04:40 AM, Victor Toso wrote:
>>> Hey,
>>>
>>> On Mon, Apr 24, 2017 at 06:40:22PM +0300, Snir Sheriber wrote:
>>>> --- Wou
Acked-by: Jeremy White
On 05/24/2017 01:57 AM, Tomáš Bohdálek wrote:
> Make sure to show both screen and console.
> ---
> resize.js | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/resize.js b/resize.js
> index f5410d3..b572de7 100644
>
On 05/23/2017 03:44 AM, Tomáš Bohdálek wrote:
> Get minimal screen height from css file.
The patch looks correct, but I'm not sure if we really want the
functionality.
When I originally set the minimum height in the css, I did it primarily
to cause the 'non connected' screen size to come up reas
Hi Tomáš,
On 05/23/2017 07:03 AM, Tomáš Bohdálek wrote:
> This allows show or hide debug console under spice screen.
> ---
> resize.js | 12 ++--
> spice.html | 18 ++
> 2 files changed, 28 insertions(+), 2 deletions(-)
>
> diff --git a/resize.js b/resize.js
> index 89b5
Hi Tomáš,
This patch looks essentially correct to me.
But could you also add constants for the image_compression enums? i.e.
SPICE_IMAGE_COMPRESSION_INVALID and friends?
Cheers,
Jeremy
On 05/24/2017 06:08 AM, Tomáš Bohdálek wrote:
> ---
> display.js | 9 +
> enums.js| 1 +
> s
Hi Tomáš,
On 05/26/2017 02:54 AM, Tomáš Bohdálek wrote:
> This allows show or hide debug console under spice screen.
> ---
> resize.js | 16 ++--
> spice.html | 18 ++
> 2 files changed, 32 insertions(+), 2 deletions(-)
This does not apply to the current master for m
Hi Tomáš,
On 05/29/2017 02:10 AM, Tomáš Bohdálek wrote:
> ---
> display.js | 26 --
> spiceconn.js | 2 ++
> webm.js | 12 ++--
> 3 files changed, 32 insertions(+), 8 deletions(-)
>
> diff --git a/display.js b/display.js
> index 0868f91..c458df6 100644
> -
On 06/14/2017 02:55 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The spice-controller was a small library to let NPAPI browser plugins
> communicate with the spice client. Due to usage of vala, the library
> could not promise ABI stability, and was also considerer a pretty
On 06/14/2017 03:46 PM, Marc-André Lureau wrote:
> Hi Jeremy
>
> - Original Message -
>> On 06/14/2017 02:55 PM, marcandre.lur...@redhat.com wrote:
>>> From: Marc-André Lureau
>>>
>>> The spice-controller was a small library to let NPAPI browser plugins
>>> communicate with the spice clie
>>>
>>> I don't see much alternative. Do you a other proposal?
>>>
>>
>> I think my use case simply requires the ability to pass the pass word in
>> a way that cannot be intercepted by any kind of hook; whether it be
>> wireshark, or an inotify hook. A unix domain socket that can receive
>> the pa
Hi,
>
> I don't see much alternative. Do you a other proposal?
>
I think my use case simply requires the ability to pass the pass word in
a way that cannot be intercepted by any kind of hook; whether it be
wireshark, or an inotify hook. A unix domain socket that ca
Ack.
Cheers,
Jeremy
On 06/08/2017 09:29 AM, Pavel Grunt wrote:
> From: Tomáš Bohdálek
>
> This allows show or hide debug console under spice screen.
> ---
> v3: rebased after dropping the patch for checking the minimal height
> ---
> resize.js | 16 ++--
> spice.html | 18 +++
Ack series, with one very minor niggle on patch 4 coming.
Cheers,
Jeremy
On 06/08/2017 09:27 AM, Pavel Grunt wrote:
> Hi,
>
> these patches implement spice messages for changing image and video
> compression.
> The last patch adds support for VP9 decoding.
>
> Tomáš Bohdálek (4):
> spicecon
Hi,
One tiny niggle:
On 06/08/2017 09:27 AM, Pavel Grunt wrote:
> @@ -606,7 +607,8 @@ SpiceDisplayConn.prototype.process_channel_message =
> function(msg)
> if (this.streams[m.base.id].codec_type ===
> SPICE_VIDEO_CODEC_TYPE_MJPEG)
> process_mjpeg_stream_data(this, m, time
>> Alright, it's up on gitlab now:
>> https://gitlab.com/spice/x11spice
>>
>> Looks like there isn't any obvious way for me to ask to edit the
>> pages; I was going to point to this link as a release file:
>> https://gitlab.com/spice/x11spice/repository/archive.tar.bz2?ref=v1.1
> Thanks!
>
> T
>
> I think we should try to solve this at the virt-viewer level, and move
> the
> discussion to virt-tools list.
>
>>>
>>> I guess a DBus interface could work equally well in this case?
>>>
>>
>> I'm not enough of an expert in DBus to say for sure, but I don't think
>> so. One
Hi Tomáš,
I am concerned about the source and license for the new code.
On 09/06/2017 03:50 AM, Tomáš Bohdálek wrote:
[snip]
> diff --git a/thirdparty/monocursor.js b/thirdparty/monocursor.js
> new file mode 100644
> index 000..5df6da9
> --- /dev/null
> +++ b/thirdparty/monocursor.js
> @@ -
Hi Tomáš,
On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:
> ---
> enums.js| 12 ++--
> main.js | 16 +++-
> spicemsg.js | 4
> 3 files changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/enums.js b/enums.js
> index d5a9003..7154595 100644
> --- a/enums.js
>
Hi Tomáš,
On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:
> ---
> main.js | 15 +++
> spice.html | 5 +
> spice_auto.html | 5 +
> 3 files changed, 25 insertions(+)
>
> diff --git a/main.js b/main.js
> index 0237f0e..447177b 100644
> --- a/main.js
> +++ b/main.j
101 - 200 of 840 matches
Mail list logo
