I realize I'm rather late to the party, but this change causes troubles
with Xspice.
That is, Xorg, on startup, closes stdout.
Since the g_log_default_handler writes to stdout for DEBUG and INFO
messages, those messages never show up anywhere.
The attached patch 'fixes' it. I'm a bit hesitant t
Hey Francois,
On 03/18/2016 09:31 AM, Francois Gouget wrote:
>
> While testing the video streaming I ran into a number of issues caused
> by Xspice's audio playback. So I investigated those and found fixes
> which gives this patch series.
>
> This patch set is totally independent from the vide
Hey Francois,
> @@ -361,14 +366,23 @@ static void start_watching(qxl_screen_t *qxl)
> }
> }
>
> +/* a helper for read_from_fifos() */
> static void wall_ticker(void *opaque)
> {
> qxl_screen_t *qxl = opaque;
> struct audio_data *data = qxl->playback_opaque;
>
> -data->wal
Hi Eric,
This is great; thanks for taking the time to put this together.
Could I ask a few favors, though? This version did not apply to the git
tip for me. I think a few corrections Christophe made recently keep
your utils.js change from applying.
Additionally, if you could keep the spice.htm
Hi,
> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> index 1b3cd07..a9bea52 100644
> --- a/src/spice-widget-egl.c
> +++ b/src/spice-widget-egl.c
> @@ -29,7 +29,9 @@
> #include
>
> #include
> +#if GTK_CHECK_VERSION(3,16,0)
> #include
> +#endif
This breaks builds on Debian,
A specific GTK version check is not appropriate for this particular include.
This fixes compilation on Debian Jessie.
Signed-off-by: Jeremy White
---
src/spice-widget-egl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
index
On 03/22/2016 08:33 AM, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
>> Hi,
>>
>>> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
>>> index 1b3cd07..a9bea52 100644
>>> --- a/src/spice-widget-egl.c
>>> +++ b/src/spice-widget-egl.c
>>> @@ -29,7 +29,9 @@
>>> #include
On 03/24/2016 10:20 AM, Christophe Fergeau wrote:
> Hey,
>
> Sorry, hadn't noticed this message earlier.
>
> On Wed, Mar 09, 2016 at 01:43:14PM -0600, Jeremy White wrote:
>> I realize I'm rather late to the party, but this change causes
>> troubles with Xsp
Hi folks,
As you know, I've done a lot of work on XSpice over the past few years.
I plan to take a new approach by following the model of the excellent
'x11vnc' client.
That is, instead of having our own X server and capturing the output, I
plan to instead use an xdummy style server with a frame
On 03/29/2016 05:43 AM, Francois Gouget wrote:
> On Mon, 28 Mar 2016, Jeremy White wrote:
> [...]
>
>> Hi folks,
>>
>> As you know, I've done a lot of work on XSpice over the past few years.
>> I plan to take a new approach by following the mod
On 03/30/2016 04:57 AM, Pedro Francisco wrote:
> Sending to list as well, this time.
>
> 2016-03-28 15:19 GMT+01:00 Jeremy White :
>> Hi folks,
>>
>> As you know, I've done a lot of work on XSpice over the past few years.
>> I plan to take a new approach b
On 05/04/2016 07:57 AM, Pavel Grunt wrote:
> Spotted by coverity
Tested, acked, and pushed.
Thanks,
Jeremy
> ---
> filexfer.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/filexfer.js b/filexfer.js
> index beabfd8..d850db2 100644
> --- a/filexfer.js
> +++ b/filexfe
lock,
the two second sync timer in the spice server would cause it to
attempt to correct the state by pressing caps lock to get the
states to match. Since the states will never match, the caps
lock effectively cycles on and off every two seconds.
Signed-off-by: Jeremy White
---
src
Signed-off-by: Jeremy White
Acked-by: Victor Toso
I don't have commit access there, do you?
If not, you can submit a merge request and ask people to merge.
Thanks for the review, and no, it looks like I don't. I've submitted a
merge request, at least as far as I can t
Provide some basic documentation as to how to use the new
spice-video-dummy driver.
Signed-off-by: Jeremy White
---
Makefile.am | 3 +++
README | 19 +++
configure.ac| 7 +++
spice-video-dummy/spicedummy.sh
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h| 2 +-
spice-video-dummy/src/dummy_cursor.c | 8 ++---
spice-video-dummy/src/dummy_driver.c | 58 ++--
3 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/spice-video-dummy/src
This patch series introduces a new xorg video driver into the x11spice tree.
The motive is that we are looking to have headless Xspice sessions
with modern DRI / OpenGL support, and the current xf86-video-qxl driver
does not lend itself well to that.
The thinking is that if we combine x11spice wi
a wide range of Mesa features for free. It also simplifies
the overall process.
Signed-off-by: Jeremy White
---
spice-video-dummy/COPYING| 2 +
spice-video-dummy/Makefile.am| 31 ++
spice-video-dummy/README.md | 18 +
spice-video-dummy/autogen.sh | 17
This makes the dummy driver similar to the mode setting driver.
This work was done by Henri Verbeet, which was in turn based heavily on
the Xorg modesetting driver.
Signed-off-by: Jeremy White
---
spice-video-dummy/.gitignore | 9 +
spice-video-dummy/README.md
On 4/18/19 3:10 AM, Frediano Ziglio wrote:
Signed-off-by: Jeremy White
Why this commit is not merged to 1/4 ?
My rationale was that this approach left 1/4 as binary identical to the
upstream repo, leaving what seemed to me like a more clear historical
record.
I don't feel str
Maybe in 1/4 specify from which repository (with url) 850c0516 came?
Sure.
However I would like to have a consistent style. As I can see you
are planning to do a lot of changes on this "dummy" driver so I would
prefer to change all style to a more SPICE one. I can see at least 4
different styl
Hi,
On 3/10/17 11:01 AM, Christophe Fergeau wrote:
On Fri, Mar 10, 2017 at 10:49:54AM -0600, Jeremy White wrote:
Hey all,
We've got an issue with a remote viewer kiosk. That is, in our normal
mode of operation, if something goes wrong with a client connection
(e.g. the sessions is k
Ping? This problem persists, and the patch I sent then:
https://lists.freedesktop.org/archives/spice-devel/attachments/20170310/6938c6dc/attachment.diff
has been working for us for a number of years without any unexpected
consequences.
Could I submit this patch and we remove it when there i
As well as this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1436589
Signed-off-by: Jeremy White
---
configure.ac| 18 ++
meson.build | 15 +++
src/spice-session.c | 15 +++
3 files changed, 48 insertions(+)
diff --git a/configure.ac
Can I suggest this follow up?
https://gitlab.freedesktop.org/fziglio/spice-gtk/commit/e76f04625c075776f0ca0e78e5a42e4aa396faa7
Sure, that approach works fine. I'd probably recommend that the Windows
interval be set to something lower than 15 seconds (from my reading, it
looks like the count
Provide some basic documentation as to how to use the new
spice-video-dummy driver.
Signed-off-by: Jeremy White
---
Makefile.am | 3 +++
README | 19 +++
configure.ac| 7 +++
spice-video-dummy/spicedummy.sh
a wide range of Mesa features for free. It also simplifies
the overall process.
This is from https://gitlab.freedesktop.org/xorg/driver/xf86-video-dummy
as of 850c0516.
Signed-off-by: Jeremy White
---
v2: Provide a specific URL for reference to the upstream xorg driver.
---
spice-video-dummy
This makes the dummy driver similar to the mode setting driver.
This work was done by Henri Verbeet, which was in turn based heavily on
the Xorg modesetting driver.
Signed-off-by: Jeremy White
---
spice-video-dummy/.gitignore | 9 +
spice-video-dummy/README.md
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h| 9 +-
spice-video-dummy/src/dummy_cursor.c | 42 +--
spice-video-dummy/src/dummy_driver.c | 558 ---
3 files changed, 281 insertions(+), 328 deletions(-)
diff --git a/spice-video-dummy/src
Hi Frediano,
Thanks for the review. I've condensed the thread to just a few
interesting points; for the most part, I was able to get indent to make
the changes you requested, and will resubmit with that.
+if (!infoPtr)
+return FALSE;
What we usually want is always brackets
a wide range of Mesa features for free. It also simplifies
the overall process.
This is from https://gitlab.freedesktop.org/xorg/driver/xf86-video-dummy
as of 850c0516.
Signed-off-by: Jeremy White
---
v2: Provide a specific URL for reference to the upstream xorg driver.
v3: Unchanged
---
spice
Provide some basic documentation as to how to use the new
spice-video-dummy driver.
Signed-off-by: Jeremy White
---
v3: Unchanged
---
Makefile.am | 3 +++
README | 19 +++
configure.ac| 7 +++
spice-video
Do this using the spice_indent script which uses indent to apply
current Spice styles (as per Frediano Ziglio on 2019-05-01.
Signed-off-by: Jeremy White
---
v2: Original version
v3: Revised to have case indent at 0, cuddle else, fix functions
returning Bool, and preserve Xorg function
From: Henri Verbeet
Signed-off-by: Jeremy White
---
v3: New
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 0acb4d2..fa23483 100644
--- a/configure.ac
+++ b/configure.ac
@@ -25,7 +25,7 @@ AS_IF([test "x$dummy"
This makes the dummy driver similar to the mode setting driver.
This work was done by Henri Verbeet, which was in turn based heavily on
the Xorg modesetting driver.
Signed-off-by: Jeremy White
---
v2: Apply Spice style
v3: Refine Spice style, disable console keyboard and mouse in default
On 5/3/19 3:27 AM, Frediano Ziglio wrote:
Do this using the spice_indent script which uses indent to apply
current Spice styles (as per Frediano Ziglio on 2019-05-01.
Do you miss a close parenthesis? Not a big issue
Yep, caught it in the push, thanks.
Signed-off-by: Jeremy White
Signed-off-by: Jeremy White
---
src/scan.c| 6 +++---
src/session.c | 8
src/spice.c | 18 +++---
3 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/src/scan.c b/src/scan.c
index bb020de..ebadaf8 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -70,7 +70,7
Signed-off-by: Jeremy White
---
v2 Use (u) (u) thing instead of (u) ((u) thing)
Simplify some casting where possible
---
src/scan.c| 6 +++---
src/session.c | 8
src/spice.c | 18 +++---
3 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/src/scan.c
Signed-off-by: Jeremy White
---
v3 Use the obviously better PRIx64
v2 Use (u) (u) thing instead of (u) ((u) thing)
Simplify some casting where possible
---
src/scan.c| 6 +++---
src/session.c | 8
src/spice.c | 18 +++---
3 files changed, 18 insertions(+), 14
Series Acked-by: Jeremy White
On 6/25/19 11:11 AM, Frediano Ziglio wrote:
Updated a longstanding patch for WebSocket support.
This includes:
- style updates:
- types (C99 instead of GLib);
- memory allocation (GLib instead of SPICE functions);
- support for Windows;
- different fixes
Signed-off-by: Jeremy White
---
src/gui.c| 3 +--
src/listen.c | 3 +--
src/main.c | 4 +---
src/spice.c | 3 +--
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/gui.c b/src/gui.c
index 6748f66e..88acf5c9 100644
--- a/src/gui.c
+++ b/src/gui.c
@@ -147,10 +147,9 @@ void
Signed-off-by: Jeremy White
---
src/options.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/options.c b/src/options.c
index 0d3138d0..cf75e54e 100644
--- a/src/options.c
+++ b/src/options.c
@@ -355,7 +355,9 @@ int options_parse_arguments(int argc, char *argv
Signed-off-by: Jeremy White
---
src/options.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/options.c b/src/options.c
index b7f487c5..0d3138d0 100644
--- a/src/options.c
+++ b/src/options.c
@@ -213,14 +213,34 @@ void
Signed-off-by: Jeremy White
---
src/options.c | 44
1 file changed, 20 insertions(+), 24 deletions(-)
diff --git a/src/options.c b/src/options.c
index b7f487c5..a206c92c 100644
--- a/src/options.c
+++ b/src/options.c
@@ -52,10 +52,10 @@ void
Signed-off-by: Jeremy White
---
src/options.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/options.c b/src/options.c
index 5a55f2c9..a3dd20ac 100644
--- a/src/options.c
+++ b/src/options.c
@@ -339,7 +339,9 @@ int options_parse_arguments(int argc, char *argv
Signed-off-by: Jeremy White
---
src/options.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/options.c b/src/options.c
index a206c92c..303c07de 100644
--- a/src/options.c
+++ b/src/options.c
@@ -50,6 +50,17 @@ void options_init(options_t *options)
memset(options, 0
Instead of trying to parse argv ourselves, just reuse getopt_long_only.
Signed-off-by: Jeremy White
---
src/main.c| 8 +---
src/options.c | 50 --
src/options.h | 2 +-
3 files changed, 42 insertions(+), 18 deletions(-)
diff --git a/src
v2: Use glib memory routines with options.c
Fix a memory use bug in options
Just call getopt_long twice, rather than trying to do a poor implementation
For the listen bug fix, use == NULL, and g_strdup
___
Spice-devel mailing list
Spice-
We were overly dependent on timing for success; now we
deliberately wait for our GC and drawing to finish.
Signed-off-by: Jeremy White
---
src/tests/xcb.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/tests/xcb.c b/src/tests/xcb.c
index 6be4a69b
Signed-off-by: Jeremy White
---
v3: Updates only 1/4; don't check g_malloc return.
---
src/options.c | 46 --
1 file changed, 20 insertions(+), 26 deletions(-)
diff --git a/src/options.c b/src/options.c
index b7f487c5..e9d33f24 100644
---
On 7/22/19 5:16 AM, Frediano Ziglio wrote:
Signed-off-by: Jeremy White
I didn't expected you would change everything :-)
:-).
Well, I appreciate the review, so when the suggestions are easy, I try
to be responsive.
-p = options->spice_password = malloc(options->genera
On 7/23/19 11:27 AM, Frediano Ziglio wrote:
Instead of trying to parse argv ourselves, just reuse getopt_long_only.
Signed-off-by: Jeremy White
This patch looks a bit long compared to the job is doing.
What is the expected behaviour mixing --config and other options?
It looks like the
Also be sure that when replacing an option string, we free it first,
and free the SSL and password_file option fields.
Signed-off-by: Jeremy White
---
v4: Consolidate a few patches into one
Use a suggestion from Freddy to free memory on replace
Use that to simplify the expression of
This fixes a bug with --config= handling.
Add expanded test code courtesy of Frediano Ziglio .
Signed-off-by: Jeremy White
---
src/main.c| 8 +++--
src/options.c | 93 ++-
src/options.h | 1 -
3 files changed, 83 insertions(+), 19 deletions
Signed-off-by: Jeremy White
---
src/options.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/options.c b/src/options.c
index 6620b853..64e6ac95 100644
--- a/src/options.c
+++ b/src/options.c
@@ -327,7 +327,9 @@ int options_parse_arguments(int argc, char *argv
Frediano and I had a slight collision in patch processing.
This set of three patches should build on the patches he committed
to bring the tree to the state intended by the last patch series.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.o
This is largely the work of Frediano Ziglio .
Signed-off-by: Jeremy White
---
src/options.c | 118 +++---
1 file changed, 54 insertions(+), 64 deletions(-)
diff --git a/src/options.c b/src/options.c
index 6c6ecb4e..cff4ac17 100644
--- a/src/options.c
Signed-off-by: Jeremy White
---
src/options.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/options.c b/src/options.c
index 6620b853..64e6ac95 100644
--- a/src/options.c
+++ b/src/options.c
@@ -327,7 +327,9 @@ int options_parse_arguments(int argc, char *argv
This fixes a bug with --config=handling.
This also includes test code courtesy of Frediano Ziglio .
Signed-off-by: Jeremy White
---
src/main.c| 8 +++--
src/options.c | 91 ++-
src/options.h | 1 -
3 files changed, 82 insertions(+), 18
test code. Perhaps I'll strip it out to avoid
confusion, and just leave it in a private branch.
Signed-off-by: Jeremy White
---
src/main.c| 8 +++--
src/options.c | 91 ++-
src/options.h | 1 -
3 files changed, 82 insertions(+
This fixes a bug with --config=handling.
Signed-off-by: Jeremy White
---
v2: Simplify even further.
---
src/main.c| 8 +
src/options.c | 96 ---
src/options.h | 5 +--
3 files changed, 47 insertions(+), 62 deletions(-)
diff --git a/src
This fixes a bug with --config=handling.
Removed old testing code as obsolete instead of updating unused code.
Signed-off-by: Jeremy White
---
v2: Simplify even further.
v3: Add a commit message about the removal of unused code, do not group
static and public functions
---
src/main.c
On 7/26/19 9:28 AM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
For series:
Acked-by: Jeremy White
---
src/options.c | 3 +--
src/options.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/options.c b/src/options.c
index c7c75a8..a6c7b9e 100644
--- a
Hi Brendan,
I've been running with this code for a while, and it works nicely. It's
hard to quantify, but with my test case I get cache hit rates in the 90%
range, and it does seem to improve overall performance.
I've got two comments on the patch, inline below:
On 7/16/19 9:16 PM, Brendan
Fixes compilation on RHEL 7.3.
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h
index af77c177..cb8afc37 100644
--- a/spice-video-dummy/src/dummy.h
+++ b/spice-video
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h | 4 ++--
spice-video-dummy/src/spicedummy_driver.c | 11 ++-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h
index a2502902..af77c177
.
Additionally, the compat-api header conflicts with the older
glamor header file, so it needs to be moved to be included
after glamor.h.
Signed-off-by: Jeremy White
---
v2: Provide more explanation
---
spice-video-dummy/src/dummy.h | 4 ++--
spice-video-dummy/src/spicedummy_driver.c | 15
#x27;. Essentially, it stored the bytes
in reverse order and had a bug while flipping them.
This code stores them in the order we transmit them which simplifies
the code.
Signed-off-by: Jeremy White
---
src/utils.js | 40 ++--
1 file changed, 18 insertions(+),
'. The prepended 0xdf is incorrect; the
correct values should be 0x48e0 and 0xc8e0. Essentially, it stored
the bytes in reverse order and had a bug while flipping them.
This code stores them in the order we transmit them which simplifies
the code.
Signed-off-by: Jeremy
Correct a typo from the upstream atKeynames.js at the same time.
Signed-off-by: Jeremy White
---
src/atKeynames.js | 2 +-
src/utils.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/atKeynames.js b/src/atKeynames.js
index 110e9e9..767e78b 100644
--- a/src
The common scan codes were disjointed and logically belong together.
Signed-off-by: Jeremy White
---
src/utils.js | 101 +--
1 file changed, 57 insertions(+), 44 deletions(-)
diff --git a/src/utils.js b/src/utils.js
index 5059a5b..79e3e5e 100644
The keypad minus key at 109 is common between at least Chrome and Firefox.
Signed-off-by: Jeremy White
---
src/utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/utils.js b/src/utils.js
index f12edf9..5059a5b 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -211,6
This is effectively v2 of 'Adjust the presentation of two byte scan codes.'
It breaks out a part of the patch separately. In reviewing this,
I caught a number of other issues. One warranted a patch (included).
For the rest, I chose to 'fix' it by updating the documentation,
which was a bit out o
On 8/5/19 1:19 PM, Brendan Shanks wrote:
Check the Debian/Ubuntu path for the non-wrapper Xorg binary
Signed-off-by: Brendan Shanks
Acked-by: Jeremy White
---
src/tests/xdummy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/tests/xdummy.c b/src/tests/xdummy.c
index 0651dc7
Hi Brendan,
Nicely done; this solves the problem I had with repeated test runs.
I have one trivial change to request:
On 8/5/19 2:12 PM, Brendan Shanks wrote:
The 'display->fullscreen' SHM segment was previously being used for both
x11spice's internal change scanning and as the spice primary s
sporadic test failures and graphical corruption.
Create a separate SHM segment 'display->primary' and use it only for the
primary surface.
Signed-off-by: Brendan Shanks
Acked-by: Jeremy White
---
v2: Rename local variable 'fullscreen' to 'pri
at 10:53 -0600, Jeremy White wrote:
This involved a review of the Firefox parsing code along
with the official specifcation, and setting these fields
to the specified default values.
Most notably, I have found that recent browsers do not need the
8 ms pre skip, and it seems to remove some audio l
Hi,
I concur with Frediano on those two changes, but this code is otherwise
working well for me.
Cheers,
Jeremy
On 8/17/19 12:05 AM, Frediano Ziglio wrote:
Add a cache to allow the reuse of SHM segments.
Shared memory segments are added to the cache instead of being
deallocated, and the ca
Series:
Acked-by: Jeremy White
and pushed.
Cheers,
Jeremy
On 8/19/19 8:03 PM, Brendan Shanks wrote:
Add a cache to x11spice for SHM segments.
v4 simplifies the 'if' clauses in shm_cache_get/add, as suggested by
Frediano.
Brendan Shanks (3):
Use unsigned int/size_t for dis
This allow us to size and dynamically resize the dummy driver.
Signed-off-by: Jeremy White
---
spice-video-dummy/src/Makefile.am | 2 +-
spice-video-dummy/src/display.c | 415 ++
spice-video-dummy/src/dri2.c | 5 +-
spice-video-dummy/src
The spice-video-dummy driver has two flaws. First, by not providing
a crtc, we take the Present extension into a code path where it
simulates a refresh rate, and the simulated rate is 1Hz.
Applications that query and use that rate then perform badly.
You can see that most easily with glxgears.
S
Using NULL causes the server to relay the message on to the agent,
which does a superior job to anything we currently want to do.
Signed-off-by: Jeremy White
---
src/spice.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/src/spice.c b/src
ned-off-by: Jeremy White
---
spice-video-dummy/src/display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/spice-video-dummy/src/display.c b/spice-video-dummy/src/display.c
index b83869bb..786e6916 100644
--- a/spice-video-dummy/src/display.c
+++ b/spice-video-dummy/src/display.c
@@ -
Versions prior to 1.20 do not have the show_cursor_check function.
Signed-off-by: Jeremy White
---
spice-video-dummy/src/display.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/spice-video-dummy/src/display.c b/spice-video-dummy/src/display.c
index 786e6916..31be0416 100644
From: Henri Verbeet
Signed-off-by: Henri Verbeet
Signed-off-by: Jeremy White
---
spice-video-dummy/src/present.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/spice-video-dummy/src/present.c b/spice-video-dummy/src/present.c
index ad29dc91..40290d70 100644
--- a
From: Henri Verbeet
Signed-off-by: Henri Verbeet
Signed-off-by: Jeremy White
---
spice-video-dummy/src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-video-dummy/src/Makefile.am
b/spice-video-dummy/src/Makefile.am
index 6befa46b..1dc4df8e 100644
--- a
From: Henri Verbeet
This is probably not strictly needed, but it's easy and gets rid of the
"Xlib: extension "DPMS" missing on display ":2"." message.
Signed-off-by: Henri Verbeet
Signed-off-by: Jeremy White
---
spice-video-dummy/src/spicedummy_driver.c |
From: Henri Verbeet
Signed-off-by: Henri Verbeet
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h
index d287a59a..dc4ab92f 100644
--- a/spice-video
From: Henri Verbeet
Signed-off-by: Henri Verbeet
Signed-off-by: Jeremy White
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index aee6c93a..7052d3ff 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,6 +11,7 @@ install-sh
missing
.deps
+.dirstamp
Signed-off-by: Jeremy White
---
spice-video-dummy/src/dummy.h | 2 +-
spice-video-dummy/src/spicedummy_driver.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/spice-video-dummy/src/dummy.h b/spice-video-dummy/src/dummy.h
index cb8afc37..d287a59a 100644
--- a
gcc 4.x warns if you use a { 0 } initialization construct
for a structure with an initial member that is also a struct.
The { } construct is simpler and appears to work on a wider
range of gcc versions.
This is a correction to fdfdf1107be100b983de1bff4beee8e6360f670b
Signed-off-by: Jeremy White
Hi,
I actively maintain spice-html5 and work to review patches and see that
they are committed. In the cases where I miss a patch or two, other
project members usually do a good job of covering them as well.
Your contributions would be welcome.
Cheers,
Jeremy
On 10/23/19 6:10 AM, 조미리 wrot
Ping?
Henri has reviewed these, and I could have him send an ack, but I was
secretly hoping to get an X expert to review patch 5.
Cheers,
Jeremy
On 9/16/19 2:13 PM, Jeremy White wrote:
The spice-video-dummy driver has two flaws. First, by not providing
a crtc, we take the Present
Hey Victor,
On 10/31/19 10:46 AM, Victor Toso wrote:
Hi list,
You might note that the Gitlab activity will increase a bit from
now on, hopefully. It was agreed within some SPICE collaborators
to give a serious try on using this infrastructure that is
available to us.
One potential great change
Series acked and pushed.
Cheers,
Jeremy
On 2/18/20 1:53 PM, Henri Verbeet wrote:
From: Jeremy White
Signed-off-by: Jeremy White
Signed-off-by: Henri Verbeet
---
spice-video-dummy/src/dummy.h | 2 +-
spice-video-dummy/src/spicedummy_driver.c | 2 +-
2 files changed, 2
truct sigaction act = { 0 };
^
test.c:12:12: warning: (near initialization for
‘act.__sigaction_handler’) [-Wmissing-braces]
Attached is the test program.
Cheers,
Jeremy
On 3/11/20 1:27 PM, Uri Lublin wrote:
Hi,
Thanks for the ping on IRC.
On 9/17/19 7:23 PM, Jeremy White wrote:
Hi,
The x11spice project is another example: we have only 4 contributors
from the beginning of the year (and a single contributor holding 70% of
the commits) and the reviews on the gitlab merge requests have been
provided by two people only, each one reviewing the merge requests
Hi all,
I'm trying to get x11spice and spice-html5, at least as packaged for
Fedora, into a pretty much 'turn key' state.
I've got 3 use cases. The first is user A sharing their current
desktop, either for themselves, or to get help. That case is largely
done, imho, modulo some documentati
I didn't know you could do that. I suppose the solution is X11 only? It
would be nice to have gnome-remote-desktop integration. Though GNOME
seems more interested to support RDP these days (having a glib/gobject
server library would certainly help them to consider Spice, *hint* ;)
Yes, altho
On 5/26/20 10:44 AM, Frediano Ziglio wrote:
I suppose you are talking about the unix socket for vdagent, right?
Right, but the same mechanism works well for adding audio for example
(but you have pulseaudio write to a socket).
Hi all,
I'm trying to get x11spice and spice-html5, at least
1 - 100 of 840 matches
Mail list logo
