When setting a new desktop resolution, detect whether the XDDM or the
WDDM driver is loaded, and use the correct API.
This patch is based on the one by Vadim Rozenfeld, with some
improvements:
- Valid for both the XDDM and the WDDM drivers.
- Avoids flickering when the target resolution is the cur
When a new custom display mode is added, the current WDDM driver notifies
a disconnection and reconnection of the virtual monitor to force Windows
to update the display modes. This produces an ugly effect, keeping the
screen black for up to some seconds and usually not repainting it
afterwards.
Th
ove support of hardware pointers. The source can be
found in https://github.com/flexvdi/qxl-dod, and precompiled and signed
binaries can be downloaded from http://depot.flexvdi.com/guest-tools/.
Javier Celaya (2):
Detect and use the new WDDM driver
Use CCD API to update the WDDM display mo
Hi
El 04/02/16 a las 15:12, Fabio Fantoni escribió:
Il 04/02/2016 13:31, Javier Celaya ha scritto:
This patch set adds support for dynamic resolution changes with the WDDM
driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
with some improvements:
- It detects both the X
+update_display_modes();
+} else {
vd_printf("escape failed with error 0x%08X", status);
}
}
--
<http://flexvdi.com><http://flexvdi.com>
Javier Celaya
Software Engineer
j <mailto:javier.cel..
When setting a new desktop resolution, detect whether the XDDM or the
WDDM driver is loaded, and use the correct API.
This patch is based on the one by Vadim Rozenfeld, with some
improvements:
- Valid for both the XDDM and the WDDM drivers.
- Avoids flickering when the target resolution is the cur
When a new custom display mode is added, the current WDDM driver
notifies
a disconnection and reconnection of the virtual monitor to force Windows
to update the display modes. This produces an ugly effect, keeping the
screen black for up to some seconds and usually not repainting it
afterwards.
Th
m.h, since they are actually not common to both the vdagent
and the vdservice. The code for those classes is in vdagent/wddm.cpp.
- Some improvements as suggested by Frediano Ziglio.
Javier Celaya (2):
Detect and use the new WDDM driver
Use CCD API to update the WDDM display modes.
Makefile
Hi
El 12/02/16 a las 12:56, Fabio Fantoni escribió:
Il 10/02/2016 15:34, Fabio Fantoni ha scritto:
Il 04/02/2016 17:01, Javier Celaya ha scritto:
El 04/02/16 a las 16:59, Javier Celaya escribió:
Hi
El 04/02/16 a las 15:12, Fabio Fantoni escribió:
Il 04/02/2016 13:31, Javier Celaya ha
El 15/02/16 a las 16:38, Victor Toso escribió:
Hi,
On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote:
This patch set adds support for dynamic resolution changes with the WDDM
driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
with some improvements:
-
Hi
El 16/02/16 a las 15:23, Victor Toso escribió:
Hi Javier,
On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote:
El 15/02/16 a las 17:01, Javier Celaya escribió:
El 15/02/16 a las 16:38, Victor Toso escribió:
Hi,
On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote
performance, ...)
You are welcome
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
<http://flexvdi.com><http://flexvdi.com>
Javier Celaya
Softw
With scaling enabled, the size request of the widget must be 640x480
(the same as with resize_guest_enable) so that the widget can be
actually scalled down.
---
src/spice-widget.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/spice-widget.c b/s
Can someone review this patch, please?
Thank you
El 13/04/16 a las 13:42, Javier Celaya escribió:
With scaling enabled, the size request of the widget must be 640x480
(the same as with resize_guest_enable) so that the widget can be
actually scalled down.
---
src/spice-widget.c | 25
nimum size of the current guest resolution. The
window can be made bigger, but never smaller.
About the patch - you should declare the update_size_request() function instead
of moving scaling_updated() down - it would be more clear what has changed.
Thanks,
Pavel
On Fri, 2016-04-22 at 08:06 +0200,
When resize-guest-to-match-window-size is disabled, the size request
(minimum size) of the spice widget is set to the current guest
resolution. The client window cannot be made smaller, even with
scale-display enabled.
This patch sets a size request of 640x480 when either
resize-guest-to-match-win
A phodav server created with a NULL shared dir is valid and
results in an error answer to all requests of the webdav channel,
instead of silently ignoring them.
This is better than just returning NULL from
spice_session_get_webdav_server because:
a) it crashes channel_webdav.c:start_client.
b) eve
Hi
El lun, 06-05-2019 a las 10:37 +, Victor Toso escribió:
> Hi,
> On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote:
> > A phodav server created with a NULL shared dir is valid andresults
> > in an error answer to all requests of the webdav channel,instead of
>
Hi,
El mié, 08-05-2019 a las 06:47 +, Victor Toso escribió:
> Hi,
> On Mon, May 06, 2019 at 04:06:45PM +0200, Javier Celaya wrote:
> > HiEl lun, 06-05-2019 a las 10:37 +, Victor Toso escribió:
> > > Hi,On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote:
&g
I'd lean towards doing "clipboard sharing for focused client" +
> > "command-line/runtime option, with clipboard sharing enabled by
> > default".
>
> I'd rather stick with a simple command-line & runtime option.
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
>
The "max-bytes" property of the appsrc GStreamer element expects a
64-bit value. Calling:
g_object_set(source, "max-bytes", 0, NULL);
in a 32-bit architecture ends up with a wrong value, it must be cast to
a long long int:
g_object_set(source, "max-bytes", 0LL, NULL);
---
src/channel-display-gst.c
> - "max-bytes", 0,
> > > + "max-bytes", 0LL,
> > > "block", TRUE,
> > > NULL);
> > > gst_caps_unref(caps);
> >
> > I would use a gint64 ca
The "max-bytes" property of the appsrc GStreamer element expects a
64-bit value. Calling:
g_object_set(source, "max-bytes", 0, NULL);
in a 32-bit architecture ends up with a wrong value, it must be cast to
a gint64:
g_object_set(source, "max-bytes", G_GINT64_CONSTANT(0), NULL);
---
src/channel-dis
The main channel reference d->main of SpiceWidget is initialized on
construction. However, it is used a couple of times before that moment
while setting the default values of some properties, like resize-guest.
This results in some annoying critical log messages. This commit makes
sure that d->main
executed in the Ubuntu guest too? If so,
how?
Thanks for your help
--
Javier Celaya Alastrué
Chief Technology Officer
javier.cel...@flexvdi.com
Hi,
El mié, 03-08-2016 a las 04:57 -0400, Frediano Ziglio escribió:
> >
> > On Wed, Aug 03, 2016 at 11:35:56AM +0300, Sameeh Jubran wrote:
> > > Hi,
> > >
> > > We've already looked into those patches (Javier's patches) and
> > > tested them.
> >
> > Ah ok, I must have missed your answer to Jav
Hi,
El mié, 03-08-2016 a las 16:36 +0300, Dmitry Fleytman escribió:
> > From: Javier Celaya
> > Date: Wed, Aug 3, 2016 at 12:17 PM
> > Subject: Re: [Spice-devel] [PATCH win-vdagent] Provide support for
> > Windows CCD API
> > To: spice-devel@lists.freedesktop.org
Hi,
El mar, 20-09-2016 a las 12:27 +0200, Christophe Fergeau escribió:
> On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote:
> > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio <
> > fzig...@redhat.com>
> > wrote:
> > > It looks like MmMapIoSpaceEx was introduced with Windows 10 while
El mar, 20-09-2016 a las 15:56 +0300, Dmitry Fleytman escribió:
> > On 20 Sep 2016, at 15:46 PM, Frediano Ziglio
> > wrote:
> >
> >
> > > On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote:
> > > > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio <
> > > > fzig...@redhat.com>
> > > >
Hi,
El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió:
> Hi Fabio,
>
> I still suspect that the performance issue is caused by the mouse. As
> you can see in flexVDI's repository (
> https://github.com/flexVDI/qxl-dod/blob/master/qxldod/QxlDod.h) the
> function "EnablePointer" always r
to send down HIDE command on each
> SetPointerPosition?
> I'd like to check it - may be we can filter it better on
> SetPointerShape?
>
>
> On Fri, Nov 18, 2016 at 7:07 PM, Frediano Ziglio
> wrote:
> > From: Javier Celaya
> >
> > This avoid havi
El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió:
> From: Javier Celaya
>
> This avoid having possibly 2 pointers (client and server) if Windows
> decide to render the mouse by itself.
> This happens for instance moving windows.
There are a couple typos here. I wou
El lun, 21-11-2016 a las 16:00 +0100, Javier Celaya escribió:
> El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió:
> > From: Javier Celaya
> >
> > This avoid having possibly 2 pointers (client and server) if
> > Windows
> > decide to render the mous
Hello Yuri
El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió:
> I'm porting to [qxl-wddm-dod] set of flexvdi changes
> related to execution of 'present display only' events
> in separate thread. There are 2 questions below I'd like to ask and
> know your opinion.
>
> I see there 2 as
you get
no performance improvement over using just one thread.
> > Thanks,
> Yuri
>
> On Fri, Nov 25, 2016 at 11:11 AM, Javier Celaya >
> > wrote:
> > Hello Yuri
> > > > El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió:
> > >
Hi, sorry for the late response, I was on holidays
El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió:
> On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya com> wrote:The main channel reference d->main of SpiceWidget is
> initialized onconstruction. However, it is used a cou
Hi guys, sorry I missed your answers
El jue, 19-07-2018 a las 18:48 +0300, Uri Lublin escribió:
> On 07/17/2018 04:05 PM, Javier Celaya wrote:
> Hello list
> I have a special scenario where I cannot get the VDAgent to run
> correctly. We are migrating a physical setup to virtual,
priv->device =
> NULL; g_boxed_free(spice_usb_device_get_type(), priv-
> spice_device); priv->spice_device = NULL; priv-
> >state = STATE_DISCONNECTED;
> Frediano___Spice-devel
>
Hi,
El mar, 21-08-2018 a las 09:47 -0400, Frediano Ziglio escribió:
>
> Hi,
> On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote:
> Yes, not against merging the fix. But if we can get it fixedinGlib,
> it is matter to help other projects that port codetowindows to be
Ping
El lun, 13-08-2018 a las 13:44 +0200, Javier Celaya escribió:
> Hi, sorry for the late response, I was on holidays
>
> El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió:
> > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya > i.com> wrote:The main channel
Hi
El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió:
> Hi,
> On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote:
> Hi, sorry for the late response, I was on holidaysEl mar, 24-07-2018
> a las 17:58 +0200, Marc-André Lureau escribió:
> On Mon, Jul 16, 2018 at
Hi again
El lun, 24-09-2018 a las 08:25 +0200, Javier Celaya escribió:
> Hi
>
> El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió:
> > Hi,
> > On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote:
> > Hi, sorry for the late response, I was on holida
hannel is created
with QEMU and/or libvirt?
Thanks
--
Javier Celaya Alastrué
Chief Technology Officer
javier.cel...@flexvdi.com
+34696969959
j
here, but I
could share the code with you if you are interested.
Best regards
> Cheers,Victor
> _______Spice-devel mailing
> listspice-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
.com/flexVDI/vd-agent-linuxhttps://github.com/flexVDI/vd-agent-win32They
are somewhat outdated, though.
Best regards
> Thanks
> Michal
--
Javier Celaya Alastrué
Chief Technology Officer
work. However,
we are not sure where the problem is. Spice server? Xorg? Qemu?
Do you have any comments on this?
Thanks in advance.
--
Javier Celaya
Chief Technology Of
em with the guest,
> either the agent or the kernel qxl driver.
That's what I think, too. And since the message is not received by the
guest agent, I would say it is the qxl driver, either in the kernel or
in Xorg. I'll try to see if there is something in there.
> Thank
ived by
> the guest agent, I would say it is the qxl driver, either in the
> kernel or in Xorg. I'll try to see if there is something in there.
>
>
> Thanks in advance.Frediano
>
--
Javier Celaya
Chie
Hi Christophe
El lun, 23-10-2017 a las 14:29 +0200, Christophe Fergeau escribió:
> Hey,
>
> On Mon, Oct 23, 2017 at 09:51:51AM +0200, Javier Celaya wrote:
> > Hello list,
> >
> > Recently, we updated the Qemu version being used by flexVDI. We
> > were
> >
Hello
My name is Javier Celaya and I work for Flexible Solutions [1]. We develop a
virtualization product that includes a VDI module with Spice. As part of this
module, we have included support for the LZ4 compression algorithm [2], and we
would like to contribute it to the main project.
The
Hello
El Miércoles, 5 de noviembre de 2014 08:58:25 Marc-André Lureau escribió:
> Hi
>
> - Original Message -
>
> > Hello
> >
> > My name is Javier Celaya and I work for Flexible Solutions [1]. We develop
> > a virtualization product that inclu
Hello
El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió:
> On Thu, Nov 06, 2014 at 10:33:19AM +0100, Javi wrote:
> > diff --git a/configure.ac b/configure.ac
> > index f47ee20..d295c5b 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -694,6 +694,24 @@ if test "x$ena
Hello
I resend the patch for the spice repository. I just realized I forgot to
remove a debug message from red_worker.c, sorry.
El Jueves, 6 de noviembre de 2014 18:21:21 Javier Celaya escribió:
> Hello
>
> El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió:
> &
13 de noviembre de 2014 16:04:00 Christophe Fergeau escribió:
> Hey,
>
> On Fri, Nov 07, 2014 at 10:17:11AM +0100, Javier Celaya wrote:
> > Hello
> >
> > I resend the patch for the spice repository. I just realized I forgot to
> > remove a debug message from red_worker
El Miércoles, 3 de diciembre de 2014 10:41:42 Christophe Fergeau escribió:
> On Thu, Nov 13, 2014 at 05:11:52PM +0100, Javier Celaya wrote:
> > However, don't forget that, since spice-protocol is a submodule of spice-
> > common, once you push the commit for spice-protocol,
t;
> >> I just made a small change to enable lz4, but the image turns out to be
> >> broken (see the screenshots). And I observed that it goes wrong only for
> >> the SpiceBitmap w/o SPICE_BITMAP_FLAGS_TOP_DOWN flag in the
> >> red_compress_image() functio
Hello
Recently, SPICE included the lz4 compression algorithm. This patch adds
a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not
exist before the commit that added this compression algorithm, so it should be
guarded with conditional compilation. How do you think this s
Sure, for the help text of the image-compression option, thanks.
El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió:
> Il 08/01/2015 11:50, Javier Celaya ha scritto:
> > Hello
> >
> > Recently, SPICE included the lz4 compression algorithm. This patch adds
> &g
Hello,
In a moment, I will send the patches that fix these problems.
El Viernes, 9 de enero de 2015 11:16:15 Fabio Fantoni escribió:
> In details:
> I tried windows 7 vm with qxl and qxl driver installed from spice guest
> tools 0.74, working good without setting lz4 compression.
> Using lz4 befor
El Lunes, 12 de enero de 2015 17:35:27 Javier Celaya escribió:
> In a moment, I will send the patches that fix these problems.
These are the patches. One patch is for spice-server, the other two are for
spice-common. Can someone review and apply them, please?
Thanks in advance&g
El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió:
> I tested them and I not found crash or regression for now.
> Seems have solved the 2 crash cases I reported, thanks.
> Should be good resend them directly to mailing list instead as attachments
> for review and add them upstream.
This patch limits the LZ4 algorithm to RGB formats. Other formats are
compressed with LZ. It also sends the top_down flag and the original
format to the client, so that it can create the right kind of pixman
surface.
---
server/lz4_encoder.c | 21 +++--
server/lz4_encoder.h | 7 ++
These two patches fix two problems that crashed the Spice client when
using the LZ4 algorithm. Note that the second patch also expects the
server to send the original image format, so it must be used with the
corresponding patch in the server.
Javier Celaya (2):
Fix LZ4 output buffer size
---
common/canvas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index ddcbe32..bb7a424 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -550,7 +550,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *
- Read the original image format from the LZ4 stream. Only RGB formats
are supported.
- Expand 24bit to 32bit image format.
---
common/canvas_base.c | 48 +++-
1 file changed, 43 insertions(+), 5 deletions(-)
diff --git a/common/canvas_base.c b/common
El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió:
> Should be good resend them directly to mailing list instead as attachments
> for review and add them upstream.
It looks like the list is rejecting what I send with git send-email... I'll
keep trying.
Hello
El Miércoles, 21 de enero de 2015 17:05:00 Christophe Fergeau escribió:
> Hey,
>
> Sorry for the late review...
>
> On Thu, Jan 15, 2015 at 12:50:21PM +0100, Javier Celaya wrote:
> > This patch limits the LZ4 algorithm to RGB formats. Other formats are
> >
Hello,
El Miércoles, 21 de enero de 2015 17:27:01 Christophe Fergeau escribió:
> Hey,
>
> On Thu, Jan 15, 2015 at 12:50:45PM +0100, Javier Celaya wrote:
> > - Read the original image format from the LZ4 stream. Only RGB formats
> >
> > are supported.
> >
. Pixman supports both formats, but expects every row of the image
to be aligned on a 32bit boundary.
Javier Celaya (6):
LZ4: Fix output buffer size
LZ4: Implement ntohl to remove dependency on arpa/inet.h
LZ4: Correctly read the top_down flag
LZ4: Decode the image format from the stream
---
common/canvas_base.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index cfbba5e..0f6b7f4 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -27,7 +27,6 @@
#include
#ifdef USE_LZ4
-#include
#
This v2 patch set is splitted into smaller patches. Also, I implemented htonl to
remove the include of arpa/inet.h.
Javier Celaya (5):
LZ4: Limit LZ4 to RGB formats
LZ4: Fix encoder output size
LZ4: Do not reverse bottom-up images
LZ4: Implement htonl to remove dependency on arpa/inte.h
---
common/canvas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index a1bfc27..cfbba5e 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -551,7 +551,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *
---
server/lz4_encoder.c | 13 ++---
server/lz4_encoder.h | 7 +++
server/red_worker.c | 18 +-
3 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index aa03721..2327e9a 100644
--- a/server/lz4_encoder.c
+++ b/
---
server/lz4_encoder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index 531ab4b..aa03721 100644
--- a/server/lz4_encoder.c
+++ b/server/lz4_encoder.c
@@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int st
---
server/lz4_encoder.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index 2327e9a..4f0f3c8 100644
--- a/server/lz4_encoder.c
+++ b/server/lz4_encoder.c
@@ -22,7 +22,6 @@
#define SPICE_LOG_DOMAIN "SpiceLz4Encoder
---
server/red_worker.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index a18987a..8f07ee9 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient
*dcc,
---
server/lz4_encoder.c | 9 +
server/lz4_encoder.h | 2 +-
server/red_worker.c | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index 4f0f3c8..f1db69f 100644
--- a/server/lz4_encoder.c
+++ b/server/lz4_encoder.c
@@ -59,7
---
common/canvas_base.c | 4
common/canvas_utils.c | 10 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 170def1..107d056 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -584,6 +584,10 @@ static pix
---
common/canvas_base.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index ec83123..c45d535 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -568,6 +568,8 @@ static pixman_image_t *canvas_get_lz
---
common/canvas_base.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 0f6b7f4..ec83123 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -566,7 +566,7 @@ static pixman_image_t *canvas_get_lz4(CanvasBase
---
common/canvas_base.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index c45d535..170def1 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -563,8 +563,7 @@ static pixman_image_t *canvas_
Warn the user if he tries to set lz4 but it is not supported. Then, fallback to
auto-glz.
---
server/reds.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index e34433b..816c4c9 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3501,6 +3501,12 @@ SPICE_G
so that you can have a working version check now.
>
> Given that lz4 support is optional, spice_server_set_image_compression
> should probably error out if we try to set lz4 but it's not supported.
Ack
>
> Christophe
>From 896a3ea776ee95653a7cb8a0c90111a89b57c73f Mon Sep 1
---
server/reds.c | 8
1 file changed, 8 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index e34433b..2bdc557 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3501,6 +3501,14 @@ SPICE_GNUC_VISIBLE int
spice_server_set_image_compression(SpiceServer *s,
ot going to be built using MSVC, I don't think it's a huge
> problem using ntohl. If you really don't want to use it, I'd favour
> adding a dependency on glib, and using GUINT32_FROM_LE.
>
> Christophe
>
> On Thu, Jan 22, 2015 at 05:21:20PM +0100, Javier Celay
Sorry, I forgot to patch the command-line help. Hope it helps.
El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió:
> On 01/23/2015 07:06 AM, Javier Celaya wrote:
> > Hello, this is the patch with the version check. Christophe, can you check
> > that the version is
Hello,
El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió:
> Hey,
>
> On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote:
> > ---
> >
> > common/canvas_base.c | 25 +++--
> > 1 file changed, 23 insertions(+), 2 d
ss a r8g8b8 there except for the lz4 code, so ACK
> with the last hunk removed (whitespace change in alloc_lz_surface).
>
> Christophe
>
> On Thu, Jan 22, 2015 at 05:21:24PM +0100, Javier Celaya wrote:
> > ---
> >
> > common/canvas_base.c | 4
> > common
El Lunes, 26 de enero de 2015 16:52:42 Christophe Fergeau escribió:
> On Mon, Jan 26, 2015 at 03:20:23PM +0100, Javier Celaya wrote:
> > Hello,
> >
> > El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió:
> > > Hey,
> > >
> > >
El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió:
> On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote:
> > On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote:
> > > I saw some comments about MSVC in spice-gtk, and I thought some
---
server/lz4_encoder.c | 13 ++---
server/lz4_encoder.h | 7 +++
server/red_worker.c | 18 +-
3 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index aa03721..2327e9a 100644
--- a/server/lz4_encoder.c
+++ b/
---
server/red_worker.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index a18987a..8f07ee9 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient
*dcc,
---
server/lz4_encoder.c | 9 +
server/lz4_encoder.h | 2 +-
server/red_worker.c | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index 2327e9a..b3e38b2 100644
--- a/server/lz4_encoder.c
+++ b/server/lz4_encoder.c
@@ -50,7
Same as v2, but stick with htonl
Javier Celaya (4):
LZ4: Limit LZ4 to RGB formats
LZ4: Fix encoder output size
LZ4: Do not reverse bottom-up images
LZ4: Send the original format with the compressed data
server/lz4_encoder.c | 21 +++--
server/lz4_encoder.h | 7
---
server/lz4_encoder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index 531ab4b..aa03721 100644
--- a/server/lz4_encoder.c
+++ b/server/lz4_encoder.c
@@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int st
Currently, the LZ4 encoding only (partially) supports RGB images, so
we must check the image format before using it. In the future, indexed
formats may be implemented too, but their use is usually very small
compared to RGB.
---
server/red_worker.c | 2 ++
1 file changed, 2 insertions(+)
diff --g
Reversing the bottom-up images in the server is not needed since Pixman,
in the client, is able to deal with them. As a result, the previous code
was more complex and wrong. This commit fixes and cleans it.
---
server/lz4_encoder.c | 13 ++---
server/lz4_encoder.h | 7 +++
server/red_
El Lunes, 26 de enero de 2015 17:00:04 Javier Celaya escribió:
> El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió:
> > On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote:
> > > On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote:
Adjust the way the top_down flag is read to the corresponding change in
the wire protocol.
---
common/canvas_base.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index cfbba5e..0dd438a 100644
--- a/common/canvas_base.c
+++ b
Mostly the same as v2, but I stick to using ntohl, and improved log comments.
Also, the row alignment is done with memmove, as suggested by Christophe.
Javier Celaya (6):
LZ4: Fix output buffer size
LZ4: Adjust reading the top_down flag
LZ4: Decode the image format from the stream
LZ4
1 - 100 of 156 matches
Mail list logo