[Spice-devel] [vd-agent-win32 1/2] Detect and use the new WDDM driver

2016-02-04 Thread Javier Celaya
When setting a new desktop resolution, detect whether the XDDM or the WDDM driver is loaded, and use the correct API. This patch is based on the one by Vadim Rozenfeld, with some improvements: - Valid for both the XDDM and the WDDM drivers. - Avoids flickering when the target resolution is the cur

[Spice-devel] [vd-agent-win32 2/2] Use CCD API to update the WDDM display modes.

2016-02-04 Thread Javier Celaya
When a new custom display mode is added, the current WDDM driver notifies a disconnection and reconnection of the virtual monitor to force Windows to update the display modes. This produces an ugly effect, keeping the screen black for up to some seconds and usually not repainting it afterwards. Th

[Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-04 Thread Javier Celaya
ove support of hardware pointers. The source can be found in https://github.com/flexvdi/qxl-dod, and precompiled and signed binaries can be downloaded from http://depot.flexvdi.com/guest-tools/. Javier Celaya (2): Detect and use the new WDDM driver Use CCD API to update the WDDM display mo

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-04 Thread Javier Celaya
Hi El 04/02/16 a las 15:12, Fabio Fantoni escribió: Il 04/02/2016 13:31, Javier Celaya ha scritto: This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: - It detects both the X

Re: [Spice-devel] [vd-agent-win32 2/2] Use CCD API to update the WDDM display modes.

2016-02-10 Thread Javier Celaya
+update_display_modes(); +} else { vd_printf("escape failed with error 0x%08X", status); } } -- <http://flexvdi.com><http://flexvdi.com> Javier Celaya Software Engineer j <mailto:javier.cel..

[Spice-devel] [vd-agent-win32 v2 1/2] Detect and use the new WDDM driver

2016-02-12 Thread Javier Celaya
When setting a new desktop resolution, detect whether the XDDM or the WDDM driver is loaded, and use the correct API. This patch is based on the one by Vadim Rozenfeld, with some improvements: - Valid for both the XDDM and the WDDM drivers. - Avoids flickering when the target resolution is the cur

[Spice-devel] [vd-agent-win32 v2 2/2] Use CCD API to update the WDDM display modes.

2016-02-12 Thread Javier Celaya
When a new custom display mode is added, the current WDDM driver notifies a disconnection and reconnection of the virtual monitor to force Windows to update the display modes. This produces an ugly effect, keeping the screen black for up to some seconds and usually not repainting it afterwards. Th

[Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

2016-02-12 Thread Javier Celaya
m.h, since they are actually not common to both the vdagent and the vdservice. The code for those classes is in vdagent/wddm.cpp. - Some improvements as suggested by Frediano Ziglio. Javier Celaya (2): Detect and use the new WDDM driver Use CCD API to update the WDDM display modes. Makefile

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

2016-02-12 Thread Javier Celaya
Hi El 12/02/16 a las 12:56, Fabio Fantoni escribió: Il 10/02/2016 15:34, Fabio Fantoni ha scritto: Il 04/02/2016 17:01, Javier Celaya ha scritto: El 04/02/16 a las 16:59, Javier Celaya escribió: Hi El 04/02/16 a las 15:12, Fabio Fantoni escribió: Il 04/02/2016 13:31, Javier Celaya ha

Re: [Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

2016-02-15 Thread Javier Celaya
El 15/02/16 a las 16:38, Victor Toso escribió: Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote: This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: -

Re: [Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

2016-02-23 Thread Javier Celaya
Hi El 16/02/16 a las 15:23, Victor Toso escribió: Hi Javier, On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote: El 15/02/16 a las 17:01, Javier Celaya escribió: El 15/02/16 a las 16:38, Victor Toso escribió: Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote

Re: [Spice-devel] SPICE WDDM driver Windows 10

2016-03-19 Thread Javier Celaya
performance, ...) You are welcome ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel -- <http://flexvdi.com><http://flexvdi.com> Javier Celaya Softw

[Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

2016-04-13 Thread Javier Celaya
With scaling enabled, the size request of the widget must be 640x480 (the same as with resize_guest_enable) so that the widget can be actually scalled down. --- src/spice-widget.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/spice-widget.c b/s

Re: [Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

2016-04-21 Thread Javier Celaya
Can someone review this patch, please? Thank you El 13/04/16 a las 13:42, Javier Celaya escribió: With scaling enabled, the size request of the widget must be 640x480 (the same as with resize_guest_enable) so that the widget can be actually scalled down. --- src/spice-widget.c | 25

Re: [Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

2016-04-22 Thread Javier Celaya
nimum size of the current guest resolution. The window can be made bigger, but never smaller. About the patch - you should declare the update_size_request() function instead of moving scaling_updated() down - it would be more clear what has changed. Thanks, Pavel On Fri, 2016-04-22 at 08:06 +0200,

[Spice-devel] [spice-gtk v2] Spice-widget: Allow smaller widget with scaling enabled

2016-04-22 Thread Javier Celaya
When resize-guest-to-match-window-size is disabled, the size request (minimum size) of the spice widget is set to the current guest resolution. The client window cannot be made smaller, even with scale-display enabled. This patch sets a size request of 640x480 when either resize-guest-to-match-win

[Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

2019-05-03 Thread Javier Celaya
A phodav server created with a NULL shared dir is valid and results in an error answer to all requests of the webdav channel, instead of silently ignoring them. This is better than just returning NULL from spice_session_get_webdav_server because: a) it crashes channel_webdav.c:start_client. b) eve

Re: [Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

2019-05-06 Thread Javier Celaya
Hi El lun, 06-05-2019 a las 10:37 +, Victor Toso escribió: > Hi, > On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote: > > A phodav server created with a NULL shared dir is valid andresults > > in an error answer to all requests of the webdav channel,instead of >

Re: [Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

2019-05-08 Thread Javier Celaya
Hi, El mié, 08-05-2019 a las 06:47 +, Victor Toso escribió: > Hi, > On Mon, May 06, 2019 at 04:06:45PM +0200, Javier Celaya wrote: > > HiEl lun, 06-05-2019 a las 10:37 +, Victor Toso escribió: > > > Hi,On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote: &g

Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

2018-01-17 Thread Javier Celaya
I'd lean towards doing "clipboard sharing for focused client" + > > "command-line/runtime option, with clipboard sharing enabled by > > default". > > I'd rather stick with a simple command-line & runtime option. > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org >

[Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch

2018-01-26 Thread Javier Celaya
The "max-bytes" property of the appsrc GStreamer element expects a 64-bit value. Calling: g_object_set(source, "max-bytes", 0, NULL); in a 32-bit architecture ends up with a wrong value, it must be cast to a long long int: g_object_set(source, "max-bytes", 0LL, NULL); --- src/channel-display-gst.c

Re: [Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch

2018-01-30 Thread Javier Celaya
> - "max-bytes", 0, > > > + "max-bytes", 0LL, > > > "block", TRUE, > > > NULL); > > > gst_caps_unref(caps); > > > > I would use a gint64 ca

[Spice-devel] [PATCH spice-gtk v2] Fix setting appsrc properties in i686 arch

2018-01-30 Thread Javier Celaya
The "max-bytes" property of the appsrc GStreamer element expects a 64-bit value. Calling: g_object_set(source, "max-bytes", 0, NULL); in a 32-bit architecture ends up with a wrong value, it must be cast to a gint64: g_object_set(source, "max-bytes", G_GINT64_CONSTANT(0), NULL); --- src/channel-dis

[Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-07-16 Thread Javier Celaya
The main channel reference d->main of SpiceWidget is initialized on construction. However, it is used a couple of times before that moment while setting the default values of some properties, like resize-guest. This results in some annoying critical log messages. This commit makes sure that d->main

[Spice-devel] VDAgent and XDMCP

2018-07-17 Thread Javier Celaya
executed in the Ubuntu guest too? If so, how? Thanks for your help -- Javier Celaya Alastrué Chief Technology Officer javier.cel...@flexvdi.com

Re: [Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

2016-08-03 Thread Javier Celaya
Hi, El mié, 03-08-2016 a las 04:57 -0400, Frediano Ziglio escribió: > > > > On Wed, Aug 03, 2016 at 11:35:56AM +0300, Sameeh Jubran wrote: > > > Hi, > > > > > > We've already looked into those patches (Javier's patches) and > > > tested them. > > > > Ah ok, I must have missed your answer to Jav

Re: [Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

2016-08-03 Thread Javier Celaya
Hi, El mié, 03-08-2016 a las 16:36 +0300, Dmitry Fleytman escribió: > > From: Javier Celaya > > Date: Wed, Aug 3, 2016 at 12:17 PM > > Subject: Re: [Spice-devel] [PATCH win-vdagent] Provide support for > > Windows CCD API > > To: spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 03/10] Use MmMapIoSpaceEx instead of MmMapIoSpace

2016-09-20 Thread Javier Celaya
Hi, El mar, 20-09-2016 a las 12:27 +0200, Christophe Fergeau escribió: > On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote: > > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio < > > fzig...@redhat.com> > > wrote: > > > It looks like MmMapIoSpaceEx was introduced with Windows 10 while

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 03/10] Use MmMapIoSpaceEx instead of MmMapIoSpace

2016-09-20 Thread Javier Celaya
El mar, 20-09-2016 a las 15:56 +0300, Dmitry Fleytman escribió: > > On 20 Sep 2016, at 15:46 PM, Frediano Ziglio > > wrote: > > > > > > > On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote: > > > > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio < > > > > fzig...@redhat.com> > > > >

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

2016-10-31 Thread Javier Celaya
Hi, El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió: > Hi Fabio, > > I still suspect that the performance issue is caused by the mouse. As > you can see in flexVDI's repository ( > https://github.com/flexVDI/qxl-dod/blob/master/qxldod/QxlDod.h) the > function "EnablePointer" always r

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

2016-11-20 Thread Javier Celaya
to send down HIDE command on each > SetPointerPosition? > I'd like to check it - may be we can filter it better on > SetPointerShape? > > > On Fri, Nov 18, 2016 at 7:07 PM, Frediano Ziglio > wrote: > > From: Javier Celaya > > > > This avoid havi

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

2016-11-21 Thread Javier Celaya
El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió: > From: Javier Celaya > > This avoid having possibly 2 pointers (client and server) if Windows > decide to render the mouse by itself. > This happens for instance moving windows. There are a couple typos here. I wou

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

2016-11-21 Thread Javier Celaya
El lun, 21-11-2016 a las 16:00 +0100, Javier Celaya escribió: > El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió: > > From: Javier Celaya > > > > This avoid having possibly 2 pointers (client and server) if > > Windows > > decide to render the mous

Re: [Spice-devel] Processing of rendering operations in separate thread

2016-11-25 Thread Javier Celaya
Hello Yuri El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió: > I'm porting to [qxl-wddm-dod] set of flexvdi changes > related to execution of 'present display only' events > in separate thread. There are 2 questions below I'd like to ask and > know your opinion. > > I see there 2 as

Re: [Spice-devel] Processing of rendering operations in separate thread

2016-11-30 Thread Javier Celaya
you get no performance improvement over using just one thread. > > Thanks, > Yuri > > On Fri, Nov 25, 2016 at 11:11 AM, Javier Celaya > > > wrote: > > Hello Yuri > > > > El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió: > > >

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-08-13 Thread Javier Celaya
Hi, sorry for the late response, I was on holidays El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya com> wrote:The main channel reference d->main of SpiceWidget is > initialized onconstruction. However, it is used a cou

Re: [Spice-devel] VDAgent and XDMCP

2018-08-16 Thread Javier Celaya
Hi guys, sorry I missed your answers El jue, 19-07-2018 a las 18:48 +0300, Uri Lublin escribió: > On 07/17/2018 04:05 PM, Javier Celaya wrote: > Hello list > I have a special scenario where I cannot get the VDAgent to run > correctly. We are migrating a physical setup to virtual,

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Javier Celaya
priv->device = > NULL; g_boxed_free(spice_usb_device_get_type(), priv- > spice_device); priv->spice_device = NULL; priv- > >state = STATE_DISCONNECTED; > Frediano___Spice-devel >

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-22 Thread Javier Celaya
Hi, El mar, 21-08-2018 a las 09:47 -0400, Frediano Ziglio escribió: > > Hi, > On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > Yes, not against merging the fix. But if we can get it fixedinGlib, > it is matter to help other projects that port codetowindows to be

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-08-22 Thread Javier Celaya
Ping El lun, 13-08-2018 a las 13:44 +0200, Javier Celaya escribió: > Hi, sorry for the late response, I was on holidays > > El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya > i.com> wrote:The main channel

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-09-23 Thread Javier Celaya
Hi El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió: > Hi, > On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote: > Hi, sorry for the late response, I was on holidaysEl mar, 24-07-2018 > a las 17:58 +0200, Marc-André Lureau escribió: > On Mon, Jul 16, 2018 at

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-09-23 Thread Javier Celaya
Hi again El lun, 24-09-2018 a las 08:25 +0200, Javier Celaya escribió: > Hi > > El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió: > > Hi, > > On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote: > > Hi, sorry for the late response, I was on holida

Re: [Spice-devel] [PATCH spice-gtk v3] glib: add SpiceQmpPort helper

2018-09-27 Thread Javier Celaya
hannel is created with QEMU and/or libvirt? Thanks -- Javier Celaya Alastrué Chief Technology Officer javier.cel...@flexvdi.com +34696969959 j

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-14 Thread Javier Celaya
here, but I could share the code with you if you are interested. Best regards > Cheers,Victor > _______Spice-devel mailing > listspice-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel --

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-22 Thread Javier Celaya
.com/flexVDI/vd-agent-linuxhttps://github.com/flexVDI/vd-agent-win32They are somewhat outdated, though. Best regards > Thanks > Michal -- Javier Celaya Alastrué Chief Technology Officer

[Spice-devel] Fedora 25 guest no changing resolution correctly

2017-10-23 Thread Javier Celaya
work. However, we are not sure where the problem is. Spice server? Xorg? Qemu? Do you have any comments on this? Thanks in advance. --                               Javier Celaya          Chief Technology Of

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

2017-10-23 Thread Javier Celaya
em with the guest, > either the agent or the kernel qxl driver. That's what I think, too. And since the message is not received by the guest agent, I would say it is the qxl driver, either in the kernel or in Xorg. I'll try to see if there is something in there. > Thank

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

2017-10-23 Thread Javier Celaya
ived by > the guest agent, I would say it is the qxl driver, either in the > kernel or in Xorg. I'll try to see if there is something in there. > > > Thanks in advance.Frediano > --                           Javier Celaya          Chie

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

2017-10-23 Thread Javier Celaya
Hi Christophe El lun, 23-10-2017 a las 14:29 +0200, Christophe Fergeau escribió: > Hey, > > On Mon, Oct 23, 2017 at 09:51:51AM +0200, Javier Celaya wrote: > > Hello list, > > > > Recently, we updated the Qemu version being used by flexVDI. We > > were > >

[Spice-devel] Patch to support LZ4 compression algorithm

2014-11-05 Thread Javier Celaya
Hello My name is Javier Celaya and I work for Flexible Solutions [1]. We develop a virtualization product that includes a VDI module with Spice. As part of this module, we have included support for the LZ4 compression algorithm [2], and we would like to contribute it to the main project. The

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-05 Thread Javier Celaya
Hello El Miércoles, 5 de noviembre de 2014 08:58:25 Marc-André Lureau escribió: > Hi > > - Original Message - > > > Hello > > > > My name is Javier Celaya and I work for Flexible Solutions [1]. We develop > > a virtualization product that inclu

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-06 Thread Javier Celaya
Hello El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió: > On Thu, Nov 06, 2014 at 10:33:19AM +0100, Javi wrote: > > diff --git a/configure.ac b/configure.ac > > index f47ee20..d295c5b 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -694,6 +694,24 @@ if test "x$ena

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-07 Thread Javier Celaya
Hello I resend the patch for the spice repository. I just realized I forgot to remove a debug message from red_worker.c, sorry. El Jueves, 6 de noviembre de 2014 18:21:21 Javier Celaya escribió: > Hello > > El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió: > &

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-13 Thread Javier Celaya
13 de noviembre de 2014 16:04:00 Christophe Fergeau escribió: > Hey, > > On Fri, Nov 07, 2014 at 10:17:11AM +0100, Javier Celaya wrote: > > Hello > > > > I resend the patch for the spice repository. I just realized I forgot to > > remove a debug message from red_worker

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-12-03 Thread Javier Celaya
El Miércoles, 3 de diciembre de 2014 10:41:42 Christophe Fergeau escribió: > On Thu, Nov 13, 2014 at 05:11:52PM +0100, Javier Celaya wrote: > > However, don't forget that, since spice-protocol is a submodule of spice- > > common, once you push the commit for spice-protocol,

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-07 Thread Javier Celaya
t; > >> I just made a small change to enable lz4, but the image turns out to be > >> broken (see the screenshots). And I observed that it goes wrong only for > >> the SpiceBitmap w/o SPICE_BITMAP_FLAGS_TOP_DOWN flag in the > >> red_compress_image() functio

[Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be guarded with conditional compilation. How do you think this s

Re: [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Sure, for the help text of the image-compression option, thanks. El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió: > Il 08/01/2015 11:50, Javier Celaya ha scritto: > > Hello > > > > Recently, SPICE included the lz4 compression algorithm. This patch adds > &g

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-12 Thread Javier Celaya
Hello, In a moment, I will send the patches that fix these problems. El Viernes, 9 de enero de 2015 11:16:15 Fabio Fantoni escribió: > In details: > I tried windows 7 vm with qxl and qxl driver installed from spice guest > tools 0.74, working good without setting lz4 compression. > Using lz4 befor

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-12 Thread Javier Celaya
El Lunes, 12 de enero de 2015 17:35:27 Javier Celaya escribió: > In a moment, I will send the patches that fix these problems. These are the patches. One patch is for spice-server, the other two are for spice-common. Can someone review and apply them, please? Thanks in advance&g

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-14 Thread Javier Celaya
El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió: > I tested them and I not found crash or regression for now. > Seems have solved the 2 crash cases I reported, thanks. > Should be good resend them directly to mailing list instead as attachments > for review and add them upstream.

[Spice-devel] [PATCH] Fix LZ4 supported image formats.

2015-01-15 Thread Javier Celaya
This patch limits the LZ4 algorithm to RGB formats. Other formats are compressed with LZ. It also sends the top_down flag and the original format to the client, so that it can create the right kind of pixman surface. --- server/lz4_encoder.c | 21 +++-- server/lz4_encoder.h | 7 ++

[Spice-devel] [PATCH 0/2] Fix two bugs in LZ4 decompression algorithm

2015-01-15 Thread Javier Celaya
These two patches fix two problems that crashed the Spice client when using the LZ4 algorithm. Note that the second patch also expects the server to send the original image format, so it must be used with the corresponding patch in the server. Javier Celaya (2): Fix LZ4 output buffer size

[Spice-devel] [PATCH 1/2] Fix LZ4 output buffer size.

2015-01-15 Thread Javier Celaya
--- common/canvas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index ddcbe32..bb7a424 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -550,7 +550,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *

[Spice-devel] [PATCH 2/2] Fix LZ4 supported image formats.

2015-01-15 Thread Javier Celaya
- Read the original image format from the LZ4 stream. Only RGB formats are supported. - Expand 24bit to 32bit image format. --- common/canvas_base.c | 48 +++- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/common/canvas_base.c b/common

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-15 Thread Javier Celaya
El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió: > Should be good resend them directly to mailing list instead as attachments > for review and add them upstream. It looks like the list is rejecting what I send with git send-email... I'll keep trying.

Re: [Spice-devel] [PATCH] Fix LZ4 supported image formats.

2015-01-22 Thread Javier Celaya
Hello El Miércoles, 21 de enero de 2015 17:05:00 Christophe Fergeau escribió: > Hey, > > Sorry for the late review... > > On Thu, Jan 15, 2015 at 12:50:21PM +0100, Javier Celaya wrote: > > This patch limits the LZ4 algorithm to RGB formats. Other formats are > >

Re: [Spice-devel] [PATCH 2/2] Fix LZ4 supported image formats.

2015-01-22 Thread Javier Celaya
Hello, El Miércoles, 21 de enero de 2015 17:27:01 Christophe Fergeau escribió: > Hey, > > On Thu, Jan 15, 2015 at 12:50:45PM +0100, Javier Celaya wrote: > > - Read the original image format from the LZ4 stream. Only RGB formats > > > > are supported. > >

[Spice-devel] [spice-common PATCHv2 0/6] LZ4: Fix bugs in LZ4 decompression algorithm

2015-01-22 Thread Javier Celaya
. Pixman supports both formats, but expects every row of the image to be aligned on a 32bit boundary. Javier Celaya (6): LZ4: Fix output buffer size LZ4: Implement ntohl to remove dependency on arpa/inet.h LZ4: Correctly read the top_down flag LZ4: Decode the image format from the stream

[Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index cfbba5e..0f6b7f4 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -27,7 +27,6 @@ #include #ifdef USE_LZ4 -#include #

[Spice-devel] [spice-server PATCHv2 0/5] LZ4: Fix supported image formats

2015-01-22 Thread Javier Celaya
This v2 patch set is splitted into smaller patches. Also, I implemented htonl to remove the include of arpa/inet.h. Javier Celaya (5): LZ4: Limit LZ4 to RGB formats LZ4: Fix encoder output size LZ4: Do not reverse bottom-up images LZ4: Implement htonl to remove dependency on arpa/inte.h

[Spice-devel] [PATCH 1/6] LZ4: Fix output buffer size

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index a1bfc27..cfbba5e 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -551,7 +551,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *

[Spice-devel] [PATCH 3/5] LZ4: Do not reverse bottom-up images

2015-01-22 Thread Javier Celaya
--- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++ server/red_worker.c | 18 +- 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index aa03721..2327e9a 100644 --- a/server/lz4_encoder.c +++ b/

[Spice-devel] [PATCH 2/5] LZ4: Fix encoder output size

2015-01-22 Thread Javier Celaya
--- server/lz4_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 531ab4b..aa03721 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int st

[Spice-devel] [PATCH 4/5] LZ4: Implement htonl to remove dependency on arpa/inte.h

2015-01-22 Thread Javier Celaya
--- server/lz4_encoder.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 2327e9a..4f0f3c8 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -22,7 +22,6 @@ #define SPICE_LOG_DOMAIN "SpiceLz4Encoder

[Spice-devel] [PATCH 1/5] LZ4: Limit LZ4 to RGB formats

2015-01-22 Thread Javier Celaya
--- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index a18987a..8f07ee9 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient *dcc,

[Spice-devel] [PATCH 5/5] LZ4: Send the original format with the compressed data

2015-01-22 Thread Javier Celaya
--- server/lz4_encoder.c | 9 + server/lz4_encoder.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 4f0f3c8..f1db69f 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -59,7

[Spice-devel] [PATCH 6/6] LZ4: Add support for 24bit pixman surfaces

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 4 common/canvas_utils.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 170def1..107d056 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -584,6 +584,10 @@ static pix

[Spice-devel] [PATCH 4/6] LZ4: Decode the image format from the stream

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index ec83123..c45d535 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -568,6 +568,8 @@ static pixman_image_t *canvas_get_lz

[Spice-devel] [PATCH 3/6] LZ4: Correctly read the top_down flag

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 0f6b7f4..ec83123 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -566,7 +566,7 @@ static pixman_image_t *canvas_get_lz4(CanvasBase

[Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

2015-01-22 Thread Javier Celaya
--- common/canvas_base.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index c45d535..170def1 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -563,8 +563,7 @@ static pixman_image_t *canvas_

[Spice-devel] [PATCH] LZ4: warn if trying to set lz4 but not supported

2015-01-23 Thread Javier Celaya
Warn the user if he tries to set lz4 but it is not supported. Then, fallback to auto-glz. --- server/reds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/server/reds.c b/server/reds.c index e34433b..816c4c9 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3501,6 +3501,12 @@ SPICE_G

Re: [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Javier Celaya
so that you can have a working version check now. > > Given that lz4 support is optional, spice_server_set_image_compression > should probably error out if we try to set lz4 but it's not supported. Ack > > Christophe >From 896a3ea776ee95653a7cb8a0c90111a89b57c73f Mon Sep 1

[Spice-devel] [PATCHv2] LZ4: warn if trying to set lz4 but not supported

2015-01-26 Thread Javier Celaya
--- server/reds.c | 8 1 file changed, 8 insertions(+) diff --git a/server/reds.c b/server/reds.c index e34433b..2bdc557 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3501,6 +3501,14 @@ SPICE_GNUC_VISIBLE int spice_server_set_image_compression(SpiceServer *s,

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-26 Thread Javier Celaya
ot going to be built using MSVC, I don't think it's a huge > problem using ntohl. If you really don't want to use it, I'd favour > adding a dependency on glib, and using GUINT32_FROM_LE. > > Christophe > > On Thu, Jan 22, 2015 at 05:21:20PM +0100, Javier Celay

Re: [Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-26 Thread Javier Celaya
Sorry, I forgot to patch the command-line help. Hope it helps. El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió: > On 01/23/2015 07:06 AM, Javier Celaya wrote: > > Hello, this is the patch with the version check. Christophe, can you check > > that the version is

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

2015-01-26 Thread Javier Celaya
Hello, El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: > Hey, > > On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote: > > --- > > > > common/canvas_base.c | 25 +++-- > > 1 file changed, 23 insertions(+), 2 d

Re: [Spice-devel] [PATCH 6/6] LZ4: Add support for 24bit pixman surfaces

2015-01-26 Thread Javier Celaya
ss a r8g8b8 there except for the lz4 code, so ACK > with the last hunk removed (whitespace change in alloc_lz_surface). > > Christophe > > On Thu, Jan 22, 2015 at 05:21:24PM +0100, Javier Celaya wrote: > > --- > > > > common/canvas_base.c | 4 > > common

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

2015-01-26 Thread Javier Celaya
El Lunes, 26 de enero de 2015 16:52:42 Christophe Fergeau escribió: > On Mon, Jan 26, 2015 at 03:20:23PM +0100, Javier Celaya wrote: > > Hello, > > > > El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: > > > Hey, > > > > > >

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-26 Thread Javier Celaya
El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: > On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: > > On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: > > > I saw some comments about MSVC in spice-gtk, and I thought some

[Spice-devel] [PATCH 3/4] LZ4: Do not reverse bottom-up images

2015-01-26 Thread Javier Celaya
--- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++ server/red_worker.c | 18 +- 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index aa03721..2327e9a 100644 --- a/server/lz4_encoder.c +++ b/

[Spice-devel] [PATCH 1/4] LZ4: Limit LZ4 to RGB formats

2015-01-26 Thread Javier Celaya
--- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index a18987a..8f07ee9 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient *dcc,

[Spice-devel] [PATCH 4/4] LZ4: Send the original format with the compressed data

2015-01-26 Thread Javier Celaya
--- server/lz4_encoder.c | 9 + server/lz4_encoder.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 2327e9a..b3e38b2 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -50,7

[Spice-devel] [spice-server PATCHv3 0/4] LZ4: Fix supported image formats

2015-01-26 Thread Javier Celaya
Same as v2, but stick with htonl Javier Celaya (4): LZ4: Limit LZ4 to RGB formats LZ4: Fix encoder output size LZ4: Do not reverse bottom-up images LZ4: Send the original format with the compressed data server/lz4_encoder.c | 21 +++-- server/lz4_encoder.h | 7

[Spice-devel] [PATCH 2/4] LZ4: Fix encoder output size

2015-01-26 Thread Javier Celaya
--- server/lz4_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 531ab4b..aa03721 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int st

[Spice-devel] [PATCH 1/4] LZ4: Limit LZ4 to RGB formats

2015-01-26 Thread Javier Celaya
Currently, the LZ4 encoding only (partially) supports RGB images, so we must check the image format before using it. In the future, indexed formats may be implemented too, but their use is usually very small compared to RGB. --- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[Spice-devel] [PATCH 3/4] LZ4: Do not reverse bottom-up images

2015-01-26 Thread Javier Celaya
Reversing the bottom-up images in the server is not needed since Pixman, in the client, is able to deal with them. As a result, the previous code was more complex and wrong. This commit fixes and cleans it. --- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++ server/red_

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

2015-01-28 Thread Javier Celaya
El Lunes, 26 de enero de 2015 17:00:04 Javier Celaya escribió: > El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: > > On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: > > > On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote:

[Spice-devel] [PATCH 2/6] LZ4: Adjust reading the top_down flag

2015-01-28 Thread Javier Celaya
Adjust the way the top_down flag is read to the corresponding change in the wire protocol. --- common/canvas_base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index cfbba5e..0dd438a 100644 --- a/common/canvas_base.c +++ b

[Spice-devel] [spice-common PATCHv3 0/6] LZ4: Fix bugs in LZ4 decompression algorithm

2015-01-28 Thread Javier Celaya
Mostly the same as v2, but I stick to using ntohl, and improved log comments. Also, the row alignment is done with memmove, as suggested by Christophe. Javier Celaya (6): LZ4: Fix output buffer size LZ4: Adjust reading the top_down flag LZ4: Decode the image format from the stream LZ4

  1   2   >