Hi,
On 29-06-16 17:42, Christophe Fergeau wrote:
This variable is accessed from 2 different threads (main thread and USB
event thread), so some care must be taken to read/write it.
The event-thread only reads it, so I believe there is no need for this.
Regards,
Hans
---
src/usb-device-ma
Hi,
On 29-06-16 17:42, Christophe Fergeau wrote:
When using USB redirection, it's fairly easy to leak the thread handling
USB events, which will eventually cause problems in long lived apps.
In particular, in virt-manager, one can:
- start a VM
- connect to it with SPICE
- open the USB redirecti
Hi,
On 30-06-16 09:13, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:20:16PM +0200, Hans de Goede wrote:
Hi,
On 29-06-16 17:42, Christophe Fergeau wrote:
This variable is accessed from 2 different threads (main thread and USB
event thread), so some care must be taken to read/write it
Hi,
On 30-06-16 09:08, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote:
Erm no, it is the caller's responsibility to make sure that all
spice_usbredir_channel's are properly torn down before the
usbdevicemanager gets torn down.
Otherwise you&#
Hi,
On 30-06-16 13:08, Hans de Goede wrote:
Hi,
On 30-06-16 09:08, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote:
Erm no, it is the caller's responsibility to make sure that all
spice_usbredir_channel's are properly torn down
Hi,
The entire series looks good to me now, one remark wrt this patch,
with that fixed this series is:
Reviewed-by: Hans de Goede
On 30-06-16 15:40, Christophe Fergeau wrote:
This is a follow-up of the previous commit ('usb-channel: Really stop
listening for USB events on disconne
Hi,
On 30-06-16 18:02, Christophe Fergeau wrote:
On Thu, Jun 30, 2016 at 04:54:53PM +0200, Hans de Goede wrote:
Hi,
The entire series looks good to me now, one remark wrt this patch,
with that fixed this series is:
Reviewed-by: Hans de Goede
On 30-06-16 15:40, Christophe Fergeau wrote
Forwarded Message
Subject: where do usbredir patches go nowadays?
Date: Mon, 18 Jul 2016 17:23:44 +0300
From: Alon Levy
To: Hans de Goede
Well, ok, so I'm taking this time to say hi - you seem to be having good
GPU fun these days.
Hi,
I needed a vm to test something and I noticed that spice-gtk
appears to be broken in F25. As long as scaling between the
guest resolution and the window size is needed everything
works fine, but as soon as the agent adjusts the guest
resolution to exactly match the window size, the display
st
Signed-off-by: Hans de Goede
---
src/spiceqxl_main_loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c
index db89b6d..0ac1f3e 100644
--- a/src/spiceqxl_main_loop.c
+++ b/src/spiceqxl_main_loop.c
@@ -330,7 +330,11 @@ static int
Hi All,
See: https://bugzilla.redhat.com/show_bug.cgi?id=1381045
Also why is Alon still the maintainer of xorg-x11-drv-qxl in
Fedora ? It would IMHO be better if the spice-team would
maintain it.
Regards,
Hans
___
Spice-devel mailing list
Spice-deve
Hi,
On 03-10-16 12:04, Christophe Fergeau wrote:
On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede
---
src/spiceqxl_main_loop.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c
index
irtual().
This commit fixes this.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1381045
Signed-off-by: Hans de Goede
---
src/qxl.h| 1 +
src/qxl_driver.c | 6 +++---
src/qxl_kms.c| 1 +
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 5
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had to install them manually from koji, since they are
not yet listed in bodhi. Can you please create bodhi
updates for these ? :
https://bodhi.fedoraproject.org/updates/?packages
Hi,
On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had to install them manually from koji, since they are
not yet listed in bodhi. Can you plea
Hi,
On 10/10/2016 02:38 PM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi,
On 10/10/2016 11:49 AM, Marc-André Lureau wrote:
Hi
- Original Message -
Hi All,
I noticed that there have been a few spice-gtk builds fixing
the bugs I was hitting, thank you for that.
I had
Hi,
On 18-11-16 14:04, Timo Aaltonen wrote:
On 04.10.2016 14:41, Hans de Goede wrote:
Hi,
On 03-10-16 12:04, Christophe Fergeau wrote:
On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede
---
src/spiceqxl_main_loop.c | 4
1 file changed, 4
mit switches to that new API, which removes the need for
RegisterBlockAndWakeupHandlers().
Thank you for doing this, one small comment inline, otherwise looks
good:
Reviewed-by: Hans de Goede
(with the comment fixed).
---
I've lightly (xeyes/rxvt) tested this on f25, and tested this still
ts on failure).
Signed-off-by: Christophe Fergeau
LGTM:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/spiceqxl_audio.c| 2 +-
src/spiceqxl_main_loop.c| 4 ++--
src/spiceqxl_spice_server.c | 12 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git
emove file_page_offset parameter from ttm_bo_device_init()
drm/ttm: Quick-test mmap offset in ttm_bo_mmap()
drm: Use the same mmap-range offset and size for GEM and TTM
The first patch looks good to me:
Reviewed-by: Hans de Goede
The vboxvideo bits in the other patches look good to me to:
Ack
Hi,
On 11-03-19 17:51, Christian König wrote:
Am 11.03.19 um 17:39 schrieb Hans de Goede:
Hi,
On 07-02-19 09:59, Thomas Zimmermann wrote:
Almost all TTM-based drivers use the same values for the mmap-able
range of BO addresses. Each driver therefore duplicates the
DRM_FILE_PAGE_OFFSET
Hi,
On 07-02-19 09:59, Thomas Zimmermann wrote:
Almost all TTM-based drivers use the same values for the mmap-able
range of BO addresses. Each driver therefore duplicates the
DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not
configurable by drivers.
This patch set replaces drive
Hi,
Forwarding this to you guys from the xorg-devel list.
Regards,
Hans
Forwarded Message
Subject: a question about Xspice
Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST)
From: cynthia
To: xorg-de...@lists.x.org, x...@lists.x.org
HI All,
I am trying to build Xspice which i
Hi,
On 11/19/2014 04:37 AM, Fabiano Fidêncio wrote:
> ping?
Looks good to me.
Regards,
Hans
>
> On Thu, 2014-11-13 at 02:32 +0100, Fabiano Fidêncio wrote:
>> As we only can filter USB devices by their Classes and sometimes it is
>> not enough (eg: I do not want to have Keyboard and Mouse, but
Hi,
On 11/20/2014 06:08 PM, Christophe Fergeau wrote:
> Hey,
>
> Here are 3 libusbredir patches. I'm not sure where they should go (here?
> bugzilla? someplace else?), just let me know if they should go elsewhere.
spice-devel (with me in the CC please as I'm no longer on spice-devel)
is fine.
A
Hi,
On 12/16/2014 04:55 PM, Christophe Fergeau wrote:
Hey,
Thanks to the detailed description. Adding Hans to cc: since he knows
USB redirection the best.
This is only a problem with libusb on windows, there is a patch-set at the
upstream libusb mailinglist to stop libusb from taking the even
Hi,
On 13-04-15 21:40, Jeremy White wrote:
Hi folks,
I've done some work on a usbredir kernel module to bring support for USB
to XSpice. In doing so, and talking with some colleagues, their
reaction was: why don't you modify libusb instead?
That is, the current change is to modify XSpice to
Hi,
On 04/14/2015 09:10 PM, Jeremy White wrote:
Hey Hans,
"most Linux applications ... are going to use libusb to access the USB
devices."
That is not true, applications using libusb rather then a kernel driver
are the exception not the rule. Basically the only major applications using
libusb
Hi Jeremy,
On 17-06-15 21:06, Jeremy White wrote:
I have started work on a usbredir kernel module to enable USB
redirection for XSpice.
I'd like to reuse the usbredirparser.c code, but it needs changes to
compile as part of a kernel module. These are those changes.
The changes look fine to m
Hi,
On 01-07-15 18:13, Greg KH wrote:
On Wed, Jul 01, 2015 at 10:55:49AM -0500, Jeremy White wrote:
On 07/01/2015 12:44 AM, Greg KH wrote:
On Tue, Jun 30, 2015 at 10:34:25PM -0500, Jeremy White wrote:
1. Is the basic premise reasonable? Is Hans correct in asserting that an
alternate USB
Hi,
On 01-07-15 20:31, Jeremy White wrote:
Assuming that's correct, then this seems to imply that the socket has raw
plain text data being sent/received, and thus precludes the possibility
of running any security protocol like TLS unless the kernel wants to have
an impl of the TLS protocol.
Go
Hi,
On 02-07-15 10:45, Oliver Neukum wrote:
On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote:
I don't really think it is sensible to be defining & implementing new
network services which can't support strong encryption and authentication.
Rather than passing the file descriptor to t
Hi,
On 07-07-15 18:47, Jeremy White wrote:
Well, the checkpatch.pl reports were all style (and mostly whitespace);
roughly 3000 of them against 3000 lines of code :-/. I did review the
code, looking for areas where I thought it would badly cram into the
kernel, and I adjusted the few I found
Hi,
On 08-07-15 15:26, Uri Lublin wrote:
See usbredirfilter.h for when interfaces are skipped.
Fixes rhbz#1179210
Sigh, the kvm in question is really messed up as it uses non bootclass hid
interfaces,
that means it won't work in many BIOS' etc. What a mess ...
---
usbredirparser/usbredir
Hi,
On 08-07-15 18:22, Uri Lublin wrote:
Hi Hans,
Thanks for the quick review.
See answers below
On Wed, 2015-07-08 at 15:45 +0200, Hans de Goede wrote:
Hi,
On 08-07-15 15:26, Uri Lublin wrote:
See usbredirfilter.h for when interfaces are skipped.
Fixes rhbz#1179210
Sigh, the kvm in
Hi,
Thinking more about this I think I've a good solution.
If we end up skipping all interfaces, then do not return
-ENOENT, but rerun the filter with the
usbredirfilter_fl_dont_skip_non_boot_hid flag or-ed
into the flags argument.
That shhold fix the use case on hand while not overriding
the u
Hi,
On 09-07-15 09:19, Christophe Fergeau wrote:
On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote:
Can you ask the reporter to provide lsusb -v output for the usb interface
of the kvm in question, then we can better analyse what exactly is going
wrong here. Perhaps my analyses of
Hi,
On 09-07-15 16:51, Uri Lublin wrote:
On Thu, 2015-07-09 at 10:13 +0200, Hans de Goede wrote:
Hi,
On 09-07-15 09:19, Christophe Fergeau wrote:
On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote:
Can you ask the reporter to provide lsusb -v output for the usb
interface
of the
Hi,
On 14-07-15 17:30, Uri Lublin wrote:
See usbredirfilter.h for when interfaces are skipped.
Force filter check on such a device by calling recursively with
a flag that forbids skipping (usbredirfilter_fl_dont_skip_non_boot_hid)
Related rhbz#1179210
Looks good to me:
Reviewed-by: Hans de
Hi,
On 20-07-15 11:51, Christophe Fergeau wrote:
Hey,
Looks good te me now.
Hans, would you mind taking a quick look at that
patch in case you have objections on the change (if
spice_usb_acl_helper_open_acl_finish() fails, try to directly open the
device node anyway as it may be user-accessible
Hi,
On 06/23/2011 12:18 PM, Alon Levy wrote:
On Wed, Jun 22, 2011 at 05:00:10PM +0200, Alon Levy wrote:
Hi All,
Ok, take two with Gerd's and Hans's and Uri's comments.
(1) spice-protocol - keep it, move code generation stuff here
(spice_codegen.py, python_modules, spice*.proto), and have
On 06/23/2011 02:15 PM, Marc-André Lureau wrote:
Hi
2011/6/23 Alon Levy:
On Thu, Jun 23, 2011 at 01:56:19PM +0200, Marc-André Lureau wrote:
On Thu, Jun 23, 2011 at 12:18:11PM +0200, Alon Levy wrote:
(1) spice-protocol - remains unchanged. specifically, despite the name, will
not contain
Hi All,
I was wondering what the status are wrt working towards the 0.10.x series.
Can we tag a 0.9.0 release from spice git master ? and release tarbals for this
at this moment in time? If not can we make a short to do list with things which
needs to be done before we can do this?
Also given t
Hi,
On 07/19/2011 11:33 AM, Christophe Fergeau wrote:
Hi Hans,
On Tue, Jul 19, 2011 at 11:20:23AM +0200, Hans de Goede wrote:
Can we tag a 0.9.0 release from spice git master ? and release tarbals for this
at this moment in time? If not can we make a short to do list with things which
needs
Hi,
On 07/19/2011 12:11 PM, Alon Levy wrote:
On Tue, Jul 19, 2011 at 11:52:28AM +0200, Hans de Goede wrote:
Hi,
On 07/19/2011 11:33 AM, Christophe Fergeau wrote:
Hi Hans,
On Tue, Jul 19, 2011 at 11:20:23AM +0200, Hans de Goede wrote:
Can we tag a 0.9.0 release from spice git master ? and
Hi,
Good! Ack!
Regards,
Hans
On 07/19/2011 01:59 PM, Gerd Hoffmann wrote:
This patch adds symbol versions to the spice server library. Each
symbol which is exported by libspice-server gets tagged with the
(stable) version where it appeared first. This way the linker and rpm
are able to fig
Hi,
The plan in short:
1) The client decides to redirect a certain usb device
(be it through user interaction, or based on admin configuration /
instructed by the controller)
2) The client opens a new usbredir spice channel to the spice-server for
this (1 channel per device)
3) spice
Hi,
The plan in short:
1) The client decides to redirect a certain usb device
(be it through user interaction, or based on admin configuration /
instructed by the controller)
2) The client opens a new usbredir spice channel to the spice-server for
this (1 channel per device)
3) spice
Hi,
On 07/19/2011 05:46 PM, Gerd Hoffmann wrote:
Hi,
3) spice server asks qemu to dynamically create a new spicevmc chardev
+ usb-redir device couple (this is the part that needs the API extension).
That isn't going to fly. Then you'll have magic usb devices on the usb bus
libvirt doesn't k
Having a loglevel variable is much more useful if we can actually change
its value without a recompile. Use a SPICEC_LOG_LEVEL environment variable so
we can do this from the spice xpi / activex too (by setting the environment
variable before starting the browser).
---
client/application.cpp |
(and girls)
are doing a good job with 0.8.2, so I trust you will do a good job
with 0.9.0 too :)
Regards,
Hans
On 07/19/2011 11:20 AM, Hans de Goede wrote:
Hi All,
I was wondering what the status are wrt working towards the 0.10.x series.
Can we tag a 0.9.0 release from spice git master ? a
Hi All,
I would like to add support for the state callback of SpiceCharDeviceInterface
to spice-qemu-char.c, because I need it for ubsredir support.
There already is code in spice-server which will call this if defined, and
this code lives in reds.c and has to do with the agent channel.
This ha
Ack series.
On 07/21/2011 06:49 PM, Christophe Fergeau wrote:
---
Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 853ffea..f8cfe25 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -12,4 +12,4 @@ DISTCLEANFILES =
Hi,
On 07/21/2011 07:15 PM, Gerd Hoffmann wrote:
Hi,
So all in all enabling open / close event for the agent channel
is a BAD (tm) idea. However as stated in the start for usbredir
actually getting client connect / disconnect events is desirable,
so that usbredir can reset its parser to start
Ack.
On 07/22/2011 05:01 PM, Alon Levy wrote:
It was sending the wrong data, the memory right after the VCSMsgHeader
which was actually not where the data was.
Fixed by having the header and data (VSCError, 4 bytes of the error code)
embedded in the ErrorItem pipe item.
---
server/smartcard.c
See this long mail for the rationale for this:
http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html
---
server/reds.c | 65 +---
1 files changed, 20 insertions(+), 45 deletions(-)
diff --git a/server/reds.c b/server/reds.c
i
Hi,
On 07/26/2011 11:57 AM, Alon Levy wrote:
On Mon, Jul 25, 2011 at 12:20:52PM +0200, Hans de Goede wrote:
See this long mail for the rationale for this:
http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html
---
server/reds.c | 65
It is a bit early to bump, since a 0.9.1 release is not happening yet,
but this allows me to test if the vdagent SpiceCharInterface state callback
fixes are present or not in qemu code, and thus disabling the ugly vdagent
specific workaround from spice-qemu-char.c when compiling against a new
enoug
Hi,
On 07/26/2011 02:31 PM, Christophe Fergeau wrote:
Hey,
On Tue, Jul 26, 2011 at 03:20:31PM +0300, Alon Levy wrote:
-#define SPICE_SERVER_VERSION 0x000900 /* release 0.9.0 */
+#define SPICE_SERVER_VERSION 0x000901 /* release 0.9.1 */
Not directly related to this patch, but should we build
Fix a race between spice_channel_buffered_write and
spice_channel_iterate_write.
---
gtk/spice-channel.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index 8834143..f367b4d 100644
--- a/gtk/spice-channel.c
+++ b
Hi,
On 07/29/2011 05:28 PM, Christophe Fergeau wrote:
After the changes to add libjpeg-turbo support to spice-server mjpeg
compression code, it's relatively easy to hit an assertion from
libjpeg in spice-server about "too few scanlines transferred" when
the mjpeg streaming code triggers. This as
Ack series.
WRT your bad for cache comment in patch 2, no worries modern processors
prefetch can handle reverse loops just fine.
Regards,
Hans
On 07/29/2011 04:50 PM, Christophe Fergeau wrote:
Hey,
When testing changes which make spice-server send streams with an odd height
(currently all s
Hi,
On 08/01/2011 10:51 AM, Christophe Fergeau wrote:
On Sat, Jul 30, 2011 at 08:26:04AM +0200, Hans de Goede wrote:
The second is to define a new jpeg-rgb format where we use jpeg
compression straight on rgb, rather then first converting it
to yuv colorspace (this happens inside libjpeg
Hi,
On 08/01/2011 03:22 PM, Alon Levy wrote:
On Mon, Aug 01, 2011 at 03:14:12PM +0200, Hans de Goede wrote:
Hi,
On 08/01/2011 10:51 AM, Christophe Fergeau wrote:
On Sat, Jul 30, 2011 at 08:26:04AM +0200, Hans de Goede wrote:
The second is to define a new jpeg-rgb format where we use
381
--- /dev/null
+++ b/server/usbredir.c
@@ -0,0 +1,272 @@
+/* spice-server usbredir code
+
+ Copyright (C) 2011 Red Hat, Inc.
+
+ Red Hat Authors:
+ Hans de Goede
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
Hi,
On 08/11/2011 08:33 AM, Alon Levy wrote:
+static void usbredir_chardev_wakeup(SpiceCharDeviceInstance *sin)
+{
+UsbRedirState *state;
+SpiceCharDeviceInterface *sif;
+int n;
+
+state = SPICE_CONTAINEROF(sin->st, UsbRedirState, chardev_st);
+sif = SPICE_CONTAINEROF(sin-
Fix a race between spice_channel_buffered_write and
spice_channel_iterate_write.
Signed-off-by: Hans de Goede
---
gtk/spice-channel.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index 8834143..f367b4d 100644
the same as using a fresh channel.
Signed-off-by: Hans de Goede
---
gtk/spice-channel.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index f367b4d..0d56677 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -2157,6
Signed-off-by: Hans de Goede
---
spice.proto |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index 4c072ed..748ae95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1173,6 +1173,13 @@ channel SmartcardChannel : BaseChannel {
} @ctype
uld switch to that.
Signed-off-by: Hans de Goede
---
configure.ac| 16 ++
gtk/Makefile.am | 23 +++
gtk/gusb/README.txt |5 +
gtk/gusb/gusb-context-private.h | 35
gtk/gusb/gusb-context.c | 292 +++
Signed-off-by: Hans de Goede
---
configure.ac|1 +
gtk/Makefile.am |6 +
gtk/channel-usbredir-priv.h | 43 ++
gtk/channel-usbredir.c | 353 +++
gtk/channel-usbredir.h | 60
gtk/map-file
Signed-off-by: Hans de Goede
---
gtk/Makefile.am |3 +
gtk/map-file |8 +
gtk/spice-client-gtk.defs | 79
gtk/spice-client.h|1 +
gtk/spice-widget.c| 21 ++
gtk/usb-device-manager.c | 459
---
gtk/spice-widget-priv.h |1 +
gtk/spice-widget.c | 36
gtk/spicy.c |8 +++-
3 files changed, 44 insertions(+), 1 deletions(-)
diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h
index 3711aaa..5527ebc 100644
--- a/
remove the keyboard_grab_count / keyboard_grab_time hack
from try_keyboard_grab, although since we are no longer doing an
ungrab on focus out, this likely could have been removed before.
I will do this in a separate patch for easier reverting if necessary.
Signed-off-by: Hans de Goede
---
With the filtering of focus in / out events caused by grabs we should no
longer need this.
Signed-off-by: Hans de Goede
---
gtk/spice-widget-priv.h |2 --
gtk/spice-widget.c | 17 -
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/gtk/spice-widget
we may be missing key releases
afterwards) makes a lot more sense then doing this on focus in, and with
the release_keys on focus out I don't really see a reason any more to do it
on focus in. But I'm leaving it in on focus in just in case, it certainly
cannot hurt there.
Signed-off-b
All 3 Look good to me.
ACK series.
Regards,
Hans
On 08/12/2011 06:03 PM, Christophe Fergeau wrote:
Even if VDAgentDisplayConfig::depth will be unused if the
VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH isn't set, it's
better to initialize it anyway to avoid warnings from valgrind.
---
clie
Ack.
On 08/17/2011 03:20 AM, Christophe Fergeau wrote:
Ping?
Christophe
On Tue, Aug 09, 2011 at 07:09:37PM +0200, Christophe Fergeau wrote:
If we don't free it, we'll leak the memory that was allocated in
main_channel_init().
---
server/main_channel.c |1 +
1 files changed, 1 insertion
Good work!
Ack series.
I think we should add these to the 0.8 branch too.
On 08/24/2011 04:41 AM, Christophe Fergeau wrote:
Issue found by the Coverity scanner.
---
server/red_dispatcher.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/red_dispatcher.c b/s
Hi all,
Just a quick update on $subject
Done:
1) update libusb1 to 1.0.9 git snapshot (in F-16 stable)
2) update usbredir to 0.3.1 (in updates-testing and as buildroot-override)
3) build a qemu with usbredir support + a few extra patches (in updates-testing)
To-do:
1) Do a new release of spice-
ultiplexing code
where we've our own multiplexing protocol wrapper over the libcacard
smartcard protocol.
Signed-off-by: Hans de Goede
---
spice/enums.h | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/spice/enums.h b/spice/enums.h
index ffaba5c..8d68b36 10064
Signed-off-by: Hans de Goede
---
server/red_channel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 87320b4..8993cc3 100644
--- a/server/red_channel.c
+++ b/server/red_channel.c
@@ -130,6 +130,7 @@ static void
Signed-off-by: Hans de Goede
---
server/usbredir.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/server/usbredir.c b/server/usbredir.c
index 8daab7d..11c4058 100644
--- a/server/usbredir.c
+++ b/server/usbredir.c
@@ -22,6 +22,8 @@
#include
#endif
Signed-off-by: Hans de Goede
---
server/usbredir.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/server/usbredir.c b/server/usbredir.c
index 11c4058..eb9b91f 100644
--- a/server/usbredir.c
+++ b/server/usbredir.c
@@ -259,6 +259,7 @@ int usbredir_device_connect
Now that the Channel struct is gone and the RedChannel has the same lifetime
as the chardev interface there is no need to have these 2 separate.
Signed-off-by: Hans de Goede
---
server/usbredir.c | 51 ++-
1 files changed, 18 insertions(+), 33
h a 1 channel / reader model, rather then the current multiplexing code
where we've our own multiplexing protocol wrapper over the libcacard
smartcard protocol.
Signed-off-by: Hans de Goede
---
server/Makefile.am |2 +-
server/char_device.h |6 +-
server/reds.c|
Hi,
On 08/25/2011 12:24 PM, Yonit Halperin wrote:
Hi all,
here is the original email I sent for #725009.
===> For this plan no change is required in libvirt. <===
This plan does not bring back seamless migration to live. But it does
make the current host switching less noticeable by the user.
T
Attached is a better diff, showing the actual changes to the
renamed file.
On 08/25/2011 12:19 PM, Hans de Goede wrote:
While discussing various things with Alon in Vancouver, it came up that
having a channel which simply passes through data coming out of a qemu
chardev frontend unmodified
Hi,
On 08/25/2011 01:35 PM, Gerd Hoffmann wrote:
Hi,
Some examples of why having a generic spicevmc pass through is good:
(5) Redirect the serial or virtio console over spice. Especially with
spice-gtk it should be easy to wind up the spice client side to a
vte widget.
Right, so this would
Hi All,
I'm happy to announce the second release in the 0.9.x
development series with tons of new features: both
multi client and usb redirection!!
Changes in spice-0.9.1:
===
* Multi-client support, disabled by default (experimental!) set the
environment variable SPICE_DEB
Hi,
On 08/26/2011 10:07 AM, Alon Levy wrote:
On Thu, Aug 25, 2011 at 01:57:21PM +0200, Hans de Goede wrote:
Hi,
On 08/25/2011 01:35 PM, Gerd Hoffmann wrote:
Hi,
Some examples of why having a generic spicevmc pass through is good:
(5) Redirect the serial or virtio console over spice
the same as using a fresh channel.
Signed-off-by: Hans de Goede
---
gtk/spice-channel.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index f8c79eb..a89b75c 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -2170,6
Signed-off-by: Hans de Goede
---
spice.proto |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index 4c072ed..748ae95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1173,6 +1173,13 @@ channel SmartcardChannel : BaseChannel {
} @ctype
uld switch to that.
Signed-off-by: Hans de Goede
---
configure.ac| 16 ++
gtk/Makefile.am | 23 +++
gtk/gusb/README.txt |5 +
gtk/gusb/gusb-context-private.h | 35
gtk/gusb/gusb-context.c | 292 +++
Signed-off-by: Hans de Goede
---
configure.ac|1 +
gtk/Makefile.am |6 +
gtk/channel-usbredir-priv.h | 43 ++
gtk/channel-usbredir.c | 353 +++
gtk/channel-usbredir.h | 60
gtk/map-file
Signed-off-by: Hans de Goede
---
gtk/Makefile.am |3 +
gtk/map-file |8 +
gtk/spice-client-gtk.defs | 79
gtk/spice-client.h|1 +
gtk/spice-widget.c| 21 ++
gtk/usb-device-manager.c | 459
---
gtk/spice-widget-priv.h |1 +
gtk/spice-widget.c | 36
gtk/spicy.c |8 +++-
3 files changed, 44 insertions(+), 1 deletions(-)
diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h
index a567f1b..bd6dedb 100644
--- a/
Hi,
On 08/25/2011 11:51 AM, Peter Hatina wrote:
Hello guys,
I did some changes in spice-xpi. Now the plugin is capable to call
JavaScript function "OnDisconnected(ErrCode)" which makes our User
Portal more natural in behavior. When spicec quit, the User Portal gets
notified by calling OnDisconn
the same as using a fresh channel.
Signed-off-by: Hans de Goede
---
gtk/spice-channel.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index f8c79eb..a89b75c 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -2170,6
Signed-off-by: Hans de Goede
---
spice.proto |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index 4c072ed..748ae95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1173,6 +1173,13 @@ channel SmartcardChannel : BaseChannel {
} @ctype
1 - 100 of 1729 matches
Mail list logo
