Re: [Spice-devel] [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-11 Thread Hans Verkuil
Hi Dmitry, On 2/18/20 9:27 PM, Dmitry Sepp wrote: > Hi all, > > This is a v4l2 virtio video driver for the virtio-video device > specification v3 [1]. > > The first version of the driver was introduced here [2]. > > Changes v1 -> v2: > * support the v3 spec (mostly) > * add a module parameter t

Re: [Spice-devel] [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Hans Verkuil
On 3/12/20 10:49 AM, Keiichi Watanabe wrote: > Hi Hans, > > On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote: >> >> Hi Dmitry, >> >> On 2/18/20 9:27 PM, Dmitry Sepp wrote: >>> Hi all, >>> >>> This is a v4l2 virtio video driver for t

Re: [Spice-devel] [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Hans Verkuil
ssion test. Regards, Hans > > Best regards, > Dmitry. > > On Donnerstag, 12. März 2020 10:54:35 CET Hans Verkuil wrote: >> On 3/12/20 10:49 AM, Keiichi Watanabe wrote: >>> Hi Hans, >>> >>> On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil w

Re: [Spice-devel] [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver

2020-03-12 Thread Hans Verkuil
On 3/12/20 11:15 AM, Dmitry Sepp wrote: > Hi Hans, > > Thank you for your great detailed review! > > I won't provide inline answers as your comments totally make sense. There is > only one thing I want to mention: > >>> + struct video_plane_format plane_format[VIRTIO_VIDEO_MAX_PLANES]; >> >>