Re: [Spice-devel] [PATCH v2] Use #ifdef {HAVE, USE}_FOO instead of #if {HAVE, USE}_FOO

2016-02-11 Thread Eduardo Lima (Etrunko)
327,7 +327,7 @@ void spice_usbredir_channel_connect_device_async( >> { >> SpiceUsbredirChannelPrivate *priv = channel->priv; >> GTask *task; >> -#if ! USE_POLKIT >> +#ifndef USE_POLKIT >> GError *err = NULL; >> #endif >> > &g

Re: [Spice-devel] [PATCH spice-gtk 3/3] spicy: s/Automagic/Automatic/

2016-03-19 Thread Eduardo Lima (Etrunko)
;, > +.label = "Automatic clipboard sharing between host and guest", > .callback= G_CALLBACK(menu_cb_bool_prop), > },{ > .name= "auto-usbredir", > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etr

Re: [Spice-devel] [PATCH spice-gtk 2/3] spice-display: Remove auto-clipboard notify

2016-03-19 Thread Eduardo Lima (Etrunko)
e_g_signal_connect_object(d->session, > "notify::inhibit-keyboard-grab", > > G_CALLBACK(session_inhibit_keyboard_grab_changed), >display, 0); > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (E

Re: [Spice-devel] [spice-gtk v2] Introduce gtask-helper.[ch]

2016-03-23 Thread Eduardo Lima (Etrunko)
On 23/03/16 09:04, Fabiano Fidêncio wrote: > gtask-helper provide methods that can easily be used for returning in > idle, as a few issues have been found in the GTask code used in > spice-gtk due to a immediately return when a return in idle was > expected. As examples of these issues, you can tak

Re: [Spice-devel] current git head spice-common fails to build on glib2 < 2.38

2016-03-28 Thread Eduardo Lima (Etrunko)
On 03/27/2016 11:19 AM, Fabiano Fidêncio wrote: > Brad, > > On Sat, Mar 26, 2016 at 2:53 PM, Brad Campbell > wrote: >> Checking the git logs, in Oct the required glib version was bumped to 2.22. >> Since that point logging has been added using g_test_* functions which were >> apparently added in

Re: [Spice-devel] make says nothing to be done for 'all'

2016-03-28 Thread Eduardo Lima (Etrunko)
Can you paste the contents of config.log file, and also the output from configure? On 03/28/2016 04:58 PM, Mahmood Naderan wrote: > I have to say that, I was able to install the RPM file. However, if > anybody have an idea about that error which prevented me to install > spice-protocol from source

Re: [Spice-devel] "undefined reference" errors while running make

2016-03-28 Thread Eduardo Lima (Etrunko)
On 03/28/2016 05:00 PM, Mahmood Naderan wrote: > Hi, > The outcome of './configure --prefix=/opt/spice' shows everything is OK > > config.status: executing libtool commands > configure: > > Spice 0.13.0.232-8b1e-dirty > == > > prefix: /opt/s

[Spice-devel] [[PATCH] [spice-common] 0/2] Configure fixes

2016-03-28 Thread Eduardo Lima (Etrunko)
From: "Eduardo Lima (Etrunko)" Eduardo Lima (Etrunko) (2): Update glib requirements to 2.38 Add check for openssl configure.ac | 7 --- m4/spice-deps.m4 | 11 ++- 2 files changed, 14 insertions(+), 4 deletions(-) -

[Spice-devel] [[PATCH] [spice-common] 1/2] Update glib requirements to 2.38

2016-03-28 Thread Eduardo Lima (Etrunko)
From: "Eduardo Lima (Etrunko)" Recent logging tests make use of g_test_subprocess() and g_test_trap_subprocess() functions, available only in glib newer than 2.38. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 2 +- m4/spice-deps.m4 | 2 +- 2 files changed, 2 insert

[Spice-devel] [[PATCH] [spice-common] 2/2] Add check for openssl

2016-03-28 Thread Eduardo Lima (Etrunko)
From: "Eduardo Lima (Etrunko)" It is required to compile ssl-verify.[ch]. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 5 +++-- m4/spice-deps.m4 | 9 + 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index bfdf86

Re: [Spice-devel] [[PATCH] [spice-common] 2/2] Add check for openssl

2016-03-29 Thread Eduardo Lima (Etrunko)
On 03/29/2016 05:24 AM, Christophe Fergeau wrote: > On Mon, Mar 28, 2016 at 06:00:28PM -0300, Eduardo Lima (Etrunko) wrote: >> From: "Eduardo Lima (Etrunko)" >> >> It is required to compile ssl-verify.[ch]. > > Makes sense. Any idea why it could be built with

Re: [Spice-devel] [[PATCH] [spice-common] 1/2] Update glib requirements to 2.38

2016-03-29 Thread Eduardo Lima (Etrunko)
On 03/29/2016 05:18 AM, Christophe Fergeau wrote: > Hey, > > On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote: >> From: "Eduardo Lima (Etrunko)" >> >> Recent logging tests make use of g_test_subprocess() and >> g_test_trap_sub

Re: [Spice-devel] [PATCH] channel: do not free rcc->stream in red_channel_client_disconnect

2016-03-29 Thread Eduardo Lima (Etrunko)
On 01/19/2016 08:14 AM, Victor Toso wrote: > Hi, > > On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote: >> This fixes a crash if red_channel_client disconnect is called >> handling a message. >> This can happen for instance handling SPICE_MSGC_ACK which calls >> red_channel_client_pu

Re: [Spice-devel] "undefined reference" errors while running make

2016-03-29 Thread Eduardo Lima (Etrunko)
On 03/29/2016 09:54 AM, Mahmood Naderan wrote: >>What is the version of glib in your system? >>Those functions were added in version 2.38. > > OK. Currently I am using Centos-6.5 which is rather old. > Anyway thanks... > I am working on a patch to fix this error in older systems, such as RHEL6

[Spice-devel] [PATCH spice-common] Fix build in systems with Glib version older than 2.38

2016-03-30 Thread Eduardo Lima (Etrunko)
From: "Eduardo Lima (Etrunko)" Tests now include functions only available in glib 2.38. To avoid setting the dependency bar too high, we simply put them between #ifdef guards. Signed-off-by: Eduardo Lima (Etrunko) --- tests/test-logging.c | 4 tests/test-marshallers.c | 7

Re: [Spice-devel] "undefined reference" errors while running make

2016-03-30 Thread Eduardo Lima (Etrunko)
On 03/29/2016 12:08 PM, Mahmood Naderan wrote: > O that is good :thumsup: > I applied the patch and the compilation passed that file. However, I get > a new undefined reference in another file > > > root@cluster:spice-src# patch < patch > can't find file to patch at input line 5 The new patch at

Re: [Spice-devel] [PATCH] channel: do not free rcc->stream in red_channel_client_disconnect

2016-03-30 Thread Eduardo Lima (Etrunko)
On 03/30/2016 06:44 AM, Victor Toso wrote: > On Tue, Mar 29, 2016 at 09:35:12AM -0300, Eduardo Lima (Etrunko) wrote: >> On 01/19/2016 08:14 AM, Victor Toso wrote: >>> Hi, >>> >>> On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote: >>&

[Spice-devel] [PATCH v2 spice-common] Fix build in systems with Glib version older than 2.38

2016-03-30 Thread Eduardo Lima (Etrunko)
Tests now include functions only available in glib 2.38. To avoid setting the dependency bar too high, we simply put them between #ifdef guards. Signed-off-by: Eduardo Lima (Etrunko) --- tests/test-logging.c | 4 tests/test-marshallers.c | 4 2 files changed, 8 insertions(+) diff

Re: [Spice-devel] "undefined reference" errors while running make

2016-03-31 Thread Eduardo Lima (Etrunko)
On 03/30/2016 09:15 AM, Eduardo Lima (Etrunko) wrote: > On 03/29/2016 12:08 PM, Mahmood Naderan wrote: >> O that is good :thumsup: >> I applied the patch and the compilation passed that file. However, I get >> a new undefined reference in another file >> >> >>

Re: [Spice-devel] current git head spice-common fails to build on glib2 < 2.38

2016-03-31 Thread Eduardo Lima (Etrunko)
On 03/26/2016 10:53 AM, Brad Campbell wrote: > Checking the git logs, in Oct the required glib version was bumped to > 2.22. Since that point logging has been added using g_test_* functions > which were apparently added in 2.38. Trying to build on 2.33 (which I > was) therefore passes the configure

Re: [Spice-devel] [PATCH spice-gtk 2/4] Use g_object_unref instead of gdk_cursor_unref

2016-04-05 Thread Eduardo Lima (Etrunko)
On 04/05/2016 01:58 PM, Pavel Grunt wrote: > GdkCursor is GObject and g_object_unref has been deprecated since 3.0 You mean gdk_cursor_unref here right? Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.

Re: [Spice-devel] [PATCH spice-gtk 4/4] Use g_clear_pointer if possible

2016-04-05 Thread Eduardo Lima (Etrunko)
7 deletions(-) > Wow, that's quite a lot of files changed. I wonder if those variables set to NULL are really reused that often to justify cleaning up like that. I found a couple of mistakes and also commented about getting rid of some curly braces. Reviewed-by: Eduardo Lima (Etrunko)

Re: [Spice-devel] [PATCH spice-gtk 3/4] Use g_clear_object if possible

2016-04-05 Thread Eduardo Lima (Etrunko)
Acked-by: Eduardo Lima (Etrunko) Maybe could be squashed with next one. On 04/05/2016 01:58 PM, Pavel Grunt wrote: > --- > src/spice-channel.c| 11 ++- > src/spice-widget.c | 22 -- > src/wocky-http-proxy.c | 3 +-- > 3 files changed, 7 in

Re: [Spice-devel] [PATCH spice-gtk v2 0/6] Cleanups for new gtk and glib

2016-04-06 Thread Eduardo Lima (Etrunko)
On 04/06/2016 10:40 AM, Pavel Grunt wrote: > Hi, > > since we bumped the glib and gtk dependencies, it's possible to clean up > the code little bit. Patches silence some deprecated warnings and change > our code to use more g_clear_pointer and g_clear_object. > > Thanks, > Pavel > > v2 adds comm

Re: [Spice-devel] [spice-gtk v3 18/19] log: create subdomains for spice-gtk

2016-04-18 Thread Eduardo Lima (Etrunko)
On 04/18/2016 10:49 AM, Victor Toso wrote: > Hey, > > On Fri, Apr 15, 2016 at 03:39:44PM +0200, David Jaša wrote: >> Will it be possible to print all existing subdomains? Or would it be >> hard to add? > > It isn't hard to add as a list to print out when requested. > But note that at this moment

[Spice-devel] [PATCH] Fix make dist

2016-04-25 Thread Eduardo Lima (Etrunko)
spicec screenshot has been removed since commit b0186fe1267dfa2b8534c7c083dc301791279f08 Signed-off-by: Eduardo Lima (Etrunko) --- docs/manual/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/manual/Makefile.am b/docs/manual/Makefile.am index ead5f46..24a11fe 100644 --- a

[Spice-devel] [PATCH] build-sys: post-release bump

2016-04-25 Thread Eduardo Lima (Etrunko)
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6d96f76..dd2d373 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJ

Re: [Spice-devel] [PATCH] build-sys: post-release bump

2016-04-25 Thread Eduardo Lima (Etrunko)
Please ignore, git send-email was called from wrong directory. On 04/25/2016 06:21 PM, Eduardo Lima (Etrunko) wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

[Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-04-25 Thread Eduardo Lima (Etrunko)
The problem happens when you run 'make dist' in a system without asciidoc installed. Even though in configure time there is a check for building the manual, it is required to be built for distribution. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac

Re: [Spice-devel] [PATCH] Fix make dist

2016-04-26 Thread Eduardo Lima (Etrunko)
pushed On 04/26/2016 02:24 AM, Pavel Grunt wrote: > On Mon, 2016-04-25 at 17:21 -0300, Eduardo Lima (Etrunko) wrote: >> spicec screenshot has been removed since commit >> b0186fe1267dfa2b8534c7c083dc301791279f08 >> >> Signed-off-by: Eduardo Lima (Etrunko) > Acke

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-04-29 Thread Eduardo Lima (Etrunko)
Any opinions here? On 04/25/2016 06:23 PM, Eduardo Lima (Etrunko) wrote: > The problem happens when you run 'make dist' in a system without > asciidoc installed. Even though in configure time there is a check for > building the manual, it is required to be built for distributi

Re: [Spice-devel] recipe for target 'red-channel.lo' failed

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/22/2016 09:14 AM, Eduards Šaraņins wrote: > Hello, > I'm trying to build spice-0.12.7 and get the following errors: > > CFLAGS="-m64" LDFLAGS="-m64" ./configure --disable-client > --disable-werror --prefix=/opt/local > > > > CC red_channel.lo > red_channel.c: In function 'red_

Re: [Spice-devel] How to modify spice version?

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/28/2016 08:45 AM, Pavel Grunt wrote: > Hi, > > On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: >> Thank you for taking time out of your busy schedule to see this letter. >> I am trying to compile spice downloaded from github, but the versions of >> these >> are 'UNKNOWN'. when I compiled

Re: [Spice-devel] How to modify spice version?

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote: > On 04/28/2016 08:45 AM, Pavel Grunt wrote: >> Hi, >> >> On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: >>> Thank you for taking time out of your busy schedule to see this letter. >>> I am trying to co

[Spice-devel] [PATCH 1/3] Update git-version-gen to latest version

2016-04-29 Thread Eduardo Lima (Etrunko)
Pick the latest git-version-gen version from http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/git-version-gen Signed-off-by: Eduardo Lima (Etrunko) --- build-aux/git-version-gen | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/build-aux/git-version

[Spice-devel] [PATCH 2/3] Fix git-version-gen output if --fallback is specified

2016-04-29 Thread Eduardo Lima (Etrunko)
ithout git installed. Signed-off-by: Eduardo Lima (Etrunko) --- build-aux/git-version-gen | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen index 6c56147..8d76e2a 100755 --- a/build-aux/git-version-gen +++ b/build-aux/git-v

[Spice-devel] [PATCH 3/3] Pass fallback version to git-version-gen

2016-04-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 18b907a..35f2f06 100644 --- a/configure.ac +++ b/configure.ac @@ -15,7 +15,7 @@ m4_define([SPICE_CURRENT], [12]) m4_define([SPICE_REVISION

[Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-04-29 Thread Eduardo Lima (Etrunko)
I am sending this series for spice-server only, if we come to an agreement, I will provide similar patches for common and gtk. Eduardo Lima (Etrunko) (3): Update git-version-gen to latest version Fix git-version-gen output if --fallback is specified Pass fallback version to git-version-gen

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Eduardo Lima (Etrunko)
On 04/30/2016 04:19 AM, Victor Toso wrote: > Hey, > > On Mon, Apr 25, 2016 at 06:23:25PM -0300, Eduardo Lima (Etrunko) wrote: >> The problem happens when you run 'make dist' in a system without >> asciidoc installed. Even though in configure time there is a check fo

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Eduardo Lima (Etrunko)
On 05/02/2016 07:39 AM, Uri Lublin wrote: > On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: >> The problem happens when you run 'make dist' in a system without >> asciidoc installed. Even though in configure time there is a check for >> building the manual,

Re: [Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-05-02 Thread Eduardo Lima (Etrunko)
On 04/29/2016 06:08 PM, Marc-André Lureau wrote: > > > - Original Message - >> I am sending this series for spice-server only, if we come to an >> agreement, I will provide similar patches for common and gtk. > > What does it actually fix? See previous thread "How to modify spice versio

Re: [Spice-devel] recipe for target 'red-channel.lo' failed

2016-05-02 Thread Eduardo Lima (Etrunko)
On 05/01/2016 06:40 AM, Eduards Šaraņins wrote: > Hi Eduardo, > I'm trying to build it on SmartOS using this guide: > http://permalink.gmane.org/gmane.os.smartos.general/125 Well, I know nothing about SmartOS, so in this case, I think you might have to find which file has SOL_TCP definition and ch

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-03 Thread Eduardo Lima (Etrunko)
On 05/03/2016 06:08 AM, Uri Lublin wrote: > On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote: >> On 05/02/2016 07:39 AM, Uri Lublin wrote: >>> On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: >>>> The problem happens when you run 'make dist' in

Re: [Spice-devel] How to modify spice version?

2016-05-03 Thread Eduardo Lima (Etrunko)
On 05/02/2016 09:46 AM, Marc-André Lureau wrote: > Hi > > On Fri, Apr 29, 2016 at 9:10 PM, Eduardo Lima (Etrunko) > wrote: >> On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote: >>> On 04/28/2016 08:45 AM, Pavel Grunt wrote: >>>> Hi, >>>> &g

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-04 Thread Eduardo Lima (Etrunko)
On 05/04/2016 06:23 AM, Uri Lublin wrote: > On 05/03/2016 06:36 PM, Frediano Ziglio wrote: >>> >>> On 05/02/2016 07:39 AM, Uri Lublin wrote: >>>> On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: >>>>> The problem happens when you run 'ma

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-04 Thread Eduardo Lima (Etrunko)
On 05/04/2016 05:51 AM, Frediano Ziglio wrote: >> >>> >>> Honestly more I look at the patch and this fix and more I think it's all >>> a big bug... >>> What I know for sure is that this patch fix a dandling pointer. >> >> That's true. >> But I think we should have a better fix that does not ignore

Re: [Spice-devel] [PATCH 0/2] Fix some regression introduced by recent patches

2016-05-05 Thread Eduardo Lima (Etrunko)
insertions(+), 10 deletions(-) > Tested and confirmed to fix the issues. Uri, any objections? Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel mailing list Spice-de

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-05 Thread Eduardo Lima (Etrunko)
On 05/05/2016 10:05 AM, Frediano Ziglio wrote: >> >> This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. >> This patch causes bug as sin->st can be NULL in some cases. >> opaque is always referring to RedsState. >> >> Signed-off-by: Frediano Ziglio >> --- > > It could be weird but I'm n

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-06 Thread Eduardo Lima (Etrunko)
On 05/06/2016 08:19 AM, Frediano Ziglio wrote: >> >> Hi, >> >> On Fri, May 06, 2016 at 12:11:46PM +0200, Victor Toso wrote: >>> Hi, >>> >>> On Thu, May 05, 2016 at 01:33:05PM +0100, Frediano Ziglio wrote: This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. This patch causes bug

Re: [Spice-devel] [PATCH v2 2/2] fix crash if agent interface is removed

2016-05-09 Thread Eduardo Lima (Etrunko)
nt_dev), NULL); > } > } > #ifdef USE_SMARTCARD > Confirmed that this solves the crash without the need of reverting the original patch which introduced the issue. Tested-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru.

Re: [Spice-devel] [PATCH v3] fix crash if agent interface is removed

2016-05-10 Thread Eduardo Lima (Etrunko)
On 05/10/2016 10:38 AM, Frediano Ziglio wrote: > Removing an interface cause SpiceBaseInstance->st to be set to NULL. > This pointer was then deferenced in agent code. > As SpiceBaseInstance should not be used after this call make sure > we don't keep pointers to it. > > Signed-off-by: Frediano Zi

Re: [Spice-devel] [PATCH spice-common] recorder: Update

2019-03-29 Thread Eduardo Lima (Etrunko)
ion(-) > > diff --git a/common/recorder b/common/recorder > index 03eb4b6..10b1787 16 > --- a/common/recorder > +++ b/common/recorder > @@ -1 +1 @@ > -Subproject commit 03eb4b6ef7aa90645a7395ea8bea55ebf33d6632 > +Subproject commit 10b178762e1d66d82bdde754385a6a608a730607 >

Re: [Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:08 AM, Victor Toso wrote: > Hi, > > On Wed, Apr 03, 2019 at 05:20:35PM +0100, Frediano Ziglio wrote: >> All generated file depends on generated_messages.h which is >> generated too. >> So add an explicit dependency from all generated file >> (except generated_messages.h generator) to g

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 5:19 AM, Frediano Ziglio wrote: >> >> Hi, >> >> On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: >>> spice-gtk and spice-server will use spice_common_client_dep >>> and spice_common_server_dep as dependencies. >>> However they will depend on both spice-common client/server

[Spice-devel] [PATCH spice-common] fixup! meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 78 +++--- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/common/meson.build b/common/meson.build index 2b7bef00..e5629af4 100644 --- a/common/meson.build +++ b/common

Re: [Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
On 4/4/19 11:50 AM, Frediano Ziglio wrote: >> >> On 4/4/19 5:19 AM, Frediano Ziglio wrote: Hi, On Wed, Apr 03, 2019 at 05:20:36PM +0100, Frediano Ziglio wrote: > spice-gtk and spice-server will use spice_common_client_dep > and spice_common_server_dep as dependencies. >>

[Spice-devel] [PATCH spice-common v3 1/3] meson: Fix dependency of generated files

2019-04-04 Thread Eduardo Lima (Etrunko)
generated at all. Add dependency to the include header to make Meson generate the proper include flag. Signed-off-by: Frediano Ziglio Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 75 +++--- 1 file changed, 45 insertions(+), 30 deletions

[Spice-devel] [PATCH spice-common v3 0/3] Meson build fixes.

2019-04-04 Thread Eduardo Lima (Etrunko)
Following up on Frediano's patches for meson, I added another one to avoid using nested lists, by changing the list items to dictionaries. This is less error prone but adds the complexity of checking for the contents of output list. Regards, Eduardo. Eduardo Lima (Etrunko) (1): meson:

[Spice-devel] [PATCH spice-common v3 2/3] meson: Do not build generated files twice

2019-04-04 Thread Eduardo Lima (Etrunko)
spice-gtk. The issue can be observed doing a "find -name \*generated\*.o" in Meson build directory. Signed-off-by: Frediano Ziglio Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/meson.buil

[Spice-devel] [PATCH spice-common v3 3/3] meson: Make targets list store dictionaries instead of lists

2019-04-04 Thread Eduardo Lima (Etrunko)
Access the items by names instead of indexes. Signed-off-by: Eduardo Lima (Etrunko) --- common/meson.build | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/common/meson.build b/common/meson.build index 980a32af..9a2725ff 100644

Re: [Spice-devel] [PATCH spice-gtk] spice-common: update submodule

2019-04-04 Thread Eduardo Lima (Etrunko)
Add missing G_GNUC_PRINTF annotations > build: Update verify.h to latest version > test-marshallers: Fix header guard > quic: Fix QUIC_VERSION definition > log: Let gcc know about the logging macros which abort > > Eduardo Lima (Etrunko) (5): >

Re: [Spice-devel] [spice-protocol v2 0/6] Prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
| 27 +++ > configure.ac | 2 +- > 6 files changed, 62 insertions(+), 1 deletion(-) > create mode 100644 .gitlab-ci.yml > rename NEWS => CHANGELOG.md (93%) > delete mode 100644 ChangeLog > delete mode 100644 README > create mode 1

Re: [Spice-devel] [spice-protocol v2 1/6] build-sys: automake: do not require NEWS and ChangeLog

2019-04-12 Thread Eduardo Lima (Etrunko)
ONFIG_MACRO_DIR([m4]) > AM_CONFIG_HEADER([config.h]) > > -AM_INIT_AUTOMAKE([dist-bzip2]) > +AM_INIT_AUTOMAKE([foreign dist-bzip2]) > AM_MAINTAINER_MODE > > m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])]) > Acked-by: Eduardo Lima (Etrunko) -- Edu

Re: [Spice-devel] [spice-protocol v2 4/6] Rename NEWS to CHANGELOG.md

2019-04-12 Thread Eduardo Lima (Etrunko)
md | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename NEWS => CHANGELOG.md (100%) > > diff --git a/NEWS b/CHANGELOG.md > similarity index 100% > rename from NEWS > rename to CHANGELOG.md > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (

Re: [Spice-devel] [spice-protocol v2 3/6] ChangeLog: remove old one

2019-04-12 Thread Eduardo Lima (Etrunko)
--git a/ChangeLog b/ChangeLog > deleted file mode 100644 > index e69de29..000 > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ Spice-devel mailing list

Re: [Spice-devel] [spice-protocol v2 5/6] README: Add basic info and .md prefix

2019-04-12 Thread Eduardo Lima (Etrunko)
linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/qxl > +[win32/qxl]: https://gitlab.freedesktop.org/spice/win32/qxl > +[win32/qxl-wddm-dod]: https://gitlab.freedesktop.org/spice/win32/qxl-wddm-dod > +[report bugs]: https://gitlab.freedesktop

Re: [Spice-devel] [spice-protocol v2 6/6] NEWS: prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
_TUNNEL_* and SPICE_MSGC_TUNNEL_* > +* Add VDAgentGraphicsDeviceInfo message > +* Add StreamMsgGraphicsDeviceInfo message > +* Add padding to SpiceStat structure > + > Major changes in 0.12.15 > ============ > * Add support for h265 video codec > With that small

Re: [Spice-devel] [linux/vd-agent v1 0/2] Prepare for 0.19.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
t; And the formatted changelog at: > > > https://gitlab.freedesktop.org/victortoso/vd_agent/blob/284fb7aab016b436d59b06fbcc3539e8abc149a4/CHANGELOG.md > Looking good. For the series Acked-by: Eduardo Lima (Etrunko) > Cheers, > > Victor Toso (2): > build-sys: ne

Re: [Spice-devel] [spice-protocol] build-sys: add README.md and CHANGELOG.md to tarball

2019-04-12 Thread Eduardo Lima (Etrunko)
\ > + README.md \ > + CHANGELOG.md \ > + meson.build > > -include $(top_srcdir)/git.mk > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@re

Re: [Spice-devel] [PATCH] build-sys: Add README.md to the tarball

2019-04-12 Thread Eduardo Lima (Etrunko)
README.md \ > CHANGELOG.md\ > data/70-spice-vdagentd.rules \ > data/spice-vdagent.desktop \ > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat

Re: [Spice-devel] [PATCH spice-gtk] build: Do not attempt to distribute not present file

2019-04-24 Thread Eduardo Lima (Etrunko)
po/meson.build \ > build-aux/git-version-gen \ > - build-aux/meson/check-spice-common \ > gtk-doc.make\ > .version \ > $(NULL) > Acked-by: Edu

Re: [Spice-devel] [PATCH spice-common] build: Remove unused git-version-gen file

2019-05-29 Thread Eduardo Lima (Etrunko)
ot;$v" | sed 's/-/./;s/\(.*\)-g/\1-/'`; > -else > -v=UNKNOWN > -fi > - > -v=`echo "$v" |sed 's/^v//'` > - > -# Don't declare a version "dirty" merely because a time stamp has changed. > -git update-index --refresh > /

Re: [Spice-devel] [PATCH spice-common] meson: Remove "install" argument from configure_file

2019-08-28 Thread Eduardo Lima (Etrunko)
utput : 'config.h', > - install : false, > configuration : spice_common_config_data) > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___

Re: [Spice-devel] [PATCH spice-server 2/2] meson: Remove a warning in spice-common

2019-08-29 Thread Eduardo Lima (Etrunko)
- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/subprojects/spice-common b/subprojects/spice-common > index ff2e99d89..4727c19d3 16 > --- a/subprojects/spice-common > +++ b/subprojects/spice-common > @@ -1 +1 @@ > -Subproject commit ff2e99d8932db6b30b

Re: [Spice-devel] [PATCH spice-gtk] build: Fix compatibility with Meson 0.49

2019-08-29 Thread Eduardo Lima (Etrunko)
cfa711..4727c19d 16 > --- a/subprojects/spice-common > +++ b/subprojects/spice-common > @@ -1 +1 @@ > -Subproject commit 5bcfa711d90839c7c4c50310db67f0d5912a3824 > +Subproject commit 4727c19d36b33071928500adaa832ecef6bdd942 > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-server] meson: Fix compatibility with Meson 0.48

2019-08-30 Thread Eduardo Lima (Etrunko)
c0..35ebf3833 100644 > --- a/meson.build > +++ b/meson.build > @@ -211,7 +211,6 @@ if host_machine.system() == 'windows' > endif > > configure_file(output : 'config.h', > - install : false, > configuration : spice_s

Re: [Spice-devel] [spice-gtk v1 5/6] spice-gstaudio: fix GTask leak on query for volume

2019-09-04 Thread Eduardo Lima (Etrunko)
,6 +680,7 @@ static void > spice_gstaudio_get_record_volume_info_async(SpiceAudio *audio, > GTask *task = g_task_new(audio, cancellable, callback, user_data); > > g_task_return_boolean(task, TRUE); > +g_object_unref(task);

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-16 Thread Eduardo Lima (Etrunko)
On 10/14/19 10:18 AM, Frediano Ziglio wrote: Hi, On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: This series is part from a former series. There's an initial import commit to better understand the changes. It contains some work from Eduardo for MingW packaging. Final patches a

Re: [Spice-devel] [PATCH spice-protocol 3/5] build-sys: Allows spec file to build MingW packages

2019-10-21 Thread Eduardo Lima (Etrunko)
On 10/11/19 6:56 AM, Frediano Ziglio wrote: Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 It's possible to disable MingW build using $ rpmbuild --without mingw -ta spice-protocol-.tar.bz2 This is base on some work by

Re: [Spice-devel] [PATCH spice-protocol v2 4/5] build-sys: Update URL in SPEC file

2019-10-22 Thread Eduardo Lima (Etrunko)
On 10/21/19 11:10 AM, Frediano Ziglio wrote: Use https instead of http, web server automatically redirects to secure version. Remove slash at the end, not needed. I think this can be squashed with the first patch in the series. Signed-off-by: Frediano Ziglio --- spice-protocol.spec.in | 4

Re: [Spice-devel] [PATCH spice-protocol v2 1/5] build-sys: Import spec file from Fedora

2019-10-22 Thread Eduardo Lima (Etrunko)
On 10/21/19 11:10 AM, Frediano Ziglio wrote: Will be used by next commits. Would you mind to provide a mode detailed commit message explaining the reason why we need the spec file in the repository? Signed-off-by: Frediano Ziglio --- spice-protocol.spec.in | 173

Re: [Spice-devel] [PATCH spice-protocol v4 1/5] build-sys: Import spec file from Fedora

2019-10-23 Thread Eduardo Lima (Etrunko)
any more with + recent rpm versions (F13+). + +* Fri Jul 9 2010 Gerd Hoffmann - 0.5.2-1 +- initial package. + Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing

Re: [Spice-devel] [PATCH spice-protocol v4 2/5] build-sys: Update URL in SPEC file

2019-10-23 Thread Eduardo Lima (Etrunko)
BuildArch: noarch %description Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org

Re: [Spice-devel] [PATCH spice-protocol v4 3/5] build-sys: Provide spec file during build

2019-10-23 Thread Eduardo Lima (Etrunko)
Summary:Spice protocol header files +Group: Development/Libraries # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ URL:https://www.spice-space.org Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Softwar

Re: [Spice-devel] [PATCH spice-protocol v4 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-23 Thread Eduardo Lima (Etrunko)
On 10/23/19 12:06 PM, Frediano Ziglio wrote: .pc files requires MingW version, not system one. I think it would be better if squashed into previous patch? This idea of building the mingw packages from the same source is nice, but it needs some more discussion. Lets keep this patch on hold fo

Re: [Spice-devel] Recent connection

2018-01-31 Thread Eduardo Lima (Etrunko)
On 31/01/18 06:05, arons wrote: > Hi, > I've recently installed spice viewer for windows version 6.0. > Everything works really well, I'm really happy about. > The only issue I have is that the "Recent connection" is not populated. > I need to fill the URL in connection address all the time. Can y

[Spice-devel] [PATCH spice-common] build: Remove FIXME_SERVER_SMARTCARD hack

2018-03-02 Thread Eduardo Lima (Etrunko)
->reader_name, in, reader_name__nelements); ^~ This second one is only a rename of 'reader_name' field to 'name', as specified in the VSCMsgReaderAdd structure in file vscard_common.h. Signed-off-by: Eduardo Lima (Etrunko) --- common/Makefile.am

Re: [Spice-devel] [PATCH spice-common] build: Remove FIXME_SERVER_SMARTCARD hack

2018-03-05 Thread Eduardo Lima (Etrunko)
On 05/03/18 08:03, Christophe Fergeau wrote: > On Fri, Mar 02, 2018 at 12:14:29PM -0300, Eduardo Lima (Etrunko) wrote: >> When we remove the hacks in configure.ac and common/Makefile.am, two >> errors pop out: >> >> generated_server_demarshallers.c: In function >>

Re: [Spice-devel] [PATCH spice-common] build: Remove FIXME_SERVER_SMARTCARD hack

2018-03-05 Thread Eduardo Lima (Etrunko)
On 05/03/18 11:19, Eduardo Lima (Etrunko) wrote: > On 05/03/18 08:03, Christophe Fergeau wrote: >> On Fri, Mar 02, 2018 at 12:14:29PM -0300, Eduardo Lima (Etrunko) wrote: >>> When we remove the hacks in configure.ac and common/Makefile.am, two

[Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-06 Thread Eduardo Lima (Etrunko)
ttp://mesonbuild.com/Gnome-module.html#gnomemkenums Signed-off-by: Eduardo Lima (Etrunko) --- server/Makefile.am | 12 ++-- .../{spice-server-enums.tmpl.c => spice-server-enums.c.tmpl} | 0 .../{spice-server-enums.tmpl.h => spice-server-e

Re: [Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-06 Thread Eduardo Lima (Etrunko)
On 06/03/18 13:37, Christophe Fergeau wrote: > On Tue, Mar 06, 2018 at 11:46:33AM -0300, Eduardo Lima (Etrunko) wrote: >> This is a preparation for meson build, which has built-in support for >> generating enums, but requires the template files to be renamed. It uses >> the

Re: [Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-07 Thread Eduardo Lima (Etrunko)
On 07/03/18 06:19, Christophe Fergeau wrote: > Hey, > > On Tue, Mar 06, 2018 at 03:00:30PM -0300, Eduardo Lima (Etrunko) wrote: >> On 06/03/18 13:37, Christophe Fergeau wrote: >>> On Tue, Mar 06, 2018 at 11:46:33AM -0300, Eduardo Lima (Etrunko) wrote: >>>> T

[Spice-devel] [PATCH spice-server 2/2] Rename stream-device.[ch] to red-stream-device.[ch]

2018-03-12 Thread Eduardo Lima (Etrunko)
In order to avoid confusion with file named stream-device.h, from spice-protocol. Signed-off-by: Eduardo Lima (Etrunko) --- server/Makefile.am | 4 ++-- server/{stream-device.c => red-stream-device.c} | 4 +--- server/{stream-device.h => red-stream-device.

[Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

2018-03-12 Thread Eduardo Lima (Etrunko)
This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code. Signed-off-by: Eduardo Lima (Etrunko) --- server/display-channel.c | 4 +++- server/reds.c| 6 +++--- server/stream-device.c | 22 +++--- 3 files

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

2018-03-13 Thread Eduardo Lima (Etrunko)
? If the latter, I think it would be better to keep a static variable and change its value according to the define. Regards, Eduardo. > > Frediano > >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> server/display-channel.c | 4 +++- >> s

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

2018-03-15 Thread Eduardo Lima (Etrunko)
On 15/03/18 08:19, Uri Lublin wrote: > On 03/13/2018 03:37 PM, Eduardo Lima (Etrunko) wrote: >> On 13/03/18 04:21, Frediano Ziglio wrote: >>>> >>>> This patch makes it clear that this is a configure switch and not a >>>> variable defined somewhe

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

2018-03-15 Thread Eduardo Lima (Etrunko)
On 15/03/18 14:20, Christophe Fergeau wrote: > On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: >> On 13/03/18 04:21, Frediano Ziglio wrote: >>>> >>>> This patch makes it clear that this is a configure switch and not a >>>>

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

2018-03-19 Thread Eduardo Lima (Etrunko)
On 19/03/18 06:28, Frediano Ziglio wrote: >> >> On 15/03/18 14:20, Christophe Fergeau wrote: >>> On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: >>>> On 13/03/18 04:21, Frediano Ziglio wrote: >>>>>> >>>>>>

Re: [Spice-devel] [PATCH spice-server 2/2] Use --enable-extra-checks option provided by spice-common

2018-03-19 Thread Eduardo Lima (Etrunko)
Acked-by: Eduardo Lima (Etrunko) On 19/03/18 10:46, Frediano Ziglio wrote: > Reuse option from common code. > Also reuse spice_extra_checks constant instead of using the preprocessor > macro directly. > > Signed-off-by: Frediano Ziglio > --- > configure

Re: [Spice-devel] [PATCH spice-common 1/2] Add --enable-extra-checks option

2018-03-19 Thread Eduardo Lima (Etrunko)
Acked-by: Eduardo Lima (Etrunko) On 19/03/18 10:46, Frediano Ziglio wrote: > Allow to enable code to do additional or expensive checks. > The option should be used by higher level libraries. > By default the option is disabled. > > Signed-off-by: Frediano Ziglio > --- >

  1   2   3   4   5   >