On Mon, Jan 18, 2016 at 02:07:49PM +0100, Fabiano Fidêncio wrote:
> On Mon, Dec 21, 2015 at 4:54 PM, Marc-André Lureau
> wrote:
> > Hi,
> >
> > With virt-viewer now dropping gtk 2.0, I don't know anyone left using
> > the spice-gtk with gtk+ 2.0. Thus I'd like to propose that the next
> > spice-gt
On Thu, Feb 04, 2016 at 04:03:10PM +, Frediano Ziglio wrote:
> Make version_string a constant.
> Also there is no need to have a pointer but declare the buffer as static
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote:
> A patch of this size cannot be accepted, no matter how good it is.
> We need to find a way to split it.
>
> Any proposal would be good.
There's some simple things which could be done ahead of the main conversion
to GObject.
- AP
On Thu, Jan 11, 2018 at 08:10:39AM -0500, Frediano Ziglio wrote:
> >
> > Hi
> >
> > - Original Message -
> > > On Tue, Jan 09, 2018 at 12:16:33PM -0500, Marc-André Lureau wrote:
> > > > I think it's problematic for traditional applications as well.
> > > > clipboard access is probably goi
On Fri, May 20, 2016 at 06:44:01AM -0400, Frediano Ziglio wrote:
> Hi,
> I'd like to have some standard on the internal documentation of
> spice-server.
>
> The current situation is quite messy having different styles.
> I think the worst think is not having any documentation, so better messy
>
On Fri, Jun 03, 2016 at 12:00:24PM +0100, Frediano Ziglio wrote:
> g_object_new is a variadic function which take property values.
> As compiler cannot check if these property values are correct
> make sure they are using casts.
> This actully fix a crash in reds.c for 32 bit architectures.
>
> Si
On Fri, Jun 03, 2016 at 07:16:57AM -0400, Frediano Ziglio wrote:
> > > diff --git a/server/spicevmc.c b/server/spicevmc.c
> > > index b662d94..a863e39 100644
> > > --- a/server/spicevmc.c
> > > +++ b/server/spicevmc.c
> > > @@ -580,8 +580,8 @@ red_char_device_spicevmc_new(SpiceCharDeviceInstance
>
On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from
> > him:
> >
> > "I'd really like to find a way to do it with pure SASL properties so that
> > the
> > code wo
On Mon, Jun 06, 2016 at 04:34:09PM +0300, Alexander Bokovoy wrote:
> On Mon, 06 Jun 2016, Daniel P. Berrange wrote:
> > On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > - Original Message -
> > > > I&#x
On Mon, Jun 06, 2016 at 01:14:21PM -0600, Garret Acott wrote:
> Anybody know how to reach the https://www.virt-manager.org guys? The site is
> down with a DB error. Or do you have an alternative place to download those
> files from? Looking for the virt-viewer for windows in particular.
Hmm, it wa
On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote:
>
> The following patch broke compilation of xf86-video-qxl:
>
> commit b41220b1441b8adea6db9a98e9da1b43a8f426bb
> Author: Christophe Fergeau
> Date: Thu Mar 5 15:28:22 2015 +0100
>
> Mark unused public API methods/code as d
On Tue, Aug 16, 2016 at 03:58:50PM +0300, Sameeh Jubran wrote:
> This patch defines the structures of ioctls that are used between
> win-vdagent and the qxl-wddm-dod driver.
>
> Signed-off-by: Sameeh Jubran
> ---
> spice/qxl_windows.h | 15 +++
> 1 file changed, 11 insertions(+), 4 d
On Fri, Sep 30, 2016 at 05:13:44PM +0200, Fabiano Fidêncio wrote:
> On Fri, Sep 30, 2016 at 1:48 PM, Victor Toso wrote:
> > Hi again!
> >
> > On Wed, Jun 22, 2016 at 04:48:39PM +0200, Victor Toso wrote:
> >> Hi all,
> >>
> >> I created a spice group in gitlab [0] mirroring the repository from
> >>
On Wed, Nov 09, 2016 at 10:32:40AM +, Frediano Ziglio wrote:
> CxImage is used for image conversion for clipboard support.
> CxImage have currently some issue:
> - library is old and unsupported;
> - required an old libpng library.
> Currently the MingW binary we distribute due to some
> issue
When used with QEMU at least, both SPICE and VNC live in the same port
range (5900+). It is thus not entirely uncommon for a user to mistakenly
connect to a SPICE server with a VNC client, or vica-verca.
When connecting to VNC server with a SPICE client, you quickly get an
error. This is because t
On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote:
> >
> > When used with QEMU at least, both SPICE and VNC live in the same port
> > range (5900+). It is thus not entirely uncommon for a user to mistakenly
> > connect to a SPICE server with a VNC client, or vica-verca.
> >
> > When
On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote:
> > > >
> > > > When used with QEMU at least, both SPICE and VNC live in the same port
> > > > range (5900+). It is thus not entirely uncommon for a user to mi
On Wed, Jan 25, 2017 at 05:59:44PM +, Daniel P. Berrange wrote:
> On Wed, Jan 25, 2017 at 12:38:09PM -0500, Frediano Ziglio wrote:
> > >
> > > On Wed, Jan 25, 2017 at 12:23:35PM -0500, Frediano Ziglio wrote:
> > > > >
> > > > > When used
The spice_auto.html file allows websockify path to be set via a
query parameter, but the standard spice.html does not provide
any mechanism for this. Add another form input field to allow
it to be set, defaulting to /websockify
Signed-off-by: Daniel P. Berrange
---
spice.html | 9 -
1
On Tue, Feb 14, 2017 at 08:33:09AM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > >
> > > Allow easier processing by scripts and csv editors
> > > ---
> > > Also it renders nicely on github
> > > https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > > From
Signed-off-by: Daniel P. Berrange
---
.gitmodules | 3 +
configure.ac | 11 --
src/Makefile.am | 30 ++--
src/keycodemapdb | 1 +
src/keymap-gen.pl | 214 ---
src/keymaps.csv | 511 --
6 files changed
On Wed, Feb 15, 2017 at 04:44:22PM +0100, Pavel Grunt wrote:
> nice, although the python script looks pretty heavy.
Different users of the keymap database have different output formats.
We don't want ever user re-implementing the same logic, as that's
just as bad what we have today. So the tool is
On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote:
> Hi,
> question was raised recently on the ML and IRC.
>
> Some time ago we decided to use gboolean but some of us would like
> to discuss again.
>
> As any style changes there's no right or wrong, mainly personal
> opinions but
Signed-off-by: Daniel P. Berrange
---
Changed in v2:
- Newer submodule hash to pull in python 3 portability fixes
.gitmodules | 3 +
configure.ac | 11 --
src/Makefile.am | 30 ++--
src/keycodemapdb | 1 +
src/keymap-gen.pl | 214 ---
src/keymaps.csv
On Mon, Feb 20, 2017 at 12:44:52PM +0100, Victor Toso wrote:
> Hi,
>
> On Fri, Feb 17, 2017 at 11:24:55AM +0100, Pavel Grunt wrote:
> > GtkVBox is deprecated since Gtk 3.2, GtkBox is going to be
> > deprecated. Just use the GtkGrid and GtkContainer api.
>
> Sure
>
> > ---
> > GtkContainer is an
On Wed, Feb 22, 2017 at 11:47:10AM +0100, Christophe Fergeau wrote:
> On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote:
> > Hi,
> >
> >
> > On 02/21/2017 06:37 PM, Christophe Fergeau wrote:
> > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote:
> > > > Remove handling w
Consume the keymaps.csv file from a git submodule instead of having
a private copy. This makes it easier to ensure all users of the keymap
(libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent
set of data.
Signed-off-by: Daniel P. Berrange
---
Changed in v3:
- Fix makefile
On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> Hello Daniel,
>
> On Mon, 2017-02-27 at 10:25 +0000, Daniel P. Berrange wrote:
> > Consume the keymaps.csv file from a git submodule instead of having
> > a private copy. This makes it easier to ensure all us
On Mon, Feb 27, 2017 at 12:44:27PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 27, 2017 at 06:39:14AM -0500, Frediano Ziglio wrote:
> > >
> > > On Wed, Feb 15, 2017 at 11:24:37AM -0500, Frediano Ziglio wrote:
> > > > >
> > > > >
> > > > > > On 15 Feb 2017, at 12:45, Frediano Ziglio
> > > >
A long while back, Pavel learnt that under XWayland we needed to
use XkbGetMap instead of XkbGetKeyboard:
commit 95e322a6bbc29dc9c28724fb80706464e276b89f
Author: Pavel Grunt
Date: Fri Feb 20 16:19:50 2015 +0100
vncdisplaykeymap: Use XkbGetMap and XkbGetNames instead of XkbGetKeyboard
On Mon, Feb 27, 2017 at 02:24:16PM +0100, Pavel Grunt wrote:
> On Mon, 2017-02-27 at 13:13 +0000, Daniel P. Berrange wrote:
> > A long while back, Pavel learnt that under XWayland we needed to
> > use XkbGetMap instead of XkbGetKeyboard:
> >
> > commit 95e322a6bbc29
On Mon, Feb 27, 2017 at 02:37:37PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 27, 2017 at 01:13:25PM +0000, Daniel P. Berrange wrote:
> > A long while back, Pavel learnt that under XWayland we needed to
> > use XkbGetMap instead of XkbGetKeyboard:
&g
t; +++ b/AUTHORS
> @@ -28,6 +28,7 @@ Patches also contributed by
> 소병철
> Cédric Bosdonnat
> Christian Ruppert
> +Christophe de Dinechin
> Cole Robinson
> Daniel P. Berrange
> Dan Kenigsberg
FWIW, git can trivially auto-fill an AUTHORS fi
On Thu, Mar 02, 2017 at 08:16:15AM +0100, Pavel Grunt wrote:
> On Thu, 2017-03-02 at 07:59 +0100, Pavel Grunt wrote:
> > On Mon, 2017-02-27 at 10:44 +0000, Daniel P. Berrange wrote:
> > > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > > > Hello D
Consume the keymaps.csv file from a git submodule instead of having
a private copy. This makes it easier to ensure all users of the keymap
(libvirt, gtk-vnc, spice-gtk, and eventually QEMU) to have a consistent
set of data.
Signed-off-by: Daniel P. Berrange
---
Changed in v4:
- Use correct
On Thu, Mar 02, 2017 at 07:59:42AM +0100, Pavel Grunt wrote:
> On Mon, 2017-02-27 at 10:44 +0000, Daniel P. Berrange wrote:
> > On Mon, Feb 27, 2017 at 11:37:44AM +0100, Pavel Grunt wrote:
> > > Hello Daniel,
> > >
> > > On Mon, 2017-02-27 at 10:25 +, Danie
On Fri, Mar 10, 2017 at 12:29:55PM +0100, Christophe Fergeau wrote:
> It's no longer used since commit e271222e "Switch over to using
> keycodemapdb submodule"
> ---
> README | 2 +-
> src/Makefile.am | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
ACK
> diff --git a/README b/
On Fri, Mar 10, 2017 at 01:16:37PM +0100, Christophe Fergeau wrote:
> This fixes make distcheck
> ---
> This applies on top of the make check-valgrind patch I sent earlier, I can
> rebase on top of git master if needed
>
> Christophe
>
> server/tests/Makefile.am | 7 ++-
> 1 file changed, 6
On Fri, Apr 28, 2017 at 07:48:01AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS
> > (deprecated)
> >
>
> It's also deprecated on Linux afaik, but it's still the preferred way in qemu
> too.
>
> An
On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 74b5811..ecab365 10
On Thu, May 11, 2017 at 07:08:13AM -0400, Frediano Ziglio wrote:
> >
> > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote:
> > > From: Christophe de Dinechin
> > >
> > > Signed-off-by: Christophe de Dinechin
> > > ---
> > > configure.ac | 14 ++
> > > 1 file c
On Wed, May 17, 2017 at 07:08:26AM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac| 3 ++-
> src/channel-cursor.c| 6 +++---
> src/channel-display-mjpeg.c | 2 +-
> src/continuation.h
On Wed, May 17, 2017 at 07:08:25AM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> configure.ac | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 74b5811..ecab365 10
On Fri, Jul 07, 2017 at 04:26:33PM +0200, Pavel Grunt wrote:
> Silence -Wmissing-field-initializers warnings.
This doesn't make sense for many of these cases you've changed
> diff --git a/src/channel-main.c b/src/channel-main.c
> index 4edd575..104b18a 100644
> --- a/src/channel-main.c
> +++ b/sr
On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote:
> On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote:
> > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote:
> > > Not really familiar with GitLab merge requests but on GitHub they
> > > remain open till clos
On Wed, Sep 27, 2017 at 06:23:36AM -0400, Frediano Ziglio wrote:
> >
> > This is required for the following GMainLoop integration,
> > which utilizes some of the new functions/definitions, namely:
> >
> > [definition][GLib version]
> > g_clear_pointer() 2.34
> > G_SOURCE_REMOVE 2.32
> > G_S
On Thu, Oct 19, 2017 at 07:47:24AM -0400, Frediano Ziglio wrote:
> > > On 19 Oct 2017, at 12:32, Frediano Ziglio < fzig...@redhat.com > wrote:
> >
>
> > > > From: Christophe de Dinechin < dinec...@redhat.com >
> > >
> >
>
> > > > This is useful for some instrumentation, e.g. the leaks tracer,
On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote:
> >
> >
> > In fact non-trivial shared libraries should generally never be unloaded,
> > even
> > if they were originally dlopend. If the library has used a pthread local
> > with
> > a destructor function, then unloading the libr
On Thu, Oct 19, 2017 at 08:53:08AM -0400, Frediano Ziglio wrote:
> >
> > On Thu, Oct 19, 2017 at 08:03:00AM -0400, Frediano Ziglio wrote:
> > > >
> > > >
> > > > In fact non-trivial shared libraries should generally never be unloaded,
> > > > even
> > > > if they were originally dlopend. If the
On Thu, Oct 19, 2017 at 03:01:17PM +0200, Christophe de Dinechin wrote:
> > One reason is that you may use a library dynamically, and you may dlclose()
> > it, and then atexit() will likely crash.
>
> Is that a real or theoretical scenario? Who loads this library dynamically
> currently?
Anyone
On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> It needs the corresponding library to be installed, as well as
> pkg-config since it installs a .pc file.
> ---
> Since the plugins are going to be dlopened, and since the main package
> does not ship a .so we need to link to, I'
On Wed, Nov 22, 2017 at 11:54:10AM +, Frediano Ziglio wrote:
> Allows to specify abstract Unix sockets addresses.
> These Unix sockets are supported on Linux and allows to not
> have file system names.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 3 +++
> 1 file changed, 3 inse
On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
> On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau
> wrote:
>
> > On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
> > > Quoting GNU maintainer manual:
> > > https://www.gnu.org/prep/maintain/html_node/Copyrig
On Thu, Oct 30, 2014 at 02:55:05PM +0100, Christophe Fergeau wrote:
> On Thu, Oct 30, 2014 at 01:38:26PM +0000, Daniel P. Berrange wrote:
> > On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
> > > On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau
> > &g
On Mon, Dec 08, 2014 at 04:25:24PM +0100, Christophe Fergeau wrote:
> On Mon, Dec 08, 2014 at 03:37:32PM +0100, Marc-André Lureau wrote:
> > So much of this is quite irrelevant to the discussion at hand about
> > unreviewed commit rule.
>
> I know this is about a lot of stuff, libvirt HACKING fine
On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote:
> On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote:
> > I saw some comments about MSVC in spice-gtk, and I thought someone could be
> > using it to build the Windows client. Anyway, I don't mind using one
> > solutio
On Wed, Feb 18, 2015 at 09:47:55AM -0500, Marc-André Lureau wrote:
>
>
> - Original Message -
> > From: "Daniel P. Berrange"
> >
> > Both Wayland and Xwayland use the evdev + 8 map for keycodes,
> > just as regular Xorg with evdev does
On Wed, Feb 18, 2015 at 09:59:05AM -0500, Marc-André Lureau wrote:
>
>
> - Original Message -
> > On Wed, Feb 18, 2015 at 09:47:55AM -0500, Marc-André Lureau wrote:
> > >
> > >
> > > ----- Original Message -
> > > > From: &
On Thu, Apr 16, 2015 at 12:30:27PM +0200, Marc-André Lureau wrote:
> I don't think there are valid reason to put fedora-specific spec file in
> upstream. You can easily build a rpm with fedpkg. nack
We've done this for years with all libvirt related packages and it
has proved pretty userful for bo
On Wed, Jun 03, 2015 at 04:22:35PM +0200, Cédric Bosdonnat wrote:
> Make sure that the password lenght is under the maximum lenght. If not
Nit-pick if you re-post, s/lenght/length/g or someone can fixup when
merging
> report it as an authentication failure with an adapted message.
> ---
> Diff
On Tue, Jun 09, 2015 at 09:49:44AM +0100, Frediano Ziglio wrote:
> This patch allow to limit number of heads using qxl driver. By default
> qxl driver is not limited on any kind on head use so can decide to use
> as much heads.
>
> libvirt has this as a video card parameter (actually set to 1 but
On Tue, Jun 30, 2015 at 04:44:10PM -0500, Jeremy White wrote:
> This module uses the usbredir protocol and user space tools,
> which are used by the SPICE project.
>
> Signed-off-by: Jeremy White
[snip]
> diff --git a/drivers/usb/usbredir/Kconfig b/drivers/usb/usbredir/Kconfig
> new file mode 1
On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote:
> On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote:
> >On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote:
> >>I spend all morning fixing this to be installed properly in the
> >>system. Anyway, I f
On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote:
> On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote:
> >On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote:
> >>On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote:
&
On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote:
> On 07/21/2015 09:41 AM, Daniel P. Berrange wrote:
> > On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote:
> >> On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote:
> >>> On T
On Wed, Jul 22, 2015 at 09:59:00AM +0200, Martin Kletzander wrote:
> On Tue, Jul 21, 2015 at 04:36:45PM +0100, Daniel P. Berrange wrote:
> >On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote:
> >>On 07/21/2015 09:41 AM, Daniel P. Berrange wrote:
> >>> On T
On Mon, Sep 07, 2015 at 06:55:47PM +0200, Lukas Venhoda wrote:
> Add inet_pton and inet_ntop which supports IPv6 address.
> inet_aton left for compatibility.
You really should not use any of the inet_* functions,
even the ones which technically support IPv6.
Instead use getaddrinfo()/getnameinfo(
On Thu, Aug 25, 2011 at 02:13:01PM +0300, Yonit Halperin wrote:
> On 08/25/2011 01:53 PM, Gerd Hoffmann wrote:
> >I've played with a approach simliar to (2) long ago. Actually did it by
> >registering a "live" migration handler. Didn't work that well too.
> >spice client will stay connected to bo
QEMU has a monitor command 'add_client' which can be used over
a UNIX domain socket connection with SCM_RIGHTS, to pass a
pre-opened client socket connection FD for graphics displays.
This series adds two new APIs for libspice-server.so which
enable QEMU to wire up this monitor command for SPICE, a
From: "Daniel P. Berrange"
Neither reds_accept_connection or reds_accept are very long,
so the split is pointless & increases code size for no gain.
Merge them together to reduce code size
* server/reds.c: Merge reds_accept_connection into reds_accept
Signed-off-by: Dani
From: "Daniel P. Berrange"
Remove the accept() call from __reds_accept_connection and
rename it to reds_init_client_connection. The caller is now
responsible for accepting the new socket. The method
reds_init_client_connection merely initializes it for
usage.
* server/r
From: "Daniel P. Berrange"
To allow setup of an SSL client, from a passed in client
socket, move all the SSL client initialization code out
of reds_accept_ssl_connection and into a new method called
reds_init_client_ssl_connection
* server/reds.c: Introduce reds_init_client_ssl_
From: "Daniel P. Berrange"
Allow applications to pass a pre-accepted client socket file
descriptor in. The new APIs are spice_server_add_ssl_client
and spice_server_add_client
* server/reds.c: Implement new APIs
* server/spice.h: Define new APIs
Signed-off-by: Daniel P. Berrange
-
From: "Daniel P. Berrange"
When an applications passes in a pre-accepted socket for a
client, they may well have already performed suitable authentication
out of band. They should thus have the option to request that any
spice authentication is skipped.
* server/reds.c, spice.h: Ad
From: "Daniel P. Berrange"
If setting the TCP_NODELAY socket option fails with ENOTSUP,
then don't treat this is a fatal error. SPICE is likely just
running over a UNIX socket instead.
* server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails
Signed-off-by: Daniel P. Berran
From: "Daniel P. Berrange"
With the proposal of some new APIs[1] to libspice-server.so it
is possible to add support for SPICE to the 'add_client'
monitor command, bringing parity with VNC. Since SPICE can
use TLS or plain connections, the command also gains a new
'
In testing my patches for 'add_client' support with SPICE, I noticed
deadlock in the QEMU/SPICE code. It only happens if I close a SPICE
client and then immediately reconnect within about 1 second. If I
wait a couple of seconds before reconnecting the SPICE client I don't
see the deadlock.
I'm usi
On Sun, Oct 23, 2011 at 10:32:10AM +0200, Alon Levy wrote:
> On Fri, Oct 21, 2011 at 04:10:58PM +0100, Daniel P. Berrange wrote:
> > QEMU has a monitor command 'add_client' which can be used over
> > a UNIX domain socket connection with SCM_RIGHTS, to pass a
> > pre-
On Sun, Oct 23, 2011 at 09:37:59AM +0200, Yonit Halperin wrote:
> Hi,
>
> Sounds like https://bugzilla.redhat.com/show_bug.cgi?id=746950 and
> https://bugs.freedesktop.org/show_bug.cgi?id=41858
> Alon's patch:
> http://lists.freedesktop.org/archives/spice-devel/2011-September
> /005369.html
> Shou
On Wed, Oct 26, 2011 at 03:29:55PM +0200, Marc-André Lureau wrote:
> Hi
>
> I would move the cb intialization in reds_init_client_connection () to
> avoid duplication:
>
> stream = link->stream;
> stream->read = stream_read_cb;
> stream->write = stream_write_cb;
> stream->writev =
An update to:
http://lists.freedesktop.org/archives/spice-devel/2011-October/005834.html
QEMU has a monitor command 'add_client' which can be used over
a UNIX domain socket connection with SCM_RIGHTS, to pass a
pre-opened client socket connection FD for graphics displays.
This series adds two n
From: "Daniel P. Berrange"
Neither reds_accept_connection or reds_accept are very long,
so the split is pointless & increases code size for no gain.
Merge them together to reduce code size
* server/reds.c: Merge reds_accept_connection into reds_accept
Signed-off-by: Dani
From: "Daniel P. Berrange"
Remove the accept() call from __reds_accept_connection and
rename it to reds_init_client_connection. The caller is now
responsible for accepting the new socket. The method
reds_init_client_connection merely initializes it for
usage.
* server/r
From: "Daniel P. Berrange"
To allow setup of an SSL client, from a passed in client
socket, move all the SSL client initialization code out
of reds_accept_ssl_connection and into a new method called
reds_init_client_ssl_connection
* server/reds.c: Introduce reds_init_client_ssl_
From: "Daniel P. Berrange"
Allow applications to pass a pre-accepted client socket file
descriptor in. The new APIs are spice_server_add_ssl_client
and spice_server_add_client
* server/reds.c: Implement new APIs
* server/spice.h: Define new APIs
Signed-off-by: Daniel P. Berrange
-
From: "Daniel P. Berrange"
When an applications passes in a pre-accepted socket for a
client, they may well have already performed suitable authentication
out of band. They should thus have the option to request that any
spice authentication is skipped.
* server/reds.c, spice.h: Ad
From: "Daniel P. Berrange"
If setting the TCP_NODELAY socket option fails with ENOTSUP,
then don't treat this is a fatal error. SPICE is likely just
running over a UNIX socket instead.
* server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails
Signed-off-by: Daniel P. Berran
On Fri, Oct 28, 2011 at 03:03:57PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > diff --git a/server/spice-server.syms b/server/spice-server.syms
> > index f1374bd..c34ff86 100644
> > --- a/server/spice-server.syms
> > +++ b/server/spice-server.syms
> > @@ -89,5 +89,7 @@ global:
> > spice_server_
FYI, I have just gone through and deleted about 200 spam pages from
the wiki.
As an anti-spam meansure, all users on the wiki must confirm their
email address before they will be allowed to make further edits.
This can be done from the user preferences page after logging in,
or just try to edit a
On Thu, Nov 24, 2011 at 02:43:52PM +0200, Alon Levy wrote:
> Hi,
>
> I want to finally have some work on the odt manuals we currently have,
> if only to mark stuff as "obsolete / not up to date" and fix simple to
> fix things (like mentioning vdagent now supports Linux/Win7/Win2008).
>
> But
On Thu, Nov 24, 2011 at 05:12:30PM +0200, Alon Levy wrote:
> On Thu, Nov 24, 2011 at 01:15:48PM +0000, Daniel P. Berrange wrote:
> > On Thu, Nov 24, 2011 at 02:43:52PM +0200, Alon Levy wrote:
> > > Hi,
> > >
> > > I want to finally have some work on the odt
An update to:
v2: http://lists.freedesktop.org/archives/spice-devel/2011-October/005881.html
v1: http://lists.freedesktop.org/archives/spice-devel/2011-October/005834.html
QEMU has a monitor command 'add_client' which can be used over
a UNIX domain socket connection with SCM_RIGHTS, to pass a
p
From: "Daniel P. Berrange"
Neither reds_accept_connection or reds_accept are very long,
so the split is pointless & increases code size for no gain.
Merge them together to reduce code size
* server/reds.c: Merge reds_accept_connection into reds_accept
Signed-off-by: Dani
From: "Daniel P. Berrange"
Remove the accept() call from __reds_accept_connection and
rename it to reds_init_client_connection. The caller is now
responsible for accepting the new socket. The method
reds_init_client_connection merely initializes it for
usage.
* server/r
From: "Daniel P. Berrange"
To allow setup of an SSL client, from a passed in client
socket, move all the SSL client initialization code out
of reds_accept_ssl_connection and into a new method called
reds_init_client_ssl_connection
* server/reds.c: Introduce reds_init_client_ssl_
From: "Daniel P. Berrange"
Allow applications to pass a pre-accepted client socket file
descriptor in. The new APIs are spice_server_add_ssl_client
and spice_server_add_client
* server/reds.c: Implement new APIs
* server/spice.h: Define new APIs
Signed-off-by: Daniel P. Berrange
-
From: "Daniel P. Berrange"
When an applications passes in a pre-accepted socket for a
client, they may well have already performed suitable authentication
out of band. They should thus have the option to request that any
spice authentication is skipped.
* server/reds.c, spice.h: Ad
From: "Daniel P. Berrange"
If setting the TCP_NODELAY socket option fails with ENOTSUP,
then don't treat this is a fatal error. SPICE is likely just
running over a UNIX socket instead.
* server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails
Signed-off-by: Daniel P. Berran
On Mon, Dec 12, 2011 at 11:56:51AM -0500, Marc-André Lureau wrote:
> Hi Daniel
>
> - Mensaje original -
> > An update to:
> >
> > v2:
> > http://lists.freedesktop.org/archives/spice-devel/2011-October/005881.html
> > v1:
> > http://lists.freedesktop.org/archives/spice-devel/2011-Octob
On Wed, Dec 14, 2011 at 09:02:52AM -0700, Bruce Rogers wrote:
> When trying to submit a spice package to openSUSE,
> our licensing team noticed that the file server/red_parse_qxl.h
> is GPL-2.0+. This seems like an oversight, particularly as the
> corresponding red_parse_qxl.c file right next to th
1 - 100 of 276 matches
Mail list logo
