[Spice-devel] [PATCH 17/30] Convert draw_blackness/whiteness/invers to using pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 77 ++-- 1 files changed, 61 insertions(+), 16 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 71dfae5..209869f 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1991,30 +1991,

[Spice-devel] [PATCH 18/30] Convert cairo canvas draw_rop3 to using pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 69 1 files changed, 29 insertions(+), 40 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 209869f..be9d3d8 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -811,7 +811,8 @

[Spice-devel] [PATCH 20/30] Convert cairo canvas to use pixman for draw_stroke

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 559 ++--- common/canvas_base.c | 11 + 2 files changed, 357 insertions(+), 213 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index e149b7d..0335aeb 100644 --- a/common/cairo_canvas.c +++ b/commo

[Spice-devel] [PATCH 19/30] Convert cairo canvas draw_transparent to use pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 254 ++--- 1 files changed, 135 insertions(+), 119 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index be9d3d8..e149b7d 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1433,6 +143

[Spice-devel] [PATCH 22/30] Convert cairo canvas read_bits() to pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 0b6f9ff..198785e 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1947,18 +1947,17 @@ void canvas_draw_stroke(CairoCanv

[Spice-devel] [PATCH 23/30] Convert cairo canvas group_start/end to pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 32 ++-- 1 files changed, 18 insertions(+), 14 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 198785e..73bd054 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1966,26 +1966,30 @@ void canva

[Spice-devel] [PATCH 24/30] Convert cairo canvas clear() to pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 73bd054..60fe2f4 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1994,14 +1994,11 @@ void canvas_group_end(CairoCanv

[Spice-devel] [PATCH 25/30] Replace custom region implementation with pixman_region32_t

2010-02-18 Thread Alexander Larsson
pixman_region32_t is an efficient well tested region implementation (its the one used in X) that we already depend on via pixman and use in some places. No need to have a custom region implementation. --- client/application.cpp | 20 +- client/canvas.h |3 +- client/cursor_c

[Spice-devel] [PATCH 27/30] Remove cairo_t from cairo canvas

2010-02-18 Thread Alexander Larsson
--- client/red_cairo_canvas.cpp | 23 --- common/cairo_canvas.c | 16 common/cairo_canvas.h | 10 -- common/canvas_base.c| 41 - server/red_worker.c | 34 -

[Spice-devel] [PATCH 26/30] Covert cairo canvas put_image() to pixman

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 119 +++- 1 files changed, 37 insertions(+), 82 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 9e61a4f..46956aa 100644 --- a/common/cairo_canvas.c +++ b/common/cairo_canvas.c @@ -1051,106 +1051

[Spice-devel] [PATCH 28/30] Remove last cairo use from canvas_base

2010-02-18 Thread Alexander Larsson
--- common/canvas_base.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 409712e..f0d0840 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -17,7 +17,6 @@ */ #include -#include #include #include #

[Spice-devel] [PATCH 29/30] Remove no longer needed CAIRO_CANVAS_CACH_IS_SHARED define and code

2010-02-18 Thread Alexander Larsson
--- client/application.cpp |8 client/windows/redc.vcproj |4 ++-- client/x11/Makefile.am |1 - 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 0fa25b4..73a3461 100644 --- a/client/application.cpp ++

[Spice-devel] [PATCH 30/30] Require cairo instead of qcairo, only use pixman in server

2010-02-18 Thread Alexander Larsson
--- client/x11/Makefile.am |4 ++-- configure.ac | 17 +++-- server/Makefile.am |4 ++-- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/client/x11/Makefile.am b/client/x11/Makefile.am index d645c38..b34b963 100644 --- a/client/x11/Makefile.am +

[Spice-devel] [PATCH 21/30] Remove unused cairo helper functions

2010-02-18 Thread Alexander Larsson
--- common/cairo_canvas.c | 455 - common/canvas_base.c | 39 - 2 files changed, 0 insertions(+), 494 deletions(-) diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c index 0335aeb..0b6f9ff 100644 --- a/common/cairo_canvas.c +++ b/com

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
pixman_utils.c. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a lounge-singing voodoo cop on a mission from God. She's a pregnant cat-loving traffic cop from a secret island of

Re: [Spice-devel] [PATCH 25/30] Replace custom region implementation with pixman_region32_t

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:40 +0200, Izik Eidus wrote: > On Thu, 18 Feb 2010 21:58:51 +0100 Alexander Larsson wrote: > > red_display_send_upgrade(DisplayChannel *display_channel, UpgradeIte > > copy->base.box = qxl_drawable->bbox; > > copy->base.cli

Re: [Spice-devel] [PATCH 03/30] Add line rasterizer

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:43 +0200, Izik Eidus wrote: > On Thu, 18 Feb 2010 21:58:29 +0100 > Alexander Larsson wrote: > > > This is based on the X11 line drawers in mi/mizerline.c etc > > --- > > client/Makefile.am |1 + > > client/lines.cpp |

Re: [Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote: > On Thu, 18 Feb 2010 21:58:42 +0100 > Alexander Larsson wrote: > > > > + > > +if (mask) > > +pixman_image_unref (mask); > > > > Any strong feelings against changing it to > if (mask)

Re: [Spice-devel] [PATCH] spice-protocl: add SPICE_MSG_DISPLAY_SURFACE_CREATE/DESTROY

2010-02-19 Thread Alexander Larsson
surface to have a specific stride? What does the server care what the stride is on the client? Also, what happens if you create multiple PRIMARY surfaces? Is that how multi-monitor works? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] [PATCH] spice-protocl: add SPICE_MSG_DISPLAY_SURFACE_CREATE/DESTROY

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 16:49 +0200, Izik Eidus wrote: > On Fri, 19 Feb 2010 14:19:29 +0100 > Alexander Larsson wrote: > > > > enum { > > > -SPICE_MSG_DISPLAY_MODE = SPICE_MSG_FIRST_AVAIL, > > > -SPICE_MSG_DISPLAY_MARK, > > > +S

Re: [Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 17:04 +0200, Izik Eidus wrote: > On Fri, 19 Feb 2010 10:15:14 +0100 > Alexander Larsson wrote: > > > On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote: > > > On Thu, 18 Feb 2010 21:58:42 +0100 > > > Alexander Larsson wrote: > > &g

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
On Thu, 2010-02-18 at 21:58 +0100, Alexander Larsson wrote: > This series converts the software based canvas "cairo_canvas" to use > pixman for rendering instead of cairo. It uses the upstream pixman > (the latest version, 0.7.16 is needed) thus dropping the dependencies >

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 16:50 +0100, Alexander Larsson wrote: > On Thu, 2010-02-18 at 21:58 +0100, Alexander Larsson wrote: > > This series converts the software based canvas "cairo_canvas" to use > > pixman for rendering instead of cairo. It uses the upstream pixman > &

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-19 Thread Alexander Larsson
On Fri, 2010-02-19 at 16:52 +0100, Alexander Larsson wrote: > diff --git a/common/cairo_canvas.c b/common/cairo_canvas.c > index a6c82ee..8d549e6 100644 > --- a/common/cairo_canvas.c > +++ b/common/cairo_canvas.c > @@ -240,7 +240,7 @@ static void canvas_mask_pixman (CairoC

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-20 Thread Alexander Larsson
nvas.c from that last patch -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a one-legged pirate inventor with a mysterious suitcase handcuffed to his arm. She's a plucky bisexual opera singer fro

Re: [Spice-devel] [PATCH 11/30] Convert cairo canvas draw_opaque() to using pixman

2010-02-22 Thread Alexander Larsson
On Sun, 2010-02-21 at 10:37 +0100, Soeren Sandmann wrote: > Alexander Larsson writes: > > > +static void scale_image (CairoCanvas *canvas, > > + pixman_region32_t *region, > > + SPICE_ADDRESS src_bitmap, > > +

Re: [Spice-devel] [PATCH 14/30] Convert cairo canvas copy bits to pixman

2010-02-22 Thread Alexander Larsson
On Sun, 2010-02-21 at 10:46 +0100, Soeren Sandmann wrote: > Alexander Larsson writes: > > > --- > > common/cairo_canvas.c | 254 > - > > 1 files changed, 41 insertions(+), 213 deletions(-) > > > > diff

Re: [Spice-devel] [PATCH 25/30] Replace custom region implementation with pixman_region32_t

2010-02-22 Thread Alexander Larsson
On Mon, 2010-02-22 at 16:15 +0200, Yonit Halperin wrote: > On 02/18/2010 10:58 PM, Alexander Larsson wrote: > > +int region_test(const QRegion *rgn, const QRegion *other_rgn, int > query) > > { > > } > > > > > The new implementation is

Re: [Spice-devel] [PATCH 20/30] Convert cairo canvas to use pixman for draw_stroke

2010-02-23 Thread Alexander Larsson
On Sat, 2010-02-20 at 10:33 +0200, Izik Eidus wrote: > On Thu, 18 Feb 2010 21:58:46 +0100 > Alexander Larsson wrote: > > +if (pixman_region32_n_rects (&gc.dest_region) == 0 || > > +stroke->brush.type == SPICE_BRUSH_TYPE_NONE) { > > +touc

Re: [Spice-devel] [PATCH 00/30] Convert cairo canvas to use pixman

2010-02-23 Thread Alexander Larsson
On Sun, 2010-02-21 at 16:51 +0200, Izik Eidus wrote: > On Fri, 19 Feb 2010 16:52:36 +0100 > Alexander Larsson wrote: > > > +if (pixman_image_get_depth (src_surface) == 1) { > > +pixman_image_t *temp; > > + > > +temp = > > pixman_i

[Spice-devel] pixman branch landed

2010-02-23 Thread Alexander Larsson
I just landed the pixman series I posted last week. All the issues pointed out on the list are fixed, as are some other issues I found. We now require the very latest pixman since we use pixman_region32_init_from_image() instead of duplicating a lot of region code in spice. There is no release wit

[Spice-devel] Win32 fixes for pixman work

2010-02-26 Thread Alexander Larsson
hink we need to work on making the win32 build better. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an immortal alc

Re: [Spice-devel] Win32 fixes for pixman work

2010-03-01 Thread Alexander Larsson
On Mon, 2010-03-01 at 17:11 +0200, Izik Eidus wrote: > On 02/26/2010 11:54 AM, Alexander Larsson wrote: > > The attached patches makes spice build on win32 again. > > Can I commit them? > > > > > >

Re: [Spice-devel] Compile error on vdesktop

2010-03-02 Thread Alexander Larsson
e/linux/types.h:13: note: previous declaration of > 'dev_t' was > >>> here > >>> > >>> > >>> > >> What repo do you use? the git repo or 0.4? > >> > >> > > Alex could it be something that related to

Re: [Spice-devel] An overview of Network redirection in Spice

2010-03-03 Thread Alexander Larsson
list installed printers on windows). -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a bookish ninja senator in a wheelchair. She's a violent mutant detective from

Re: [Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-03-03 Thread Alexander Larsson
?id=2d203bc428c9006c47e3936cb6e3190e17d8431a -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an obese Catholic paramedic who must take medication to keep

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Alexander Larsson
On Sun, 2010-03-07 at 22:16 +0100, Stefan Zintgraf wrote: > Hi, > > i have two questions regarding SPICE. > > a) 32-bit support > I want to run a Windows guest on a 32-Bit Ubuntu system (version 9.10). The > client shall also run on the same (32-Bit) machine. According the FAQ (and my > exper

Re: [Spice-devel] SPICE questions

2010-03-08 Thread Alexander Larsson
On Mon, 2010-03-08 at 15:34 +0100, Stefan Zintgraf wrote: > Thanks for the answer. > > > > The faq says: I built Spice server on a 32-bit machine and it failed. > What can I do? > > I've read the FAQ but was not aware if it is impossible by design to > get everything running on a single 32 Bit

Re: [Spice-devel] [PATCH 0/8] Refactoring canvas code

2010-03-08 Thread Alexander Larsson
On Mon, 2010-03-08 at 18:33 +0100, al...@redhat.com wrote: > From: Alexander Larsson > > This is a series of patches that clean up the "public" canvas API > by hiding all the internals of the canvas implementation behind > a single SpiceCanvas type with multiple cons

[Spice-devel] New libspice api pushed

2010-03-09 Thread Alexander Larsson
. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a notorious flyboy dwarf on the edge. She's a radical impetuous nun in the wron

Re: [Spice-devel] [PATCH] Explicitly depend on various X libraries, and -pthread

2010-03-10 Thread Alexander Larsson
libraries, and also the pthread > library. Looks good to commit. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He

[Spice-devel] Added spice allocators

2010-03-11 Thread Alexander Larsson
alloc failed"); -} -memset(dispatcher, 0, sizeof(RedDispatcher)); +dispatcher = spice_new0(RedDispatcher, 1); -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@

[Spice-devel] fast-scale branch performance improvements

2010-03-11 Thread Alexander Larsson
arly is a significant win, and I'd like to get this branch (or something based on it) into 0.18.0 to avoid performance regressions in spice. [1] http://cgit.freedesktop.org/~siamashka/pixman/log/?h=fast-scaling -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [Pixman] fast-scale branch performance improvements

2010-03-12 Thread Alexander Larsson
On Thu, 2010-03-11 at 14:41 +0100, Alexander Larsson wrote: > This clearly is a significant win, and I'd like to get this branch (or > something based on it) into 0.18.0 to avoid performance regressions in > spice. > > [1] http://cgit.freedesktop.org/~siamashka/pixman/log/?h=

Re: [Spice-devel] [Pixman] fast-scale branch performance improvements

2010-03-12 Thread Alexander Larsson
On Fri, 2010-03-12 at 16:17 +0100, Alexander Larsson wrote: > On Thu, 2010-03-11 at 14:41 +0100, Alexander Larsson wrote: > > > This clearly is a significant win, and I'd like to get this branch > (or > > something based on it) into 0.18.0 to avoid performance

[Spice-devel] bilinear fast path

2010-03-15 Thread Alexander Larsson
On Fri, 2010-03-12 at 16:18 +0100, Alexander Larsson wrote: > > > > I took this as a base and created a new branch that does fast > scaling, > > achieving similar performance, and passing scaling-test. > > > > > http://cgit.freedesktop.org/~alexl/pixman/log/

[Spice-devel] Adding a proper marshaller/demarshaller to spice

2010-03-23 Thread Alexander Larsson
pixman regions. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a notorious alcoholic jungle king who must take medication to keep him sane. She's a strong-will

Re: [Spice-devel] autoconf for slirp

2010-03-26 Thread Alexander Larsson
something that does not conflict with the original package? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a scrappy

Re: [Spice-devel] autoconf for slirp

2010-03-28 Thread Alexander Larsson
On Sun, 2010-03-28 at 09:03 +0300, Yonit Halperin wrote: > On 03/26/2010 11:45 AM, Alexander Larsson wrote: > > On Fri, 2010-03-26 at 10:25 +1000, Dave Airlie wrote: > >> this is quick and dirty, and not completely tested yet, but it > makes > >> my life a little

Re: [Spice-devel] autoconf for slirp

2010-03-31 Thread Alexander Larsson
On Wed, 2010-03-31 at 08:52 +0300, Yonit Halperin wrote: > On 03/28/2010 02:30 PM, Alexander Larsson wrote: > > On Sun, 2010-03-28 at 09:03 +0300, Yonit Halperin wrote: > >> On 03/26/2010 11:45 AM, Alexander Larsson wrote: > >>> On Fri, 2010-03-26 at 10:25 +1000, Dav

Re: [Spice-devel] [PATCH 02/18] channel security cleanup

2010-03-31 Thread Alexander Larsson
t_channel_security(SpiceServer *s, int security); As the public API? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.com

Re: [Spice-devel] [PATCH 07/18] fix visibility

2010-03-31 Thread Alexander Larsson
_visible__ __attribute__ ((visibility ("default"))) > + > /* old interface */ > void spice_init(CoreInterface *core); This needs to go in an internal spice-server header, not the public header. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
SpiceQxlInterface { SpiceImplementation parent; ... }; int spice_server_add(SpiceServer *s, SpiceImplementation *implementation) int spice_server_remove(SpiceServer *s, SpiceImplementation *implementation); -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
t too, which is nice for C++ code (for the client or common code). -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an

Re: [Spice-devel] [PATCH] client: handling SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST

2010-03-31 Thread Alexander Larsson
connect(false); +} + +void RedClient::connect(bool wait_main_disconnect) Can't you use default argument values here instead of two functions? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

Re: [Spice-devel] [PATCH 02/18] channel security cleanup

2010-03-31 Thread Alexander Larsson
On Wed, 2010-03-31 at 13:34 +0200, Gerd Hoffmann wrote: > Works for me. We could even drop > spice_server_set_default_channel_security() and use channel == NULL > for > "set default". Works for me! -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 0/3] spice interface redesign.

2010-03-31 Thread Alexander Larsson
as SpiceKbdState, i mean for it to be exactly the struct above. Its just useful to get a pointer to the interface from the instance. There would still be a separate spice-side state object like SpiceKbdState. And if we want to be able to pair the two we could return it from spice_server_add() just

Re: [Spice-devel] [PATCH] server configuration: make network redirection support optional

2010-04-06 Thread Alexander Larsson
On Tue, 2010-04-06 at 18:07 +0300, Yonit Halperin wrote: > By default it is disabled. To enable: configure --enable-tunnel. > When active, requires libslirp. > --- Pushed, thanks! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lis

Re: [Spice-devel] spice for upstream qemu

2010-04-09 Thread Alexander Larsson
/git/work/spice/server/.libs $spice_cflags" + spice_cflags="$spice_cflags -L/export/git/work/slirp/release" + spice_libs="$spice_libs -lspice-server -lslirp" /export/git, eh? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Lar

Re: [Spice-devel] spice for upstream qemu

2010-04-12 Thread Alexander Larsson
hange this in configure.ac: SPICE_LT_VERSION=m4_format("%d:%d:%d", SPICE_MAJOR, SPICE_MINOR, SPICE_MICRO) AC_SUBST(SPICE_LT_VERSION) Instead of hardcoding it in the Makefile. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] [Spice-commits] client/windows

2010-04-12 Thread Alexander Larsson
On Sun, 2010-04-11 at 16:38 +0300, Yonit Halperin wrote: > On 04/08/2010 10:31 AM, Alexander Larsson wrote: > > client/windows/redc.sln|4 ++-- > > client/windows/redc.vcproj | 13 ++--- > > 2 files changed, 8 insertions(+), 9 deletions(-) > >

[Spice-devel] libjpeg performance

2010-04-12 Thread Alexander Larsson
he libjpeg code to make it a bit faster, but we might still be able to tweak this a bit in favour of performance rather than compression if thats what we want. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

[Spice-devel] New win32 binary set

2010-04-12 Thread Alexander Larsson
. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an impetuous zombie paranormal investigator on the run. She's an artistic punk cab driver who inherited a spooky stately manor fro

Re: [Spice-devel] libjpeg performance

2010-04-12 Thread Alexander Larsson
On Mon, 2010-04-12 at 20:57 +0200, Alexander Larsson wrote: > I did some simple testing of the new mjpeg encoder. > Showing the youtube "will it blend - ipad" video i got quite better > compression (24k per frame average as opposed to 35k before), but the > code used a bit

Re: [Spice-devel] libjpeg performance

2010-04-12 Thread Alexander Larsson
On Tue, 2010-04-13 at 08:04 +0300, Izik Eidus wrote: > On Mon, 12 Apr 2010 22:36:03 +0200 > Alexander Larsson wrote: > > > On Mon, 2010-04-12 at 20:57 +0200, Alexander Larsson wrote: > > > I did some simple testing of the new mjpeg encoder. > > > Showing the you

Re: [Spice-devel] New win32 binary set

2010-04-13 Thread Alexander Larsson
On Mon, 2010-04-12 at 21:45 +0200, Alexander Larsson wrote: > We just added a new set of win32 dependency libraries for unstable spice > at: > http://spice-space.org/download.html > > This contains both the new dependencies (libjpeg and pixman 0.18.0), and > removes the ones

[Spice-devel] Spice relicensed to LGPL 2.1 or later

2010-04-13 Thread Alexander Larsson
. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a jaded Catholic gangster with a passion for fast cars. She's an enchanted hip-hop strippe

Re: [Spice-devel] libjpeg performance

2010-04-14 Thread Alexander Larsson
On Wed, 2010-04-14 at 09:33 +0300, Uri Lublin wrote: > On 04/12/2010 09:57 PM, Alexander Larsson wrote: > > I did some simple testing of the new mjpeg encoder. > > Showing the youtube "will it blend - ipad" video i got quite better > > compression (24k per frame a

[Spice-devel] Pixel format handling with offscreen surfaces

2010-04-14 Thread Alexander Larsson
new member uint32_t flags; uint32_t type; } SpiceMsgSurfaceCreate; BTW, what is the type member here used for? Seems unused. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a

Re: [Spice-devel] Pixel format handling with offscreen surfaces

2010-04-15 Thread Alexander Larsson
On Thu, 2010-04-15 at 02:12 +0300, Izik Eidus wrote: > On Wed, 14 Apr 2010 16:12:21 +0200 > Alexander Larsson wrote: > > enum { > > SPICE_SURFACE_FMT_INVALID, > > SPICE_SURFACE_FMT_1A, > > SPICE_SURFACE_FMT_8A, > > SPICE_SURFACE_FMT_16_5

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-22 Thread Alexander Larsson
upstream qemu to take patches for spice support. This work is led by Gerd Hoffmann and can be followed in this list. We hope to have patches that we can send to upstream qemu very soon. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] Spice in Fedora Rawhide?

2010-04-23 Thread Alexander Larsson
On Thu, 2010-04-22 at 08:58 -0400, Matthew Miller wrote: > On Thu, Apr 22, 2010 at 10:28:14AM +0200, Alexander Larsson wrote: > > > > The next major problem is that > > Fedora doesn't really accept "leaf" libraries (i.e.

Re: [Spice-devel] Pixel format handling with offscreen surfaces

2010-04-23 Thread Alexander Larsson
on between different canvas bitdepths and X bitdepths. Its a large change though, so I'm sure there will be something broken. Please test this carefully. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] reminder

2010-04-26 Thread Alexander Larsson
top git then. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a notorious ninja inventor with a passion for fast cars. She's a high-kicking winged snake charmer from

Re: [Spice-devel] Ubuntu Spice Howto

2010-04-26 Thread Alexander Larsson
bit painful. However, the build will be a lot easier as we're getting rid of many of the "problematic" dependencies. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al

[Spice-devel] New win32 driver for master

2010-04-26 Thread Alexander Larsson
of spice-protocol/spice/vdesktop to run this. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an obese misogynist se

Re: [Spice-devel] New win32 driver for master

2010-04-28 Thread Alexander Larsson
On Mon, 2010-04-26 at 16:38 +0200, Alexander Larsson wrote: > I just commited the patches from gerd for backwards compatibility with > 0.4, and this in addition to the recent format changes break > compatibility with the win32 driver, so i built a new driver, availible > at: >

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Alexander Larsson
work byte-ordering > > issues? > > spice protocol (on the wire) is defined to be little endian. > > Alexander Larsson is working on a marshaller/demarshaller for the spice > network protocol, I think this will also handle endianness, i.e. > byteswap the data if neede

Re: [Spice-devel] C version of find_msb()

2010-05-03 Thread Alexander Larsson
On Sat, 2010-05-01 at 22:25 -0600, Bryan Stillwell wrote: > Recently I tried building the Ubuntu SPICE packages on powerpc and found > that the spicec package fails on some x86 assembly code in > common/gl_utils.h. This motivated me to create an optimized C version > of the find_msb() function, wh

Re: [Spice-devel] [PATCH] server: fix invalid self loop in surfaces dependencies.

2010-05-03 Thread Alexander Larsson
On Wed, 2010-04-28 at 18:26 +0300, Yonit Halperin wrote: > Cyclic dependencies between surfaces mustn't occur. They can cause invalid > rendering - > recent drawables might be rendered before older ones. Pushed to master ___ Spice-devel mailing list Sp

Re: [Spice-devel] libspice and save/restore/migration

2010-05-03 Thread Alexander Larsson
> Plan for unstable: > > (1) Keep surface metadata in device memory, i.e. delay the release of > QXL_SURFACE_CMD_CREATE command until the surface is destroyed. > (2) Keep the most recent QXL_CURSOR_SET command in device memory, i.e. > delay the release until the next one comes in. > (3)

Re: [Spice-devel] CEGUI xml error

2010-05-03 Thread Alexander Larsson
On Tue, 2010-05-04 at 08:49 +0200, Attila Sukosd wrote: > I managed to fix it by recompiling CEGUI with the Libxml parser and > now it works fine. > > Now I stumbled upon another issue using gl_fbo or gl_pbuff to render > on the client side: > canvas_get_mask: access violation 0x0 18 > Aborted T

Re: [Spice-devel] Build Windows Client from git Repo

2010-05-10 Thread Alexander Larsson
ugh, you just need to setenv SPICE_COMMON_DIR to point to the spice-protocol directory and then run "build" in a build environment for the windows display driver kit. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] [PATCH 20/35] VDInterface: redesign.

2010-05-17 Thread Alexander Larsson
ot;unsupported net wire interface"); > +red_printf("unsupported net wire interface"); > #endif The switch from not returning anything to returning -1 on failure means that #else HAVE_SLIRP case need to return -1. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Alexander Larsson
On Wed, 2010-05-12 at 13:32 +0200, Gerd Hoffmann wrote: > > +if (sif->state) > +sif->state(sin, reds->agent_state.connected); Lacks brackets around block. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Alexander Larsson
tate(vdagent, reds->agent_state.connected); > reds->agent_state.plug_generation++; Missing brackets around block. > +if (sif->state) > +sif->state(vdagent, state->connected); Here too. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] [PATCH 31/35] replace worker load/save with loadvm_commands, allow keeping surface content

2010-05-17 Thread Alexander Larsson
ext.group_id); > +red_process_surface(worker, surface_cmd, ext.group_id, 1); > +break; > +} Maybe we want a default: here to catch any weird things happening with a printf? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [PATCH 00/35] new libspice-server API patches.

2010-05-17 Thread Alexander Larsson
rtheless. I have not looked at these yet, but given your comments above, lets land the other parts first and move to the new qemu. Then we could put these on a new branch. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] Questions on security.

2010-05-17 Thread Alexander Larsson
ect to the new server, and we need to ensure that the client doesn't connect to some rouge server but really to the "same" (migrated) guest. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an

Re: [Spice-devel] [PATCH 33/35] [debug] migration troubleshooting

2010-05-17 Thread Alexander Larsson
/*2sec*/ > #define MM_TIMER_GRANULARITY_MS (1000 / 30) Uhm, You don't propose this for merging, do you? -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He

Re: [Spice-devel] [PATCH] don't use alpha channel bitmap for primary surface operations

2010-05-18 Thread Alexander Larsson
On Tue, 2010-05-18 at 04:56 -0400, Alon Levy wrote: > This is an idea suggested by izik, I just tested it a little so far. > > Basically the test for alpha in QXLGetBitmap is done even when the target > is a primary surface (side note: our driver only supports a single monitor > right now, and har

Re: [Spice-devel] [PATCH 31/35] replace worker load/save with loadvm_commands, allow keeping surface content

2010-05-18 Thread Alexander Larsson
On Mon, 2010-05-17 at 20:37 +0200, Gerd Hoffmann wrote: > On 05/17/10 11:54, Alexander Larsson wrote: > > >> @@ -9138,7 +9086,7 @@ static inline void > >> handle_dev_create_primary_surface(RedWorker *worker) > >> } > >> > >> red_crea

Re: [Spice-devel] [PATCH 00/35] new libspice-server API patches.

2010-05-18 Thread Alexander Larsson
On Mon, 2010-05-17 at 20:59 +0200, Gerd Hoffmann wrote: > Hi, > > > I reviewed the patches up to 31. Some minor issues were pointed out in > > separate mails, but generally i think this looks good and should go in > > now. > > Yes, I agree on it. Sort the remaining minor bits, then merge. > > >

Re: [Spice-devel] [PATCH 36/39] NetWireInterface: redesign

2010-05-19 Thread Alexander Larsson
unnel_worker.c in the patch. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a fiendish Jewish messiah fleeing from

Re: [Spice-devel] [PATCH 38/39] zap vd_interface.h

2010-05-19 Thread Alexander Larsson
ce.h or we could forward declare it like SpiceRect above. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a leather-clad Amish stage ac

Re: [Spice-devel] [PATCH 38/39] zap vd_interface.h

2010-05-19 Thread Alexander Larsson
On Wed, 2010-05-19 at 11:11 +0200, Gerd Hoffmann wrote: > On 05/19/10 10:45, Alexander Larsson wrote: > > On Tue, 2010-05-18 at 17:43 +0200, Gerd Hoffmann wrote: > >> +struct SpiceRect; > >> +struct QXLWorker { > >> +uint32_t minor_version; > >>

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-21 Thread Alexander Larsson
ve to even build it. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a fast talking voodoo matador who dotes on his loving old ma. S

Re: [Spice-devel] RFC: client: don't invalidate unless primary surface

2010-05-24 Thread Alexander Larsson
());\ POST_DRAW; \ invalidate(type->base.box, false); \ } -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gma

Re: [Spice-devel] RFC: client: don't invalidate unless primary surface

2010-05-24 Thread Alexander Larsson
On Mon, 2010-05-24 at 04:52 -0400, Alon Levy wrote: > ok, want me to add it and send a patch? this makes sense? Yeah, it totally makes sense. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat,

Re: [Spice-devel] [PATCH] sound channels: restart audio on client reconnect.

2010-05-25 Thread Alexander Larsson
On Thu, 2010-05-20 at 13:33 +0200, Gerd Hoffmann wrote: Some brackets missing after if, but otherwise this looks good to me. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al

  1   2   3   >