Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 14:33 schrieb Tomi Valkeinen: [...] Yeah, there are constrains in the scanline and buffer alignments and orientation. And if we say that bpp==12 means NV12, it will be a problem for all other cases where bpp==12 makes sense. I feel I still don't quite understand. Can't we d

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it resolves all the points you have. The current CREATE_DUMB I had missed the discussion, and, indeed, the patch you attached fixes the problem on Xilin

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Daniel Stone
On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > No disagreement there, we need CREATE_DUMB2. > > My point is that we have the current UAPI, and we have userspace using > it, but we don't have clear rules what the ioctl does with specific > parameters, and we don't document how it has to be u

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
gt;dma_align, 0); +    if (ret) +    return ret;     return drm_gem_dma_dumb_create_internal(file_priv, drm, args);   } I have some trouble with this one. I have sent a series to add some pixel formats: https://lore.kernel.org/all/20250115-xilinx-formats-v2-0-160327ca6...@ideasonboard.com/

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 13:06 schrieb Tomi Valkeinen: Hi, On 15/01/2025 13:37, Thomas Zimmermann wrote: Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it resolves all the points you have. The current CREA