Re: [Spice-devel] [PATCH v1 0/5] dcc: Create a stream for non-gl/remote clients that want to use dmabuf

2023-04-21 Thread Frediano Ziglio
> > > > > The style (well, also the style of spice code I have to admit) is a > > > bit "messy" but better to fix the big problems first than try to solve > > [Vivek] Ok, I guess we can fix it incrementally if you can first point out > > the worst style violoations. > > > > I'll try to write some f

Re: [Spice-devel] [PATCH v1 2/5] dcc: Create a stream associated with gl_draw for non-gl clients

2023-04-21 Thread Frediano Ziglio
Il giorno gio 16 mar 2023 alle ore 06:05 Vivek Kasireddy ha scritto: > > For non-gl/remote clients, if a stream does not exist or if any > of the key parameters associated with gl_draw such as x/y or > width/height are changed, then we create a new stream. Otherwise, > we just update the current s

Re: [Spice-devel] [PATCH v1 3/5] dcc-send: Encode and send gl_draw stream data to the remote client

2023-04-21 Thread Frediano Ziglio
Il giorno gio 16 mar 2023 alle ore 06:05 Vivek Kasireddy ha scritto: > > For remote (or non-gl) clients, if a valid gl_draw stream exists, > then we first extract the dmabuf fd associated with the scanout and > share it with the encoder along with other key parameters such as > stride, width and h

Re: [Spice-devel] [PATCH v1 4/5] gstreamer-encoder: Add an encoder function that takes dmabuf fd as input

2023-04-21 Thread Frediano Ziglio
Il giorno gio 16 mar 2023 alle ore 06:05 Vivek Kasireddy ha scritto: > > This patch adds a new function to enable the creation of Gst memory with > the dmabuf fd as the source by using a dmabuf allocator. And, it also > adds a mechanism to register and invoke any callbacks once the Gst memory > ob

Re: [Spice-devel] [PATCH v1 5/5] video-stream: Don't stop a stream if a gl_draw operation is pending

2023-04-21 Thread Frediano Ziglio
Il giorno gio 16 mar 2023 alle ore 06:05 Vivek Kasireddy ha scritto: > > Before stopping a stream, we need to ensure that there is no ongoing > gl_draw operation; otherwise, we may not get another opportunity to > create a new stream if the current one gets stopped. And, once the > stream is stopp