[Spice-devel] [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
By default the bits per pixel for the emulated framebuffer device is set to dev->mode_config.preferred_depth, but some devices need another value. Since this second parameter is only used by a few drivers, and to allow drivers to use it for passing other configurations when registering the fbdev,

[Spice-devel] [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello, This series contain patches suggested by Thomas Zimmermannas a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial, I decided to just split this part in a new patch-set and revisit the

Re: [Spice-devel] [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 10:48:29AM +0200, Javier Martinez Canillas wrote: > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is

Re: [Spice-devel] [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 13:34, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > Thanks a lot for your feedback. [snip] >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -2501,8 +2501,16 @@ static const struct drm_client_funcs >> drm_fbdev_client_funcs = { >> /** >> * drm_

Re: [Spice-devel] [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello Thomas, On 5/2/22 12:35, Thomas Zimmermann wrote: > Hi Javier > > Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: >> Hello, >> >> This series contain patches suggested by Thomas Zimmermannas a feedback for Ups, I missed a space here. I meant to write "Zimmermann as a feedback..." >

Re: [Spice-devel] [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Thomas Zimmermann
Hi Javier Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: Hello, This series contain patches suggested by Thomas Zimmermannas a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial,

[Spice-devel] [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
By default the bits per pixel for the emulated framebuffer device is set to dev->mode_config.preferred_depth, but some devices need another value. Since this second parameter is only used by a few drivers, and to allow drivers to use it for passing other configurations when registering the fbdev,

[Spice-devel] [PATCH v2 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello, This series contain patches suggested by Thomas Zimmermann as a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial, I decided to just split this part in a new patch-set and revisit th

Re: [Spice-devel] [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is

Re: [Spice-devel] [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices nee