> hi, all,
> I install ubuntu 18.04 amd64 with virt-manager,
> the vdagent default installed is ok. the copy &paste and windows resize is
> ok。
> but when I build the vdagent with the source code, it does not work.
> and log has this error: "GetSeats failed: The name org.freedesktop.ConsoleKit
>
Move final cleanups to qxl_drm_release() callback.
Add drm_atomic_helper_shutdown() call to qxl_pci_remove().
Reorder calls in qxl_device_fini(). Cleaning up gem & ttm
might trigger qxl commands, so we should do that before
releaseing command rings.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu
>
> Move final cleanups to qxl_drm_release() callback.
Can you explain in the commit why this is better or preferable?
> Add drm_atomic_helper_shutdown() call to qxl_pci_remove().
I suppose this is to replace the former manual cleanup calls,
which were moved to qxl_drm_release, I think this cou
On Fri, Dec 20, 2019 at 07:09:20AM -0500, Frediano Ziglio wrote:
> >
> > Move final cleanups to qxl_drm_release() callback.
>
> Can you explain in the commit why this is better or preferable?
It gets called when the drm device refcount goes down to zero.
It's needed for a proper cleanup in the c
Hi Frediano,
Thanks for reviewing!
On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
>
> >
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to
> > encode and decode video stream respectively.
> > Though video encoder and decoder a
Hi Keiichi,
On Mittwoch, 18. Dezember 2019 14:02:13 CET Keiichi Watanabe wrote:
> Hi,
> This is the 2nd version of virtio-video patch. The PDF is available in [1].
> The first version was sent at [2].
>
> Any feedback would be appreciated. Thank you.
>
> Best,
> Keiichi
>
> [1]:
> https://drive
Hi Keiichi,
On Freitag, 20. Dezember 2019 15:05:02 CET Keiichi Watanabe wrote:
> Hi Frediano,
> Thanks for reviewing!
>
> On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
> > > From: Dmitry Sepp
> > >
> > > The virtio video encoder device and decoder device provide
> > > functionalities
Hi Keiichi,
On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> Hi Dmitry,
> Thanks for the feedback.
>
> On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > Thank you for the update. Please see some comments below.
> >
> > Also, we need to bring t
Hi Dmitry,
Thanks for the feedback.
On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> Thank you for the update. Please see some comments below.
>
> Also, we need to bring the virtio_video_control back as it is in fact used by
> the driver to enumerate supported encoder contr
