[Spice-devel] [PATCH spice-server v2 5/7] red-client: Automatically set MainChannelClient

2019-10-14 Thread Frediano Ziglio
This make sure that the RedClient has always an attached MainChannelClient. Signed-off-by: Frediano Ziglio --- server/red-client.c | 11 +-- server/red-client.h | 2 -- server/reds.c | 1 - server/tests/test-channel.c | 1 - server/tests/test-smar

[Spice-devel] [PATCH spice-server v2 4/7] red-client: Make sure MainChannelClient is freed as last

2019-10-14 Thread Frediano Ziglio
MainChannelClient is used by other clients to store some data so should not disappear if other clients are still present. Keep a owning reference to it and release after RedClient is released. Signed-off-by: Frediano Ziglio --- server/red-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[Spice-devel] [PATCH spice-server v2 2/7] red-client: Protect concurrent list accesses

2019-10-14 Thread Frediano Ziglio
The channels list was not protected by a lock in red_client_destroy. This could cause for instance a RedChannelClient object to be created while scanning the list so potentially modifying the list while scanning with all race issues. Consider a client which attempt to connect to a new channel and

[Spice-devel] [PATCH spice-server v2 3/7] red-client: Avoid stale channel client after disconnection

2019-10-14 Thread Frediano Ziglio
Disconnecting a single channel from the client caused the server to keep a stale channel client (RedChannelClient object) till the client (RedClient object) entirely disconnected, that is the channel client is disconnected but still in the list preventing new connections. Calling red_client_remove_

[Spice-devel] [PATCH spice-server v2 0/7] Thread and Smartcard

2019-10-14 Thread Frediano Ziglio
This series should finish the Smartcard changes. I still had a subtest for Smartcard but it was not working due to a small issue in RedChannelClient. In order to fix that issue I used an old series which was not merged which was fixing some minor issues on RedClient. Beside removing minor issues t

[Spice-devel] [PATCH spice-server v2 1/7] smart-channel-client: Remove spicec client reference from comment

2019-10-14 Thread Frediano Ziglio
spicec is an obsolete client. Signed-off-by: Frediano Ziglio --- server/smartcard-channel-client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c index 43df902f5..da472a2a7 100644 --- a/server/smartcard

[Spice-devel] [PATCH spice-server v2 7/7] red-channel-client: Reuse red_channel_client_shutdown

2019-10-14 Thread Frediano Ziglio
red_channel_client_shutdown remove the watch and shutdown the socket. Reuse in red_channel_client_disconnect. Calling shutdown will close the connection earlier. Signed-off-by: Frediano Ziglio --- server/red-channel-client.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[Spice-devel] [PATCH spice-server v2 6/7] test-smartcard: Test invalid reader closes the channel

2019-10-14 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tests/test-smartcard.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/server/tests/test-smartcard.c b/server/tests/test-smartcard.c index f102452f4..25a1bc2bc 100644 --- a/server/tests/test-smartcard.c +

Re: [Spice-devel] [PATCH spice-server] event-loop: Change internal core interface

2019-10-14 Thread Victor Toso
Hi, On Thu, Oct 10, 2019 at 11:02:00AM +0100, Frediano Ziglio wrote: > Allow to modify/cancel timers/watches without having to retrieve > the code interface. > This will make sure that you are not using the wrong interface. > Simplify code to deal with timers/watches. Yes > Remove the requiremen

[Spice-devel] [spice/docs] docs: include protocol and for-newbies documents

2019-10-14 Thread Victor Toso
From: Victor Toso Only by building and sharing the documents we will be able to get them up to date. Signed-off-by: Victor Toso --- docs/meson.build | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/docs/meson.build b/docs/meson.build index 82864bb8..ce0334c0

Re: [Spice-devel] [PATCH spice-server] spice_protocol: Update many names

2019-10-14 Thread Victor Toso
Hi, On Thu, Oct 10, 2019 at 03:56:30PM +0100, Frediano Ziglio wrote: > Using an old "renames" file found in spice-protocol repository > I update some old names in the documentation protocol. > Also updated some other names manually. > I processed the file and fixed some code indentation. > File lo

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Victor Toso
Hi, On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > This series is part from a former series. > There's an initial import commit to better understand the changes. > It contains some work from Eduardo for MingW packaging. > Final patches are really minor. Should I/we wait for Ed

[Spice-devel] [PATCH spice-gtk] spice-widget: Fix invalidate region in case of image is scaled

2019-10-14 Thread Frediano Ziglio
In case the drawing on the screen is scaled the scaling required to invalidate a slightly bigger region. This is due to the interpolation done during the resize. So if scaling is performed invalidate also the adjacent pixels. This fixes https://gitlab.freedesktop.org/spice/spice-gtk/issues/19. Si

Re: [Spice-devel] [spice/docs] docs: include protocol and for-newbies documents

2019-10-14 Thread Frediano Ziglio
> > From: Victor Toso > > Only by building and sharing the documents we will be able to get them > up to date. > > Signed-off-by: Victor Toso > --- > docs/meson.build | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/docs/meson.build b/docs/meson.build

Re: [Spice-devel] [PATCH spice-server] spice_protocol: Update many names

2019-10-14 Thread Frediano Ziglio
> Hi, > > On Thu, Oct 10, 2019 at 03:56:30PM +0100, Frediano Ziglio wrote: > > Using an old "renames" file found in spice-protocol repository > > I update some old names in the documentation protocol. > > Also updated some other names manually. > > I processed the file and fixed some code indenta

Re: [Spice-devel] [PATCH spice-server] spice_protocol: Update many names

2019-10-14 Thread Victor Toso
On Mon, Oct 14, 2019 at 07:02:05AM -0400, Frediano Ziglio wrote: > > > Hi, > > > > On Thu, Oct 10, 2019 at 03:56:30PM +0100, Frediano Ziglio wrote: > > > Using an old "renames" file found in spice-protocol repository > > > I update some old names in the documentation protocol. > > > Also updated

[Spice-devel] [PATCH v2 2/2] docs: update Makefile to match meson dist

2019-10-14 Thread Victor Toso
From: Victor Toso Sort the files names in alphabetic order and include the .html version for spice_for_newbies and spice_protocol Signed-off-by: Victor Toso --- .gitignore | 3 +-- docs/Makefile.am | 11 +++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.gitigno

[Spice-devel] [PATCH v2 1/2] docs: include protocol and for-newbies documents

2019-10-14 Thread Victor Toso
From: Victor Toso Only by building and sharing the documents we will be able to get them up to date. Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- docs/meson.build | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/docs/meson.build b/docs/meson.buil

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Fix invalidate region in case of image is scaled

2019-10-14 Thread Victor Toso
Hi, On Mon, Oct 14, 2019 at 11:54:43AM +0100, Frediano Ziglio wrote: > In case the drawing on the screen is scaled the scaling required to > invalidate a slightly bigger region. > This is due to the interpolation done during the resize. > So if scaling is performed invalidate also the adjacent pix

Re: [Spice-devel] [PATCH v2 2/2] docs: update Makefile to match meson dist

2019-10-14 Thread Frediano Ziglio
> > From: Victor Toso > > Sort the files names in alphabetic order and include the .html > version for spice_for_newbies and spice_protocol > > Signed-off-by: Victor Toso Acked > --- > .gitignore | 3 +-- > docs/Makefile.am | 11 +++ > 2 files changed, 8 insertions(+), 6 dele

Re: [Spice-devel] [PATCH v2 1/2] docs: include protocol and for-newbies documents

2019-10-14 Thread Frediano Ziglio
> > From: Victor Toso > > Only by building and sharing the documents we will be able to get them > up to date. > OT: is the page at www.spice-space.org updated manually based on these changes? (https://www.spice-space.org/documentation.html) I suppose being them in PDF format the reply is no.

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Frediano Ziglio
> > Hi, > > On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > > This series is part from a former series. > > There's an initial import commit to better understand the changes. > > It contains some work from Eduardo for MingW packaging. > > Final patches are really minor. > > Sh

Re: [Spice-devel] [PATCH v2 1/2] docs: include protocol and for-newbies documents

2019-10-14 Thread Victor Toso
Hi, On Mon, Oct 14, 2019 at 08:55:21AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Only by building and sharing the documents we will be able to get them > > up to date. > > > > OT: is the page at www.spice-space.org updated manually based on these > changes? > (https://w

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Victor Toso
Hi, On Mon, Oct 14, 2019 at 09:18:51AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > > > This series is part from a former series. > > > There's an initial import commit to better understand the changes. > > > It contains som