[Spice-devel] [PATCH spice-server 2/2] smartcard: Reset vheader value

2019-10-10 Thread Frediano Ziglio
The buffer could change inside smartcard_read_buf_prepare. Signed-off-by: Frediano Ziglio --- server/smartcard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/smartcard.c b/server/smartcard.c index d62847d60..961633f0e 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -151

[Spice-devel] [PATCH spice-server 1/2] smartcard: Fix statement termination

2019-10-10 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/smartcard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/smartcard.c b/server/smartcard.c index 340118e18..d62847d60 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -559,7 +559,7 @@ red_smartcard_channel_class_ini

Re: [Spice-devel] [PATCH spice-common] codegen: Add 'chunk' to the output attributes

2019-10-10 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > Output attributes are the attributes that specify how to store > > > > > that field in the C structure. > > > > > There can be only one output type specified. > > > > > > > > > > Sign

Re: [Spice-devel] [PATCH spice-server 1/2] event-loop: Move adapter interface from reds.c

2019-10-10 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping the series > > > > > > > > > > > > > > > > > Put more event loop code in event-loop.c. > > > > > > This is a preparation patch for the next one. > > > > > > > > > > > > Signed-

Re: [Spice-devel] [PATCH spice-common v2] codegen: Check validity of array members

2019-10-10 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > Check that combination of fields for an array does not > > > > > lead to unsafe code. > > > > > check_valid method came from generate_c_declaration with > > > > > some more check and i

[Spice-devel] [spice-gtk] main: abort previous migration on switch-host message

2019-10-10 Thread Victor Toso
From: Victor Toso In the host, it is possible that the migration goes faster than client side would expect. In case we receive a migrate-begin message followed by switch-host message, we should be sure to abort previous migration to avoid keeping some unused objects in memory plus critical messag

Re: [Spice-devel] [PATCH spice-server 1/2] smartcard: Fix statement termination

2019-10-10 Thread Victor Toso
On Thu, Oct 10, 2019 at 10:02:33AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio For series, Acked-by: Victor Toso > --- > server/smartcard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/smartcard.c b/server/smartcard.c > index 340118e18..d6

Re: [Spice-devel] [PATCH spice-server 1/2] event-loop: Move adapter interface from reds.c

2019-10-10 Thread Victor Toso
On Tue, Aug 06, 2019 at 03:52:49PM +0100, Frediano Ziglio wrote: > Put more event loop code in event-loop.c. > This is a preparation patch for the next one. > > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > server/event-loop.c | 58 + >

Re: [Spice-devel] [spice-gtk] main: abort previous migration on switch-host message

2019-10-10 Thread Frediano Ziglio
> > From: Victor Toso > > In the host, it is possible that the migration goes faster than > client side would expect. In case we receive a migrate-begin message > followed by switch-host message, we should be sure to abort previous Aren't these message exclusives? Is there a bug in the server?

Re: [Spice-devel] [PATCH spice-server 2/2] event-loop: Change internal core interface

2019-10-10 Thread Victor Toso
Hi, On Tue, Aug 06, 2019 at 03:52:50PM +0100, Frediano Ziglio wrote: > Allow to modify/cancel timers/watches without having to > retrieve the code interface. > This will make sure that you are not using the wrong interface. > Simplify code to deal with timers/watches. > Remove the requirement to h

Re: [Spice-devel] [spice-gtk] main: abort previous migration on switch-host message

2019-10-10 Thread Victor Toso
Hi, On Thu, Oct 10, 2019 at 05:48:39AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > In the host, it is possible that the migration goes faster than > > client side would expect. In case we receive a migrate-begin message > > followed by switch-host message, we should be sure

[Spice-devel] [PATCH spice-server] event-loop: Change internal core interface

2019-10-10 Thread Frediano Ziglio
Allow to modify/cancel timers/watches without having to retrieve the code interface. This will make sure that you are not using the wrong interface. Simplify code to deal with timers/watches. Remove the requirement to have the core interface available for removing timers/watches. Signed-off-by: Fr

Re: [Spice-devel] [PATCH spice-common] codegen: Add 'chunk' to the output attributes

2019-10-10 Thread Victor Toso
Hi, On Wed, Aug 14, 2019 at 06:08:25PM +0100, Frediano Ziglio wrote: > Output attributes are the attributes that specify how to store > that field in the C structure. > There can be only one output type specified. It misses documentation on valid_attributes in case you feel like adding too > Sig

Re: [Spice-devel] [PATCH spice-common v2] codegen: Check validity of array members

2019-10-10 Thread Victor Toso
Hi, I was doing some tests, seems to work well :) On Wed, Aug 14, 2019 at 06:08:24PM +0100, Frediano Ziglio wrote: > Check that combination of fields for an array does not > lead to unsafe code. > check_valid method came from generate_c_declaration with > some more check and it's use in demarshal

[Spice-devel] [PATCH spice-common] codegen: Document "chunk" attribute

2019-10-10 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 796a436..5aa6e18 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -60,6 +60,9 @@ valid_attributes=set

Re: [Spice-devel] [PATCH spice-common] codegen: Document "chunk" attribute

2019-10-10 Thread Victor Toso
On Thu, Oct 10, 2019 at 12:38:33PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso Thanks, > --- > python_modules/ptypes.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py > index 796a436..5aa6

[Spice-devel] Question about bidirectional audio

2019-10-10 Thread Eduardo Hoefel
Hello, I'm a developer doing a freelance job for a company. They want to connect Asterisk call center to a vm running Spice. I see that it's possible to do Bidirectional Audio, according to your user manual. I want to stream audio from a client to the server, and have that audio played through

Re: [Spice-devel] Question about bidirectional audio

2019-10-10 Thread Frediano Ziglio
> > Hello, > > I'm a developer doing a freelance job for a company. They want to > connect Asterisk call center to a vm running Spice. I see that it's > possible to do Bidirectional Audio, according to your user manual. > I want to stream audio from a client to the server, and have that audio > p

[Spice-devel] [PATCH spice-server] spice_protocol: Update many names

2019-10-10 Thread Frediano Ziglio
Using an old "renames" file found in spice-protocol repository I update some old names in the documentation protocol. Also updated some other names manually. I processed the file and fixed some code indentation. File looks much more up to date. Signed-off-by: Frediano Ziglio --- docs/spice_proto

Re: [Spice-devel] Question about bidirectional audio

2019-10-10 Thread Eduardo Hoefel
Sorry for not being clear. In this case, the client is Asterisk and the server is a SPICE server. They want to send audio from the client to the server. The documentation says that I need to use RED_RECORD_* messages. The server must start requesting the record from the client, with a RED_REC