[Spice-devel] [spice 1/8] tests: migrate: remove spicec option

2019-09-25 Thread Victor Toso
From: Victor Toso Removed, see: | commit 1876971442ef808b5dcdaa5dc12df617f2179cb5 | Author: Christophe Fergeau | Date: Fri Nov 21 11:01:17 2014 +0100 | | client: Remove client code | | The client has been superseded by virt-viewer ( | http://virt-manager.org/download/sourc

[Spice-devel] [spice 0/8] migrate.py

2019-09-25 Thread Victor Toso
From: Victor Toso Some changes to make this usable. More fixes to come later. Victor Toso (8): tests: migrate: remove spicec option tests: migrate: use uri for default's spicy client tests: migrate: add support to run with remote-viewer tests: migrate: fix relative qmp.py path tests: m

[Spice-devel] [spice 3/8] tests: migrate: add support to run with remote-viewer

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- tests/migrate.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/tests/migrate.py index 5a0f5930..f893b2ac 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -58,7 +58,7 @@ def get_args(): pars

[Spice-devel] [spice 4/8] tests: migrate: fix relative qmp.py path

2019-09-25 Thread Victor Toso
From: Victor Toso Moved in qemu, see: | commit 8f8fd9edba4bd6768da2c8e2bea49ad5c16ced1a | Author: Cleber Rosa | Date: Wed Feb 6 11:29:01 2019 -0500 | | Introduce a Python module structure | | This is a simple move of Python code that wraps common QEMU | functionality, and

[Spice-devel] [spice 8/8] tests: migrate: add counter for tests

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- tests/migrate.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/tests/migrate.py index fcf51bdb..e83a6159 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -62,6 +62,8 @@ def get_args():

[Spice-devel] [spice 5/8] tests: migrate: remove multiple client option

2019-09-25 Thread Victor Toso
From: Victor Toso Not supported feature to be tested so reduce unused/untested code for now. Signed-off-by: Victor Toso --- tests/migrate.py | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/migrate.py b/tests/migrate.py index 5cbc8218..31593c8a 100755 --

[Spice-devel] [spice 7/8] tests: migrate: add option to wait user input

2019-09-25 Thread Victor Toso
From: Victor Toso The iterate() method already considers it. This is useful if one wants to attach gdb on qemu for instance. Signed-off-by: Victor Toso --- tests/migrate.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/tests/migrate.py index 4ac6289b

[Spice-devel] [spice 6/8] tests: migrate: bool instead of on/off option in cmd line

2019-09-25 Thread Victor Toso
From: Victor Toso Simpler. Make the default to be False as well as 1) No args should run as simple as possible 2) True is currently broken Signed-off-by: Victor Toso --- tests/migrate.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/migrate.py b/tests/migrate

[Spice-devel] [spice 2/8] tests: migrate: use uri for default's spicy client

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- tests/migrate.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/migrate.py b/tests/migrate.py index 0c302c92..5a0f5930 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -96,8 +96,8 @@ def start_qemu(qemu_exec,

Re: [Spice-devel] [spice 1/8] tests: migrate: remove spicec option

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Removed, see: > > | commit 1876971442ef808b5dcdaa5dc12df617f2179cb5 > | Author: Christophe Fergeau > | Date: Fri Nov 21 11:01:17 2014 +0100 > | > | client: Remove client code > | > | The client has been superseded by virt-viewer ( > | http://virt

Re: [Spice-devel] [spice 2/8] tests: migrate: use uri for default's spicy client

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/migrate.py b/tests/migrate.py > index 0c302c92..5a0f5930 100755 > --- a/tests/migrate.py > +++ b/tests/migrate.py > @@ -96,8 +96,8 @

Re: [Spice-devel] [spice 3/8] tests: migrate: add support to run with remote-viewer

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/migrate.py b/tests/migrate.py > index 5a0f5930..f893b2ac 100755 > --- a/tests/migrate.py > +++ b/tests/migrate.py > @@ -58,7 +58,7 @

Re: [Spice-devel] [spice 4/8] tests: migrate: fix relative qmp.py path

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Moved in qemu, see: > > | commit 8f8fd9edba4bd6768da2c8e2bea49ad5c16ced1a > | Author: Cleber Rosa > | Date: Wed Feb 6 11:29:01 2019 -0500 > | > | Introduce a Python module structure > | > | This is a simple move of Python code that wraps common QEMU

Re: [Spice-devel] [spice 5/8] tests: migrate: remove multiple client option

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Not supported feature to be tested so reduce unused/untested code for > now. > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/tests/migrate.py b/tests/migrate.py > index 5

Re: [Spice-devel] [spice 6/8] tests: migrate: bool instead of on/off option in cmd line

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Simpler. Make the default to be False as well as > 1) No args should run as simple as possible > 2) True is currently broken > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests

Re: [Spice-devel] [spice 3/8] tests: migrate: add support to run with remote-viewer

2019-09-25 Thread Victor Toso
Hi, On Wed, Sep 25, 2019 at 05:29:56AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > tests/migrate.py | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tests/migrate.py b/tests/migrate.py > > index 5a0f

Re: [Spice-devel] [spice 7/8] tests: migrate: add option to wait user input

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > The iterate() method already considers it. This is useful if one wants > to attach gdb on qemu for instance. > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/migrate.py b/tests/

Re: [Spice-devel] [spice 8/8] tests: migrate: add counter for tests

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Signed-off-by: Victor Toso > --- > tests/migrate.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tests/migrate.py b/tests/migrate.py > index fcf51bdb..e83a6159 100755 > --- a/tests/migrate.py > +++ b/tests/migrate.py > @@ -62,6 +62,8

Re: [Spice-devel] [spice 0/8] migrate.py

2019-09-25 Thread Frediano Ziglio
> > From: Victor Toso > > Some changes to make this usable. More fixes to come later. > > Victor Toso (8): > tests: migrate: remove spicec option > tests: migrate: use uri for default's spicy client > tests: migrate: add support to run with remote-viewer > tests: migrate: fix relative q

Re: [Spice-devel] [spice 0/8] migrate.py

2019-09-25 Thread Victor Toso
Hi, On Wed, Sep 25, 2019 at 05:40:51AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Some changes to make this usable. More fixes to come later. > > > > Victor Toso (8): > > tests: migrate: remove spicec option > > tests: migrate: use uri for default's spicy client > >

Re: [Spice-devel] [spice 8/8] tests: migrate: add counter for tests

2019-09-25 Thread Victor Toso
On Wed, Sep 25, 2019 at 05:39:50AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > tests/migrate.py | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/tests/migrate.py b/tests/migrate.py > > index fcf51bdb

[Spice-devel] [spice v2 0/8] migrate.py

2019-09-25 Thread Victor Toso
From: Victor Toso Addressing some comments from v1 review by Frediano. In this batch, only "tests: migrate: remove multiple client option" is not acked due the fact I changed Migrator's attribute name from clients to connected_client. I can simply run migration test now considering that I have q

[Spice-devel] [spice v2 3/8] tests: migrate: add support to run with remote-viewer

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- tests/migrate.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/tests/migrate.py index 5a0f5930..1e15ffa7 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -58,7 +58,7 @

[Spice-devel] [spice v2 8/8] tests: migrate: add counter for tests

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- tests/migrate.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/tests/migrate.py index b76bc877..b11befdd 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -62,6 +62,8

[Spice-devel] [spice v2 7/8] tests: migrate: add option --wait-user-input

2019-09-25 Thread Victor Toso
From: Victor Toso The iterate() method already considers it. This is useful if one wants to attach gdb on qemu for instance. Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- tests/migrate.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/migrate.py b/test

[Spice-devel] [spice v2 2/8] tests: migrate: use uri for default's spicy client

2019-09-25 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- tests/migrate.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/migrate.py b/tests/migrate.py index 0c302c92..5a0f5930 100755 --- a/tests/migrate.py +++ b/tests/migrate.py @@ -96,8 +96,8 @

[Spice-devel] [spice v2 6/8] tests: migrate: bool instead of on/off option in cmd line

2019-09-25 Thread Victor Toso
From: Victor Toso Simpler. Make the default to be False as well as 1) No args should run as simple as possible 2) True is currently broken Signed-off-by: Victor Toso Acked-by: Frediano Ziglio --- tests/migrate.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests

[Spice-devel] [spice v2 4/8] tests: migrate: fix relative qmp.py path

2019-09-25 Thread Victor Toso
From: Victor Toso Moved in qemu, see: | commit 8f8fd9edba4bd6768da2c8e2bea49ad5c16ced1a | Author: Cleber Rosa | Date: Wed Feb 6 11:29:01 2019 -0500 | | Introduce a Python module structure | | This is a simple move of Python code that wraps common QEMU | functionality, and

[Spice-devel] [spice v2 1/8] tests: migrate: remove spicec option

2019-09-25 Thread Victor Toso
From: Victor Toso Removed, see: | commit 1876971442ef808b5dcdaa5dc12df617f2179cb5 | Author: Christophe Fergeau | Date: Fri Nov 21 11:01:17 2014 +0100 | | client: Remove client code | | The client has been superseded by virt-viewer ( | http://virt-manager.org/download/sourc

[Spice-devel] [spice v2 5/8] tests: migrate: remove multiple client option

2019-09-25 Thread Victor Toso
From: Victor Toso Not supported feature to be tested so reduce unused/untested code for now. Signed-off-by: Victor Toso --- tests/migrate.py | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tests/migrate.py b/tests/migrate.py index c20d5e3a..fbbc505c 10075