Re: [Spice-devel] [PATCH spice-gtk] spicy: Do not call gst_init directly

2019-09-23 Thread Frediano Ziglio
ping > > GStreamer is already initialized using gst_init_get_option_group and > gst_init_get_option_group. > > From gst_init documentation: >WARNING: This function does not work in the same way as >corresponding functions in other glib-style libraries, >such as gtk_init(). In particu

Re: [Spice-devel] [PATCH v8 00/20] added feature of sharing CD image

2019-09-23 Thread Yuri Benditovich
On Thu, Sep 19, 2019 at 5:11 PM Victor Toso wrote: > > From: Victor Toso > > Hi, > > CI: https://gitlab.freedesktop.org/victortoso/spice-gtk/tree/cd-rom-split-v8 > > v7->v8 (review by Frediano): > * squashed v7 10/20 into v7 09/20 (an acked fixup) > * Added missing patch, now v8 10/20 > * add pro

[Spice-devel] [PATCH 28/36] drm/qxl: use bpp instead of cpp for drm_format_info

2019-09-23 Thread Sandy Huang
cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/qxl/qxl_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_

[Spice-devel] [spice] main-channel-client: style fixup, indentation of return

2019-09-23 Thread Victor Toso
From: Victor Toso Found while reading the code. Signed-off-by: Victor Toso --- server/main-channel-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/main-channel-client.c b/server/main-channel-client.c index 1261ad78..ef6e065f 100644 --- a/server/main-channel-

Re: [Spice-devel] [PATCH spice-gtk] spicy: Do not call gst_init directly

2019-09-23 Thread Victor Toso
On Tue, Sep 10, 2019 at 10:21:34AM +0100, Frediano Ziglio wrote: > GStreamer is already initialized using gst_init_get_option_group and > gst_init_get_option_group. > > From gst_init documentation: >WARNING: This function does not work in the same way as >corresponding functions in other g

Re: [Spice-devel] [spice] main-channel-client: style fixup, indentation of return

2019-09-23 Thread Frediano Ziglio
> > From: Victor Toso > > Found while reading the code. Not sure if this is important but fine for me > > Signed-off-by: Victor Toso Otherwise, Acked-by: Frediano Ziglio > --- > server/main-channel-client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/serv

Re: [Spice-devel] [PATCH spice-server v2 1/4] spicevmc: Do not use RedCharDevice pipe items handling

2019-09-23 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > ping the series > > > > > > > > > > > > > > > > > > > > As we don't use any token there's no reason to not queue directly > > > > > > > inste