Re: [Spice-devel] [PATCH spice-server 1/2] event-loop: Move adapter interface from reds.c

2019-08-20 Thread Frediano Ziglio
ping the series > > Put more event loop code in event-loop.c. > This is a preparation patch for the next one. > > Signed-off-by: Frediano Ziglio > --- > server/event-loop.c | 58 + > server/red-common.h | 1 + > server/reds.c | 54

Re: [Spice-devel] [PATCH spice-gtk 1/3] usb-backend: Cache isochronous value

2019-08-20 Thread Frediano Ziglio
ping > > ping the series > > > > > Allows to remove _SpiceUsbDevice structure. > > _SpiceUsbDevice is only caching this value from SpiceUsbBackendDevice. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/usb-backend.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --gi

Re: [Spice-devel] [PATCH spice-server v2 1/4] spicevmc: Do not use RedCharDevice pipe items handling

2019-08-20 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping the series > > > > > > > > > > > > > > As we don't use any token there's no reason to not queue directly > > > > > instead > > > > > of passing through RedCharDevice. > > > > > This will make easier to limit the

Re: [Spice-devel] [PATCH spice-server v2 1/2] char-device: Don't use RedClient API

2019-08-20 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > ping > > > > > > > > > > > > > > > > > ping the series > > > > > > > > > > > > > > > > > > > > RedClient was an opaque structure for RedCharDevice. > > > > > > > It started to be used when Re

Re: [Spice-devel] USB redirection: "LIBUSB_ERROR_NOT_SUPPORTED"

2019-08-20 Thread Yuri Benditovich
I see the virt-viewer 8.0 uses only WinUSB as it includes libusb 1.0.22 (which uses dynamic configuration of backend with WinUSB as default) and spice-gtk 0.35 (which does not configure libusb to use UsbDk). I suggest to try virt-viewer 7.0 instead, then libusb will work with UsbDk. Best regards,

Re: [Spice-devel] USB redirection: "LIBUSB_ERROR_NOT_SUPPORTED"

2019-08-20 Thread Yuri Benditovich
BTW, I see that Windows' libspice*.dll released with mingw do not have any version information (that usually for Windows binaries comes during build from resource file). On Tue, Aug 20, 2019 at 12:46 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > I see the virt-viewer 8.0 uses only

[Spice-devel] windows spice-client-glib hotplug not working

2019-08-20 Thread zhou qi
Hello, I write a demo under windows unsing spice-client-glib only, I can get usb devices from UsbManager. but hotplug is not working. no device change event recieved. I found the function g_udev_client_initable_init in win-usb-dev.c create a hidden window to monitor WM_DEVICECHANGE message. but

[Spice-devel] [PATCH spice-gtk 1/2] vmcstream: fix task cancellation

2019-08-20 Thread Jakub Janků
If the task is cancelled, g_task_propagate_pointer() in spice_vmc_output_stream_write_finish() returns NULL which produces following errors: (spicy:13597): GSpice-CRITICAL **: 15:39:46.168: spice_vmc_write_finish: assertion 'result != NULL' failed (spicy:13597): GLib-GObject-CRITICAL **:

[Spice-devel] [PATCH spice-gtk 2/2] webdav: ref client when demuxing

2019-08-20 Thread Jakub Janků
The client can be unrefed before the demux_to_client_cb() is called which could lead to segfault. So ref it first before starting the async write. Signed-off-by: Jakub Janků --- src/channel-webdav.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/channel-webdav.c b/src/

[Spice-devel] [PATCH spice-gtk] channel-display: fix bug when sending preferred video codecs

2019-08-20 Thread Kevin Pouget
The transfer between the codecs array and the message payload cannot be done with memcpy because the data-types are different (gint/uint8_t). Signed-off-by: Kevin Pouget --- src/channel-display.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/channel-display.c

Re: [Spice-devel] [PATCH spice-gtk] channel-display: fix bug when sending preferred video codecs

2019-08-20 Thread Frediano Ziglio
> > The transfer between the codecs array and the message payload cannot > be done with memcpy because the data-types are different > (gint/uint8_t). > > Signed-off-by: Kevin Pouget Acked > --- > src/channel-display.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > dif

Re: [Spice-devel] [PATCH x11spice v4 0/3] Add cache for SHM segments

2019-08-20 Thread Jeremy White
Series: Acked-by: Jeremy White and pushed. Cheers, Jeremy On 8/19/19 8:03 PM, Brendan Shanks wrote: Add a cache to x11spice for SHM segments. v4 simplifies the 'if' clauses in shm_cache_get/add, as suggested by Frediano. Brendan Shanks (3): Use unsigned int/size_t for display width/h

[Spice-devel] windows spice-client-glib hotplug not working

2019-08-20 Thread zhou qi
Hello, I write a demo under windows unsing spice-client-glib only, I can get usb devices from UsbManager. but hotplug is not working. no device change event recieved. I found the function g_udev_client_initable_init in win-usb-dev.c create a hidden window to monitor WM_DEVICECHANGE message. but

Re: [Spice-devel] USB redirection: "LIBUSB_ERROR_NOT_SUPPORTED"

2019-08-20 Thread Yuri Benditovich
On Tue, Aug 20, 2019 at 8:58 PM Brian Wengel wrote: > Tried to use a W10 client, Viewer 8.0 and no usbdk installed. Same problem > and same error. > Log-file attached ;-) > So, this looks like a problem of libusb with WinUSB, which is not preferrable Spice configuration. I think this is worth to

Re: [Spice-devel] [Nouveau] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-20 Thread Ben Skeggs
On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann wrote: > > Hi, > > > > Changing the order doesn't look hard. Patch attached (untested, have no > > > test hardware). But maybe I missed some detail ... > > > > I came up with something very similar by splitting up nouveau_bo_new() > > into allocation