Re: [Spice-devel] [PATCH v3 spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-22 Thread Frediano Ziglio
> > This allows to set plugin key=value properties on run time. > To add encoder plugin property use the following syntax: > -c gst.prop="property=value" -c gst.prop="property2=value2"... > Make sure syntax is accurate and that the property is supported by > the chosen plugin, wrong properties may

Re: [Spice-devel] [spice-gtk 2/5] usb-redir: unify device hotplug/unplug for Windows and Linux

2019-07-22 Thread Frediano Ziglio
> > On Fri, Jul 19, 2019 at 1:14 PM Victor Toso wrote: > > > > Hi, > > > > On Sun, Jul 14, 2019 at 05:07:38PM +0300, Yuri Benditovich wrote: > > > Remove Windows-specific part of hotplug detection from > > > usb-device-manager and win-usb-dev and place it into > > > USB backend module. Connect th

Re: [Spice-devel] [spice-gtk 2/5] usb-redir: unify device hotplug/unplug for Windows and Linux

2019-07-22 Thread Yuri Benditovich
On Mon, Jul 22, 2019 at 12:53 PM Frediano Ziglio wrote: > > > > > On Fri, Jul 19, 2019 at 1:14 PM Victor Toso wrote: > > > > > > Hi, > > > > > > On Sun, Jul 14, 2019 at 05:07:38PM +0300, Yuri Benditovich wrote: > > > > Remove Windows-specific part of hotplug detection from > > > > usb-device-mana

[Spice-devel] [PATCH 2/2] tests: rename video-encoders to test-video-encoders

2019-07-22 Thread Uri Lublin
--- server/tests/Makefile.am | 6 +++--- server/tests/meson.build | 2 +- server/tests/{video-encoders => test-video-encoders} | 0 3 files changed, 4 insertions(+), 4 deletions(-) rename server/tests/{video-encoders => test-video-encoders}

[Spice-devel] [PATCH 1/2] ci: pre-install "file"

2019-07-22 Thread Uri Lublin
This fixes the following warning: ./configure: line 7040: /usr/bin/file: No such file or directory Signed-off-by: Uri Lublin --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 316a860dd..33210cb9d 100644 --- a/.gitlab-ci

Re: [Spice-devel] [PATCH v2 x11spice 1/4] Convert to the use of glib memory routines in options.c.

2019-07-22 Thread Frediano Ziglio
> > Signed-off-by: Jeremy White I didn't expected you would change everything :-) > --- > src/options.c | 44 > 1 file changed, 20 insertions(+), 24 deletions(-) > > diff --git a/src/options.c b/src/options.c > index b7f487c5..a206c92c 100644 > ---

Re: [Spice-devel] [PATCH 1/2] ci: pre-install "file"

2019-07-22 Thread Frediano Ziglio
> > This fixes the following warning: > ./configure: line 7040: /usr/bin/file: No such file or directory > > Signed-off-by: Uri Lublin Acked > --- > .gitlab-ci.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 316a860dd..33

Re: [Spice-devel] [PATCH 2/2] tests: rename video-encoders to test-video-encoders

2019-07-22 Thread Frediano Ziglio
Acked > > --- > server/tests/Makefile.am | 6 +++--- > server/tests/meson.build | 2 +- > server/tests/{video-encoders => test-video-encoders} | 0 > 3 files changed, 4 insertions(+), 4 deletions(-) > rename server/tests/{video-encoders =>

Re: [Spice-devel] [PATCH spice-server 09/13] dispatcher: Use a new API to handle events

2019-07-22 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > Instead of having to manually register the file descriptor and > > > than need to call dispatcher_handle_recv_read just provide a single > > > API to create the watch. > > > This has some advantage: > > > - replace 2 API with 1; > > > - code reuse

[Spice-devel] [PATCH spice-server 1/3] glz-encoder-dict: Remove useless __packed__ attribute

2019-07-22 Thread Frediano Ziglio
The structure has no holes, adding this attribute could only decrease efficiency. Note that HashEntry structure is used for a large (8MB) array so this won't affect much possible container size. Signed-off-by: Frediano Ziglio --- server/glz-encoder-priv.h | 2 +- 1 file changed, 1 insertion(+),

[Spice-devel] [PATCH spice-server 3/3] Use start/end-packet.h headers instead of direct GCC attribute

2019-07-22 Thread Frediano Ziglio
All other code use these headers. Signed-off-by: Frediano Ziglio --- server/migration-protocol.h | 32 ++-- server/reds.c | 4 +++- 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/server/migration-protocol.h b/server/migration-protocol.

[Spice-devel] [PATCH spice-server 2/3] glz-encoder: Remove useless __packed__ attribute

2019-07-22 Thread Frediano Ziglio
These structure contain only bytes, no need for this attribute. Signed-off-by: Frediano Ziglio --- server/glz-encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/glz-encoder.c b/server/glz-encoder.c index 341294035..ee9d95ae9 100644 --- a/server/glz-encoder

[Spice-devel] [PATCH spice-gtk v2] usb-device-manager: Do not give warnings for supported configuration

2019-07-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- src/usb-device-manager.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Changes since v1: - conver a debug into warning to inform the user at least one time diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 9aba275f.

[Spice-devel] [PATCH spice-gtk 1/2] spice-widget-egl: Use sizeof instead of hand coded constant

2019-07-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- src/spice-widget-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 7bae4e58..7db66082 100644 --- a/src/spice-widget-egl.c +++ b/src/spice-widget-egl.c @@ -129,7 +129,7 @@ static gboole

[Spice-devel] [PATCH spice-gtk 2/2] spice-widget-egl: Declare and initialise "tex" and "verts" shortly

2019-07-22 Thread Frediano Ziglio
Just syntax change. Reduce code to initialise these matrices. Signed-off-by: Frediano Ziglio --- src/spice-widget-egl.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 7db66082..f

Re: [Spice-devel] [PATCH spice-server 3/3] Use start/end-packet.h headers instead of direct GCC attribute

2019-07-22 Thread Snir Sheriber
Hi, Here we can also remove some of the packing Otherwise, ack for the series On 7/22/19 2:08 PM, Frediano Ziglio wrote: All other code use these headers. Signed-off-by: Frediano Ziglio --- server/migration-protocol.h | 32 ++-- server/reds.c |

Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-widget-egl: Use sizeof instead of hand coded constant

2019-07-22 Thread Snir Sheriber
Acked-by: Snir Sheriber On 7/22/19 2:25 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- src/spice-widget-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 7bae4e58..7db66082 100644 --- a/src/spice-wi

[Spice-devel] [PATCH phodav 2/2] spice: handle client disconnect gracefully

2019-07-22 Thread Jakub Janků
If the client (spice-gtk) disconnects e.g. during a file transfer, the mux stream gets closed and the count of read bytes does not match the count that the client previously announced. However, in this case, we mustn't simply return, since that would prevent any further connections. Signed-off-by:

[Spice-devel] [PATCH phodav 1/2] spice: read_thread: return number of read bytes on EOF

2019-07-22 Thread Jakub Janků
We already check with each input_stream_read_thread_finish() whether the count of the read bytes matches the requested one. Also, this is the way GLib handles it. Signed-off-by: Jakub Janků --- https://gitlab.gnome.org/GNOME/phodav/merge_requests/4 I've opened the merge request on gitlab some

Re: [Spice-devel] [spice-gtk 5/5] usb-redir: move USB events handling to USB backend

2019-07-22 Thread Yuri Benditovich
Ping On Sun, Jul 14, 2019 at 5:07 PM Yuri Benditovich wrote: > > Before this commit: > usb-device-manager starts thread for handling libusb events. > On Linux - from the beginning (as it is needed for hotplug > callbacks) > On Windows - starts it on first redirection and stops when > ther

Re: [Spice-devel] [PATCH spice-server 3/3] Use start/end-packet.h headers instead of direct GCC attribute

2019-07-22 Thread Frediano Ziglio
> > Hi, > > > Here we can also remove some of the packing > Do you mean the nested ones? I'm not sure and I would prefer a follow up, it's more "conservative" to keep the attribute if there was in the previous commit. > Otherwise, ack for the series > > > On 7/22/19 2:08 PM, Frediano Ziglio

Re: [Spice-devel] [PATCH spice-server 3/3] Use start/end-packet.h headers instead of direct GCC attribute

2019-07-22 Thread Frediano Ziglio
> > > > > Hi, > > > > > > Here we can also remove some of the packing > > > > Do you mean the nested ones? I'm not sure and I would prefer a follow up, > it's more "conservative" to keep the attribute if there was in the previous > commit. > I tested, nested attributes are needed, otherwise

Re: [Spice-devel] [spice-gtk 5/5] usb-redir: move USB events handling to USB backend

2019-07-22 Thread Victor Toso
Hi, On Mon, Jul 22, 2019 at 04:34:48PM +0300, Yuri Benditovich wrote: > Ping Sorry, missed it. Patch seems fine and again, code is getting nicer thanks to usb-backend.[ch]. Thanks. Only cosmetic changes for v2. > On Sun, Jul 14, 2019 at 5:07 PM Yuri Benditovich > wrote: > > > > Before this com

Re: [Spice-devel] [PATCH spice-server v2 1/2] red-replay-qxl: Fix some issue of alignment

2019-07-22 Thread Uri Lublin
On 7/19/19 12:18 PM, Frediano Ziglio wrote: Do not pass unaligned QXLPHYSICAL but pass a valid pointer and then cast. Signed-off-by: Frediano Ziglio Ack. Uri. --- server/red-replay-qxl.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) Changes since v1: - remov

Re: [Spice-devel] [spice-gtk 5/5] usb-redir: move USB events handling to USB backend

2019-07-22 Thread Yuri Benditovich
On Mon, Jul 22, 2019 at 6:00 PM Victor Toso wrote: > > Hi, > > On Mon, Jul 22, 2019 at 04:34:48PM +0300, Yuri Benditovich wrote: > > Ping > > Sorry, missed it. > > Patch seems fine and again, code is getting nicer thanks to > usb-backend.[ch]. Thanks. Only cosmetic changes for v2. > > > On Sun, Ju

Re: [Spice-devel] [spice-gtk 5/5] usb-redir: move USB events handling to USB backend

2019-07-22 Thread Victor Toso
Hi, On Mon, Jul 22, 2019 at 06:31:24PM +0300, Yuri Benditovich wrote: > On Mon, Jul 22, 2019 at 6:00 PM Victor Toso wrote: > > > > Hi, > > > > On Mon, Jul 22, 2019 at 04:34:48PM +0300, Yuri Benditovich wrote: > > > Ping > > > > Sorry, missed it. > > > > Patch seems fine and again, code is getting