On Tue, Jul 9, 2019 at 1:07 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Jun 24, 2019 at 06:02:23PM +0300, Yuri Benditovich wrote:
> > On Mon, Jun 10, 2019 at 1:48 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > Keeping the chat as you might enjoy then, in order to merge this
> > > patches:
> > >
On Mon, Jun 17, 2019 at 05:34:56PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/spice-char.h | 26 ++
> 1 file changed, 26 insertions(+)
>
> Changes since v1:
> - updated comments
>
> diff --git a/server/spice-char.h b/server/spice-char.h
Hi,
On Wed, Jul 10, 2019 at 11:02:13AM +0300, Yuri Benditovich wrote:
> On Tue, Jul 9, 2019 at 1:07 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Mon, Jun 24, 2019 at 06:02:23PM +0300, Yuri Benditovich wrote:
> > > On Mon, Jun 10, 2019 at 1:48 PM Victor Toso wrote:
> > > >
> > > > Hi,
> > > >
> >
As a step toward possibility to present emulated USB devices
to the guest, we remove the knowledge about libusb and
usbredirhost (which depends on libusb) from all the modules
and concentrate it in one (usb backend) which presents
abstract USB objects and internal API to all other modules.
Internal
This layer communicates with libusb and libusbredir and
provides the API for all the operations related to USB
redirection. All other modules of spice-gtk communicate
only with usb backend instead of calling libusb and
usbredirhost directly.
This is prerequisite of further implementation of
cd-shar
SpiceUsbDevice* was converted to SpiceUsbDeviceInfo* as _SpiceUsbDevice
was never defined. Define instead the structure to avoid useless
casts.
Signed-off-by: Frediano Ziglio
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 54 ++--
1 file chang
Do not keep bus, address, vid and pid of the USB device
in SpiceUsbDeviceInfo structure. Getters for these properties
can easily obtain them from respective backend device.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 29 +
1 file changed, 13 inserti
Hi,
On Wed, Jul 10, 2019 at 12:23:42PM +0300, Yuri Benditovich wrote:
> This layer communicates with libusb and libusbredir and
> provides the API for all the operations related to USB
> redirection. All other modules of spice-gtk communicate
> only with usb backend instead of calling libusb and
>
This layer communicates with libusb and libusbredir and
provides the API for all the operations related to USB
redirection. All other modules of spice-gtk communicate
only with usb backend instead of calling libusb and
usbredirhost directly.
This is prerequisite of further implementation of
cd-shar
From: Yuri Benditovich
As a step toward possibility to present emulated USB devices
to the guest, we remove the knowledge about libusb and
usbredirhost (which depends on libusb) from all the modules
and concentrate it in one (usb backend) which presents
abstract USB objects and internal API to al
From: Yuri Benditovich
SpiceUsbDevice* was converted to SpiceUsbDeviceInfo* as _SpiceUsbDevice
was never defined. Define instead the structure to avoid useless
casts.
Signed-off-by: Frediano Ziglio
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 54 ++---
From: Yuri Benditovich
Do not keep bus, address, vid and pid of the USB device
in SpiceUsbDeviceInfo structure. Getters for these properties
can easily obtain them from respective backend device.
Signed-off-by: Yuri Benditovich
---
src/usb-device-manager.c | 29 +
1
On 7/9/19 5:16 PM, Victor Toso wrote:
Hi,
On Tue, Jul 09, 2019 at 07:47:18AM -0400, Frediano Ziglio wrote:
On 7/8/19 3:00 PM, Frediano Ziglio wrote:
This series is from Marc-André, I just rebased it on current master.
Not much left of the original series.
I think it's time to get back to it.
On Wed, Jul 10, 2019 at 02:11:48PM +0300, Uri Lublin wrote:
> On 7/9/19 5:16 PM, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Jul 09, 2019 at 07:47:18AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On 7/8/19 3:00 PM, Frediano Ziglio wrote:
> > > > > This series is from Marc-André, I just rebased i
Hi,
On Wed, Jul 10, 2019 at 10:49:21AM +0100, Frediano Ziglio wrote:
> This layer communicates with libusb and libusbredir and
> provides the API for all the operations related to USB
> redirection. All other modules of spice-gtk communicate
> only with usb backend instead of calling libusb and
>
ping
On Thu, Jul 4, 2019 at 12:29 PM Kevin Pouget wrote:
> spice_display_channel_change_preferred_video_codec_types: new function
> for sending an array of video codecs instead of only one.
>
> Signed-off-by: Kevin Pouget
> ---
> doc/reference/spice-gtk-sections.txt | 1 +
> src/channel-displ
ping
On Thu, Jul 4, 2019 at 12:29 PM Kevin Pouget wrote:
> Instead of sending only the preferred video codec (selected), spicy
> now sends an ordered list. When a video codec is selected in the radio
> box, this codec is moved to beginning of the list.
>
> Signed-off-by: Kevin Pouget
> ---
> t
ping
On Thu, Jul 4, 2019 at 10:08 AM Kevin Pouget wrote:
> Interrupt the video streams when the user changes the preferred
> video-codecs (dcc_handle_preferred_video_codec_type) or when the host
> admin updates the list of video-codecs allowed
> (display_channel_set_video_codecs).
>
> The video
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 565a79f33..e0f3b8183 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -725,7 +725,6 @@ static
In red_pipe_replace_rendered_drawables_with_images, the
value of pipe_item is re-written on the next iteration.
Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item
is no longer used to control the loop.
Found by Covscan.
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 1 -
1 file change
'l' is being freed within the loop
Found-by: Frediano Ziglio
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index e0f3b8183..4a92ce8cd 100644
--- a/server/dcc-send.c
+++ b/server/dcc-
This patch-set fixes some problems in dcc-send's
red_pipe_replace_rendered_drawables_with_images().
v1->v2:
- Two additional patches:
- remove unused variable 'image' (Frediano)
- fix use-after-free (Uri)
If people prefer I can squash all three into a single patch.
Frediano Ziglio (1)
Hi,
On Thu, Jul 04, 2019 at 12:29:21PM +0200, Kevin Pouget wrote:
> spice_display_channel_change_preferred_video_codec_types: new function
> for sending an array of video codecs instead of only one.
>
> Signed-off-by: Kevin Pouget
Looks fine,
> ---
> doc/reference/spice-gtk-sections.txt | 1
Hello,
On Thu, Jul 11, 2019 at 8:16 AM Victor Toso wrote:
>
> Hi,
>
> On Thu, Jul 04, 2019 at 12:29:21PM +0200, Kevin Pouget wrote:
> > spice_display_channel_change_preferred_video_codec_types: new function
> > for sending an array of video codecs instead of only one.
> >
> > Signed-off-by: Kevin
24 matches
Mail list logo
