[Spice-devel] [PATCH spice-server 2/3] fixup! reds: Add ability to query the video-codecs currently enabled

2019-07-05 Thread Frediano Ziglio
Minor style updates --- server/spice-server.h | 14 +- server/video-stream.c | 3 ++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/server/spice-server.h b/server/spice-server.h index 24df8e651..c6c8646ae 100644 --- a/server/spice-server.h +++ b/server/spice-server.h

[Spice-devel] [PATCH spice-server 1/3] reds: Add ability to query the video-codecs currently enabled

2019-07-05 Thread Frediano Ziglio
From: Kevin Pouget spice_server_get_video_codecs: new public function to query the video encoders/codecs currently enabled in the spice server. It returns a string that can be fed to the setter counter (spice_server_set_video_codecs). The string returned by this function should be released with s

[Spice-devel] [PATCH spice-server 3/3] fixup! reds: Add ability to query the video-codecs currently enabled

2019-07-05 Thread Frediano Ziglio
Do not add separator at the end of string --- server/video-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/video-stream.c b/server/video-stream.c index d22784f5f..6aa859a02 100644 --- a/server/video-stream.c +++ b/server/video-stream.c @@ -987,7 +987,7 @@ char *

[Spice-devel] [PATCH] reds: Add ability to query the video-codecs currently enabled

2019-07-05 Thread Kevin Pouget
spice_server_get_video_codecs: new public function to query the video encoders/codecs currently enabled in the spice server. It returns a string that can be fed to the setter counter (spice_server_set_video_codecs). The string returned by this function should be released with spice_server_free_vide

Re: [Spice-devel] [PATCH] reds: Add ability to query the video-codecs currently enabled

2019-07-05 Thread Frediano Ziglio
> spice_server_get_video_codecs: new public function to query the video > encoders/codecs currently enabled in the spice server. It returns a > string that can be fed to the setter counter > (spice_server_set_video_codecs). The string returned by this function > should be released with spice_serv

Re: [Spice-devel] Spice on WinXPSP3

2019-07-05 Thread Frediano Ziglio
> Hi, > I'm trying to start remote-viewer.exe on WES7 WYSE with Windows XP SP3 > (32bit) and get stuck with and error message "The procedure entry point > AcquireSRWLockExlusive could not be located in the dynamic link library > KERNEL32.dll.". > I read that it's about Windows XP kernel not support

Re: [Spice-devel] Spice on WinXPSP3

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 06:39:10AM -0400, Frediano Ziglio wrote: > > Hi, > > I'm trying to start remote-viewer.exe on WES7 WYSE with Windows XP SP3 > > (32bit) and get stuck with and error message "The procedure entry point > > AcquireSRWLockExlusive could not be located in the dynamic link library

[Spice-devel] [PATCH spice-server] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

2019-07-05 Thread Frediano Ziglio
The 0 result means success however the function (correctly) could report a failure if the string is incorrect. This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3 ("spice_server_set_video_codecs: fail when no codec can be installed"). Signed-off-by: Frediano Ziglio --- serv

Re: [Spice-devel] [PATCH spice-server 1/2] websocket: Add header guards

2019-07-05 Thread Frediano Ziglio
ping the series > > Signed-off-by: Frediano Ziglio > --- > server/websocket.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/server/websocket.h b/server/websocket.h > index 22120d939..7707e6804 100644 > --- a/server/websocket.h > +++ b/server/websocket.h > @@ -15,6 +15,9 @@ >

Re: [Spice-devel] [PATCH spice-server 06/13] red-channel: Inline red_channel_pipes_create_batch

2019-07-05 Thread Frediano Ziglio
ping > > ping > > > > > The function is called only by red_channel_pipes_new_add. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/red-channel.c | 20 > > 1 file changed, 4 insertions(+), 16 deletions(-) > > > > diff --git a/server/red-channel.c b/server/red-ch

Re: [Spice-devel] [PATCH spice-server 09/13] dispatcher: Use a new API to handle events

2019-07-05 Thread Frediano Ziglio
ping > > ping > > > > > Instead of having to manually register the file descriptor and > > than need to call dispatcher_handle_recv_read just provide a single > > API to create the watch. > > This has some advantage: > > - replace 2 API with 1; > > - code reuse for handling the event (removed 2

Re: [Spice-devel] [PATCH spice-server] event loop: improve implementation of watches

2019-07-05 Thread Frediano Ziglio
ping > > Avoid having to destroy and create a new GSource every time > we change event mask. > Interfaces required for this patch are available since GLib 2.36. > on Windows GPollFD::fd can be an HANDLE but not a socket. > > Signed-off-by: Frediano Ziglio > --- > server/event-loop.c | 97 +

Re: [Spice-devel] [PATCH spice-server v2 1/4] spicevmc: Do not use RedCharDevice pipe items handling

2019-07-05 Thread Frediano Ziglio
ping the series > > As we don't use any token there's no reason to not queue directly instead > of passing through RedCharDevice. > This will make easier to limit the queue which currently is unlimited. > > RedCharDevice flow control has some problems: > - it's really designed with VDI in mind.

[Spice-devel] [PATCH spice-server] red-qxl: Better encapsulation of device display information

2019-07-05 Thread Frediano Ziglio
Do not expose multiple function to fetch different part of internal structures. Signed-off-by: Frediano Ziglio --- server/red-qxl.c | 36 +--- server/red-qxl.h | 4 +--- server/reds.c| 19 +-- 3 files changed, 23 insertions(+), 36 deletions(-)