Re: [Spice-devel] [PATCH] Fix compile errors on Linux 32bit system

2019-06-10 Thread Uri Lublin
On 6/5/19 6:18 AM, Hongzhi.Song wrote: There are folowing compile errors on Linux 32bit system with -Werror for gcc. red-channel.c:207:73: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=] |207| red_channel_debug(self, "thre

[Spice-devel] [client] gstreamer: Initialize last_mm_time to avoid an overflow

2019-06-10 Thread Francois Gouget
The mm_time is an unsigned 32 bit int but spice_mmtime_diff() returns a signed 32 bit int. That's reasonable because we normally substract frame times which should be at most seconds apart. But last_mm_time was zero on stream startup, resulting in an overflow and an uncalled for warning for the fir

Re: [Spice-devel] [client] gstreamer: Initialize last_mm_time to avoid an overflow

2019-06-10 Thread Snir Sheriber
Hi, On 6/10/19 11:49 AM, Francois Gouget wrote: The mm_time is an unsigned 32 bit int but spice_mmtime_diff() returns a signed 32 bit int. That's reasonable because we normally substract s/substract/subtract Ack, I'll do this fix and push frame times which should be at most seconds apart

Re: [Spice-devel] [PATCH 2/3] usb-redirection: isolate usage of libusb and usbredirhost

2019-06-10 Thread Victor Toso
Hi, Keeping the chat as you might enjoy then, in order to merge this patches: On Wed, Apr 10, 2019 at 10:31:38PM +0300, Yuri Benditovich wrote: > As a step toward possibility to present emulated USB devices > to the guest, we remove the knowledge about libusb and > usbredirhost (which depends on

Re: [Spice-devel] [PATCH 3/3] usb-redirection: do not duplicate USB device properties

2019-06-10 Thread Victor Toso
On Wed, Apr 10, 2019 at 10:31:39PM +0300, Yuri Benditovich wrote: > Do not keep bus, address, vid and pid of the USB device > in SpiceUsbDeviceInfo structure. Getters for these properties > can easily obtain them from respective backend device. Why should we keep this structure at all? gboolean is

Re: [Spice-devel] [PATCH spice-server] char-device: Reuse macros to scan GList

2019-06-10 Thread Victor Toso
On Mon, Jun 03, 2019 at 09:22:34AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Looks fine, Acked-by: Victor Toso > --- > server/char-device.c | 27 --- > 1 file changed, 8 insertions(+), 19 deletions(-) > > diff --git a/server/char-device.c b/server/

Re: [Spice-devel] [PATCH spice-server] common-graphics-channel: Avoid closing server if client send huge messages

2019-06-10 Thread Victor Toso
Hi, On Mon, Jun 03, 2019 at 08:39:30AM +0100, Frediano Ziglio wrote: > The Cursor/DisplayChannel is not expecting large messages (which are > protocol violations). > > This fixes https://gitlab.freedesktop.org/spice/spice-server/issues/11. > > Signed-off-by: Frediano Ziglio Sure, Acked-by: Vic

Re: [Spice-devel] [PATCH v3 spice-gtk] Adjust to window scaling

2019-06-10 Thread Victor Toso
Hi, On Sun, Jun 02, 2019 at 03:55:28PM +0300, Snir Sheriber wrote: > Hi, > > > On 5/27/19 8:29 PM, Marc-André Lureau wrote: > > Hi > > > > On Mon, May 27, 2019 at 10:04 AM Snir Sheriber wrote: > > > When GDK_SCALE is != 1 and egl is used, the image presented does not > > > fit to the window (s

[Spice-devel] [spice-gtk v4] Adjust to window scaling

2019-06-10 Thread Victor Toso
From: Snir Sheriber When GDK_SCALE is != 1 and egl is used, the image presented does not fit to the window (scale of 2 is often used with hidpi monitors). Usually this is not a problem since all components are adjusted by gdk/gtk but with egl, pixel-based data is not being scaled. In this case wi

Re: [Spice-devel] [spice-gtk v4] Adjust to window scaling

2019-06-10 Thread Victor Toso
Hi, On Mon, Jun 10, 2019 at 12:15:27PM +, Victor Toso wrote: > From: Snir Sheriber > > When GDK_SCALE is != 1 and egl is used, the image presented does not > fit to the window (scale of 2 is often used with hidpi monitors). > Usually this is not a problem since all components are adjusted by

Re: [Spice-devel] [PATCH] Fix compile errors on Linux 32bit system

2019-06-10 Thread Frediano Ziglio
> > On 6/5/19 6:18 AM, Hongzhi.Song wrote: > > There are folowing compile errors on Linux 32bit system with -Werror > > for gcc. > > > > red-channel.c:207:73: error: format '%x' expects argument of type > > 'unsigned int', but argument 7 has type 'long unsigned int' > > [-Werror=format=] > > |207

Re: [Spice-devel] [PATCH 3/3] usb-redirection: do not duplicate USB device properties

2019-06-10 Thread Yuri Benditovich
On Mon, Jun 10, 2019 at 2:15 PM Victor Toso wrote: > > On Wed, Apr 10, 2019 at 10:31:39PM +0300, Yuri Benditovich wrote: > > Do not keep bus, address, vid and pid of the USB device > > in SpiceUsbDeviceInfo structure. Getters for these properties > > can easily obtain them from respective backend

Re: [Spice-devel] [spice-gtk v4] Adjust to window scaling

2019-06-10 Thread Snir Sheriber
On 6/10/19 3:45 PM, Victor Toso wrote: Hi, On Mon, Jun 10, 2019 at 12:15:27PM +, Victor Toso wrote: From: Snir Sheriber When GDK_SCALE is != 1 and egl is used, the image presented does not fit to the window (scale of 2 is often used with hidpi monitors). Usually this is not a problem sin