This structure is not declares as SPICE_ATTR_PACKED resulting it
as aligned and no packed using GCC (no MingW).
This structure is only packed under MingW or Microsoft compilers.
This structure is not technically a definition for QXL device but
is used only for spice-server QXL interface.
As said ab
Do not declare the structure as aligned.
The start/end-packed.h headers affects only MingW or Microsoft
compilers. To have unaligned structure with GCC compiler you have
to use SPICE_ATTR_PACKED. This way the definition are the same for
all compiler.
This structure is used in a lot of QXL structure
Signed-off-by: Frediano Ziglio
---
configure.ac | 2 +-
meson.build | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index b56f414..bc3e33f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@ AC_PREREQ([2.57])
m4_define([SPICE_MAJOR],
On 5/8/19 4:06 PM, Frediano Ziglio wrote:
Copy to/from unaligned field to avoid potential unaligned access.
Although it adds a copy it's not in a hot path (migration) and
the structure is pretty small.
Signed-off-by: Frediano Ziglio
Ack, but see one comment below.
I wrote a similar patch, yo
On 5/7/19 12:57 PM, Daniel P. Berrangé wrote:
On Tue, May 07, 2019 at 12:48:55PM +0300, Uri Lublin wrote:
The gcc warning address-of-packed-member is new and on by
default in gcc 9.
Many of the structures sent over the network are packed
and with unaligned fields.
This breaks the build -- due
Signed-off-by: Snir Sheriber
---
m4/manywarnings.m4 | 1 -
1 file changed, 1 deletion(-)
diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
index 4f701f4..3864100 100644
--- a/m4/manywarnings.m4
+++ b/m4/manywarnings.m4
@@ -116,7 +116,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
-Wbuiltin-macro-r
Hi,
On Mon, May 13, 2019 at 10:45:54AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Yep,
Acked-by: Victor Toso
> ---
> configure.ac | 2 +-
> meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index b56f414
Hi,
On Mon, May 13, 2019 at 04:52:46PM +0300, Snir Sheriber wrote:
> Signed-off-by: Snir Sheriber
Acked-by: Victor Toso
> ---
> m4/manywarnings.m4 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
> index 4f701f4..3864100 100644
> --- a/m4/manywa
>
> Signed-off-by: Snir Sheriber
Acked-by: Frediano Ziglio
> ---
> m4/manywarnings.m4 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
> index 4f701f4..3864100 100644
> --- a/m4/manywarnings.m4
> +++ b/m4/manywarnings.m4
> @@ -116,7 +116,6 @@ AC
