Re: [Spice-devel] Spice connection audio problem

2019-04-03 Thread Victor Toso
Hi, On Wed, Apr 03, 2019 at 12:52:55AM +0800, 天魔 wrote: > Hi,I am having a problem when I connect my win10 virtual > machine with the latest spice client under win10 1809 64-bit > version. With latest, you mean virt-viewer-x86-8.0 from: https://virt-manager.org/download/ ? > I added an inte

Re: [Spice-devel] [PATCH spice-common] proto: Fix typo in message name

2019-04-03 Thread Victor Toso
Hi, On Tue, Apr 02, 2019 at 02:46:33PM +0100, Frediano Ziglio wrote: > RecoderChannel::data message is the same as PlaybackChannel::data > one. Is this the right fix? What I see here is that in the RecordChannel you changed SpiceMsgcRecordPacket to SpiceMsgcPlaybackPacket which already exists in

Re: [Spice-devel] [PATCH spice-common] build: Add new check for recorder library

2019-04-03 Thread Victor Toso
Hi, On Tue, Apr 02, 2019 at 01:49:06PM +0100, Frediano Ziglio wrote: > Newer version try to use this function if available. So it should be checked if recorder is enabled, no? That's on stdio.h so I can't really see why not anyway Acked-by: Victor Toso > Signed-off-by: Frediano Ziglio > --- >

Re: [Spice-devel] [spice-streaming-agent PATCH] mjpeg: get_time: fix off-by-0

2019-04-03 Thread Victor Toso
Hi, On Sun, Mar 31, 2019 at 09:05:16AM -0400, Frediano Ziglio wrote: > > Subject: [Spice-devel] [spice-streaming-agent PATCH] mjpeg: get_time: fix > > off-by-0 > > > > Only 9 0's are required > > > > Signed-off-by: Uri Lublin > > Code is fine, comment I'm not sure about. > Usually off-by- ref

Re: [Spice-devel] [PATCH spice-common] build: Add new check for recorder library

2019-04-03 Thread Frediano Ziglio
> > Hi, > > On Tue, Apr 02, 2019 at 01:49:06PM +0100, Frediano Ziglio wrote: > > Newer version try to use this function if available. > > So it should be checked if recorder is enabled, no? > That's on stdio.h so I can't really see why not anyway > Not for MingW (implementation reasons) and it

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-04-03 Thread Victor Toso
Hi, On Fri, Feb 22, 2019 at 10:01:00AM +, Frediano Ziglio wrote: > RedClient was an opaque structure for RedCharDevice. > It started to be used when RedsState started to contain all > the global state. > Make it opaque again. Not particular familiar with the possibilities but I can't see any

Re: [Spice-devel] [PATCH linux/vd-agent 01/11] Add a .gitpublish

2019-04-03 Thread Victor Toso
Hi, On Fri, Mar 22, 2019 at 04:12:36PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Set a default profile for git-publish. > (https://github.com/stefanha/git-publish) > > Signed-off-by: Marc-André Lureau > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+

[Spice-devel] [PATCH spice-common v2] proto: Fix typo in message name

2019-04-03 Thread Frediano Ziglio
RecoderChannel::data message is the same as PlaybackChannel::data one. This fixed compilation of spice-gtk using updated spice-common. Before generating the messages automatically the definition was: typedef struct SpiceMsgPlaybackPacket { uint32_t time; uint8_t *data; uint32_

Re: [Spice-devel] [PATCH spice-common v2] proto: Fix typo in message name

2019-04-03 Thread Victor Toso
Hi, On Wed, Apr 03, 2019 at 09:53:21AM +0100, Frediano Ziglio wrote: > RecoderChannel::data message is the same as PlaybackChannel::data > one. > This fixed compilation of spice-gtk using updated spice-common. > > Before generating the messages automatically the definition was: > > typedef str

Re: [Spice-devel] [PATCH spice-server v2 1/2] docs: Add some notes on event scheduling and threading

2019-04-03 Thread Victor Toso
Hi, On Fri, Mar 29, 2019 at 11:15:28AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > docs/spice_threading_model.txt | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/docs/spice_threading_model.txt b/docs/spice_threading_model.txt > index 9351141c8

[Spice-devel] [PATCH spice-server] Update spice-common submodule

2019-04-03 Thread Frediano Ziglio
This brings in the following changes: Christophe Fergeau (8): canvas_base: Fix variable shadowing warning backtrace: Add missing include lz: Don't try to print uninitialized variable build: Add missing G_GNUC_PRINTF annotations build: Update verify.h to latest version

Re: [Spice-devel] [PATCH linux/vd-agent 01/11] Add a .gitpublish

2019-04-03 Thread Frediano Ziglio
> > Hi, > > On Fri, Mar 22, 2019 at 04:12:36PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Set a default profile for git-publish. > > (https://github.com/stefanha/git-publish) > > > > Signed-off-by: Marc-André Lureau > > --- > > .gitpublish | 4 > > 1 f

Re: [Spice-devel] [PATCH spice-gtk 2/3] clipboard: pre-condition on selection value < 256

2019-04-03 Thread Victor Toso
Hi, On Fri, Mar 22, 2019 at 03:20:13PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The protocol uses a u8 for the selection value. Make sure the given > argument value fits there, or throw a critical. > > The other places seem to use u8 variables already. > > Signed

Re: [Spice-devel] [PATCH spice-server] Update spice-common submodule

2019-04-03 Thread Victor Toso
Hi, On Wed, Apr 03, 2019 at 10:05:23AM +0100, Frediano Ziglio wrote: > This brings in the following changes: > > Christophe Fergeau (8): > canvas_base: Fix variable shadowing warning > backtrace: Add missing include > lz: Don't try to print uninitialized variable > build:

[Spice-devel] [PATCH spice-common] meson: Fix dependency of generated files

2019-04-03 Thread Frediano Ziglio
All generated file depends on generated_messages.h which is generated too. So add an explicit dependency from all generated file (except generated_messages.h generator) to generated_messages.h generator. This fixes compiling SPICE server where generated_messages.h was not generated at all. Signed-

[Spice-devel] [PATCH spice-common 1/2] meson: Fix dependency of generated files

2019-04-03 Thread Frediano Ziglio
All generated file depends on generated_messages.h which is generated too. So add an explicit dependency from all generated file (except generated_messages.h generator) to generated_messages.h generator. This fixes compiling SPICE server where generated_messages.h was not generated at all. Signed-

[Spice-devel] [PATCH spice-common 2/2] meson: Do not build generated files twice

2019-04-03 Thread Frediano Ziglio
spice-gtk and spice-server will use spice_common_client_dep and spice_common_server_dep as dependencies. However they will depend on both spice-common client/server libraries and their sources causing the sources to be compiled multiple times and causes linker errors on spice-gtk. The issue can be

Re: [Spice-devel] [PATCH spice-common 2/2] meson: Do not build generated files twice

2019-04-03 Thread Frediano Ziglio
> > spice-gtk and spice-server will use spice_common_client_dep > and spice_common_server_dep as dependencies. > However they will depend on both spice-common client/server > libraries and their sources causing the sources to be compiled > multiple times and causes linker errors on spice-gtk. > Th

[Spice-devel] [PATCH spice-common v2 2/2] meson: Do not build generated files twice

2019-04-03 Thread Frediano Ziglio
spice-gtk and spice-server will use spice_common_client_dep and spice_common_server_dep as dependencies. However they will depend on both spice-common client/server libraries and their sources causing the sources to be compiled multiple times and causes linker errors on spice-gtk. The issue can be

[Spice-devel] [PATCH spice-common v2 1/2] meson: Fix dependency of generated files

2019-04-03 Thread Frediano Ziglio
All generated file depends on generated_messages.h which is generated too. So add an explicit dependency from all generated file (except generated_messages.h generator) to generated_messages.h generator. This fixes compiling SPICE server where generated_messages.h was not generated at all. Add depe

[Spice-devel] [spice-streaming-agent PATCH v2] mjpeg: get_time: fix conversion of seconds to nanaseconds

2019-04-03 Thread Uri Lublin
1 second is 10^9 nanosecond, not 10^10. Signed-off-by: Uri Lublin Acked-by: Victor Toso --- changes since V1: - Subject and log message reworded (Frediano, Victor) --- src/mjpeg-fallback.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mjpeg-fallback.cpp b/src/mjpe

[Spice-devel] Blank screen on SPICE when using vGPU

2019-04-03 Thread James Freeman
Hi all, Conscious this might not be a SPICE issue but trying to debug where the issue is right now. I'm working with someone who is using RHV 4.2 with a vGPU configuration. At present we are stuck on a problem whereby the vGPU can be successfully assigned to a given VM (either Windows or Linu