Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50

2019-03-24 Thread Jakub Janku
Hi, On Fri, Mar 22, 2019 at 4:13 PM wrote: > > From: Marc-André Lureau > > This is required for using the new GObject macros. Which macros are you referring to? G_DECLARE_FINAL_TYPE is available since 2.44 > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > GLib version to

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

2019-03-24 Thread Jakub Janku
On Fri, Mar 22, 2019 at 2:57 PM wrote: > > From: Marc-André Lureau > > When this capability is negoticated by both the client & the agent, > the clipboard grab messages have an associated serial counter. > > The serial is reset to 0 upon client connection. > > The counter is increment by 1 on eac

Re: [Spice-devel] [PATCH spice-gtk 2/2] clipboard: do not release between remote grabs

2019-03-24 Thread Jakub Janku
Hi, On Thu, Mar 21, 2019 at 1:21 PM wrote: > > From: Marc-André Lureau > > Delay the release events for 0.5 sec. If no further grab comes in, > then release the grab. Otherwise, let's skip the release. This avoids > some races with clipboard managers. > > Related to: > https://gitlab.freedesktop

Re: [Spice-devel] [PATCH spice-gtk 1/2] clipboard: do not release between client grabs

2019-03-24 Thread Jakub Janku
Hi, On Thu, Mar 21, 2019 at 1:21 PM wrote: > > From: Marc-André Lureau > > On the client side, whenever the grab owner changes (and the clipboard > was previously grabbed), spice-gtk sends a clipboard release followed > immediately by a new grab. But some clipboard managers on the remote > side

Re: [Spice-devel] [PATCH spice-gtk 0/2] clipboard: skip release between grabs

2019-03-24 Thread Jakub Janku
Hi, On Fri, Mar 22, 2019 at 10:15 AM Victor Toso wrote: > > Hi James, > > If you have the time, could you give this a try? CC-ing James > > Cheers, > > On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > There has been sev

[Spice-devel] [PATCH spice-space] Update support.rst

2019-03-24 Thread Snir Sheriber
--- Due to outdated links reported Daniel P. Berrang?? in "[Spice-devel] Bug tracker links outdated" In addition i did changes in the text so i sent it for review --- support.rst | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/support.rst b/support.rst

Re: [Spice-devel] [PATCH linux/vd-agent 02/11] session: free active session

2019-03-24 Thread Jakub Janku
On Fri, Mar 22, 2019 at 4:13 PM wrote: > > From: Marc-André Lureau > > According to sd_seat_get_active(2), you must free() the pointer. > > Signed-off-by: Marc-André Lureau > --- > src/vdagentd/systemd-login.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vdagentd/systemd-login.c

Re: [Spice-devel] [PATCH linux/vd-agent 02/11] session: free active session

2019-03-24 Thread Marc-André Lureau
Hi On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote: > > On Fri, Mar 22, 2019 at 4:13 PM wrote: > > > > From: Marc-André Lureau > > > > According to sd_seat_get_active(2), you must free() the pointer. > > > > Signed-off-by: Marc-André Lureau > > --- > > src/vdagentd/systemd-login.c | 1 + > >

Re: [Spice-devel] [PATCH spice-gtk 1/2] clipboard: do not release between client grabs

2019-03-24 Thread Marc-André Lureau
Hi On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote: > > Hi, > > On Thu, Mar 21, 2019 at 1:21 PM wrote: > > > > From: Marc-André Lureau > > > > On the client side, whenever the grab owner changes (and the clipboard > > was previously grabbed), spice-gtk sends a clipboard release followed > > i

Re: [Spice-devel] [PATCH spice-gtk 0/2] clipboard: skip release between grabs

2019-03-24 Thread Marc-André Lureau
Hi On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote: > > Hi, > > On Fri, Mar 22, 2019 at 10:15 AM Victor Toso wrote: > > > > Hi James, > > > > If you have the time, could you give this a try? > > CC-ing James > > > > Cheers, > > > > On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lur...@red

Re: [Spice-devel] [PATCH spice-gtk 2/2] clipboard: do not release between remote grabs

2019-03-24 Thread Marc-André Lureau
Hi On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote: > > Hi, > > On Thu, Mar 21, 2019 at 1:21 PM wrote: > > > > From: Marc-André Lureau > > > > Delay the release events for 0.5 sec. If no further grab comes in, > > then release the grab. Otherwise, let's skip the release. This avoids > > some

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

2019-03-24 Thread Marc-André Lureau
Hi On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote: > > On Fri, Mar 22, 2019 at 2:57 PM wrote: > > > > From: Marc-André Lureau > > > > When this capability is negoticated by both the client & the agent, > > the clipboard grab messages have an associated serial counter. > > > > The serial is r